GitLab

Review URL: http://codereview.chromium.org/7621003

TBR=jkummerow@chromium.org
Review URL: http://codereview.chromium.org/7621005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96347 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:5066
TEST=manual

Review URL: http://codereview.chromium.org/7608023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96344 0039d316-1c4b-4281-b951-d872f2087c98

Make sure we return value in non-void function.

BUG=none
TBR=erikwright
TEST=it builds with linux_use_heapchecker=1

Review URL: http://codereview.chromium.org/7623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19017
TEST=manual

Review URL: http://codereview.chromium.org/7618006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96342 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7621003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92440

Review URL: http://codereview.chromium.org/7601021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96340 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=made sure chrome compiles

Review URL: http://codereview.chromium.org/7583047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96336 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the display offset and cursor bounds are valid on use.
Build in offset logic to RenderText display and hit-testing.
Implement simpler temporary GetStringWidth and GetCursorBounds.
Fix SetDisplayRect signature, code file ordering, invalidation.
Rename and refactor a bit, update comments.

Fixes adornment display & hit testing on text field overflows.
Increases abstraction/encapsulation for easier client use.

BUG=90426
TEST=--use-pure-views / touch_ui textfield use with overflow.

Review URL: http://codereview.chromium.org/7466048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=about:tracing with GLES2 on ARM.


Review URL: http://codereview.chromium.org/7587008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96333 0039d316-1c4b-4281-b951-d872f2087c98

Revert 96162 - Revert 96149 - Enable/disable input methods according to |text_input_type_| when a view is selected so that input methods don't eat keyboard shortcuts.

FindInPageTest.PrepopulateRespectBlank began to fail after I land this CL and I reverted it as r96162. I ran interactive_ui_tests on my machine and didn't see any failure so I try to land the CL again.

BUG=80772
TEST=manual

Review URL: http://codereview.chromium.org/7554005

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7604029

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7620005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91619
TEST=Set up a remoting sesssion and make sure it works.

Review URL: http://codereview.chromium.org/7491070

TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/7622002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91619
TEST=Set up a remoting sesssion and make sure it works.

Review URL: http://codereview.chromium.org/7491070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96327 0039d316-1c4b-4281-b951-d872f2087c98

Changed ConfigureDataTypes to take a set of types to add and a set of types to remove.

Changed Activate/DeactivateDataType to take ModelTypes instead of
the DataTypeControllers directly.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7511004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89388
TEST=none

Review URL: http://codereview.chromium.org/7587015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96325 0039d316-1c4b-4281-b951-d872f2087c98

This is to make the future transition to a shared resource tracker (which
will use refcounted resources) easier. There should be no behavior change.

Review URL: http://codereview.chromium.org/7608030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96324 0039d316-1c4b-4281-b951-d872f2087c98

Enable SWIG threading for PyAuto calls. SWIG by default locks CPython's Global Interpreter Lock for all calls, preventing Python execution on any other thread.


BUG=chromium-os:18436
TEST=Write an autotest that uses a local HTTP server and make a PyAuto call to navigate to a URL served from the server.


Review URL: http://codereview.chromium.org/7607024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92439
TEST=None

Review URL: http://codereview.chromium.org/7587019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96320 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ran watchlists.py manually

Review URL: http://codereview.chromium.org/7552037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96318 0039d316-1c4b-4281-b951-d872f2087c98

TEST=made demo and tested it.
BUG=91046

Review URL: http://codereview.chromium.org/7604027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90117,92371
TEST=Sync everything, enable typed url sync, go to NTP, see notification, click on it, stop seeing notifications.


Review URL: http://codereview.chromium.org/7481023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Build, and test through UI.

Review URL: http://codereview.chromium.org/7466016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7619002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7605021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran on views and verified that things looked ok.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96306

Review URL: http://codereview.chromium.org/7566050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96311 0039d316-1c4b-4281-b951-d872f2087c98

Remove name parameters from StreamChannelCallback and
DatagramChannelCallback. This argument is redundant: callback currying
can be used instead where neccessary.

BUG=None
TEST=compiles.

Review URL: http://codereview.chromium.org/7605018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran on views and verified that things looked ok.

Review URL: http://codereview.chromium.org/7566050

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7622001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran on views and verified that things looked ok.

Review URL: http://codereview.chromium.org/7566050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96306 0039d316-1c4b-4281-b951-d872f2087c98

This patch extends the existing AutofillSyncPerfTest class to also measure add and
delete time for autofill keys.  Updating an individual autofill key is not possible,
as far as I can tell.

BUG=none
TEST=sync_performance_tests


Review URL: http://codereview.chromium.org/7590007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92111
TEST=

Review URL: http://codereview.chromium.org/7607036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96089

Review URL: http://codereview.chromium.org/7508044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ovdatest passes, gles2 works & closing tab mid-play tears down OVDA.


Review URL: http://codereview.chromium.org/7587004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96300 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6340: (mcgrathr) Remove __pthread_shutdown
r6341: (mseaborn) Add test for repeated, sequential pthread_create()+pthread_join()
r6342: (mseaborn) Get more information about failures of the multiple-sandboxes test
r6343: (jvoung) Warn on unused results when calling nacl thread ctors and check return values where missing.
r6344: (krasin) service runtime: remove unused work_queue field from NaClApp.
r6345: (sehr) Eliminate browser API agnostic base classed from the plugin.
r6346: (mcgrathr) Update glibc revision to facb66a
r6347: (polina) PPAPI Proxy: remove calls to remote PPP_Instance::DidDestroy and
r6348: (mcgrathr) Build IRT and in-tree tests with private libraries, drop non-IRT support from libnacl
r6349: (mcgrathr) Fix leak_test after r6348
r6350: (kschimpf) Compress the prefix/opcode tables, removing approximately 2300 entries.
r6351: (kschimpf) Modify the x86-32 validator to generate more detailed messages when not in
r6352: (kschimpf) Fix bug in revision 6351.
r6353: (mcgrathr) Bump toolchain DEPS to 6349
r6354: (bradnelson) Revert 6353 - Bump toolchain DEPS to 6349
r6355: (khim) Pull 84d7d30. Enable static tests in glibc-tests.
r6356: (eaeltsin) Get rid of old tool names completely
r6357: (mseaborn) x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S
r6358: (khim) Bump DEPS file, enable run_glibc_static_hello_test.
r6359: (khim) Fix the bots.
r6360: (khim) Fix *-spec bots.
r6361: (khim) Fix lucid_64-newlib-x86_64-spec bot.
r6362: (jvoung) Run pnacl sandboxed translators with IRT blob loaded (ask sel_universal to).
r6363: (ncbray) Refactored NaClAppLoadFile by pulling code out into seperate functions.
r6364: (khim) Final (hopefully) fix for *-spec bot.
r6365: (mcgrathr) Initialize "second TLS" pointer in thread_create syscall
r6366: (jvoung) Scoot pnacl DEPS revision back until the toolchain with the driver
r6367: (mseaborn) Revert r6357: "x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S"
r6368: (robertm) Added secondary event queue so that we do not overflow
r6369: (mcgrathr) Add valgrind trybots to default set
r6370: (pasko) Bump REVISIONS for newlib
r6371: (mseaborn) atomic_ops_test: Simplify by using joinable threads
r6372: (jvoung) Add steps to build pnacl sandboxed toolchain prerequisites if they aren't
r6373: (sehr) Remove the now-obsolete nacl_startup function.
r6374: (sehr) Revert r6373.
r6375: (bsy) enable manifest file access before pepper initialization.
r6376: (mcgrathr) Reimplement pthread thread-specific data using __thread
r6377: (mcgrathr) Don't build all of libpthread for the IRT
r6378: (sehr) Second try to remove obsolete startup function, nacl_startup.  This change
r6379: (mseaborn) Multiple sandboxes test: Use NaClExit() instead of an implicit exit()
r6380: (mcgrathr) Remove irt_elf_utils
r6381: (mcgrathr) Remove __nc_adopt_thread
r6382: (jvoung) Bump toolchain deps.
r6384: (pasko) Toolchain DEPS up(6382).
r6385: (pasko) Bump REVISIONS for newlib.
r6386: (mseaborn) x86 CPUID check: Fix inline assembly to declare that it clobbers %eax

Re-enable NaCl tests on Mac since the Mac Clang build is fixed by r6386.

BUG=91371
TEST=trybots


Review URL: http://codereview.chromium.org/7462016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96298 0039d316-1c4b-4281-b951-d872f2087c98

Instantiate OriginBoundCertService in relevant places and do plumbing to pass it down to HttpNetworkSession.

BUG=88782
TEST=None

Review URL: http://codereview.chromium.org/7493025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96296 0039d316-1c4b-4281-b951-d872f2087c98

Change some DLOG and NOTREACHED to LOG, to make debugging component extensions on Release build easier
Add a ValidateExtension call after loading a component extension to find errors such as file loading failure
Change the signature of ValidateExtension for const correctness

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7585003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96295 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.

This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Apps, Extensions and Themes datatypes to the new model, and contains the following changes:

- LiveAppsSyncTest is no longer a class that inherits from LiveSyncTest, but is now a namespace called apps_helper, and contains a bunch of methods that perform various operations related to Apps. Similar changes were made to Extensions and Themes.
- SingleClientLiveAppsSyncTest is renamed to SingleClientAppsSyncTest, and is a subclass of LiveSyncTest. It uses the methods in namespace apps_helper by including its header file and attaching itself to the helper. Similar changes were made to Extensions and Themes.
- LiveSyncExtensionHelper is renamed to SyncExtensionHelper.

BUG=88510
TEST=sync_integration_tests, sync_performance_tests

Review URL: http://codereview.chromium.org/7599019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96292 0039d316-1c4b-4281-b951-d872f2087c98

"FILES" is used when producing zip snapshots of Chromium.  This file
is read by chrome/trunk/tools/build/scripts/slave/chromium/archive_build.py.

This will allow NaCl to invoke crash_service64.exe in the NaCl
standalone build, although this is mainly for consistency across
standalone and non-standalone test runs, since the NaCl standalone
build won't support producing Breakpad crash dumps.

Add to "FILES.cfg" for consistency.  This file is read by
chrome-internal/trunk/tools/build/scripts/slave-internal/stage_build.py.

BUG=89730
TEST=untestable


Review URL: http://codereview.chromium.org/7610006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91729
TEST=None
Review URL: http://codereview.chromium.org/7462021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96289 0039d316-1c4b-4281-b951-d872f2087c98