- 09 Apr, 2020 6 commits
-
-
Lukasz Anforowicz authored
This CL changes FromProgrammaticContentScript_PermissionToAllUrls_FileUrls so that it uses XHR instead of fetch API, because fetch API fails because it doesn't support file: URLs (and not because CORS blocks the response as expected by the test). Bug: 1051594 Change-Id: I3d6c58ce09e3c5fc7d4436c5a78659623006dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135380 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757654}
-
Xiaohan Wang authored
This CL adds IsCrossOrigin, IsTopFrame and IsAdFrame info to Media.EME.RequestMediaKeySystemAccess UKM. Bug: 1068642 Change-Id: I103e1fdd11f0a01868b21d2f8a4d9340ac4e1a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139994 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#757653}
-
Su Hong Koo authored
Add HighlightDisplay() to CrosDisplayConfigController mojo interface. The new method is used to specify which display DisplayHighlightController should render the highlights on. Bind CrosDisplayConfig interface to OSSettingsUI to support setting selected display from Displays Settings page. Bug: 1068252 Change-Id: Ie077eff838d79d6774f4a03a0998af201bfc43e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111752Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Su Hong Koo <sukoo@google.com> Cr-Commit-Position: refs/heads/master@{#757652}
-
rbpotter authored
Bug: 1026426 Change-Id: I328de7bfaf6d6f5501e0fc386dd64e901fa387e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141129 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757651}
-
Yuichiro Hanada authored
State updates from Android side is valid only if an ARC app is focused. This CL factors out the check to a separate method to avoid having the repeated comments. This should not cause any behaviour change. Bug: 1063740 Test: components_unittests Change-Id: I56a558d2fbc5478a58b917a10768620f66d3d510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142071Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#757650}
-
Chris Hamilton authored
This standardizes visitors by making sure all nodes have them where it makes sense, and also making them have a return value (useful for many simple cases). It additionally adds a RenderFrameHostProxy, so all node types now have a corresponding PM->UI thread WeakPtr like mechanism. Change-Id: I17da13fd5ec42500b3a0034e0fa58898c5e51805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141043 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757649}
-
- 08 Apr, 2020 34 commits
-
-
Jeff Yoon authored
Migrated iOS bots that use the Chromium recipe have the xcode build version set by the GN template. This required the user to look at two locations to migrate the version. This change deprecates the xcode version set in GN files, and moves it to //testing/buildbot alongside the xcode cache set for the Swarming task. Xcode 11c29 is still passed to the test runner, and should not have any overall change. Bug: 1055164,912681 Change-Id: I67695a18a3cbfb1fde2f57ed9ae6efb41ae4089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135835 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757648}
-
Tibor Goldschwendt authored
NewTabPageCustomizeDialogTest was disabled due to flakiness, e.g. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8884313005389563392 From this run it appears that the scroll border tests are causing the flakiness. This CL re-enables the NewTabPageCustomizeDialogTest and disables the scroll border tests to at least re-gain coverage of the other NewTabPageCustomizeDialogTests. Bug: 1066459 Change-Id: I6477efb6763ce80ec84d581dcb9e73907850cdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142731 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757647}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5185df5cad73..8d8bae65e67d git log 5185df5cad73..8d8bae65e67d --date=short --first-parent --format='%ad %ae %s' 2020-04-08 kthelgason@webrtc.org Migrate to modern selector syntax for ObjcVideoEncoderFactory. Created with: gclient setdep -r src/third_party/webrtc@8d8bae65e67d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba40fd254925712a6fa5c6a523dc5668fb5726d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757646}
-
Shawn Gallea authored
This allows users to experiment with webviews via touch. Bug: 1011977 Test: Run client, experiment. Change-Id: Iffbb528e5858ad8e6fbab122633ee14d25428d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122912Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#757645}
-
Bruce Dawson authored
This is an experimental tool which will inject a thread into a Chrome process (tested on the browser and GPU process) and run code to call HeapSetInformation with HEAP_OPTIMIZE_RESOURCES_CURRENT_VERSION. This tells Windows to trim unnecessary memory from the heaps in that process. This tool uses sketchy techniques such as copying memory from one executable to another (only works if the code is relocatable and has no external references), VirtualAllocEx, and CreateRemoteThread. This is not for production use. To build run build.bat To run either run it manually (passing the PIDs of the processes of interest) or run trim_loop.bat (passing the PIDs of the processes of interest) to run it every five minutes in a loop. While it sometimes frees non-trivial amounts of memory the savings are not persistent. Bug: 1050059, 982452 Change-Id: I646c515e59598c2c3003500419c154bacd34aeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139127 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#757644}
-
Jason Lin authored
The shelf menu for windowed web app should match chrome's behavior: there should be one entry per browser by default, and one entry per tab if shift key is pressed. The old code has some dead code in AdvanceToNextApp() to bounce the window when there is only one item. This cl also fixes this bug. Other than this, the behavior for a non tabbed-window app should be the same. extension Test: browsertests and manual test with terminal SWA, PWA, drive Bug: 1060871 Change-Id: Ibcd3da607e37fb77fba2bda61badf7a628c2ffc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126649 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757643}
-
Chong Gu authored
Allow webengine to accept switches without values. Necessary for some Telemetry gpu integration tests. Bug: 1058255 Change-Id: Ie964b67424afd0a41dace55912fd6937c46ad675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134698Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#757642}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for apps section page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: If18c13f7e2e9730ff01eaed687a0e4139cf37aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142634Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c440b23d505b..e3a42b258eda git log c440b23d505b..e3a42b258eda --date=short --first-parent --format='%ad %ae %s' 2020-04-08 wnwen@chromium.org More detailed build-step type summary for android Created with: gclient setdep -r src/third_party/depot_tools@e3a42b258eda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067273 Tbr: agable@chromium.org Change-Id: I418a3ced7236bed19bddb488610aa539fd4db543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140980Reviewed-by:
-
Adenilson Cavalcanti authored
One of the optimizations (i.e. chunk_copy) will perform vector stores on 16 bytes chunks instead of the original 3 bytes scalar operations. It is interesting to validate its safety while operating with small payloads (i.e. data input smaller than a single load/store). Even though it is a corner case (i.e. the payload would be smaller than the wrapper used for the DEFLATE stream for GZIP), it is good to certify that the optimization works as expected. This will also add gtest as a dependency as the plan is to write some tests to stress the optimizations we ship. Bug: 1032721 Change-Id: Ifc6a81879e3dba6a9c4b7cfde80e7207258b934c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128836 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757639}
-
Nnamdi Theodore Johnson-Kanu authored
This CL removes Supervision Dialog strings that are not used/referenced in ChromeOS or browser settings. Bug: 967883 Change-Id: I567499b5460798a90fc43c714968ec5506b9a85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142582Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings Network error strings from settings_strings.grdp to chromeos_strings.grdp. These strings are not in os_settings_localized_strings_provider.cc, but are used in chromeOS network page (network_element_localized_strings_provider.cc). It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I743208524ffdbc9e23f2502a34d97b5c0e24dbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142146Reviewed-by:
-
Julian Watson authored
I have a strong suspicion that the OSSettingsCrostiniPageTests were not hanging, but instead were timing out because there were a lot of tests under a single target, which only gets a 30 second window to run. In crrev.com/c/2124281 the target was split up into 6 roughly equally sized targets, of which one was disabled because we suspected that it might be flaky. None of which have subsequently flaked. Upon investigating the disabled test, I believe it isn't flaky, as all of its asynchronous function invocations invoke flushAsync which cannot timeout. Due to this, I believe it is safe to reenable, however I have added some temporary logging, which will help us track down the cause if it is in fact flakey. If it doesn't flake within a week I will remove the new logging. Bug: 1056268 Change-Id: I4d1869016642fcc26d94950aa0c138892d1df82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141874Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
-
Kurt Horimoto authored
Now that the kNonModalDialogs feature is enabled by default, the legacy coordinator-based implementation can be removed. This CL moves this functionality into a BrowserAgent that adds OverlayRequests for app launcher dialogs to the appropriate WebState's queue when an AppLauncherTabHelper attempts to open an external app. Since this functionality no longer requires a coordinator, the tab helper can now be constructed alongside the rest in AttachTabHelpers(). The AppLauncherTabHelperDelegate protocol was converted into a C++ interface to reduce plumbing when hooking the BrowserAgent up to the tab helpers. Additionally, LaunchAppForTabHelper() was updated to return void, as its return value was unused by the tab helper. Bug: 1068418 Change-Id: I01703acc19712b32810d73876d7e58e364711d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140714 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#757635}
-
spdonghao authored
Class to write top sites favicon info to devices. Bug: 1061906 Change-Id: Iece46799499890bff10e17bd7f6b7835b851bb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122848Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757634}
-
tby authored
This adds a finch flag and a linked chrome flag to be used for the launcher settings search experiment, which adds search results for cros settings into the launcher. Bug: 1068851 Change-Id: I6ff10f8e9bb6eda2e74e52b9090eb3c42ada0d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141478Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#757633}
-
David Van Cleve authored
TrustTokenRequestSigningHelper, responsible for executing the "request signing" Trust Tokens operation, currently has the guts of the signing operation mocked out. This CL adds a concrete signer, implemented using Ed25519 and BoringSSL, capable of signing an outgoing request. R=svaldez Bug: 1042962 Change-Id: I9e6ca211334e81abc37d0c4e0b664e61355ef34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137504 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757632}
-
Becca Hughes authored
Since we have MHKS, MHS didn't really do anything apart from proxy to MHSI. This replaces MHS with MHSI. BUG=1024351 Change-Id: Ifb6e6c6d33d428dbfd415e3e81a63a22858835c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138553 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757631}
-
Natalie Chouinard authored
Enable flaky test to gather failure images. Unable to repro locally, and insufficient information on bug for speculative fixes yet. Bug: 888129 Change-Id: I438daec8bbb9faa4d098fc83016e96f3db1792d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136272 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757630}
-
Clark DuVall authored
It seems like some devices were having the system location setting disabled, this change makes sure it is enabled for the geolocation tests. This is similar to what is done for the chrome geolocation tests. Bug: 1064500 Change-Id: Ia21ad63d8f5345eb9b0e2274452375400760aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142393Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3150d88ba4ca..185d3d4fa709 git log 3150d88ba4ca..185d3d4fa709 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 jvanverth@google.com Add onMap, onUnmap, and onUpdateData to GrD3DBuffer. 2020-04-08 fmalita@chromium.org [svg] Reference cycle avoidance 2020-04-08 bsalomon@google.com Add getter for channels to GrBackendFormat 2020-04-08 tdenniston@google.com [SVG] Fix application of skewX/skewY attributes 2020-04-08 reed@google.com more infixifcation -- no functional change 2020-04-08 mtklein@google.com add SkVM_min_max unit test Created with: gclient setdep -r src/third_party/skia@185d3d4fa709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: If85f3aa0ef83c5ec4eac948a3ffda5cccb54df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142487Reviewed-by:
-
Devlin Cronin authored
Introduce a action_info_test_util file that provides some common test functionality. In particular, this adds: - GetManifestKeyForActionType() to get a particular manifest key for an action type, and - GetActionInfoOfType() to retrieve an ActionInfo if and only if it is of the specified type. This is a test-only function because most production code shouldn't actually care about the type in question. This is another step in making actions more agnostic, to allow for an easier transition to a generic "action" key. Bug: 893373 Change-Id: I8b7551eba8cecc846df1524d7b1af254b40a0525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133117 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#757627}
-
Tibor Goldschwendt authored
Makes simple and animated doodles focusable. Emulates click when pressing space or enter on a focused doodle. Bug: 1039910 Change-Id: I705f9dc048be0d2cbb30bb601e5a9d3e7cf2a2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140775 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#757626}
-
Scott Violet authored
I came across this when looking at some code. This code was added for mash: https://chromium-review.googlesource.com/c/1423397 . I'm pretty sure it's no longer necessary. BUG=none TEST=none Change-Id: I4338dbb7fd7b2dd8e795ffca37c38930f49cb9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142316Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#757625}
-
Siyu An authored
Fixed: 1063901, 1063902, 1063903, 1066018 Change-Id: I1f47abc3c1aeda75a77e33fd7f9a69dec35a7014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140618 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#757624}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates DistilledPagePrefsView class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: I02df44675d0cc422b2d5681f3b9e946021718703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139716Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757623}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e3984a4c68e..c2a74de9d52b Created with: gclient setdep -r src-internal@c2a74de9d52b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com Change-Id: I20ea091653315c409de859a45207cfc9c688f9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142485Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757622}
-
Nnamdi Theodore Johnson-Kanu authored
This CL removes Easy Unlock Page strings that are not used/referenced in ChromeOS or browser settings. Bug: 967883 Change-Id: Ic668157f7d6a3bd37541620e339103e97a6099b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142143 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Andrew Grieve authored
Goals: 1) Fix incremental build speed regression of desugar_with_d8=true 2) Fix release build binary size regression of desugar_with_d8=true 3) Allow method backporting even when desugaring with Desugar.jar desugar_with_d8 = is_java_debug is replaced by: enable_bazel_desugar = true When this is set to false, D8/R8 is the only source of desugaring. Bug: 1067278 Change-Id: I637dc434b56af6b43bf56c3448bfa9992f84a7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142392 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757620}
-
Peter Kasting authored
This partially reverts commit c878198d. The programmatic computation is only enabled for extension and autogenerated themes for now. Long-term, we will figure out something we can do consistently, then enable that for all themes. Bug: 878664, 1068907 Change-Id: I8e66aac3f75dd25f0938d8ff1a61b1add4b855f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141650 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#757619}
-
Gyuyoung Kim authored
This CL moves relpos-with-percentage-top.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this CL renames the file name to position-relative-percentage-top-001.html to be align with WPT test names. Bug: 1063749 Change-Id: I28c7e91e25678f30ad7af38464be8bfc6c87644b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134752 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#757618}
-
Oriol Brufau authored
When inspecting a ::marker originated by a ::before or ::after pseudo elements, the devtools use InspectorCSSAgent::getMatchedStylesForNode to retrieve the styles of the ::marker. This ends up calling MatchSlottedRules, which gets the AssignedSlot() of the originating ::before or ::after. But pseudo-elements can't have an assigned slot, so a DCHECK fails. This patch avoids this problem by aborting PseudoCSSRulesForElement in case that we have a pseudo-element. This also fixes the issue that devtools used to say that a *::marker selector would match a nested ::before::marker or ::after::marker. BUG=457718 TEST=http/tests/devtools/elements/styles-2/nested-pseudo-elements.js TEST=inspector-protocol/css/nested-pseudo-element-matching-selectors.js Change-Id: I78a1efe708dc1668934025141231b2cc87f34136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138413 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#757617}
-
Chong Gu authored
Add flags to turn on Vulkan for content_shell on Fuchsia in AEMU. Skip tests that don't work with Scenic. Create new cmx for content_shell. Bug: 1047480 Change-Id: Iaff6064da088647041bef33646297ef652218aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055793Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#757616}
-
Renjie Tang authored
This reverts commit 5d234387. Reason for revert: The session cache needs more implementations. It shouldn't be used right now. Original change's description: > Initialize QuicClientSessionCache in QuicCryptoClientConfig. > > Change-Id: I1f82aab5bf180adf0dc489b833689fabbf9a1749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122864 > Reviewed-by: Nick Harper <nharper@chromium.org> > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753821} TBR=nharper@chromium.org,renjietang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I49553222e74e22ac194b8cc50f1d11bb28844737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142616Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757615}
-
