- 06 Sep, 2019 40 commits
-
-
Javier Ernesto Flores Robles authored
Integration test for other password in Manual Fallback. Should fail before the fix (crrev.com/c/1784614) is merged. Bug: 997632 Change-Id: I1c9ea719c85e8ba56fe3a6ca50a1d600e8ad2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783446Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694250}
-
Dominik Röttsches authored
This reverts commit dcf25ed5. Re-enable field trial config on Windows for FontSrcLocalMatching after bot testing has stabilzied, see issue 996167. Note to sheriffs: Should you see crashes or issues with DWriteFontLookupTableBuilder or testing issues relating to matching @font-face: { src: local() } fonts on Windows, in particular Windows 7, please only revert this CL, preferably not the related one: https://chromium-review.googlesource.com/c/chromium/src/+/1777862 - if you can't reach drott@, try getting in touch with etienneb@ please before reverting. Thanks. Bug: 999787 Change-Id: I47a18fc1c31d0879700378a8924aff23de64997a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787614 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694249}
-
Andrew Grieve authored
Guessing they used to be required for ProGuard. Change-Id: I52d708459530daddbab9a20c82dd743ee3193cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786873 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694248}
-
Olga Sharonova authored
This reverts commit 74ae0216. Reason for revert: Looks like not a root cause Original change's description: > Revert "Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded" > > This reverts commit 0b7170d7. > > Reason for revert: Speculative: suspected of causing failures of > InfoCollection_basic > InfoCollection_direct_composition > https://ci.chromium.org/p/chromium/builders/ci/Win10%20x64%20Debug%20%28NVIDIA%29/829?blamelist=1#blamelist-tab > > Original change's description: > > Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded > > > > - Add a JNI method to callback when both DeviceInfoTracker and > > LocalDeviceInfoProvider are ready > > - Also removed redundant setVibration in SharingNotificationUtil > > > > Bug: 996318 > > Change-Id: Id4df6b407ac2fb1c1622071ffb7ee8bb3a747b41 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787379 > > Commit-Queue: Alex Chau <alexchau@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Richard Knoll <knollr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694208} > > TBR=treib@chromium.org,alexchau@chromium.org,knollr@chromium.org > > Change-Id: I3837352ddf7345751b679f4065b0c00de28d5d43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 996318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789234 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694223} TBR=treib@chromium.org,olka@chromium.org,alexchau@chromium.org,knollr@chromium.org Change-Id: I377486659e744c6d9f69659e845d6b5d88253fd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789533Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#694247}
-
Finnur Thorarinsson authored
Bug: 988278, 860467 Change-Id: Ie77f86b054818f87d9d75531c5d8f160ba8e2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778499 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694246}
-
Rune Lillesveen authored
Disconnected elements do not have style and ancestor computed styles need to be construced in order to do inheritance. Attempt at adding sanity DCHECKs in StyleResolver failed because of these tests. Change-Id: Ic61abc2dc84ccf0d303fde41900e819b6b0723ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789528 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#694245}
-
Antonio Gomes authored
... and base::flat_set. Instead WTF::String and WTF::HashSet are used, respectively. This is a follow up of [1]. [1] https://crrev.com/c/1785162 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I774b039e67c98fb07c4e01bdb64e5ca8b31c885d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786037 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#694244}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/565f1b848215..3f05f651ae36 git log 565f1b848215..3f05f651ae36 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 absl-team@google.com Googletest export 2019-09-06 absl-team@google.com Googletest export 2019-09-06 krystian.kuzniarek@gmail.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@3f05f651ae36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Id6b8a4dd5808ec674050f344332c6add93461845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694243}
-
Olga Sharonova authored
This reverts commit 3df4743f. Reason for revert: suspected root cause of bug 1001496 BUG: 1001496 TBR:rockot@google.com, alevelthal@chromium.org Original change's description: > Fix LocalizedLandmarkType for contentinfo aria role and <footer> scoped to body > > Change the LocalizedLandmarkType and LocalizedControlType for the > contentinfo aria role from "content info" to "content information" per > https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. > > Also update the LocalizedLandmarkType for <footer> when scoped to the > body element to "content information", since it inherits this from > the contentinfo role per https://w3c.github.io/html-aam/#el-footer. > > Note that this doesn't affect <footer>'s LocalizedControlType, > which should be "footer" (but is currently still "content info"). > That is handled in the separate change at > https://chromium-review.googlesource.com/c/chromium/src/+/1763243. > > Bug: 997897 > Change-Id: If958b2090447010f0c0f3839739354dd4a0ea683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772228 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Dan Clark <daniec@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#693375} TBR=rockot@google.com,aleventhal@chromium.org,kbabbitt@microsoft.com,daniec@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997897 Change-Id: I3da07d47fd4cdd502f2ecbfb191293bcfa95ea2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789295 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Backport some tests in /components/password_manager/core/browser/android_affiliation to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/password_manager/core/browser/android_affiliation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 891670 Change-Id: Ia5d73069ba593026184db80de535de0090617c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786997 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694241}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d0131152681b..d915f1866fa0 git log d0131152681b..d915f1866fa0 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 vapier@chromium.org sysroot_lib: rename async to background for Python 3.7 Created with: gclient setdep -r src/third_party/chromite@d915f1866fa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibde134de4b52887170bbae5ee62eb480ab165e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789546Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/19b256616d96..b218ad19949f git log 19b256616d96..b218ad19949f --date=short --no-merges --format='%ad %ae %s' 2019-09-05 stevenperron@google.com Fold Min, Max, and Clamp instructions. (#2836) 2019-09-05 stevenperron@google.com Replace uses of SPV_AMD_shader_trinary_minmax extension (#2835) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b218ad19949f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I259553b5768c437f332e53805ad759a166d8c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788984Reviewed-by:
-
Alex Chau authored
This would avoid the timer not firing in background for Android Bug: 1001098 Change-Id: I18b8bb3a6b9fdc55a159bd936554c9331392cf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789584 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#694238}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50b0baf510da..a3baf2a3b165 git log 50b0baf510da..a3baf2a3b165 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 nisse@webrtc.org Add one more BasicPortAllocator constructor 2019-09-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cccc3ec..df72a9a5 (694083:694187) 2019-09-06 titovartem@webrtc.org Refactor video analyzer injection helper 2019-09-06 nisse@webrtc.org Reland "New build target p2p:stun_types" 2019-09-06 phoglund@webrtc.org Prepare to move packet_socket_factory to api/. Created with: gclient setdep -r src/third_party/webrtc@a3baf2a3b165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib9df1e39dfaeb12c3e65804317719f173ca299c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789544Reviewed-by:
-
Jesse Schettler authored
Ensure the print document is being deleted on a non-UI thread when the print session ends. Bug: b:139551164 Test: Close print preview and verify print document is deleted Change-Id: I4e0afbaf2942b7a2fb89b319a3885855243963d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787558 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#694236}
-
Ulan Degenbaev authored
The filtering of GC results is now done by the GC metric. Bug: 1000187 Change-Id: Ie2c43485cef863c96ec92b4509b20c3d36f62c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789285Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694235}
-
Matt Menke authored
There was a field trial for this two years ago, but it's been left disabled by default since then. We should enable this by default, or remove it. I've opted for the latter. Bug: 705031 Change-Id: I91a93d1b8429e08bb06377a9e379168618e2e815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788324 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#694234}
-
Marc Treib authored
This tags a PasswordForm as coming from either the profile-scoped store or the account-scoped store (or "not set", as the default value or for parsed forms). It will be used to differentiate these credentials in the filling UI and in settings. Bug: 998455 Change-Id: Idb49c7f0a5e659eb0e070c489adedd20bf192c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749187Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#694233}
-
Ilya Nikolaevskiy authored
Bug: webrtc:10925 Change-Id: I7ef59ed0387cbcb43a4c3ba03b807751593d97d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786643 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#694232}
-
Leonard Grey authored
Mac and Aura have different ideas about what it means for a widget to be "active". The check is not necessary on Mac, and certain conditions (for example, opening an internal link via the profile menu) break an important accessibility focus workaround. Bug: 926492 Change-Id: I8a0760f44703c642795396becb0807df473755f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787464Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#694231}
-
Antonio Gomes authored
Now that its child class (WebTransmissionEncodingInfoHandler) has been moved to Blink [1], it can be used directly. [1] https://crrev.com/c/1785162/ BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I6f34a60260c214e7e74e09fc36e8ff7b94a8319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784906 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
François Beaufort authored
Following https://github.com/gpuweb/gpuweb/pull/327 change, this CL makes GPUSamplerDescriptor optional in GPUDevice.createSampler(). Change-Id: I09f931a7194063960a30a45d585963c9aa180cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789307 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#694229}
-
Joshua Pawlicki authored
Bug: 997862 Change-Id: I4e32c0f5bf8ecc1fe94ac813ab6b7806ea5fca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772297Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694228}
-
Olivier Robin authored
Bug: 994775 Change-Id: I9156b827969930dfb0f98b1f24edc1247024ecb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789309Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#694227}
-
Jinfeng Ma authored
Scroll corner depends on scrollbars, so it shouldn't be destroyed only when css pseudo-element style is removed, hidden or destroyed scrollbars also need to be considered. This CL needs to be submitted after: https://chromium-review.googlesource.com/c/chromium/src/+/1778899 SetDangerousOneWayParent prevents us from destroying custom scroll corner after layout. Bug: 999062 Change-Id: I3032c69e61752b76b9a78ac337e0ac9f710b01ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775652Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694226}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/consent_auditor. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vitaliii@chromium.org Bug: 891670 Change-Id: Ia30be54ecda2737d30a4eee109d023673342361d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786689 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694225}
-
arthursonzogni authored
This test CL disabled the test: DropDownListTest#testDropDownScaledViewPortUseWideViewPort on more devices, including the Pixel 2. Tbr: aluo@chromium.org Bug: 947352 Change-Id: I09c52e1d3b49e8ef03b5c5bd97e58c1d0f38e3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789311Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694224}
-
Olga Sharonova authored
This reverts commit 0b7170d7. Reason for revert: Speculative: suspected of causing failures of InfoCollection_basic InfoCollection_direct_composition https://ci.chromium.org/p/chromium/builders/ci/Win10%20x64%20Debug%20%28NVIDIA%29/829?blamelist=1#blamelist-tab Original change's description: > Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded > > - Add a JNI method to callback when both DeviceInfoTracker and > LocalDeviceInfoProvider are ready > - Also removed redundant setVibration in SharingNotificationUtil > > Bug: 996318 > Change-Id: Id4df6b407ac2fb1c1622071ffb7ee8bb3a747b41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787379 > Commit-Queue: Alex Chau <alexchau@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694208} TBR=treib@chromium.org,alexchau@chromium.org,knollr@chromium.org Change-Id: I3837352ddf7345751b679f4065b0c00de28d5d43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789234Reviewed-by:
-
Gabriel Charette authored
Backport some tests in /components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vitaliii@chromium.org Bug: 891670 Change-Id: I2716a45c81b330e553938972f2d856dc96198ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786751 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/sync_sessions. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vitaliii@chromium.org Bug: 891670 Change-Id: I7d613562534207fcb526a2e8cbd1bff08ddb28e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786847 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
All passwords is now presented from the browser coordinator. Browser Coordinator is now the AutofillSecurityAlertPresenter. PasswordListNavigator has been split into 2 protocols. FormInputAccessoryCoordinatorDelegate is renamed to FormInputAccessoryCoordinatorNavigator ivars named manualFillInjectionHandler renamed to injectionHandler. Regression test: crrev.com/c/1783446 Bug: 997632 Change-Id: I85166491cdd6b898ee4451a6fcb9e0b343c75e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784614 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Olga Sharonova authored
TBR=lanwei@chromium.org Bug: 999261 Change-Id: Ide11dca175c8dc96fdd279294b2e39171065ab20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789232Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ebdb12ff. With Chromium commits locally applied on WPT: 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js" 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3f47374f958d8d1a25f6d0d45f41434605a3b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789442Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac3232fef4c9..dff4674a483a Created with: gclient setdep -r src-internal@dff4674a483a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia4cb382bd53cdf7efe954e9e5440368285d0cba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694217}
-
François Beaufort authored
This CL makes GPUDevice an EventTarget. When an uncaptured error is raised in Dawn, the "uncapturederror" error is fired in GPUDevice. Change-Id: Ib0082e080667448e309d9879ea22de7ac1706fad Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787504 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694216}
-
Rune Lillesveen authored
Only the root element of the display:none subtree needs that. ComputedStyle below the root will follow from propagating the StyleRecalcChange down RecalcStyle() if necessary. This CL avoids unnecessary style recalc passes over display:none or non-slotted children. Bug: 972752 Change-Id: I39dc393104b27a6734705120902b2f173dfd9566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782855Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694215}
-
Armando Miraglia authored
This CL replaces the usage of unretained pointers with weak pointers in VideoCaptureManager. This conversion is safe because all places where the pointers are saved are on the IO thread as well as the place were the callbacks are then executed (see line 326 and 348). BUG=998548 Change-Id: I47bda798fa7bcbd66bf23682ee6c6dd26b5642c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789223Reviewed-by:
-
Olga Sharonova authored
TBR=aee@chromium.org Bug: 1000950 Change-Id: Iee20cc3507c1e3e174450bb1f2dc7bf90114ca90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789286Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5d0faf9be9d7..6726fcfdd4aa git log 5d0faf9be9d7..6726fcfdd4aa --date=short --no-merges --format='%ad %ae %s' 2019-09-06 swiftshader.regress@gmail.com Regres: Update test lists @ 5d0faf9b Created with: gclient setdep -r src/third_party/swiftshader@6726fcfdd4aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I5a5cc1cc69c759d24ba7bd037ea2b40a51857ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789462Reviewed-by:
-
Nazerke authored
This CL changes splash screen, shown before 'Accept and continue' screen, after fresh install and launch chrome into dark in dark mode. Bug: 997170. Change-Id: If35987cf9b50ca12a662f9de7f15080a0909f3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787384 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
