GitLab

BUG=See https://github.com/catapult-project/catapult/issues/2738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2300653002
Cr-Commit-Position: refs/heads/master@{#415805}

This CL adds the submit button as requested in https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20Pin%20lock%20pods.png%3Fz=width. Moves the caps lock button accordingly.

BUG=638643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2254623003
Cr-Commit-Position: refs/heads/master@{#415804}

AVDACopyingBackingStrategy is unused so it's now deleted. Since we only have a single
strategy left, it's renamed to AVDAPictureBufferManager, since its role is mostly
to associate PictureBuffers with MediaCodec buffers.

BUG=637463

Review-Url: https://codereview.chromium.org/2296513003
Cr-Commit-Position: refs/heads/master@{#415803}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c9d33b2cad5e6ac88718541b140ba551cb36f37 Add use_sysroot=false to Linux PDFium bots. (thestig@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2295723005
Cr-Commit-Position: refs/heads/master@{#415802}

BUG=636507

Review-Url: https://codereview.chromium.org/2287993004
Cr-Commit-Position: refs/heads/master@{#415801}

The SDK used shouldn't be dependent on lint in any way, so make the lint variables dependent on the SDK instead.

BUG=640267

Review-Url: https://codereview.chromium.org/2294823002
Cr-Commit-Position: refs/heads/master@{#415800}

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests
TBR=pastarmovj

Review-Url: https://codereview.chromium.org/2303483002
Cr-Commit-Position: refs/heads/master@{#415799}

This is a revision to https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be reverted due to a linker error impacting Android bots w/ symbol_level=1. The delta from that CL is to extract WebSocketHandle as a pure interface so that the unit test can simply mock it out without need to link against implementations of WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2284473002
Cr-Commit-Position: refs/heads/master@{#415798}

Revert of Moves ash content specific tests into ash_content_unittests (patchset #7 id:120001 of https://codereview.chromium.org/2296973002/ )

Reason for revert:
AshTestEnvironmentDefault::GetBlockingPool() never gets released causing memory leaks in tests:

WallpaperControllerTest.DontScaleWallpaperWithCenterLayout
WallpaperControllerTest.ResizeCustomWallpaper

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15788

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15787

Original issue's description:
> Moves ash content specific tests into ash_content_unittests
>
> The vast majority of the tests don't need content, so having to build
> content all the time is a drain (especially on windows).
>
> BUG=641026
> TEST=test only changes
> R=jamescook@chromium.org, dpranke@chromium.org
>
> Committed: https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e
> Cr-Commit-Position: refs/heads/master@{#415743}

TBR=reveman@chromium.org,dpranke@chromium.org,jam@chromium.org,jamescook@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641026

Review-Url: https://codereview.chromium.org/2303453003
Cr-Commit-Position: refs/heads/master@{#415797}

Cells' border boxes were not getting resized when their collapsed
border changed when a sibling with a dominant border was added.

BUG=613728

Review-Url: https://codereview.chromium.org/2281343002
Cr-Commit-Position: refs/heads/master@{#415796}

The StyleAdjuster::adjustStyleForAlignment logic is optimized to avoid
resolving 'auto' values on alignment properties using its parent's
align-items default value. This way we can minimize the copy-on-write
overhead, since 'auto' is the default value of some CSS Alignment
properties.

However, align-items default value is different depending on whether the
CSS Grid Layout feature is enabled in runtime flags or not. We were not
checking out the runtime flags when applying the optimization mentioned
before, hence, when Grid is disabled, we are overwriting all the
align-self properties with 'auto' values (the default) with its parent's
align-items default value (stretch). This was verified as the root cause
of the performance regression reported in bug 642263.

This patch solves the issue by using the proper default value, depending
on the runtime flags, when evaluating whether resolving the align-self's
'auto' values or not.

BUG=642263

Review-Url: https://codereview.chromium.org/2298613004
Cr-Commit-Position: refs/heads/master@{#415795}

Revert of Allow component-updated Flash to override the placeholder fake Flash even if (patchset #2 id:20001 of https://codereview.chromium.org/2298343002/ )

Reason for revert:
missing ;

Original issue's description:
> Allow component-updated Flash to override the placeholder fake Flash even if
> the version is lower.
>
> BUG=642323
>
> Committed: https://crrev.com/30f12cd92e58dddfd196e72356aea5abefacaf4d
> Cr-Commit-Position: refs/heads/master@{#415781}

TBR=wfh@chromium.org,waffles@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642323

Review-Url: https://codereview.chromium.org/2300883002
Cr-Commit-Position: refs/heads/master@{#415794}

Remove chrome_browser_ui.gypi

TBR=dpranke

Review-Url: https://codereview.chromium.org/2296333002
Cr-Commit-Position: refs/heads/master@{#415793}

This will give us an idea for how common it is to have in-body external
stylesheets and gauge the impact of making them not block paint or
determine if we need stronger protection like blocking the HTML parser.

BUG=481122, 638074

Review-Url: https://codereview.chromium.org/2286793002
Cr-Commit-Position: refs/heads/master@{#415792}

LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly
relying on WillBeginImplFrameOnThread only being called once after the
OutputSurface was recreated. In reality, this function could be called
multiple times.

This patch causes us to handle cleanup in DidInitializeOutputSurface,
which will only be called once after recreating an OutputSurface.

BUG=642881,642836
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2297413002
Cr-Commit-Position: refs/heads/master@{#415791}

ChromeExtensionFunctionDetails and ChromeUIThreadExtensionFunction have
many identical methods, and the implementations are nearly identical as
well (down to the comments being replicated). Instead, just give
ChromeUIThreadExtensionFunction a ChromeExtensionFunctionDetails and
use it directly to reduce duplicate code.

BUG=None

Review-Url: https://codereview.chromium.org/2296603005
Cr-Commit-Position: refs/heads/master@{#415790}

Remove chrome_browser.gypi

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2296863005
Cr-Commit-Position: refs/heads/master@{#415789}

MouseWarpController and its implemenations must be implemented
differently in mus so separate them from the eventually shared between
ash and mus DisplayManager code.

BUG=581462

Review-Url: https://codereview.chromium.org/2282903003
Cr-Commit-Position: refs/heads/master@{#415788}

Reason: When downloading expectations for newly imported/updated w3c
tests, we only want to download baselines for tests that are modified
in the CL, because w3c test update CLs only modify tests (not Blink
source code).

This should prevent downloading baselines for other tests that failed
on the try bots on some platform.

BUG=629275

Review-Url: https://codereview.chromium.org/2291153003
Cr-Commit-Position: refs/heads/master@{#415787}

BUG=606513

Review-Url: https://codereview.chromium.org/2296833002
Cr-Commit-Position: refs/heads/master@{#415786}

BUG=629006, 630372

Review-Url: https://codereview.chromium.org/2298273003
Cr-Commit-Position: refs/heads/master@{#415785}

This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation
to make it more reliable (by ensuring a more proper clean up).

BUG=640319

patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1)

Review-Url: https://codereview.chromium.org/2303443002
Cr-Commit-Position: refs/heads/master@{#415784}

wasCached() does not contain memory cache hit case. But WebFonts
intervention study's results imply memory cache hit case is not
minor group, but probably bigger one than Miss group.

This patch adds one additional group MemoryHit to WebFoint.CacheHit
metric to ensure memory cache hit ratio.

Review-Url: https://codereview.chromium.org/2289113002
Cr-Commit-Position: refs/heads/master@{#415783}

Adds the initial plumbing needed in order to move
Ash-specific .icon files out of ui/gfx/vector_icons
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual

Review-Url: https://codereview.chromium.org/2251643011
Cr-Commit-Position: refs/heads/master@{#415782}

the version is lower.

BUG=642323

Review-Url: https://codereview.chromium.org/2298343002
Cr-Commit-Position: refs/heads/master@{#415781}

This experiment is rolled out to 100% of users server-side, so:
(1) Update the client code to default to the new code path, and
(2) Remove the old code path, which is no longer reachable.

BUG=none
TEST=none
R=mlliu@chromium.org

Review-Url: https://codereview.chromium.org/2282273002
Cr-Commit-Position: refs/heads/master@{#415780}

BUG=642709

Review-Url: https://codereview.chromium.org/2295043004
Cr-Commit-Position: refs/heads/master@{#415779}

The highlight animations for download item views was being posted to a
non-nested loop. This allowed them to clear after returning from a blocking
menu call.

Menus do not block now. Updating the animations to register a callback
with DownloadShelfContextMenuView so that they can clear the highlight
once the menu has closed.

TEST=manually test download visuals
BUG=642672

Review-Url: https://codereview.chromium.org/2295323002
Cr-Commit-Position: refs/heads/master@{#415778}

This removes the duplication of outputs from core/inspector:protocol_sources to
the compiled version in core:core_generated. A new target is created
core/inspector:protocol that uses get_target_outputs on :protocol_sources to
avoid duplicating the sources list.

To make this easier to implement, the core_config_add and core_config_remove
configs list were moved to core.gni so it can be shared with multiple core
build files.

The inspector_protocol.gni file was changed from listing the sources to
defining a template to run the script. This elimiates some duplicated code
between the two users of this script.

BUG=

Review-Url: https://codereview.chromium.org/2294123002
Cr-Commit-Position: refs/heads/master@{#415777}

Revert of Remove default begin frame sources from the renderer (patchset #11 id:200001 of https://codereview.chromium.org/2083423006/ )

Reason for revert:
Speculative revert as there are some bots failing with a common and related stack.

Original issue's description:
> Remove default begin frame sources from the renderer
>
> This changes both cc proxies to no longer create default begin frame
> sources.  In cc, it must either be the case that an external begin frame
> source is provided (with use_external_begin_frame_source set) or the
> output surface provides a begin frame source (with
> use_output_surface_begin_frame_source).
>
> This changes the world from three states of BFS creation (default,
> output surface provided, and external) to only two (output surface
> provided and external).  In the future, external will also be removed.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
> Cr-Commit-Position: refs/heads/master@{#415757}

TBR=danakj@chromium.org,sievers@chromium.org,enne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2296353002
Cr-Commit-Position: refs/heads/master@{#415776}

BUG=630753

Review-Url: https://codereview.chromium.org/2247063002
Cr-Commit-Position: refs/heads/master@{#415775}

This change moves the connection validation logic for It2Me from the host
factory and into a callback in the It2Mehost class.

A subsequent change will move the confirmation dialog into this new method as
well but that is a larger change and I wanted to keep the initial change small.

BUG=617185

Review-Url: https://codereview.chromium.org/2271933002
Cr-Commit-Position: refs/heads/master@{#415774}

This field trial has expired.

BUG=557984

Review-Url: https://codereview.chromium.org/2280183002
Cr-Commit-Position: refs/heads/master@{#415773}

After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL
enables to install the downloaded WebAPK to finish the updating.

This CL depends on CL (https://codereview.chromium.org/2259553002/).

BUG=631025, 637097

Review-Url: https://codereview.chromium.org/2264753002
Cr-Commit-Position: refs/heads/master@{#415772}

Since the verdict field is currently marked as 'required', whenever Chrome (or Firefox) can't parse this field properly, it leads to an overall failure in parsing the entire proto message.

Making it optional with a default value (SAFE) solves that problem.

See: cl/131841696

BUG=

Review-Url: https://codereview.chromium.org/2292963004
Cr-Commit-Position: refs/heads/master@{#415771}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f835a9107ae607130e9c658067a23c7334b22f83 Revert of lightweight builds archiving for mac and win64 (patchset #8 id:140001 of https://codereview.chromium.org/2279953002/ ) (miimnk@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=604452

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2298873003
Cr-Commit-Position: refs/heads/master@{#415770}

Both drag and drop and context menu use the same gesture: long press on Android.
In order to maintain backwards compatibility, we need to suppress drag and drop
for links on Android and continue to use long press gesture for context menus.

This change also applies to other platforms with a touch screen, so that touch
screen behavior is consistent on all platforms.

BUG=636005

Review-Url: https://codereview.chromium.org/2247963002
Cr-Commit-Position: refs/heads/master@{#415769}

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2290763002
Cr-Commit-Position: refs/heads/master@{#415768}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d16d190..4877527d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2301643002
Cr-Commit-Position: refs/heads/master@{#415767}

https://pdfium.googlesource.com/pdfium.git/+log/fc9b11358a47..21b111fcf71e

$ git log fc9b11358..21b111fcf --date=short --no-merges --format='%ad %ae %s'
2016-08-31 thestig Attempt to fix potential integer overflow in CFX_FaceCache::LoadGlyphPath().
2016-08-31 dsinclair Use CheckedNumeric for strength calculation.

BUG=641333,639506

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2300793002
Cr-Commit-Position: refs/heads/master@{#415766}