GitLab

Currently if a webapp shows a safe-browsing interstitial, the webapp is
closed and the page is launched in browser mode. The purpose of this
logic was to work around bug where Chrome could not display multiple
interstitials (e.g. interstitial in webapp and interstitial in Chrome
browser). crbug.com/293717 Based on testing, the underlying bug is fixed
and the workaround is no longer needed.

BUG=1073748

Change-Id: If1aedb38d7c6c5eed08e3de2c61ed72818ce1244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161453Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761956}

Bug: 1073518
Change-Id: Ic29cf58a00cb200e5d3aa5565834621d50c169d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162825Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761955}

The image orientation is not applied when creating a CanvasImageSource
directly from an uploaded file. This is because we do not extract and
pass on the orientation from the decoder.

Fix it by obtaining orientation from the decoder on the worker thread
and passing it back to the original thread to create the image.

Bug: 1069965
Change-Id: I3f64519ed8b91e97bfa9afc802fe90ceb7eb2c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160353Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761954}

This class is meant to parse the JSON of the connector policies and
give a clean abstraction to get settings and to eventually cache these
settings.

Change-Id: I7b15dddc36a0a8727c26cd5421eec04e3fdde2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147874Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761953}

Since the <script> tag appeared after defining the base URL of the
document, the script wasn't fetched and run. This likely worked out
anyway because of having Ahem available through other means.
Fix this and export the test to WPT while at it.

Change-Id: I9dff35db0bcfa6ccaa697d791583e897e47b768f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162888Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#761952}

Improper use of Unretained in asynchronous callbacks can lead to
crashes or even UAF. In this particular case, it appears that
we're using Annotator as a singleton, so Unretained might be okay - but
just to be safe, and to prevent future issues, using a WeakPtr is
super easy and provides some extra safety.

Bug: none
Change-Id: If01b73c142c8df3641b8112f62fe1e560f5d7d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161768Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761951}

This reverts commit c71eaf36.

Reason for revert: CL breaks chrome perf builder

Original change's description:
> Componentize ChannelsInitializer
> 
> ChannelDefinitions is made into an abstract class that exposes
> functionality to ChannelsInitializer, and defines useful types like
> PredefinedChannel. The channel definitions themselves live in the
> Chrome subclass, ChromeChannelDefinitions. Some of these definitions
> will be duplicated later for WebLayer.
> 
> ChannelsInitializerTest uses ChromeChannelDefinitions so it's left
> in //chrome. (We could replace ChromeChannelDefinitions with a
> TestChannelDefinitions, but that would reduce coverage of production
> code.)
> 
> Both the channel IDs and the channel group IDs will have to be different
> for WebLayer. It would be possible to account for this in code by
> judiciously prepending "org.chromium.weblayer.", and then keeping
> the channel definitions together, but that was both more complicated
> and seemed more error prone, as it would mean that the
> ChannelDefinitions.ChannelId type would no longer represent the Android
> system notification channel identifier. For example, code that used
> NotificationManagerProxy.getNotificationChannel() would have to be
> careful *not* to pass ChannelDefinitions.ChannelId without adding a
> prefix. In Chrome, which has no prefix, this would succeed, but in
> to-be-shared code, such as NotificationCompatBuilder, this would succeed
> for Chrome and fail for WebLayer.
> 
> Bug: 1069895
> Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066
> Commit-Queue: Evan Stade <estade@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#761922}

TBR=peter@chromium.org,dtrainor@chromium.org,estade@chromium.org,xingliu@chromium.org,knollr@chromium.org

Change-Id: I1e0af9d688d5c7a23b2977f0ef7471716c07c8ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1069895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162771Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#761950}

This change modifies the FieldPropertiesFlags enum to use kEnumStyle
instead of MACRO_STYLE for its enumerators.

Bug: 1071122
Change-Id: Iea64dce0effdc11c48542292b542f10dcd2df6f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162730Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761949}

Move the expiry date of the ReadingList histograms by one year.

Fixed: 1072582
Change-Id: Iea0c8dbe0b6e3c573a80f472b77173d76c7577e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159714
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761948}

Commit cb62c8fc
(https://chromium-review.googlesource.com/c/chromium/src/+/2155497)
removed the use of ChromeAsyncExtensionFunction from
media_galleries API, but left its #include behind.

This CL changes the include to the correct one:
"extensions/browser/extension_function.h"

This CL also removed unused "chrome_extension_function_details.h"

Bug: 634140
Change-Id: Id00bc2388beec26269c2470e6206a6c63d5b9f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162367
Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761947}

We're working to enable Clank to act as a security key. Behind a flag
it's now possible to exercise this code in Canary but, unlike in local
builds, trying to do so crashes with:

04-22 14:55:04.709 11850 11850 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.chrome.canary/org.chromium.chrome.browser.settings.SettingsActivity}: E9: Unable to instantiate fragment yy2: could not find Fragment constructor
...
04-22 14:55:04.709 11850 11850 E AndroidRuntime: Caused by: java.lang.NoSuchMethodException: yy2.<init> []

This is happening at the call here[1]. If I check the ProGuard mapping file, we indeed find:

org.chromium.chrome.modules.cablev2_authenticator.CableAuthenticatorModuleProvider -> yy2

However, if I pull the release APK from the device and disassemble it with apktool, yy2.smali contains:

.class public abstract Lyy2;
.super LH9;    // maps to Fragment
.source "chromium-Monochrome.aab-canary-412200223"

That explains why yy2.<init> cannot be found, but the class wasn't
abstract[2] when it started out! (There is a dynamic feature module in
play here, but this part of the code all lives in the base module.)

I'm guessing that Proguard is discarding the contents of the class
because it cannot see the use via reflection. Thus I'm taking a guess
that we need to explicitly configure it with this change. I have not
verified that this works, however. I'll probably need to wait for
another Canary release for that.

[1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java;l=502;drc=2bec188eb6264f8decadf7629ede3de73cfe585c?originalUrl=https:%2F%2Fcs.chromium.org%2F
[2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/modules/cablev2_authenticator/public/java/src/org/chromium/chrome/modules/cablev2_authenticator/CableAuthenticatorModuleProvider.java;l=29;drc=2bec188eb6264f8decadf7629ede3de73cfe585c?originalUrl=https:%2F%2Fcs.chromium.org%2F

BUG=1002262

Change-Id: I708af8d222d18ece32976e882af531f9bc98aeb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161968Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761946}

Since NoStatePrefetch does not swap in prerenders, there is no reason to
keep this line in the deprecated code. The tests that run the deprecated
code don't have test coverage for this.

Bug: 10380658
Change-Id: I26807b1f44a83b273b0367f10eda11ba09002fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161966
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761945}

The restoration of the URL shouldn't be done for session restoration
URL, otherwise ther URL will be the session restoration URL of a session
restoratin URL, which create issues.
It also fixes tests, adding a timeout for checking the URL.

Fixed: 1073871, 1017147
Change-Id: Ia91e626d589d7ad5f04d34c9181160e8039f85fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162807
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#761944}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Iba562a6b740d6fdd70afe28b01c608fbb05a9c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761943}

synchronously.

Before this patch CompromisedCredentialsObserver operated on the UI thread.
- [UI] UpdateLogins
- [Background] change the password, notify the observers
- [UI] CompromisedCredentialsObserver processes the update
- [Background] compromised credential removed, observers are notified.

This is not ideal because removal of the compromised credential is
visible on the UI thread much later at unspecified time. Now:
- [UI] UpdateLogins
- [Background] change the password, notify the observers, compromised
password is removed, the observers are notified.
The UI thread sees the compromised credential gone as soon as the new
password value was updated.

Bug: 1049200
Change-Id: I9665bf77a216842925d913479c3d192597f3b606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162767Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761942}

Updates the expires_after attribute for 63 histograms that show
frequent access in the past 90 days.  These are the 100% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-10-18.

Change-Id: Ie66edd756524cc2e3b4f99dd1ae9cac5b1ad78dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162966
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761941}

These tests are timing out on Webkit Linux Leak. Bunch of similar tests
already have been disabled.

Tbr: hiroshige@chromium.org
Bug: 1068175
Change-Id: Idc4adb0e7a1d6bcba9a970c0662d5577c9554c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162728Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#761940}

The regressions is because we call sk_surface_->getCanvas(), it
will create a SkCanvas and cache it. Creating SkCanvas is not cost
free, so remove it for now.

Bug: 1071557,1071481
Change-Id: Ic21c8f066c4e4b3ece497bb9483f97bf012b462c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157286Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761939}

Update cros_healthd telemetry handling code to check for and log errors
from NonRemovableBlockDeviceInfo request.

Bug: chromium:1041153
Change-Id: I8d9d2af77d4b267fef2936dc71d5255dc3e3c5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150965
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761938}

This is a pure mechanical CL that moves all password feature manager
helper methods from the passord_manager_util.cc to a dedicated
password_manager_featuers_util.cc

TBR=vasilii@chromium.org,

Change-Id: Ib86307c4756709f4508f7ce0d33e08417af0b76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161075
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761937}

https://webrtc.googlesource.com/src.git/+log/9427b51d6ff5..e110a44628b1

git log 9427b51d6ff5..e110a44628b1 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 danilchap@webrtc.org Delete uri for the Generic Frame Descriptor v1
2020-04-23 ilnik@webrtc.org Revert "Launch external ref control for vp9 encoder"

Created with:
  gclient setdep -r src/third_party/webrtc@e110a44628b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1027108
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I1fbb3e5ede385d5dc0494e0c35be481b976cf44d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163005Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761936}

Bug: 1053101
Change-Id: I5c3ee229a94ff9326d9a9e3c19f2fed852aca4fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161448Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761935}

* Login.TokenObtainResponseTime

Fixed: 1072523
Change-Id: Ic19814674908b9ac5861b354cdeecdfd74f197b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162805Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761934}

Came across these deps when looking at updating the library.

It's pulled in via weblayer but turned out to be unused.
Saves 220kb normalized apk size for system_webview_apk.

Bug: 1064727
Change-Id: Ie1fc056d9d93da1942183ffe905fb836ad04f01c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159799Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761933}

When introducing |date_last_used| field in crrev.com/c/1768320
some PasswordFormData initialisations have been migrated to the new
field.

This CL is fixing that.

Those are only test changes and don't have any product behavioural
change.

Change-Id: If9df2cf8ee550e338a5c78594b9325c495fd5dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162769Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761932}

https://skia.googlesource.com/skia.git/+log/edccc66c323f..cefc2d9a4582

git log edccc66c323f..cefc2d9a4582 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 mtklein@google.com convert Val* fingers to int regs

Created with:
  gclient setdep -r src/third_party/skia@cefc2d9a4582

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Id65539ff87856574f64e0f41b84f8cd453901ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162692Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761931}

IOS platform has its own ConfigurationPolicyHandlerListFactory class and
policy_test_cases.json file. Add two files' links to the documentation.

Change-Id: I5e2f9202af1e306b9a47f8a9a4fd360533bf4df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157248
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761930}

This browser test EnterpriseEnrollmentTest.StoragePartitionUpdated
checks that storage partition is changed when the enterprise
enrolment screen is shown the second time. Currently, the test is
dependent on the fact that wizard controller is recreated on every call
to StartWizard() in login display host.
The goal is to make the test independent of this.

1) To fix this, the first enrolment screen is cancelled by tapping on the
back button. The exit callback of the screen hides it and shows the
login screen but |current_screen_| in the wizard controller still
points to the enterprise enrolment screen.
Due to this, the screen is not shown the second time as the wizard
controller thinks that it is already shown. To fix this,
|current_screen_| is reset to NULL when login screen is shown.

2) If the wizard control is reused and WizardController::ShowLoginScreen
is called multiple times, like in case of reset screen shown and hidden
multiple times, then due to login_screen_started_ being true after the
first time, the login screen is not shown in the further attempts. For
this we need to reset  login_screen_started_ when we advance to another
screen.

Bug: 1064271
Change-Id: I01d2c44a85256cb9d21f6a92f746bee3819fe074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144197
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761929}

Bug: 1036900
Change-Id: Ib3ba74825403c35b7e8d265d52ef20089accb681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161737Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761928}

Like 'deprecated' or 'future', 'cloud' will hide the policy from policy
templates and documentation. However, cloud policy will be treated as a
released policy.

Bug: 1067190
Change-Id: I9bbf195bb4805c7bf0f998f1d83917c82a320635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158014Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761927}

Bug: 1012203
Change-Id: I0e70dd0135bb84126b82bf62b55bc32cd04ae0d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160993
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761926}

https://android.googlesource.com/platform/external/perfetto.git/+log/595075bda5d3..34c40d668082

git log 595075bda5d3..34c40d668082 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 treehugger-gerrit@google.com Merge "Make github happy with LICENSE"

Created with:
  gclient setdep -r src/third_party/perfetto@34c40d668082

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I3463035cd9049053db0ecaf7563505f701816bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162693Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761925}

The DefaultUserAgent is only enabled for iOS 13. This CL updates the
tests to reflect that.

Fixed: 1073875
Change-Id: I9ad4490d80baad68cdbfeddd675d4105b989ad06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162749Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761924}

This reverts commit f909a6a2.

Reason for revert: _RemoveCurrentDirectoryPrefix was missing a
line to return the original argument if it was not modified,
i.e. the function was returning None if no modification took
place. This reland adds the missing return statement.

Original change's description:
> Revert "boilerplate.py: Ignore current-dir prefixes .\, ./"
>
> This reverts commit 9d14b9ec.
>
> Reason for revert: Change is breaking calls without .\ prefix.
>
> Original change's description:
> > boilerplate.py: Ignore current-dir prefixes .\, ./
> >
> > This change makes boilerplate.py trim a leading ".\" (Windows's
> > current-directory prefix) or "./" (Unix's current-directory prefix)
> > from the filename argument, if present.
> >
> > This is a convenience change for cases where the current-directory
> > prefix is prepended. For example, Windows PowerShell automatically
> > prepends ".\" to a path when tab completion is used (e.g., typing
> > "chrome/b" and pressing tab results in ".\chrome\browser"). This
> > change will remove artifacts of this for users who use tab completion
> > while typing the filename argument.
> >
> > Currently:
> > `tools/boilerplate.py .\test.h` produces include guard `__TEST_H_`
> > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "./test.h"`
> >
> > With this change:
> > `tools/boilerplate.py .\test.h` produces include guard `TEST_H_`
> > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "test.h"`
> >
> > Change-Id: I19fd2e72c58135b5e87d4a1e22ec8bc76ef326aa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157876
> > Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#761085}
>
> TBR=rsesek@chromium.org,jessemckenna@google.com
>
> Change-Id: Ic02537133fd1548f5279ead83abb0492d6657aaa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159993
> Reviewed-by: Jesse McKenna <jessemckenna@google.com>
> Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> Cr-Commit-Position: refs/heads/master@{#761185}

Change-Id: Iaef7fdecaff8ae205fd0c242777676bbffb788a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161895
Auto-Submit: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761923}

ChannelDefinitions is made into an abstract class that exposes
functionality to ChannelsInitializer, and defines useful types like
PredefinedChannel. The channel definitions themselves live in the
Chrome subclass, ChromeChannelDefinitions. Some of these definitions
will be duplicated later for WebLayer.

ChannelsInitializerTest uses ChromeChannelDefinitions so it's left
in //chrome. (We could replace ChromeChannelDefinitions with a
TestChannelDefinitions, but that would reduce coverage of production
code.)

Both the channel IDs and the channel group IDs will have to be different
for WebLayer. It would be possible to account for this in code by
judiciously prepending "org.chromium.weblayer.", and then keeping
the channel definitions together, but that was both more complicated
and seemed more error prone, as it would mean that the
ChannelDefinitions.ChannelId type would no longer represent the Android
system notification channel identifier. For example, code that used
NotificationManagerProxy.getNotificationChannel() would have to be
careful *not* to pass ChannelDefinitions.ChannelId without adding a
prefix. In Chrome, which has no prefix, this would succeed, but in
to-be-shared code, such as NotificationCompatBuilder, this would succeed
for Chrome and fail for WebLayer.

Bug: 1069895
Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761922}

Prerender only runs in the NoState Prefetch configuration, which doesn't
run script. Since pop ups can only be opened by script or click,
removing the pop up handling code is safe.

The removed test runs in the deprecated prerender configuration.

Bug: 1038054
Change-Id: Ie2442bdd3c4d03e20f7dd7fff0f63ccc0029f816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161315Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761921}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/209a6444a270..28447fd262e4

git log 209a6444a270..28447fd262e4 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 jacktfranklin@chromium.org Add ESLint rule to ban `assert.equal`
2020-04-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@28447fd262e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Icffe0095ea0df924556ef0b48c65226c1df3ffca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761920}

The test code was not waiting for pointerlockchanged and pointerlockerror events before checking for correctness.

Bug: 1014324
Change-Id: I04dac67731f954a5f220c426db031502a6309e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158934Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761919}

No longer logging the following disused metrics:

    LevelDBEnv.TimeUntilSuccessFor*
    LevelDBEnv.IDB.TimeUntilSuccessFor*
    MojoLevelDBEnv.TimeUntilSuccessFor*

Note: LevelDBEnv.IDB.TimeUntilSuccessFor did not have an entry in
      histograms.xml

Bug: 1053059
Change-Id: If6cd4783d8b0714a5a2a359cb4bab8b97b1c5a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161126
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761918}

Chrome Prerender (NoStatePrefetch) no longer runs script, so the
credentials manager can not run during a prerender.

Bug: 1038066, 658732
Change-Id: I34dc2229e56119cf7949b855d66e667511c9830f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158446Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761917}