- 13 Aug, 2020 40 commits
-
-
Ben Pastene authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic74f39a1c42e9c463e8ad492f7aa0ea978e63dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351454Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#797548}
-
Alexander Cooper authored
Now that it is impossible to enter the VR Browser, there is no need for android to provide mechanisms for entering text. All child "UI" classes allow for both the KeyboardDelegate and TextInputDelegates to be null, so the browser renderer factory can simply stop creating the classes. This is a speculative fix for the flaky tests described in the bug, and full cleanup of the classes/codepaths that are always null will be done at a future time. Bug: 1114265 Change-Id: I26977ac0faaf504702465369b4a33a2169181b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352519 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797547}
-
nancylingwang authored
Add the new temporary metrics to check whether all Arc app icons are real adaptive icons with separate foreground and background files. The information could be helpful to collect information for the next phase, e.g. whether we should refactor or removing the non-adaptive icon code. BUG=183331 Change-Id: Id0e5f58972cfe1f04c14f13aa2cf18a908bbf23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346092Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797546}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..dbee93ac203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I437f0c59866b2fcb7da57738fd7bc98cd16afcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797545}
-
Brandon Mousseau authored
This change extends android_aar_prebuilt to support including any assets in the aar file in the output. Currently, if the source aar file contains any files in the assets subdirectory, the target must define the ignore_assets flag. This change now optionally allows the user to instead supply the extract_assets flag so that the assets will be copied to the output instead. If assets are included in the source aar, then either ignore_assets or extract_assets, but not both, must be set. Assets will be copied to the output target with the same directory structure as the input aar file. Bug: 643966 Change-Id: Ibf66543fd9e9dc8db7221234b82c1d860f7f2724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350340 Auto-Submit: Brandon Mousseau <bmoose@google.com> Commit-Queue: Brandon Mousseau <bmoose@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797544}
-
Yue Li authored
Bug: b/152643590 Test: Manual Test Change-Id: Ifd67289fcd7e8d9e62816c4a318a7f78cfc268df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351726 Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797543}
-
Lukasz Anforowicz authored
The CL modifies URLLoaderFactoryParamsHelper::CreateForRendererProcess so that it sets |request_initiator_site_lock| of the process-wide factory to an opaque origin. This change is based on https://crbug.com/1105794 which shows that there are indeed no cases in the wild where a process-wide factory is used with a non-opaque initiator origin. This intuitively makes sense - the process-wide factory should only be used in frames that have not yet committed any navigation and such frame should not (yet) have a non-opaque origin. Additionally, thanks to the change described above, there is no longer a need for site/eTLD+1 comparisons in VerifyRequestInitiatorLock nor for SiteInstanceImpl::GetRequestInitiatorSiteLock. Fixed: 1098938 Change-Id: I9e8b53139a2418636c84e783f86ea8d7be34eed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274591Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#797542}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c4f3b713800f..cda86eff6461 2020-08-13 capn@google.com Implement shaderStorageImageMultisample support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I41f09004f0ef96a17479a119ce922da91e815a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352040Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597255086-4c97f40f3099850ce4002243596e1c9e8589ecba.profdata to chrome-mac-master-1597275686-7da657e756f53f89a89030a34195741313ee681f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id438759c3f712d359b4495d0981f3801aa9ff230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352693Reviewed-by:
-
Thomas Lukaszewicz authored
This CL adds the enum and histogram necessary to record whether or not the user switches tabs from within Tab Search from a filtered search result list or an unfiltered list. The matching WebUI CL is below: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3210171 Bug: 1099917 Change-Id: Ia45ced80831af962bd4b9a73c6ba1c297abaa6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348698Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797539}
-
Glen Robertson authored
on disk. Reading maskable icons will be added to app_icon_factory in next CL. Bug: 1102701,1114638 Change-Id: Iabfc86d745282e2a5a27f5c62f70df92186b44d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342224 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#797538}
-
François Degros authored
Split feature flag files-zip-no-nacl into flags files-zip-mount, files-zip-pack and files-zip-unpack. These flags will allow to independently develop and release different aspects of the new ZIP system in Files App. BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" --gtest_list_tests TEST=browser_tests --gtest_filter="ZipFiles/*" Change-Id: I2cfebb9befdb013e1b064bfe3d99fe39deba564f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348242Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#797537}
-
Kenichi Ishibashi authored
We still want to check this metric. Bug: 1037274 Change-Id: I73b51bd110fddc56a33e3c65adf65d0e0b73f16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352572Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Nasko Oskov authored
This CL adds a new tracing utility to //content/common that facilitates tracing all possible return paths out of a method. It is then used to add tracing to the ClassifyNavigation method of NavigationControllerImpl to make debugging through chrome://tracing easier. Bug: 1043616 Change-Id: I1e4ede0f39dfa507a90fd0ef92f671425761d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348699Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#797535}
-
Yuke Liao authored
This CL does two things: 1. Fix the position of comma. 2. Disable one more test in views_unittests. Bug: 1111979 Change-Id: Iee71b4e5fb790cca0fc7f0b104cc2a7ce81cb87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352037 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797534}
-
Weilun Shi authored
Use the unsafe version of the appendChild to reduce the overhead of appending sorted histograms in the new histograms node. Bug: 1115727 Change-Id: Idbf5d6aaca84d42990f1e367494611ee3a4d72a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352219 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797533}
-
Xianzhu Wang authored
This is to evaluate the performance improvement of the optimization in 1 or 2 canary builds. Will revert after that. This disables the optimization for composited scrolling added in crrev.com/774232. Bug 1113269 Change-Id: I2cf85fd5e550c1fef7d29f76b90e5d1b7219d579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353066 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797532}
-
Kenichi Ishibashi authored
This CL moves service worker script resource purging logic from ServiceWorkerRegistry to ServiceWorkerStorageControlImpl. See [1] for the motivation and how the new purging logic would work. [1] https://docs.google.com/document/d/1VnZN2k9YbpX1Xy-Yvo93DKDnW4-M2W-rwjkGF1swqLo/edit?usp=sharing Bug: 1055677 Change-Id: I4f8e9a54b47a9ec39538b8126ef8fb3e05f04c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348734 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797531}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fac64cf60aa2..dbee93ac203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If5261cbe52c07e591cc86a91bb4715aba5fdc021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353689Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie1c1dbf611a1ee7ee1404d34eabb7c5fed6e790e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353540Reviewed-by:
-
David Maunder authored
As part of the effort to move Tab attributes to UserData objects so Tab doesn't become too big and unwieldy. Bug: 1112171 Change-Id: I454c2acce385da7953c2f91bc5411a70cacc6dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347958 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#797528}
-
William Lin authored
Implementing a subset matching cache will require a more complex cache for the IdentityAPI class. At the moment, the existing cache is contained inside the IdentityAPI class. This CL separates the two, so all of the caching logic for IdentityAPI is in its own class. Additionally, unit tests have been added to test the basic functionality of this cache. Bug: 1100535 Change-Id: I39f5357d3ce87ae4d958aa2c8585cc2deec624be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343318Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: William Lin <williamlin@google.com> Cr-Commit-Position: refs/heads/master@{#797527}
-
Jinsuk Kim authored
The feature is not being deployed. This CL removes the flag. Bug: 949819 Change-Id: I13fa6aa8897b29971ecd27b0247af61ff2c29c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352253Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797526}
-
Martin Šrámek authored
Bug: 1015841 Change-Id: I4927a2ad0d7e1d4ca61c48efb557694dd6d03866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339994Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797525}
-
Darren Shen authored
InputMethodBase implements ImeInputContextHandlerInterface. Remove this dependency by moving all the Chrome OS only interfaces to ui/base/ime/ chromeos. Bug: 1083803 Change-Id: If63dba6e320bbb58df36687778f049e03729027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339401 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797524}
-
Eric Roman authored
This adds a default limit of 6000 on the open UDP sockets throughout the entire process, configurable with the "LimitOpenUDPSockets" feature. An "open UDP socket" specifically means a net::UDPSocket which successfully called Open(), and has not yet called Close(). Once the limit has been reached, opening UDP socket will fail with ERR_INSUFFICIENT_RESOURCES. In Chrome Browser, UDP sockets are brokered through a single process (that hosting the Network Service), so this is functionally a browser-wide limit too. Bug: 1083278 Change-Id: Ib95ab14b7ccf5e15410b9df9537c66c858de2d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350395Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797523}
-
Roberto Carrillo authored
I.e. project-chromium-tryjob-access R=estaab,vadimsh Change-Id: I6c5fa75eac552408641b14db89ca49fd7257ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353690 Auto-Submit: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#797522}
-
Karandeep Bhatia authored
This is part of the work to enforce isolated world CSP for resource requests when the feature IsolatedWorldCSP is enabled and to correctly bypass the main world CSP otherwise. Note that it's possible that the plumbed DOMWrapperWorld might not always be completely correct (for example if it is plumbed asynchronously from the point which caused the resource request). However this is still better than the status quo where the CSP checks for isolated worlds are bypassed based on calling FrameFetchContext::ShouldBypassMainWorldCSP() which is often incorrect especially for redirects since we might be in a different different world by then. Further CLs will ensure the DOMWrapperWorld is plumbed for all ResourceLoaderOptions object. BUG=1099975 Change-Id: I237175d070a1383453a128c7c97b701f4162399d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341843 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#797521}
-
Ted Meyer authored
When using the flag --enable-accelerated-video-decode, use this new angle pixmap. Bug: 1066176 Change-Id: I9619fbda3348c163618323474dfe1372d0c198e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119669 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797520}
-
Mitch McDermott authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/C4uGPvOKetOg4cH-ijCNNQo9zb0CSgH-DLV-l8618cYC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200811_RC00.html Bug: b/162102940, b/153113592, b/159083441, b/160021753, b/153274181 Fixed: 1112044 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I0a07263ed0ecc606f0b096dde7a9e3409b136856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351260Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mitchell McDermott <mcdermottm@google.com> Cr-Commit-Position: refs/heads/master@{#797519}
-
Justin DeWitt authored
No functionality changes, this is just a multi-sided rename. CL chain: - https://chromium-review.googlesource.com/c/chromium/src/+/2261633 - https://chromium-review.googlesource.com/c/chromium/src/+/2285471 - cl/320246139 - https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3167007 - [this CL] Change-Id: I0430d16ad79ea1d43bcdc63dbc5795ef7c1f3d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284097Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#797518}
-
Jeff Yoon authored
Autorollers were enabled, and rolled a bad PGO profile into src. Reverting win32 and win64 to profiles generated by the last known good builds: * https://ci.chromium.org/p/chrome/builders/ci/win64-pgo-trunk/2598 * https://ci.chromium.org/p/chrome/builders/ci/win32-pgo-trunk/3174 The bad profiles were uploaded before validation was introduced to prevent this. Autorollers have been paused until win pgo builders become green. * buganizer: https://buganizer.corp.google.com/issues/163192598 Bug: 1113316 Change-Id: Iad60607eeb66c85d596de90dc64e2f4e6024c7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353580Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797517}
-
Joel Hockey authored
Terminal settings are currently stored as SYNCABLE_PREF, but since Terminal System App only relates to Chrome OS, I believe it should be using SYNCABLE_OS_PREF. Change-Id: Iead464a35f0bcbf2a39ca6958073f11ad385e43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352252Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#797516}
-
Joe DeBlasio authored
The strings for desktop and Android are now the same. This CL just removes the unnecessary duplicate Android strings. Fixed: 1114359 Change-Id: I2dd409a93659a13505f48712b692c51b9a988fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353575 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#797515}
-
Kuo Jen Wei authored
Add check of no external monitor plugged in with screen backlight forced off event to judge whether to suspend camera stream. Bug: 1114967 Test: Pluggin both external camera and external monitor, check CCA's preview is still on after closing lid of device. Change-Id: Ia07e1efe9d21814521a62a4ad1c63324221b991d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351579Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#797514}
-
Jiewei Qian authored
Let browser_navigator check for OS Settings origin when it decides to open OS Settings in a standalone window. Before this CL, browser_navigator ignores the scheme and checks for os-settings host only. Thus URLs like http://os-settings/ will open a standalone window (with OS Settings icon). This is misleading. Fixed: 1114023 Change-Id: I8a8f5d21e3f3d6aae0d4baea9194ac64d065fcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342232Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797513}
-
Yuta Hijikata authored
Patch crrev.com/c/2326511 incorrectly imports <error.h> instead of <errno.h> to access char* program_invocation_short_name. It should be <errno.h> that is imported. https://linux.die.net/man/3/program_invocation_short_name BUG=chromium:1110865 TEST=run `ps aux` on a chromebook Change-Id: I24f687cab02eaa34efe87d4d209cbb437021d9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352250Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797512}
-
My Nguyen authored
While waiting for ClearAutocorrectRange in https://crrev.com/c/2327773, let's clear the marker with SetAutocorrectRange. Clear autocorrect range and text if text is empty or range is (0,0). Remove SetAutocorrectRangeTextWithNoInitalText test because it doesn't make sense in the current context. Bug: 1114877 Change-Id: Ib68e929e588cbd21a9df7ef1e86fc3bf7cea6e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346097 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
James Cook authored
The structure is just a representation of a bitmap. I'd like to use it in another API for an icon. * Extract the mojom struct into its own file * Rename the C++ class and mojo traits serialization helpers * Rename the |bitmap| member to |pixels| so we don't have to type bitmap.bitmap None of the implementation changed. Gerrit shows file add/deletes because the renames touched most lines. Bug: 1113889 Change-Id: Ie0d9aa30d913089adab52d0f4bd3ac050575e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352645Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Peter Kasting authored
Once a layout is performed, if anything moves, that will schedule paints as appropriate. Bug: 627663 Change-Id: Ia6c32431f39af8380ebb9e9ec9a357ea5366da84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348292Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797509}
-
