GitLab

BUG=101513
Review URL: https://chromiumcodereview.appspot.com/10272033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134735 0039d316-1c4b-4281-b951-d872f2087c98

R=benwells@chromium.org
TBR=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10261005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134734 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134731 0039d316-1c4b-4281-b951-d872f2087c98

R=ananta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10264003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125679
Review URL: https://chromiumcodereview.appspot.com/10261022

TBR=apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10265030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134729 0039d316-1c4b-4281-b951-d872f2087c98

Renamed all the *_metro_1x.png theme art assets to the more generic *_touch_1x.png and moved them from chrome/app/theme/metro to chrome/app/theme/touch

I need this as ground-work for touch-friendly toolbar.

BUG=125265
TEST=compiles
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10264032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134728 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for making FindEntryByPathAsync() private.
The new function is not used in production code yet.

This function is needed as we get metadata of a file or
a directory in gdata_file_system_proxy.cc, without knowing
if the file path points to a file or a directory.

BUG=chromium-os:30251
TEST=add unit tests

Review URL: https://chromiumcodereview.appspot.com/10274025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134727 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134726 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10243011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134725 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10266023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134724 0039d316-1c4b-4281-b951-d872f2087c98

PowerButtonController wasn't getting registered as an
observer on the aura::RootWindow, so its background layer
wasn't resized to match the root window's size.  I don't
think that this caused any problems in practice, as the
layer gets recreated every time it's shown.

BUG=none
TEST=added


Review URL: http://codereview.chromium.org/10263015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134722 0039d316-1c4b-4281-b951-d872f2087c98

Instead use ReadDirectoryByPathAsync().
This is in preparation for making FindEntryByPathAsync() private.

BUG=chromium-os:30251
TEST=GDataFileSystemTest.DuplicatedAsyncInitialization

Review URL: https://chromiumcodereview.appspot.com/10263023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134720 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125679
Review URL: https://chromiumcodereview.appspot.com/10261022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134718 0039d316-1c4b-4281-b951-d872f2087c98

First of several CLs to rename "metro" assets to "touch" so it's clear we can use them on non-Metro touch platforms.

BUG=125265
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10265012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134717 0039d316-1c4b-4281-b951-d872f2087c98

The code that was using Event has been removed, so we shouldn't see this
issue anymore.

BUG=116421

Review URL: https://chromiumcodereview.appspot.com/10261021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134715 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10271002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10272027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134713 0039d316-1c4b-4281-b951-d872f2087c98

There are two ways this was bad:
 * Copying a touch-release event ended up with an incorrect touch-id. This is
   because the original XEvent was releasing the slot-id associated with the
   tracking-id of the event. When the event is copied, the copied event then
   would look for a new touch-id for the same tracking id, and would end up with
   the first available touch-id, which may or may not be the same as the
   touch-id of the original native event (e.g. when second finger is released
   after first finger).
 * The copied XEvent was leaking, because set_delete_native_event was not being
   set on the TouchEvent. So every queued touch-event was leaking an Xevent.
   Yikes.

Making a copy of the native event does not provide any benefits. So avoid copying altogether.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10272025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134711 0039d316-1c4b-4281-b951-d872f2087c98

Views are owned by their parent, so having an additional scoped_ptr to them in the associated item/model is confusing and misleading.

BUG=124269
TEST=Test status area


Review URL: http://codereview.chromium.org/10269017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123219
TEST=existing tests suffice


Review URL: http://codereview.chromium.org/10257026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134709 0039d316-1c4b-4281-b951-d872f2087c98

SessionService. This comes from crash data. Only way I could see this
happening is if between the time we request the data from the backend
and the time we get it the service is destroyed.

BUG=95125
TEST=none
R=marja@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10265010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134708 0039d316-1c4b-4281-b951-d872f2087c98

Change LauncherContextMenu::ToggleAutoHideMenu to just return the toggled auto
hide behavior and make the behavior change go through ChromeLauncherDelegate,
which would persist the new behavior.

Also removed no longer in use kAlwaysAutoHideShelf pref.

BUG=124083
TEST=Verify fix for issue 124083.

Review URL: https://chromiumcodereview.appspot.com/10273012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125725
TEST=NONE


Review URL: http://codereview.chromium.org/10262032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10270002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134705 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit.

BUG=123580
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134620
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=134630

Review URL: http://codereview.chromium.org/10093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134704 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enal@chromium.org
BUG=125728
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10271031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134703 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134702 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134701 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik

Review URL: https://chromiumcodereview.appspot.com/10274028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134700 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=125724

Review URL: https://chromiumcodereview.appspot.com/10271030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134699 0039d316-1c4b-4281-b951-d872f2087c98

Since r134147 (https://chromiumcodereview.appspot.com/10213009), startup prefs migration is more complex and may trigger the protector for users on M19.


BUG=122936
TEST=ProtectedPrefsWatcherTest.*


Review URL: http://codereview.chromium.org/10170046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134698 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enal@chromium.org
BUG=125723

Review URL: https://chromiumcodereview.appspot.com/10269027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134696 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10274011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134695 0039d316-1c4b-4281-b951-d872f2087c98

They are currently in their minimal form. The proper dependencies will be added
afterward. This makes the whole process simpler.

R=rogerta@chromium.org
BUG=98834
TEST=GYP_DEFINES="$GYP_DEFINES tests_run=check" build/gyp_chromium \
     ninja -C out/Release browser_tests_run ui_tests_run

Review URL: https://chromiumcodereview.appspot.com/10262028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29242
TEST=Checkbox to disable drive should be visible in the downloads section of advanced settings. Selecting this should disable drive in the filemanager (requires restart in M20).

Review URL: http://codereview.chromium.org/10270019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111275
TEST=Open a new window while hovering over a Flash instance that hides the cursor; the cursor should re-appear as soon as the mouse moves.


Review URL: http://codereview.chromium.org/10169003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134691 0039d316-1c4b-4281-b951-d872f2087c98

The pattern get() ? true : false isn't widely used and after this patch has no
more occurrences across chromium/src/ codebase.

R=tommi@chromium.org


Review URL: http://codereview.chromium.org/10262014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134690 0039d316-1c4b-4281-b951-d872f2087c98

Revert r134670 "Revert 134667 "Revert r134508 "Revert 134507, broke the main builders:""

This CL's going to get in at whatever cost. I moved more optional files to be untracked.

The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

Manual edits:
- Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
- Removed testserver.log and unit_tests.log.
- Added copyright.
- Removed *.db-journal files.

TBR=rogerta@chromium.org
BUG=98636
TEST=

Review URL: https://chromiumcodereview.appspot.com/10263018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134689 0039d316-1c4b-4281-b951-d872f2087c98