- 11 Jul, 2014 28 commits
-
-
jar@chromium.org authored
r=wtc Review URL: https://codereview.chromium.org/380403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282511 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
For some applications where we need to keep multiple copies of the audio bus around (particularly in STL containers), a scoped_ptr to an audio bus isn't enough. For those rare situations, we're adding a RefCounted version of the AudioBus. R=dalecurtis@chromium.org BUG=None. Review URL: https://codereview.chromium.org/388563005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282510 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=bruening@chromium.org BUG=392585 Review URL: https://codereview.chromium.org/386863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282509 0039d316-1c4b-4281-b951-d872f2087c98
-
lcwu@chromium.org authored
BUG=336640 Review URL: https://codereview.chromium.org/223143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282508 0039d316-1c4b-4281-b951-d872f2087c98
-
yhirano@chromium.org authored
In order to update forbidden header names in Blink side, I remove a subtest from a browsertest. I will restore the subtest once the Blink side CL[1] is landed. 1: https://codereview.chromium.org/378183003/ BUG=373120 Review URL: https://codereview.chromium.org/385523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282507 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
This is done by setting results_are_the_same_on_every_page property on TimelineBasedMeasurement to False. BUG=393049 Review URL: https://codereview.chromium.org/387783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282506 0039d316-1c4b-4281-b951-d872f2087c98
-
ppi@chromium.org authored
This patch uses the existing browser_navigation_start field in FrameMsg_Navigate to set the navigation start time for browser navigations in new tabs. For browser navigations that result in cross-site swap, the value is later overriden with the end of the beforeunload event of the current document. BUG=376004 Review URL: https://codereview.chromium.org/339573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282505 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
The navigation transition needs to apply some styles during the transition, so we need to expose this call to java. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Review URL: https://codereview.chromium.org/375073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282504 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=391943 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/387753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282502 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
Creating a canvas can fail, so be robust to this. BUG=392587 Review URL: https://codereview.chromium.org/386803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282500 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
The default cookie option excludes http only cookies. And thus causing some streams not being able to play. android bug 66050 Review URL: https://codereview.chromium.org/386723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282499 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
android_tools/sdk/tools/proguard/bin/proguard.sh was removed with SDK tools update. https://gerrit.chromium.org/gerrit/#/c/70802/ updates SDK tools and we want to roll to start using it. BUG=393019 Review URL: https://codereview.chromium.org/377353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282498 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
It still takes time to componentize autocomplete input and search features. However, we have componentized some important parts already. The added code will be replaced by the real autocomplete code in the future, but meanwhile, this is good enough. Feature: - the logic to check if the input looks like URL / host names - canonicalize the input to form the actual URL (http://...) - use TemplateURLService to create the search result page URL if it looks like a query. BUG=387207 R=oshima@chromium.org, hashimoto@chromium.org TBR=pkasting@chromium.org, jar@chromium.org TEST=manually Review URL: https://codereview.chromium.org/382683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282497 0039d316-1c4b-4281-b951-d872f2087c98
-
imcheng@chromium.org authored
Inputs: - directory to libffmpegsumo.so. - network simulation parameters given as a proto. BUG=none Review URL: https://codereview.chromium.org/362123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282496 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
Having the same name for a grd is bad because the post processor flattens the file so one of them gets overriten with the other. NOTRY=true TBR=blundell BUG=372175 Review URL: https://codereview.chromium.org/381353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282495 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=392874 Review URL: https://codereview.chromium.org/382963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282494 0039d316-1c4b-4281-b951-d872f2087c98
-
dyen@chromium.org authored
It looks like this crash came from the following CL: https://codereview.chromium.org/338523007 R=sehr@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 Review URL: https://codereview.chromium.org/383803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282493 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/386733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282492 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Makes the "IsSystemThemeDistinctFromDefaultTheme()" detection logic compatible with non-GTK (ie. Aura) Linux. It moves the check out of sync code and into the ThemeService so this kind of bug will be less likely to recur if the themes logic changes again. Re-enables an integration test that was disabled during the transition to Aura. BUG=304554,392934 Review URL: https://codereview.chromium.org/388563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282491 0039d316-1c4b-4281-b951-d872f2087c98
-
johannkoenig@google.com authored
Pending libvpx updates BUG=392309 R=scherkus@chromium.org Review URL: https://codereview.chromium.org/376283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282490 0039d316-1c4b-4281-b951-d872f2087c98
-
kelvinp@chromium.org authored
There is a typo in the output element of the "Build Remoting Webapp unittest.html" action. The current output element refers to a non-existent location. As a result, ninja invoke the action on every build run. I also removes exclude-js from the input element, as there is no need to re-invoke the action if the content of an excluded script is modified. BUG=392834 Review URL: https://codereview.chromium.org/385713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282486 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This builds on https://codereview.chromium.org/385653002/ . Many functions in Python's logging module grab a lock internally. Some appear to do so before converting the provided message to a string via its __str__ method. Calling an object's __str__ method before calling a logging funciton allows anything called by the __str__ method to log without the risk of hitting a deadlock. BUG=392869 Review URL: https://codereview.chromium.org/383793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282485 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
Ensure that enrollment recovery really only is triggered when the machine id can be accessed. BUG=389481 Review URL: https://codereview.chromium.org/386643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282484 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
We probably shouldn't allow this, but it's currently relied upon by the WebAudio code and cleaning it up is a big deal: http://crbug.com/151051. The AudioRendererSink interface does not specify that after Stop() the sink can no longer be used. All other sinks allow restart, so this is just keeping with the pace. In http://crrev.com/280502 I conflated the one-stop-only mechanics of AudioRenderer:Stop() with those of AudioRendererSink::Stop(). This patch reverts that mistake while keeping the fixes for the original issue. BUG=389204,390977 TEST=new unittest. Review URL: https://codereview.chromium.org/381823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282481 0039d316-1c4b-4281-b951-d872f2087c98
-
jbudorick@chromium.org authored
As requested by frankf: https://codereview.chromium.org/351603002/#msg2 https://codereview.chromium.org/358993003/#msg9 https://codereview.chromium.org/371813005/#msg8 BUG=267773 Review URL: https://codereview.chromium.org/377373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282480 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
ChromeRenderViewObserver::CapturePageInfo is a relic. It hasn't captured page content for indexing for about a year now (r212459), and the fancy footwork to avoid re-indexing isn't needed any more. BUG=371151 TEST=everything still works Review URL: https://codereview.chromium.org/363293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282479 0039d316-1c4b-4281-b951-d872f2087c98
-
samuong@chromium.org authored
BUG=chromedriver:843 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/385753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282477 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
We recently moved to new directory structure, and while refactoring we missed to specify localname for the module. crreve.com/282209 NOTRY=true BUG=393057 Review URL: https://codereview.chromium.org/389453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282476 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jul, 2014 12 commits
-
-
rpaquay@chromium.org authored
Pre-CL for https://codereview.chromium.org/379943003/: We need to delay load "setupapi.dll" as device/bluetooth now uses "SetupDiGetDevicePropery" which is available on Vista+ only. BUG=388016 TBR=keybuk@chromium.org, armansito@chromium.org Review URL: https://codereview.chromium.org/387673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282472 0039d316-1c4b-4281-b951-d872f2087c98
-
dtseng@chromium.org authored
TEST=Observe an onvoiceschanged event handler gets called when... - built-in extension tts engine loads. - webstore-based extension engine is enabled/disabled. Review URL: https://codereview.chromium.org/361363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282471 0039d316-1c4b-4281-b951-d872f2087c98
-
rob@robwu.nl authored
Previously, errors in the user-defined callback function could break the internal state of the pageCapture API. This is now mitigated by reading and nulling the callback before using it, and only access the properties of the response object after verifying that it is not void. Also fixed a typo in an error message. BUG=392800 TEST=Manually the tests from the bug report (or read the source code and infer from the changes that the reported bugs have been fixed.) Review URL: https://codereview.chromium.org/384653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282470 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
Fixes an issue when using managed_install=1 with Android L. BUG=None NOTRY=true TBR=cjhopman@chromium.org Review URL: https://codereview.chromium.org/380343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282469 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282468 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/996861db81bec78480b83e7a77f18fd5a786320e..fd429991e99d18cbb956f91b7c347440b39684c1 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=jcgregorio@google.com BUG= Review URL: https://codereview.chromium.org/388493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282467 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282464 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=391927 TESTED=manual testing libyuv compiles with clang-cl R=rnk@chromium.org Review URL: https://codereview.chromium.org/380813004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282463 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
All existing actions can now be accessed from ActionRunner directly, so this file has outlived its usefulness. BUG=361809 Review URL: https://codereview.chromium.org/356833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282462 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
Both internals pages were displaying the partition path, which is bogus when in Incognito mode - both just store everything in memory. Track and pass the state along from context -> internals helper -> JS -> HTML and show a label instead. (Screenshots in the bug.) BUG=388168 R=michaeln@chromium.org Review URL: https://codereview.chromium.org/388583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282460 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Removes most remaining dependencies from core sync/ files on sync/notifier/. There are some internal_api/public files that still reference sync/notifier. These will be dealt with after sync/notifer/ has been moved to components/invalidation/. BUG=259559 Review URL: https://codereview.chromium.org/377413003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282458 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
It was removed from the gyp build a while back. BUG=353602 TEST=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/384833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282457 0039d316-1c4b-4281-b951-d872f2087c98
-