GitLab

BUG=none
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/13926015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194534 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14096010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/13949012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194530 0039d316-1c4b-4281-b951-d872f2087c98

Move DriveFileSystem::NotifyFileSystemMounted() and
NotifyFileSystemToBeUnmounted() to DriveSystemServiceObserver
in favor of less things to have in DriveFileSystem

BUG=231788
TEST=none

Review URL: https://codereview.chromium.org/13866050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194529 0039d316-1c4b-4281-b951-d872f2087c98

Broke "Linux Tests (dbg)(2)" build.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/33655

[4808:4808:0416/202705:277959527:FATAL:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed 

The error is FATAL with a Debug build but ERROR with a Release build, hence linux_rel try bot passed:
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/117475/steps/interactive_ui_tests/logs/stdio

[10001:10001:0416/181034:1303866619:ERROR:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed

> Add InitWidgets() phase for GTK infobars.
> 
> This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown.  Currently, this generally happens at construction.  Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.
> 
> Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.
> 
> BUG=none
> TEST=none
> 
> Review URL: https://codereview.chromium.org/11775019

TBR=pkasting@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194528 0039d316-1c4b-4281-b951-d872f2087c98

Ports XMPP Invalidation code from drive_file_sync_service in /sync_file_system to /google_apis/drive_notification_manager so it can be shared between ChromeOS file manager and SyncFS.

Please note that to keep this patch streamlined I've only ported over the XMPP invalidation code for now and will port the polling logic in the next patch.

BUG=173339

Review URL: https://codereview.chromium.org/13866037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194526 0039d316-1c4b-4281-b951-d872f2087c98

This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown.  Currently, this generally happens at construction.  Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.

Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11775019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194525 0039d316-1c4b-4281-b951-d872f2087c98

unique function body.

Changed ShutdownWatchDogThread::Alarm's to call
ShutdownCrash(), so it does not get merged by the link time 
optimization.

R=jar@chromium.org, eroman@chromium.org
BUG=232080
Review URL: https://codereview.chromium.org/14250003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194524 0039d316-1c4b-4281-b951-d872f2087c98

* Use ldd to detect chrome for cros local builds. 
* Add browser types debug-cros and release-cros for chrome for cros on linux. 
* Remove browser option --cros-desktop 

BUG=229692
TEST=run_tests works with cros-debug going through the login flow. 
NOTRY=True
Review URL: https://codereview.chromium.org/13891011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194522 0039d316-1c4b-4281-b951-d872f2087c98

Changing ContentBrowserClient::GetAdditionalAllowedSchemesForFileSystem()
not to return std::vector<std::string> as return value (but as an out
parameter) to follow the coding convention.

A follow-up patch for https://chromiumcodereview.appspot.com/13415006

BUG=none
TEST=no new tests as no behavioral changes

Review URL: https://codereview.chromium.org/14200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230968
TEST=Lauch Chrome on Mac with instant extended. Ensure you have no bookmark. On the NTP observe that the "Apps" button does not overlap the empty bookmark bar message.

Review URL: https://codereview.chromium.org/14262013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194516 0039d316-1c4b-4281-b951-d872f2087c98

navigating forward / back to a page generated by a
POST that can not be retrieved from the CACHE.

This was broken (knowingly) in revision 191712
(https://codereview.chromium.org/12277011/).

BUG=174194,226909

Review URL: https://codereview.chromium.org/13811022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194514 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194513 0039d316-1c4b-4281-b951-d872f2087c98

TBR=haraken

Review URL: https://codereview.chromium.org/13972013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194512 0039d316-1c4b-4281-b951-d872f2087c98

We weren't adding apps to the installed_app set when it doesn't have
any storage permissions.

BUG=231167
TEST=ExtensionSpecialStoragePolicyTest.IsInstalled

Review URL: https://codereview.chromium.org/13994010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194511 0039d316-1c4b-4281-b951-d872f2087c98

This fixes two issues related to OnRepaint (window damage) messages:

1.) In the case of a renderer-resized widget, the browser's information about
the size of the widget could be out of date. If the browser widget was asked to
paint in compositing mode before it received the proper size it could send a
ViewMsg_OnRepaint with 0x0 size and then set repaint_ack_pending_, expecting the
renderer to reply. The renderer wasn't actually replying with a frame since
damaging a 0x0 rect doesn't actually require painting anything. This suppresses
sending the OnRepaint message if the browser's size is 0x0. Either the size will
at some point become 0x0, triggering a repaint, or the user will never see it.

2.) In compositing mode on the renderer side we weren't plumbing the OnRepaint
window damage rect properly in to the compositor. Thus the compositor could end
up not producing a frame after receiving an OnRepaint message, confusing the
browser rate limiting logic greatly.

BUG=230766

Review URL: https://codereview.chromium.org/13926009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194510 0039d316-1c4b-4281-b951-d872f2087c98

on mouse over) when a network error happens in an iframe.

Also add the same icon to the main frame error page.

BUG=174194
Review URL: https://codereview.chromium.org/13737002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194509 0039d316-1c4b-4281-b951-d872f2087c98

R=piman
BUG=231715

Review URL: https://codereview.chromium.org/14065015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194508 0039d316-1c4b-4281-b951-d872f2087c98

Broke x64 compile.

> intsafe workaround to separate header
> 
> Allows workaround to work without precompiled headers (as in
> buildtype=Official)
> 
> R=cpu@chromium.org
> BUG=225822
> 
> Review URL: https://codereview.chromium.org/14201003

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13977005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194507 0039d316-1c4b-4281-b951-d872f2087c98

Allows workaround to work without precompiled headers (as in
buildtype=Official)

R=cpu@chromium.org
BUG=225822

Review URL: https://codereview.chromium.org/14201003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194506 0039d316-1c4b-4281-b951-d872f2087c98

> Add the LoggedIn Predictor, to detect which websites a user is likely
> logged into (or has been logged into).
> R=shishir@chromium.org, bauerb@chromium.org
> 
> Review URL: https://codereview.chromium.org/13903018

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/13995007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194505 0039d316-1c4b-4281-b951-d872f2087c98

R=shishir

Review URL: https://codereview.chromium.org/14307004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194504 0039d316-1c4b-4281-b951-d872f2087c98

Reverting seems to fix memory_test test locally on linux.

BUG=230085

> Revert r192949 "Disable shader disk cache by default."
> 
> This reverts commit r192949. The disable has been merged into
> M27 so re-enabling on trunk.
> 
> BUG=228989
> 
> Review URL: https://chromiumcodereview.appspot.com/13872012

TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/13924005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194503 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160311
TBR=ben

Review URL: https://codereview.chromium.org/13998026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194499 0039d316-1c4b-4281-b951-d872f2087c98

These were introduced in https://codereview.chromium.org/13932025/.

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/14081007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/14148004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194497 0039d316-1c4b-4281-b951-d872f2087c98

Add ChangeListLoader::CheckForUpdates()
Make ChangeListLoader::LoadFromServerIfNeeded() private.

BUG=193417
TEST=Open Drive in Files.app; Ctrl-click-on the gear menu and select 'Reload'. Confirm that the files appear shortly.

Review URL: https://codereview.chromium.org/14292002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194496 0039d316-1c4b-4281-b951-d872f2087c98

> Re-enable various ExtensionManagementApiTest tests.
> 
> These had been disabled due to flakes on Windows. The Win builders now
> haves symbols, so the stacks generated by flakes should be actionable.
> 
> BUG=174411,176023,179430,230165
> 
> Review URL: https://codereview.chromium.org/14232006

TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/14318002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194495 0039d316-1c4b-4281-b951-d872f2087c98

The UMA histogram name is appended with library names. Since we only have limited number of ppapi plugins this shouldn't be an issue for the server to handle.

BUG=226107
TEST=Tested Widevine CDM loading.

Review URL: https://codereview.chromium.org/13548005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194494 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/14096008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194493 0039d316-1c4b-4281-b951-d872f2087c98

Previously, Telemetry would not output any summary ("RESULT=") lines if
at least one page in a page set failed.  Now, if a failed page exists,
Telemetry will output the individual page results from the passing pages,
but it will not output any average data or any overall results that are
not associated with a page.

Also added a few unit tests for this change.

BUG=230998
TEST=Verified with the scrolling_benchmark on a local chromeOS device
(which currently has at least one failing page) that RESULT= lines are
now outputted only for the passing pages.  Also verified that all unit
tests for page_benchmark_results.py pass.

Review URL: https://codereview.chromium.org/14172017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194491 0039d316-1c4b-4281-b951-d872f2087c98

Still hanging on the bots

> Revert 194260 "Revert 194220 "[Telemetry] Make page cyclers more..."
> 
> Re-landing. Should work now that a race has been fixed by r194470.
> 
> > Revert 194220 "[Telemetry] Make page cyclers more telemetric."
> > 
> > Caused page cycler to hang on bots.
> > 
> > > [Telemetry] Make page cyclers more telemetric.
> > > 
> > > This causes the page cyclers to use page_sets instead of just navigating to the
> > > start page and letting the pages cycle themselves. This means we'll be using
> > > Telemetry "properly" which will allow us to record new page sets to update the
> > > page cyclers and it means that page cycler page sets are interchangeable with
> > > other benchmarks.
> > > 
> > > The page cyclers still measure the same thing as they measured previously: the
> > > time to load the page and perform a layout. However, they measure it differently
> > > now. Instead of setting a new Date().getTime() in the cookie immediately before
> > > navigating and then grabbing the finish Date in the onload handler, this now
> > > just grabs performance.now() in the onload handler. This returns the number of
> > > milliseconds since navigationStart where navigation start is the same as the
> > > immediately before navigation time marked before. I've verified locally that the
> > > times reported are consistent, and will monitor the bots to verify.
> > > 
> > > This involved moving the serving_dirs property up from the page to the page_set.
> > > 
> > > BUG=None
> > > TEST=All page cyclers on linux and morejs on windows
> > > NOTRY=True
> > > 
> > > Review URL: https://codereview.chromium.org/13817009
> > 
> > TBR=tonyg@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/14048008
> 
> TBR=tonyg@chromium.org
> 
> Review URL: https://codereview.chromium.org/14119007

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/14222013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194489 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the state stansition was CONNECTING->CONNECTED, but r194079 introduced the AUTHENTICATED state without updating the expectation in ConnectionToHost::NotifyIfChannelsReady

BUG=231997

Review URL: https://codereview.chromium.org/14308012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225975
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/13813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174002
This extension is not needed anymore.

Review URL: https://codereview.chromium.org/14301007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194486 0039d316-1c4b-4281-b951-d872f2087c98

logged into (or has been logged into).
R=shishir@chromium.org, bauerb@chromium.org

Review URL: https://codereview.chromium.org/13903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194484 0039d316-1c4b-4281-b951-d872f2087c98

It was missing en-US.pak, causing language string to be missing.

TBR=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13921003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194483 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/14058002, the function named
_IsWebkitVersionNotOlderThan was changed to
_IsContentVersionNotOlderThan.  There was one more reference to the
old function name in the file that needed to be updated.  That is
done here.  Without this fix, the Chrome Endure tests are broken.

BUG=None
TEST=Verified that a basic run of a Chrome Endure test failed before
this change, but passed after this change.

Review URL: https://codereview.chromium.org/14272005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229660
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/14064011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194481 0039d316-1c4b-4281-b951-d872f2087c98