- 25 Aug, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/288014f2..30f6538a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c5fa3c8c9f95d13f997dc377b03244a6ea87a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376285Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801597}
-
Erik Staab authored
The tests pass with and without GPUs and this will slightly improve utilization and pending times. Bug: 1115109 Change-Id: I33f026dac158f124581c14e5bc2ae419123a7d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294092Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#801596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e1c948be. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" aab733a4 "[Document Policy] Migrate sync-script to document policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Idfe1b83b9cd3ce3a4dc5b67898de2f0571d15669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375059Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801595}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b09f2bb2f282..dff2104727dc 2020-08-25 ddoman@chromium.org [resultdb] moves the cipd pin of infra/tools/rdb 2020-08-25 brucedawson@chromium.org Shorten hash to avoid MAX_PATH limits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120785,chromium:1121678 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iee839bae6ebc556b93af19bac35f6b9468b2608c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801594}
-
Daniel Classon authored
Modify the change account picture search result so that it returns the setting and not the subpage. Bug: 1084154 Change-Id: Ie45d385ff1afcbe73e1068a638236c0a4d7ef6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376475Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#801593}
-
Jazz Xu authored
This CL adds a media tray containing a media icon to CrOS status area next to system tray. Bug: 1114901 Change-Id: Ic363d925efbf8dac260dc48e950972e30a96283c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347378Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801592}
-
kdillon authored
QueueClass is currently used for high-level policy decisions in the main thread. For the most part, the policies applied to each queue class are largely the same. This change removes QueueClass entirely and adds bits on the policy for pausing and deferring task queues as well as whether or not virtual time is enabled. Change-Id: Iae28c5d7d2ad4c9deb7dad2e1c3294e7ac6b9470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365315 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801591}
-
Xiaocheng Hu authored
[Sheriff] Disable KeyboardLockInteractiveBrowserTest.SubsequentLockCallSupersedesPreviousCall on ChromeOS Change-Id: I4103f71d674ce6944cb75a828f2f6fbc8a6631bf Tbr: ellyjones@chromium.org NoTry: True Bug: 1121172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376085 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801590}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/21b36f736809..b6c82a149ed8 2020-08-25 rharrison@google.com Roll 4 dependencies and updated expectations (#1132) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I6605c83139f4ca94d6adda3af55aa8726cd618f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376429Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8ae5a73f875..8f012723b79d 2020-08-25 yangguo@chromium.org Revert "Localization: creating and integrating i18n module" 2020-08-25 vidorteg@microsoft.com Localization: creating and integrating i18n module 2020-08-25 patrick.brosset@microsoft.com Grid: Match the label colors with the line colors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121152 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I870871e0a798ae679294164651261c39a96032bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376428Reviewed-by:
-
Sven Zheng authored
Some tests were caused failing bot. Some tests are picked from highest score in flake portal. Currently the lacros bot is flaky, we need to have a more stable bot. Bug: 1121486 Change-Id: I72905f0da0533e8fc0c9d6ff9d5475d701e0e8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376525 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#801587}
-
Xiaocheng Hu authored
Bug: 1121422 Change-Id: Ic4ae72842f34099241422e0498aac998fdd8012f NoTry: True Tbr: agawronska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376374Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff77947e7ecc..7023f47299aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5776e85a6ff3f0d3f5ae731143c5fa0cb47c7c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375802Reviewed-by:
-
Jinsuk Kim authored
This CL fixes a potential bug of https://crrev.com/c/2371384. OverscrollSceneLayer should always start observing WindowAndroid, regardless of compositor attachment state. Bug: 1120832 Change-Id: I9de81b89a4aacf08d74c53498e80e74ff358218a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371725Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#801584}
-
nuwanda authored
Now when histogram_samples category is set only the histograms listed in a trace config will be monitored. If there are no histograms in a trace config, the effect of enabling the histogram_samples category will remain the same: all the histograms will be monitored. Monitoring all the histograms results in a significant increase in trace size and processing time, that's why we need a way to monitor only a subset of histograms. Based on the events added to trace when enabling the histogram_samples category TBMv3 UMA metrics will be implemented. Change-Id: If2c36ba22e222c0c1efb4415aba54edcd69b2b4c Bug: 1119834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363747Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#801583}
-
Mike Wasserman authored
Add an optional display id paramater to ForSecurityDropFullscreen. This limits fullscreen exiting to WebContents on a specific display. Always exit on window.open; limit to the destination screen if known. (conduct that fullscreen exit once the target display is determined) Also exit on window.moveTo, etc.; limit to the destination screen. Bug: 1040297, 1120746 Test: Windows cannot be programatically placed over fullscreen windows. Change-Id: If4feee5d1bc1283add2c21615c1715bb4babe2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373446 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801582}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3cce1125f027..3c02c934afa7 2020-08-25 rmistry@google.com Revert "Update SKP version" 2020-08-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-08-25 mtklein@google.com set _XOPEN_SOURCE=0 when building ICU 2020-08-25 johnstiles@google.com Remove newly-added SkDEBUGFAILs when we can't make an FP in drawAtlas. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I9b79686de21ff748ba5f055091f6b723419f0c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376430Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id1d752a54deda9a86810d479997c261daa01329a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376486Reviewed-by:
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/b08e25388629..f70065f62227 $ git log b08e25388..f70065f62 --date=short --no-merges --format='%ad %ae %s' 2020-08-24 sarahmashay [validation] Validate if entry point functions accept parameters 2020-08-24 sarahmashay [validation] Adds disable test for v-0023, entry point functions accept no params 2020-08-24 tommek [wgsl-reader] Adding body_statement to statement grammar 2020-08-24 cwallez Fix triangle.wgsl's floating point literals. 2020-08-21 dneto Re-enable float emission tests 2020-08-21 sarahmashay [validation] validate if entry point functions return void 2020-08-20 sarahmashay [validation] Add disabled test for v-0024-entry point functions return void 2020-08-20 sarahmashay [validation] checks if function used in entry point exists 2020-08-20 sarahmashay [validation] Add disabled test for v-0019-entry point functions must exist 2020-08-20 sarahmashay [validation] Checks if recursions exist 2020-08-19 dsinclair [hlsl-writer] Add support for import statements. 2020-08-19 dsinclair [hlsl-writer] Generate intrinsics. 2020-08-19 dsinclair [hlsl-writer] Emit cast expressions. 2020-08-19 dsinclair [hlsl-writer] Add tests for entry point data. 2020-08-19 dsinclair [hlsl-writer] Emit module constants. 2020-08-19 dsinclair [hlsl-writer] Fix emission of struct aliases. 2020-08-19 dsinclair [hlsl-writer] Emit uniform variables. 2020-08-19 dsinclair [hlsl-writer] Add CallExpression. 2020-08-19 dsinclair [hlsl-writer] Add support for input locations and builtins. 2020-08-19 dsinclair [hlsl-writer] Add function handling. 2020-08-18 dsinclair Add missing block decoration. 2020-08-18 sarahmashay [type-determiner] return false when type determining an undeclared function 2020-08-17 sarahmashay [validation] Add Disabled test for detecting recursion 2020-08-17 dsinclair [spirv-writer] Output name for constant global variables. Created with: roll-dep src/third_party/tint/src Change-Id: Idb5d634f365266852e298bf1cc30c2d7824a51b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372803 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#801579}
-
Dale Curtis authored
This adds code to the GPU composited image paths to treat decoded HDR images as having an SDR white level equivalent to the display's during upload. Currently all GPU compositing paths but RGB w/ in-process rasterization work (due to https://crbug.com/1120719) Bug: 1112437 Test: New unittests. Change-Id: I66a7b54e542d845b35a27422076a373d985226a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368286 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#801578}
-
Jeffrey Cohen authored
Bug: 1121200 Change-Id: Id33c808f9ec136561be29d44b5b3d726e746347e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372818Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801577}
-
David Tseng authored
R=anastasi@google.com, dmazzoni@chromium.org Test: manually verify the virtual keyboard is pruned from the accessibility tree when hidden and attached when shown Change-Id: Idb5a28e7458a18b8284d455976be48bf90ec53da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375941Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801576}
-
Thomas Lukaszewicz authored
This CL factors out common css styles from Tab Search into mwb_shared_styles and mwb_shared_vars. These are currently being referenced by Tab Search and will be used in the upcomming Read Later feature. Sharing common vars and styles will allow both features to remain visually consistent and enable better co-ordination between the teams wrt style changes. Bug: 1099917 Change-Id: Idee622cb638499269a0bd2ad1135454e2e1aecb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365335 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#801575}
-
Ryan Hansberry authored
This came up as a suggested refactor during crrev.com/c/2358129 review. Change-Id: Id2db265a35259a37dcbbbe12546296e081d46d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365693 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801574}
-
Nate Chapin authored
We typically expect DidStartProvisionaLoad messages to be paired with a DidCommitLoad when the navigation is successful. For pseudo-navigations like XSLT processing and javascript: urls, we skip the DidCommitLoad message. If we do not also skip the DidStartProvisionalLoad message, listeners that expect these notifications to be paired will get confused (e.g., the inspector debugger may leave breakpoints disabled in the new Document). Bug: 1095920 Change-Id: I5bdd18b3f4103d5d2c52fe48060c1114efb21b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254818 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#801573}
-
Dana Fried authored
This is a start at eliminating redundant layouts and memory allocations during layout in the tabstrip. Instead of a border, we use kInternalPaddingKey with a pre-allocated gfx::Insets. This is the same approach used by ToolbarButton and will also help if tabs are switched to using a layout manager. Ultimately, we want to eliminate both allocation of border objets as well as all layout invalidations during layout. Bug: 1121681 Change-Id: Icf7ac6c93eda5ccf80639ab95b2e0c705c1c5d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375741 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#801572}
-
Mike Dougherty authored
This is to prevent a crash due to NSMutableDictionary being modified on multiple threads simultaneously. Per https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Multithreading/ThreadSafetySummary/ThreadSafetySummary.html, NSMutableDictionary can be used on multiple threads, but not at the same time. Bug: 1119964, 1121401 Change-Id: If37ea9ebb8d0e4b8276dc69ffd52fad318a181ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367704 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#801571}
-
Robert Ogden authored
Creates a TLS socket connection to probe connectivity to the origin. This probe must also complete a DNS resolution in order to complete successfully, in order to get the IPAddress of the probe url. Bug: 1115731 Change-Id: I862ef52d353c4572e45d8596f5809af1b0b60081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358490Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Alex Newcomer authored
We added an api to ClipboardNonBacked, which is used as the CrOS clipboard. This API is used to modify the clipboard in order to enable pasting previously pasted items. We do not want metrics to be recorded when we do admin ops, so we test that in this CL. Bug: 1120775 Change-Id: Ib7d5b64c0128a820a37f058fc26c884fcd8eeedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373294 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#801569}
-
Daniel Classon authored
Modified AddSubpageResult to check for identical search tags between subpages and child settings, similar to the existing check between settings and subpages. Helps with deep linking the change account image setting which ran into this behavior. Bug: 1084154 Change-Id: I19ef66dff5279a2804041eaf258a5b59ad687f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376453Reviewed-by:
-
Mike Dougherty authored
web::test::HttpServer usage is suspected of introducing flake into the bot runs. This test has the last usage of web::test::SetUpSimpleHttpServerWithSetCookies, so Convert it to use the new test server in order to reduce test helpers utilizing the old http server. Bug: 891834 Change-Id: Ie1161507fd78e5b0095a17c91456218a0b6f05c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376407 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#801567}
-
Joe DeBlasio authored
This CL adds a public document explaining the cirumstances under which we downgrade the displayed hostname to just eTLD+1. Bug: 1106962 Change-Id: I565c4575b4537caca15824aa3b765da866f3e6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376372Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#801566}
-
Andrey Kosyakov authored
This reverts commit f985905e. Reason for revert: break headless build. Repro: mkdir ./out/headless && echo 'import("//build/args/headless.gn")' > out/headless/args.gn && gn gen ./out/headless Waiting for editor on "/usr/local/google/home/caseq/cr/src/out/headless/args.gn"... Generating files... ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. assert(ozone_platform_x11) ^----- See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. "//ui/events/platform/x11", ^------------------------- Original change's description: > X11 and Ozone: enable use_x11 and use_ozone > > This is the final change that enables use_x11 > and use_ozone for Linux builds and (as it was > before) excludes X11 for chromeos, chromecast, > lacros. > > in order to run ozone/X11/wayland, one must pass > —enable-features=UseOzonePlatform > —ozone-platform=x11 or wayland. otherwise, > non-ozone/X11 is used. > > it’s also possible to completely disable X11 > so that clients, who need that kind of build can > continue to have that. > > Bug: 1085700 > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801523} TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: Id1f451c6b8a9aeeaa48a8d12da2776b8676aca09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376482Reviewed-by:
-
edchin authored
This CL improves performance of Close All and Undo Close All by processing in batch. Bug: 1092371 Change-Id: I7704a537c4302cb8acc12190d2402aae2ae7c937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370518 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#801564}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/41db2fb64914..ff77947e7ecc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I25ff298ff308c17794a6bd8382425a24d53ad198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376348Reviewed-by:
-
Gang Wu authored
Bug:1119882 Change-Id: If328575a06abb271b9b775007b59cca69b6795fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366658Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801562}
-
Zentaro Kavanagh authored
- All the instances here were either in the translation description. None were displayed to end users in UI. Bug: None Change-Id: Id1fd682af180a9026161c8ad0444b7613f82aeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375734 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Eric Robinson authored
The current behavior of AdsPageLoadMetricsObserver (APLMO) is to stop observing when chrome is backgrounded and report all histograms because it is unknown if proper reporting will occur. While this behavior is desired, it also means that the observer stops monitoring the page, preventing it from properly triggering when a Heavy Ads intervention occurs. This change finalizes histograms when chrome is backgrounded, but has APLMO continue observing after that time. This also adds testing around FlushMetricsOnAppEntersBackground functionality, as no testing of that existed previously for the APLMO. Bug: 1103699 Change-Id: Ib4f5eeb0b90a30e3189e0490cbb13df5b1e49e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305675Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#801560}
-
Carlos IL authored
URLs where the TLD is separate from the host, which can happen for URLs of the form http://LTR.RTL/RTL, were displayed with a blank spot when elision was enabled. This CL changes this so the in between section, which is not elided in this case, is also not colored transparent. Bug: 1117631 Change-Id: I9bba2d2c0d494a4021b8c8edaacc87084e040964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368458Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Removes usage of web::tests::HttpServer which has been replaced by direct usage of embeddedTestServer through |self.testServer|. Bug: 891834, 1121505 Change-Id: Iebfd9aae926fdc7d48fb3ee52a44ebacc59d0768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376406 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#801558}
-
