- 25 Jun, 2020 40 commits
-
-
Matt Wolenetz authored
Reduces confusion between a couple top-level mp4 box log messages: 1) BoxReader::IsValidTopLevelBox() issues a MEDIA_LOG if an unrecognized top-level box is found in the path that returns false, and typically results in parse error. Since I could find no caller which allows this to proceed without parse error, I changed this from a DEBUG to an ERROR to give web apps more visibility into the root cause via MediaError.message. (Caveat, until bug 1099034 is fixed, the more generic "stream parsing failed" error replaces the more specific, new parse error added in this change.) 2) Mp4StreamParser::ParseBox() issued a similarly-worded DVLOG if there is a top-level box that *is* valid, but is skipped over. This change removes the confusing word "unrecognized" from this DVLOG, since the box is recognized as valid, but is just not parsed in detail. TEST=(For #1) Updated BoxReaderTest.WrongFourCCTest BUG=1096273,1099034 Change-Id: I5525119177343465a8046aaa6dec3f7993a4caec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264510 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782621}
-
Cammie Smith Barnes authored
This is a reland of 8c0f99be Original change's description: > Ad metrics: Add heuristic to estimate proportion of ad frames throttled. > > Our CreativeOriginStatus metric is recorded as unknown for approximately > 70% of ads. We want to see how much of this indeterminacy is due to > frame throttling, so we add another histogram that splits by whether > there is any unthrottled frame in the ad frame tree. > > The CreativeOriginStatus metric relies on FCP, which for cross-origin > frames can be very large. This is partially due to the flow where: a > frames starts outside the viewport and is throttled; frame is later > scrolled into the viewport, becomes unthrottled; frame receives FCP. > > Because paint-timings are relative to navigation start for the frame, > the values are skewed. This change propagates some additional info, a > best-effort timestamp of when a frame is first not throttled, up to the > browser process to address this. > > Continuation of > https://chromium-review.googlesource.com/c/chromium/src/+/2088037 > which had inexplicable trybot failures. This is the same code ported > into a fresh CL. > > Tests: > > third_party/blink/renderer/core:unit_tests > out/Default/blink_unittests > --gtest_filter=*PaintEligibility* > > chrome/test:unit_tests > --gtest_filter=*CreativeOrigin*Throttling > > chrome/test:browser_tests > --gtest_filter=*CreativeOrigin* > > Bug: 1049125 > Change-Id: I8c9ddd41870ce9797ff0f01de853f7576efd4606 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161606 > Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781029} TBR=kinuko@chromium.org Bug: 1049125 Change-Id: Ied7129a9a112c88fb1324eefa9deccf3e465e4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264857 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782620}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ R=gab@chromium.org Bug: 1097092 Change-Id: I0524298abd36ca6dcd3ba55bedd0e087f33ef97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262255 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#782619}
-
Tim Volodine authored
Implement support for Safe Browsing Extended Reporting in WebLayer. This functionality helps improve security on the web for everyone. When opted-in it sends URLs of some pages you visit, limited system information, and some page content to Google, to help discover new threats and protect everyone on the web. Provide the option for the user to opt-in to extended reporting via interstitial checkbox, internally corresponds to prefs::kSafeBrowsingScoutReportingEnabled. Provide the option for the embedder to enable/disable the Extended Reporting functionality, which is disabled by default. In this patch: - add a ping_manager and implement SendSerializedThreatDetails(), - add handling of the relevant commands in error_page_helper (persistent user opt-in), - implement the relevant bits in safe_browsing_blocking_page (to allow user opt-in), - add GetURLLoaderFactory() to safe_browsing_service, - add WebLayer API for setting/getting the settings (corresponding to prefs::kSafeBrowsingScoutReportingEnabled). BUG=1080742,1098022 Change-Id: Ifef3759ee3c89d7957442d518a7b5cffee196856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258733 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782618}
-
Toby Huang authored
Added a reminder to switch to the correct branch and to rebase any changes from the upstream branch before resuming development work. Bug: None Change-Id: I7828562118825feab8b4a8d322f31bca17f77070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262119 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#782617}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: If5d0ff4d249eb0da2a642e1342524bee300857a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267849Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782616}
-
Muyao Xu authored
Add UKM metrics to record the website that initiated a mirroring session and whether audio playback happens on the sender device (used on Meet) or the receiver device (used on Slides). Bug: b/158093883, 1095967 Change-Id: I79ddbc7b3e20b39ad68dc2e821005d0c7d550fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251201Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#782615}
-
Ella Ge authored
TBR=altimin@chromium.org No-try: true Bug: 1099395 Change-Id: Id6a241da8ec03929c725e6a4549b014025790e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267647Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#782614}
-
Li Lin authored
Bug: b/159848957 Test: manual test Change-Id: I54bfd91ccd36da61d6524a268a8d00751f2a485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264949Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782613}
-
Patrick To authored
If the xrCompatible flag is set on the attributes when creating a WebGL context and we cannot be xr compatible, today's behavior returns a null context. Instead, a WebGL context should be created and returned with the xrCompatible flag set to false. XRSystem::MakeXrCompatible* is also changed to return kNotCompatible on failure. This previously returned kAlreadyCompatible because MacOS doesn't have a VR service, so MakeXrCompatible fails. This caused tests on MacOS to fail since null was being returned when requesting a WebGL context. Bug: 1086697 Change-Id: Ida9b99b334a85f12c6313bc700cd02e7e5bda8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264599Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782612}
-
Ella Ge authored
Launch bug: crbug/1061219 Turn on the flag will not force all TWA to delegate location delegation TWA client app will need to declare location permission in its AndroidManifest.xml file to enrolled in location delegation. Otherwise it will fallback to use chrome permission. Bug: 1069506 Change-Id: Id4e3ec23211c50713fbfd3943dc9bb6d7911c97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260428Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#782611}
-
Ella Ge authored
TBR=meiliang@chromium.org Bug: 1096997 Change-Id: I12b0ae9c880489c581bf7d101ce19903fe81f03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268018Reviewed-by:
-
Garrett Beaty authored
Creating a fake so that read_file and write_file operate on a dictionary means that many operations do not perform the same between the test and production (e.g. raising a KeyError when attempting to read a non-existent file instead of an IOError or finding the actual file on the filesystem for a file that should not exist when using glob). The fake filesystem provided by pyfakefs means that the test will only see files that have actually been created by the test (modulo some default files such as /tmp) and no mocking is necessary without paying the cost of writing out to disk. Change-Id: Ib3401b62cdac93289e9ba327d9a8f39d47bb45c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267502Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#782609}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ R=gab@chromium.org Bug: 1097092 Change-Id: I92dd00dc61e49eac413181ec19b5f9252412932c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262453 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Owen Min authored
webstorePrivate.getExtensionStatus and requestExtension should return extension status as a string but not an array of string. Bug: 1099334 Change-Id: Ib56e466cc1d967e3a322494076ad7640a6868aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267719 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782607}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593097140-08659fb2dab2f981f5f09b831574debe8a1a216c.profdata to chrome-win64-master-1593104261-feaf838502d2cebda7dce5b42f2db042fba267b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id051a6fb8fb93a0ed2f6086b96a6824a8cc4c8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782606}
-
Christopher Cameron authored
On macOS, any SharedImageBacking that has a GLImage may be used as an overlay, shared with Dawn, or shared with Metal-backed Skia. There exists support for these things over in SharedImageBackingFactoryIOSurface, along with a copy-paste of a lot of the stuff found in SharedImageBackingGLImage. To avoid doing more copy-pasting, add some small ifdef spaghetti that calls the needed code in SharedImageBackingFactoryIOSurface. After this patch, the only user of SharedImageBackingFactoryIOSurface will be WebGPU. The next patch will remove that usage as well, and turn SharedImageBackingFactoryIOSurface into a set of helper functions. Bug: 1092155 Change-Id: Ia28ad13dd407d7de7bb3c5a5e16af95659238d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264858Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#782605}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593086359-249ab01be069392f844a8c0fded8d0e5e145da95.profdata to chrome-mac-master-1593108049-54cd7c484f00124b00c3e227cbddebfe7f650a96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2bf27042a407664d7de469decaf4aa7082b52774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267853Reviewed-by:
-
Mikel Astiz authored
Both the commit codepath and the getupdates codepath are dead because there is no Directory datatype registered in practice. All code is now deleted and the basic APIs cleaned up, although there continues to be a lot of code that can be deleted or simplified. Change-Id: Ic0cd67d8829766c1cd05d78af90230948a3ca78e Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256238 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#782603}
-
Tarun Bansal authored
Change-Id: Ieaef124ec362df615c263e7427b06525cee2270d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267431Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782602}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: I51766ea902b0b2bd90ead91dcb8bbeb2ee9e0857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267449 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782601}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/70ada5b1cf0c..4f404fa8beab 2020-06-25 jec@chromium.org Update What's New in DevTools 85 with breakpoints content link 2020-06-25 janscheffler@chromium.org [Network] Keep resource type when redirecting 2020-06-25 brgoddar@microsoft.com Grid: Add High Contrast styles for Line Labels If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I84cb9c04d82271cabc566ee800eacb0906726de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267414Reviewed-by:
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. This CL we should replace eventSender.mouseScrollBy with wheelTick which uses gpuBenchmarking.smoothScrollByXY in forms/resources/common-wheel-event.js. Bug: 1047176 Change-Id: I7416727dfcfbe2d88a283907ee132c838952747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171955Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782599}
-
Mike Dougherty authored
Additionally, update tests to use correctly formatted frame ids. Fixed: 1098606 Change-Id: I0d0b9cfa473d20433c228863af3a434ffd50b5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264468 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#782598}
-
Miriam Zimmerman authored
Per chrome inclusive language efforts, this CL replaces uses of the term "whitelist" with more-descriptive alternatives. BUG=1099354 TEST=CQ Change-Id: I1d5c10516c05d61db0e0591a30dbc103d09610b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267918Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#782597}
-
Jordan Bayles authored
This patch reenables the ShoveHighFrameRateDownYerThroat flaky cast_unittests End2EndTest. Turns out the test is flaky because on ASAN builds occasionally some of the quantitative checks don't take the expected amount of time. This patch is a targeted fix, and allots more time for ASAN runs of the tests specifically. This patch also removes references to WontFix'ed bug 612496 and adds a new CAST_E2E_TEST macro that toggles off tests in OFFICIAL_BUILD environments. Bug: 801794 Change-Id: I860e02d3e8cf1f7bd9a990cc49104058822860d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258460Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#782596}
-
Jordan Taylor authored
Both of these tests were already marked as flaky: virtual/threaded/fast/scroll-snap/snaps-after-scrollbar-scrolling.html virtual/threaded/fast/scroll-snap/snaps-after-keyboard-scrolling.html Additional flakes are occurring so I am expanding the expectations to cover more flaky cases. Bug: 878878 Change-Id: I6fc4b83c8ec69300507ac04929ea435888d34f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264868Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782595}
-
Steven Bennetts authored
This CL: * Converts network_ui.html/js to a Polymer element * Introduces a browser proxy for chrome.send / cr.sendWithPromise calls * Replaces chrome.send + listeners with cr.sendWithPromise * Replaces cr tabpanels with cr-tabs + iron-pages. Bug: 921726 Change-Id: Ib140fc17de7b000205709dfee619b848c56448a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265503Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782594}
-
Katie D authored
They have left Google, so it doesn't make sense for them to be in OWNERS any more with their Google.com email. Bug: None Change-Id: I964c4e74677f22593b5b53f17c713127c40e0c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267427Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#782593}
-
Chris Blume authored
This CL fixes a misspelling in gpu/config/gpu_switches.cc Change-Id: I57bde5aa8e01de99d369d32cc80b77a414989e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258963 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782592}
-
John Delaney authored
Re-enables this browsertest suite with the storage layer to address flaky browsertest issues. This successfully resolved similar flakes on https://chromium-review.googlesource.com/c/chromium/src/+/2225286 Bug: 1087775 Change-Id: I3444395bf6f7269ec91ee95547b3e236a398994f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264576 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
-
Mila Green authored
Bug: 1020650 Change-Id: Ie9f32ea00acf8f7c3269da0916866757e8317b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267846Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782590}
-
zhaoyangli authored
- Changed SIM_IPAD_PRO_14_0 as Xcode 12 requires a generation suffix for it. - Fixed a version typo in SIM_IPAD_6_GEN_14_0. Bug: 1098818 Change-Id: Iab27f1ec84dab417abb41f998df06c4093257e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265494Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782589}
-
Rob Buis authored
Make NGMathRowLayoutAlgorithm store margins. To help collect the margins per child, add ChildWithOffsetAndMargins, based on NGContainerFragmentBuilder::ChildWithOffset but with added margin information. Bug: 6606 Change-Id: Ib546caa720d982c37843717904f06c4c85bbe95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257894 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782588}
-
Ella Ge authored
TBR=kbr@chromium.org Bug: 1099206 Change-Id: I282de7e0bd96a52bf4485dbca508219acda18cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267580Reviewed-by:
-
Peng Huang authored
Currently, ExternalVkImageBacking uses Vulkan API to upload pixels data directlly, so it has to call gr_context->submit() to make sure skia internal primary command buffer is submitted. The commands in the skia internal command buffer may need to access content of the ExternalVkImageBacking before WritePixels() call. Remove this submit() by using GrContext::updateBackendTextre(), so the commands for updating pixels data will be recorded in skia internal command buffer too, and then the this command buffer will be submitted later, if the backing doesn't need synchronization. Bug: 1087063 Change-Id: Id38acc50490ea3e1c833bb8858b63ebf76f560c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267419 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782586}
-
Charlie Harrison authored
This CL adds a ContentBrowserClient API to allow the embedder to disable impression / conversion registration wholesale. The initial implementation of this in the //chrome layer is to disallow when the third party cookie blocking setting is enabled, though we expect this implementation to change in the future. Bug: 1058018 Change-Id: I152a95a9f800f53d3be984ddd9f6586b3539b53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155291 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Klaus Weidner authored
This script runs on multiple input files provided in --idl-files-list, so an assertion error causes a generic build failure without any clear indication which of the inputs was problematic. This change adds the filename and additional context to the assertion error messages. Before/after example: File "../../third_party/blink/renderer/bindings/scripts/generate_origin_trial_features.py", line 72, in read_idl_file assert len(interfaces) == 1 AssertionError AssertionError: Expected one interface in file '../../third_party/blink/renderer/modules/example_init.idl', found 0 Change-Id: I5de2abbec9b38a72b19b7c1598654d11ab006767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261266 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#782584}
-
Daniel Murphy authored
* Creates UserPageOrdinal and UserLaunchOrdinal data entries in the WebApps system, and has them sync across devices. * Integrates these values & web apps in general into ChromeAppSorting. * Integrates hooks required for storing, refreshing, and resolving these ordinals into WebAppSyncBridge * Initializes the webapp portion of ChromeAppSorting in WebAppUIManagerImpl * Tests the syncing & conflict resolution behavior in the BMO sync tests A nunace in this change: * When setting page or launch ordinals, they are set for BOTH the extensions & WebAppProvider system now. That means there are sync change events happening on both systems. * This ensures that this data is synced between versions of chrome that are BMO and non-BMO. * This means that we want to ensure we STOP doing this when we decide remove the extensions data for migrated webapps. Bug: 1061586 Change-Id: I2076c18d293e99b339b542a84cdc31a9ad60a87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243603Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#782583}
-
Becca Hughes authored
As discussed, since this is a server side driven feature we can switch this on by default and use the server side allowlist. BUG=1044741 Change-Id: I74a0352062c718027bef90aad42f202934a96289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261632 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782582}
-
