GitLab

BUG=418536

Review URL: https://codereview.chromium.org/633073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderGrid::resolveContentBasedTrackSizingFunctions() was not spec
compliant because it used to compute content-based track sizes going
track-by-track. The specs clearly specify that instead, we should collect
all items spanning content-sized tracks and process them one by one after
sorting them by ascending span.

The obvious issue in the old implementation is that a grid item spanning the
first track was always processed before a non spanning item in the second
track. That leads to weird track size computations.

Review URL: https://codereview.chromium.org/592803003

git-svn-id: svn://svn.chromium.org/blink/trunk@183657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=419676

Review URL: https://codereview.chromium.org/634543002

git-svn-id: svn://svn.chromium.org/blink/trunk@183656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://codereview.chromium.org/625843002

git-svn-id: svn://svn.chromium.org/blink/trunk@183655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Made top controls work with virtual viewport pinch-to-zoom. (Blink) (patchset #3 id:100001 of https://codereview.chromium.org/643473002/)

Reason for revert:
Broke PinchViewportTest.TestTopControlsAdjustment on Mac bots (e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/32476/steps/webkit_unit_tests/logs/TestTopControlsAdjustment)

Original issue's description:
> Made top controls work with virtual viewport pinch-to-zoom. (Blink)
> 
> Together with the Chromium-side patch, makes top controls work properly
> under the virtual viewport mode of pinch zoom. The key changes on the
> Blink side are to adjust both the PinchViewport and FrameView max scroll
> bounds to account for the change in the top controls offset on the
> compositor. Additionally, I changed these to make the same floating point
> and snapping calculations as in the compositor to prevent losing pixel
> fractions.
> 
> Chromium side: https://codereview.chromium.org/641873003/
> 
> BUG=364109
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183639

TBR=aelias@chromium.org,rbyers@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364109

Review URL: https://codereview.chromium.org/655763002

git-svn-id: svn://svn.chromium.org/blink/trunk@183653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This property is parsed and stored on RenderStyle, but it's not
used anywhere, i.e. it has no effect.

If we later decide that we want this after all, we can re-implement
it as 'aspect-ratio' behind a flag.

Review URL: https://codereview.chromium.org/647723002

git-svn-id: svn://svn.chromium.org/blink/trunk@183652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes it possible to use a converter, and makes
style/animation application cleaner.

Review URL: https://codereview.chromium.org/644953003

git-svn-id: svn://svn.chromium.org/blink/trunk@183651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptForbiddenScope used to trigger a fatal assert if Blink tried to
execute script in a forbidden scope. This was problematic because
plugins often tried to run scripts inside these scopes.

To prevent these crashes, AllowSuperUnsafeScripts was added as an opt
out to allow plugin-triggered scripts to execute script anyway in these
dangerous contexts. This lead to bugs like https://crbug.com/367210,
where something that should be "impossible" wasn't.

In order to prevent random code from having to work around edge cases
that only happen when script shouldn't even be running, the entry points
for executing user script have been updated to first check if scripting
is forbidden. If it is, they just return undefined or an empty object as
appropriate.

A followup patch will attempt to apply a similar approach for handling
internal scripts.

BUG=363099,371084

Review URL: https://codereview.chromium.org/648423003

git-svn-id: svn://svn.chromium.org/blink/trunk@183650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Title should reflect action that will happen when button is pressed.

BUG=414140

Review URL: https://codereview.chromium.org/632253002

git-svn-id: svn://svn.chromium.org/blink/trunk@183649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183641

BUG=415031
TBR=sataya.m@samsung.com

Review URL: https://codereview.chromium.org/652983003

git-svn-id: svn://svn.chromium.org/blink/trunk@183648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423211

Review URL: https://codereview.chromium.org/653833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Moved the following blocks from interface.cpp to interface_base.cpp:
- security_check_functions,
- install_conditional_attributes, and
- install_conditional_methods

BUG=380523

Review URL: https://codereview.chromium.org/645833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423203

Review URL: https://codereview.chromium.org/636173006

git-svn-id: svn://svn.chromium.org/blink/trunk@183645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TEST=no layout test failure

Review URL: https://codereview.chromium.org/645743003

git-svn-id: svn://svn.chromium.org/blink/trunk@183644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a set of trace events to track reason when
StyleInvalidator invokes Node::setNeedsStyleRecalc. One of the trace events is guaranteed to be issued before StyleInvalidator issues setNeedsStyleRecalc on the node. The trace events come with InspectorStyleInvalidatorInvalidateEvent, which contains inspector node id, human readable reason string, and optionally the tagName/id/class/attr/invalidationList involved.

This is to be used from devtools so we post process and find the StyleInvalidator trace event on the given node to see the detailed reason for why StyleInvalidator decided issue setNeedsStyleRecalc on the node.

BUG=410701

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183177

Review URL: https://codereview.chromium.org/580373002

git-svn-id: svn://svn.chromium.org/blink/trunk@183643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebSocket implementation has moved to chrome. As it is stable now, let's
delete the old implementation.
This CL doesn't delete some platform/ and web/ classes, as some chromium-side
code depends on them.

BUG=423201
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/639333003

git-svn-id: svn://svn.chromium.org/blink/trunk@183642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Overlay Scrollbar if not scrollable along that axis. If the 
scrollSize along that axis is zero then set scrollbar along that
axis to false. This is applicable to Solid-Color scrollbars in Android
& Overlay scrollbars in the Aura.

BUG=415031

Review URL: https://codereview.chromium.org/643933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388375,401381
TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/642933008

git-svn-id: svn://svn.chromium.org/blink/trunk@183640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Together with the Chromium-side patch, makes top controls work properly
under the virtual viewport mode of pinch zoom. The key changes on the
Blink side are to adjust both the PinchViewport and FrameView max scroll
bounds to account for the change in the top controls offset on the
compositor. Additionally, I changed these to make the same floating point
and snapping calculations as in the compositor to prevent losing pixel
fractions.

Chromium side: https://codereview.chromium.org/641873003/

BUG=364109

Review URL: https://codereview.chromium.org/643473002

git-svn-id: svn://svn.chromium.org/blink/trunk@183639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
meter tag should have MSAA+IA2 Role as ROLE_SYSTEM_PROGRESSBAR and
AX role as AXGroup and Role description as "group"

BUG=421376

Review URL: https://codereview.chromium.org/652663003

git-svn-id: svn://svn.chromium.org/blink/trunk@183638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a fast, conservative way to determine if we are in the main thread.

1) In ThreadState::init(), take the underestimated size of the main thread.

2) When ThreadState::current() is called, check if the current stack address is within the underestimated size from the stack start of the main thread. If yes, we can immediately return the mainThreadState() without looking up TLS. Otherwise, we look up TLS.

TLS is very slow especially in Mac and Windows. This CL improves blink_perf.parser.querySelector-* (and other) benchmarks by 6% in Mac.

BUG=420515

Review URL: https://codereview.chromium.org/643883002

git-svn-id: svn://svn.chromium.org/blink/trunk@183637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we count CSS properties in CSSPropertyParser::parseValue (the
non-static version). This function is used recursively for shorthands,
so we end up tracking many CSS properties which haven't been specified
by users.

This patch moves the check up a level, so that it is only called on
properties specified by a user. I've also made it only count properties
that succeeded at parsing (behaviour wouldn't change for declarations
that fail to parse if we removed the property).

This should reduce the usage numbers on chromestatus.com for many
properties. For example while border-spacing is not specced as a
shorthand, it is implemented as a shorthand and we end up measuring
-webkit-border-horizontal-spacing whenever we parse border-spacing.

Review URL: https://codereview.chromium.org/642583006

git-svn-id: svn://svn.chromium.org/blink/trunk@183636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I misremoved the UseCounter in the process of moving marquee implementation
to JS. This CL readds the UseCounter.

Review URL: https://codereview.chromium.org/653753003

git-svn-id: svn://svn.chromium.org/blink/trunk@183635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Slimming Paint codepath wasn't properly adding paint offsets
to the applied clip rects, causing only a fraction of text to be
drawn. Also adding a debug red background to make it more obvious
when we're failing to paint. Cribbed from FrameView's old paint
code.

BUG=423071

Review URL: https://codereview.chromium.org/654713003

git-svn-id: svn://svn.chromium.org/blink/trunk@183634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tried to improve readability. Also re-arranged the for-loop a bit.

This CL is part of splitting up [1].

[1] https://codereview.chromium.org/639433002

R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/652703002

git-svn-id: svn://svn.chromium.org/blink/trunk@183633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unify the pixel snapping logic for selection rects by moving the logic
into selectionRectForText and having selectionRectForSimpleText and
selectionRectForComplexText respectively return precise values.

R=fmalita@chromium.org

Review URL: https://codereview.chromium.org/648633003

git-svn-id: svn://svn.chromium.org/blink/trunk@183632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=410411
TEST=no visible change

Review URL: https://codereview.chromium.org/655613002

git-svn-id: svn://svn.chromium.org/blink/trunk@183631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417463

Review URL: https://codereview.chromium.org/648223003

git-svn-id: svn://svn.chromium.org/blink/trunk@183630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This new event is of type MediaEncryptedEvent, which has initDataType instead of contentType (but this CL just renames one to the other, without translation), and changes the type of initData from Uint8Array to ArrayBuffer as per the WD EME spec.

Also in this CL:
  - Start renaming keyNeeded() to encrypted() by renaming the it on HTMLMediaElementEncryptedMedia.
  - Remove unused contentType argument from createWebkitNeedKeyEvent() (good thing it's unused or the contentType to initDataType change would be a lot harder).
  - Fix prefixed/encrypted-media-events.html test to test the prefixed needkey event instead of the unprefixed one.

TBR=jochen@chromium.org,ddorwin@chromium.org
BUG=224786
(cherry picked from commit ad09c3ed1914691ee4a089cfe95988892ed42407)

Review URL: https://codereview.chromium.org/655603003

git-svn-id: svn://svn.chromium.org/blink/trunk@183628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the API for WebContentDecryptionModule and
WebContentDecryptionModuleSession in order to implement
the latest EME API spec.

BUG=224786
TEST=Adding to API, no code using it. All existing EME tests pass.

Review URL: https://codereview.chromium.org/642583003

git-svn-id: svn://svn.chromium.org/blink/trunk@183627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch switches to "Causes" for explaining timeline records. The
major change is "Stacks" have been renamed "Causes". This is prepwork
for two upcoming projects: invalidation tracking which will fill out many
more causes, and javascript samples which are easily confused with
the "stack" term. If the causes checkbox is not checked, no initiator
or stack information will be shown.

Some minor rewording of the causes has also been done. For example,
the stack for a layout now reads "First layout invalidation" instead of
"Layout invalidated".

A screenshot is available at http://pr.gg/justcause3.png

BUG=410701

Review URL: https://codereview.chromium.org/631573002

git-svn-id: svn://svn.chromium.org/blink/trunk@183626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'parent' argument is not used, remove it.

This implicitly fixes an incorrect invocation of the constructor from
ScrollAnimatorNoneTest::SavePerAxisData, which following r183583 was
passing in an uninitialized pointer value as argument.

R=mkwst
BUG=

Review URL: https://codereview.chromium.org/648273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=183172 .

BUG=81439
TEST=none
TBR=jamesr

Review URL: https://codereview.chromium.org/641643004

git-svn-id: svn://svn.chromium.org/blink/trunk@183624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In pinch viewport mode, the size of the FrameView is always the content
width of the document (not the true viewport size), so this patch plumbs
the viewport size to fullscreen elements separately.  Secondly, in this
mode there is an "inner viewport" that scrolls separately and whose
scrollability additionally needs to be disabled.  Do so by using
setUserScrollable() (which is a mechanism that only works in this mode).

BUG=411072

Review URL: https://codereview.chromium.org/636363003

git-svn-id: svn://svn.chromium.org/blink/trunk@183623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is blink side CL to expose input type radio button with menu as parent with
correct IA2 role similar to aria role menuitemradio.

BUG=422879

Review URL: https://codereview.chromium.org/651893002

git-svn-id: svn://svn.chromium.org/blink/trunk@183622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL encapsulates the simple/complex logic in a low level glyphBuffer builder function, and removes all paint-related codepath-specific methods. Everything above buildGlyphBuffer() now operates on a codepath-agnostic data structure (glyphBuffer).

To pull this off, the CL unifies GlyphBuffer & GlyphBufferWithOffsets by adding offset support to the former. The approach has no downside beyond a slightly increased stack frame size for the simple path, and is aligned with plans to eventually store offsets for simple text also (and possibly drop advances altogether).

Also, most text blob caching logic is relocated down into Font drawText() - which allows us to trivially add support for complex text blobs (currently still off due to the lack of offsets support in buildTextBlob). The advance return value (which doesn't play well with blob caching) is dropped, and the only existing client for it is converted to use a new dedicated, blob-cache-bypassing drawUncachedText() method.

R=jbroman@chromium.org,eae@chromium.org,dominik.rottsches@intel.com,leviw@chromium.org

Review URL: https://codereview.chromium.org/645363003

git-svn-id: svn://svn.chromium.org/blink/trunk@183620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fetch the actual fill from the various paint-server RenderSVGResources
into a new "data blob" SVGPaintServer. This makes said resources
independent of the GC, and means that GC-state can be managed more
directly by the caller.
Since this makes postApplyResource useless, it's removed, and
applyResource is renamed to preparePaintServer.
Some functions residing on RenderSVGResource is moved to SVGPaintServer.
Paint-server fetch+application is moved to updateGraphicsContext, which
is also changed to return a bool indicating if a paint-server is
available. Handling of clip-path-as-mask is also moved here.

BUG=420022

Review URL: https://codereview.chromium.org/638933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All uses appear to have been removed from the codebase.

BUG=417463
TBR=adamk@chromium.org

Review URL: https://codereview.chromium.org/650933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417275

Review URL: https://codereview.chromium.org/602783002

git-svn-id: svn://svn.chromium.org/blink/trunk@183616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/652693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183614 bbb929c8-8fbe-4397-9dbb-9b2b20218538