GitLab

This CL changes the web request API to use the main_frame and sub_frame resource
types for navigation preload requests. Currently these requests use the 'other'
resource type. This also requires separating the
content::ResourceType::kNavigationPreload type into distinct types for
main-frame and sub-frame.

BUG=965960

Change-Id: I82340a87d18d9ccb9dc16f66a4c4531aa0f0c94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666715Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676640}

There was a race around |g_use_in_memory_db_for_testing| :

[ RUN      ] NonRecordingSiteDataCacheTest.EndToEnd
==================
WARNING: ThreadSanitizer: data race (pid=1484)
  Write of size 1 at 0x55e6654d29d0 by main thread:
    #0 ~AutoReset base/auto_reset.h:40:25 (unit_tests+0x42d690c)
    #1 operator() buildtools/third_party/libc++/trunk/include/memory:2338 (unit_tests+0x42d690c)
    #2 reset buildtools/third_party/libc++/trunk/include/memory:2651 (unit_tests+0x42d690c)
    #3 ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2605 (unit_tests+0x42d690c)
    #4 performance_manager::(anonymous namespace)::NonRecordingSiteDataCacheTest::~NonRecordingSiteDataCacheTest() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:30 (unit_tests+0x42d690c)
    #5 performance_manager::NonRecordingSiteDataCacheTest_EndToEnd_Test::~NonRecordingSiteDataCacheTest_EndToEnd_Test() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:66:1 (unit_tests+0x42d65d9)
    #6 HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x65f041e)
    #7 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2704 (unit_tests+0x65f041e)
    #8 testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:2828:28 (unit_tests+0x65f0ef6)
    #9 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5285:44 (unit_tests+0x6603366)
    #10 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x6602859)
    #11 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4873 (unit_tests+0x6602859)
    #12 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2453:46 (unit_tests+0x9dd5692)
    #13 base::TestSuite::Run() base/test/test_suite.cc:316 (unit_tests+0x9dd5692)
    #14 content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:103:23 (unit_tests+0x9ee213f)
    #15 Invoke<int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite *> base/bind_internal.h:499:12 (unit_tests+0x9dc3168)
    #16 MakeItSo<int (content::UnitTestTestSuite::*const &)(), content::UnitTestTestSuite *> base/bind_internal.h:599 (unit_tests+0x9dc3168)
    #17 RunImpl<int (content::UnitTestTestSuite::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > &, 0> base/bind_internal.h:672 (unit_tests+0x9dc3168)
    #18 base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:654 (unit_tests+0x9dc3168)
    #19 Run base/callback.h:97:12 (unit_tests+0x9ddf24b)
    #20 base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:158 (unit_tests+0x9ddf24b)
    #21 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:494:10 (unit_tests+0x9ddf0b0)
    #22 main chrome/test/base/run_all_unittests.cc:35:10 (unit_tests+0x9dc3099)

  Previous read of size 1 at 0x55e6654d29d0 by thread T18:
    #0 performance_manager::LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabaseImpl() chrome/browser/performance_manager/persistence/site_data/leveldb_site_data_store.cc:374:7 (unit_tests+0xb3e7762)
    #1 performance_manager::LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabase() chrome/browser/performance_manager/persistence/site_data/leveldb_site_data_store.cc:195:30 (unit_tests+0xb3e7394)
    #2 Invoke<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), performance_manager::LevelDBSiteDataStore::AsyncHelper *> base/bind_internal.h:499:12 (unit_tests+0xb3e9608)
    #3 MakeItSo<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), performance_manager::LevelDBSiteDataStore::AsyncHelper *> base/bind_internal.h:599 (unit_tests+0xb3e9608)
    #4 RunImpl<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), std::__1::tuple<base::internal::UnretainedWrapper<performance_manager::LevelDBSiteDataStore::AsyncHelper> >, 0> base/bind_internal.h:672 (unit_tests+0xb3e9608)
    #5 base::internal::Invoker<base::internal::BindState<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), base::internal::UnretainedWrapper<performance_manager::LevelDBSiteDataStore::AsyncHelper> >, void ()>::RunOnce(base::internal::BindStateBase*) base/bind_internal.h:641 (unit_tests+0xb3e9608)
    #6 Run base/callback.h:97:12 (unit_tests+0xacb91d5)
    #7 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/task/common/task_annotator.cc:142 (unit_tests+0xacb91d5)
    #8 base::internal::TaskTracker::RunBlockShutdown(base::internal::Task*) base/task/thread_pool/task_tracker.cc:773:19 (unit_tests+0xacdde01)
    #9 RunTaskWithShutdownBehavior base/task/thread_pool/task_tracker.cc:788:7 (unit_tests+0xacdd825)
    #10 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/task/thread_pool/task_tracker.cc:617 (unit_tests+0xacdd825)
    #11 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/task/thread_pool/task_tracker_posix.cc:24:16 (unit_tests+0xad5bfc4)
    #12 base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/test/scoped_task_environment.cc:663:46 (unit_tests+0x9dd0a08)
    #13 base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource) base/task/thread_pool/task_tracker.cc:479:5 (unit_tests+0xacdd119)
    #14 base::internal::WorkerThread::RunWorker() base/task/thread_pool/worker_thread.cc:320:34 (unit_tests+0xacf08cd)
    #15 base::internal::WorkerThread::RunPooledWorker() base/task/thread_pool/worker_thread.cc:222:3 (unit_tests+0xacf0561)
    #16 base::internal::WorkerThread::ThreadMain() base/task/thread_pool/worker_thread.cc:201:7 (unit_tests+0xacf03cf)
    #17 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 (unit_tests+0xad5cbb4)

  Location is global 'performance_manager::(anonymous namespace)::g_use_in_memory_db_for_testing' of size 1 at 0x55e6654d29d0 (unit_tests+0x0000132b39d0)

  Thread T18 'ThreadPoolForeg' (tid=1837, running) created by main thread at:
    #0 pthread_create /b/swarming/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:989:3 (unit_tests+0x3bd013b)
    #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:120:13 (unit_tests+0xad5c5c7)
    #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:246:10 (unit_tests+0xad5c4c5)
    #3 base::internal::WorkerThread::Start(base::WorkerThreadObserver*) base/task/thread_pool/worker_thread.cc:68:3 (unit_tests+0xaceff6d)
    #4 operator() base/task/thread_pool/thread_group_impl.cc:185:15 (unit_tests+0xace7e06)
    #5 ForEachWorker<(lambda at ../../base/task/thread_pool/thread_group_impl.cc:184:37)> base/task/thread_pool/thread_group_impl.cc:150 (unit_tests+0xace7e06)
    #6 base::internal::ThreadGroupImpl::ScopedWorkersExecutor::FlushImpl() base/task/thread_pool/thread_group_impl.cc:184 (unit_tests+0xace7e06)
    #7 base::internal::ThreadGroupImpl::ScopedWorkersExecutor::~ScopedWorkersExecutor() base/task/thread_pool/thread_group_impl.cc:103:30 (unit_tests+0xace47f4)
    #8 base::internal::ThreadGroupImpl::Start(int, int, base::TimeDelta, scoped_refptr<base::TaskRunner>, base::WorkerThreadObserver*, base::internal::ThreadGroup::WorkerEnvironment, base::Optional<base::TimeDelta>) base/task/thread_pool/thread_group_impl.cc:425:1 (unit_tests+0xace4799)
    #9 base::internal::ThreadPoolImpl::Start(base::ThreadPoolInstance::InitParams const&, base::WorkerThreadObserver*) base/task/thread_pool/thread_pool_impl.cc:197:11 (unit_tests+0xace0133)
    #10 base::test::ScopedTaskEnvironment::InitializeThreadPool() base/test/scoped_task_environment.cc:391:30 (unit_tests+0x9dcf8fc)
    #11 base::test::ScopedTaskEnvironment::ScopedTaskEnvironment(base::test::ScopedTaskEnvironment::MainThreadType, base::test::ScopedTaskEnvironment::ThreadPoolExecutionMode, base::test::ScopedTaskEnvironment::NowSource, base::test::ScopedTaskEnvironment::ThreadingMode, bool, base::trait_helpers::NotATraitTag) base/test/scoped_task_environment.cc:348:5 (unit_tests+0x9dcf2bc)
    #12 base::test::ScopedTaskEnvironment::ScopedTaskEnvironment<base::test::ScopedTaskEnvironment::SubclassCreatesDefaultTaskRunner, base::test::ScopedTaskEnvironment::MainThreadType, void>(base::test::ScopedTaskEnvironment::SubclassCreatesDefaultTaskRunner, base::test::ScopedTaskEnvironment::MainThreadType) base/test/scoped_task_environment.h:161:9 (unit_tests+0x3c4e2f0)
    #13 content::TestBrowserThreadBundle::TestBrowserThreadBundle<void>() content/public/test/test_browser_thread_bundle.h:131:13 (unit_tests+0x3c4e287)
    #14 performance_manager::(anonymous namespace)::NonRecordingSiteDataCacheTest::NonRecordingSiteDataCacheTest() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:23:3 (unit_tests+0x42d6a76)
    #15 NonRecordingSiteDataCacheTest_EndToEnd_Test chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:66:1 (unit_tests+0x42d69d4)
    #16 testing::internal::TestFactoryImpl<performance_manager::NonRecordingSiteDataCacheTest_EndToEnd_Test>::CreateTest() third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:460 (unit_tests+0x42d69d4)
    #17 HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x65f01df)
    #18 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2688 (unit_tests+0x65f01df)
    #19 testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:2828:28 (unit_tests+0x65f0ef6)
    #20 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5285:44 (unit_tests+0x6603366)
    #21 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x6602859)
    #22 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4873 (unit_tests+0x6602859)
    #23 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2453:46 (unit_tests+0x9dd5692)
    #24 base::TestSuite::Run() base/test/test_suite.cc:316 (unit_tests+0x9dd5692)
    #25 content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:103:23 (unit_tests+0x9ee213f)
    #26 Invoke<int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite *> base/bind_internal.h:499:12 (unit_tests+0x9dc3168)
    #27 MakeItSo<int (content::UnitTestTestSuite::*const &)(), content::UnitTestTestSuite *> base/bind_internal.h:599 (unit_tests+0x9dc3168)
    #28 RunImpl<int (content::UnitTestTestSuite::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > &, 0> base/bind_internal.h:672 (unit_tests+0x9dc3168)
    #29 base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:654 (unit_tests+0x9dc3168)
    #30 Run base/callback.h:97:12 (unit_tests+0x9ddf24b)
    #31 base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:158 (unit_tests+0x9ddf24b)
    #32 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:494:10 (unit_tests+0x9ddf0b0)
    #33 main chrome/test/base/run_all_unittests.cc:35:10 (unit_tests+0x9dc3099)

The problem is that opening the DB (in LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabaseImpl)
is done asynchronously, and by the time we get there the AutoReset might
have been destroyed. Waiting for the DB to be initialized fixes this.

This reverts commit b7310e3f.

Bug: 961336
Change-Id: Ia7d9367b10857837340358d7a516c26b87d0cebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682668Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676639}

Bug: 878585
Change-Id: I8e9d2ba68f509ad3505567812b3b798347a66740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682797Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676638}

The 'additional info' column can contain arbitrarily large contents. To make
viewing easier, this CL adds a download link to the cell on hover. Downloads
as JSON.

Change-Id: I004e050da09043fe9692e6a4b4e153645b2dc281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685896
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676637}

This is a cherry-pick Lighthouse roll.

The bundling for DevTools sets `Runtime.cachedResources` after the scripts run.
However, one of the modules in these scripts is resolved early in runtime,
before any resources are processed. Deferring with a getter works around this.

Bug: 979131
Change-Id: I3b9e5b6ca0b984e8289d2af56e00ea7bfdd260ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696348Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@google.com>
Cr-Commit-Position: refs/heads/master@{#676636}

Currently when auto translation is triggered, target language tab is not
selected after translation is completed. This CL fixes this bug.

Change-Id: I605a8f1d04a3bea92054c3f37eb37be9f4d1732b
Issue: 963148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687050Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Haohao Wang <hhw@google.com>
Cr-Commit-Position: refs/heads/master@{#676635}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I2355a49d74a5b72fcbea906a764d116c6fd70267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699127Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676634}

Not all exceptions have a |msg| member leading to crashes like:

Force-installing 972ed755f8e6d31cae9ba15fcd08136ae1a7886f to update it.
Traceback (most recent call last):
  File "src/buildtools/ensure_gn_version.py", line 116, in <module>
    sys.exit(main())
  File "src/buildtools/ensure_gn_version.py", line 99, in main
    print('Failed to extract the binary:\n%s\n' % e.msg)
AttributeError: 'exceptions.IOError' object has no attribute 'msg'
Error: Command '/usr/bin/python src/buildtools/ensure_gn_version.py git_revision:972ed755f8e6d31cae9ba15fcd08136ae1a7886f'
       returned non-zero exit status 1 in /usr/local/src/chromium

Let Python stringify the entire exception as it should DTRT all the
time.  Here we now get:
Force-installing 972ed755f8e6d31cae9ba15fcd08136ae1a7886f to update it.
Failed to extract the binary:
[Errno 13] Permission denied: '/usr/local/src/chromium/src/buildtools/linux64/gn'

Similarly, not all exceptions fill out the |message| member.
If the tool doesn't exist, subprocess fails with OSError (ENOENT),
and the message string is empty.  So rely on stringifying the whole
exception to get something useful out:
  `/usr/local/src/chromium/src/buildtools/linux64/gn --version` failed:
  [Errno 2] No such file or directory

Change-Id: I878e2d2d9b8933743b3e3a632b2e65bc9a0b5724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697946
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676633}

already shown.

There is a race condition in the logic creating context menus on
touchless. The TouchlessModelCoordinatorImpl is notified
asynchronously, and it is typically the thing that guards us from
creating a second context menu. This patch fixes this by having the
TouchlessContextMenuManager implement its own guarding logic, which
will work synchronously and not be vulnerable to any races.

This solution relies on the ModalDialogManager always notifying the
TouchlessContextMenuManager when the previous dialog was closed.
Otherwise we could get stuck in a state where the
TouchlessContextMenuManager thinks there's an open dialog when there
isn't actually one and the user is unable to open the context menu.

Bug: 982826
Change-Id: Ibf030b637c5d55122108731fa727976f967e168f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699210Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676632}

This reverts commit c0c5f227.

[Sheriff here:]

Reason for revert:
Failing on Windows bots:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64
(sometimes in different ways)

One failure example:
https://test-results.appspot.com/data/layout_results/Win7_Tests__1_/93239/webkit_layout_tests/layout-test-results/results.html
---
This is a testharness.js-based test.
PASS document.cookie set/overwrite/delete observed by CookieStore
PASS CookieStore set/overwrite/delete observed by document.cookie
FAIL CookieStore agrees with document.cookie on encoding non-ASCII cookies assert_equals: Empty cookie jar after document.cookie cookie-clearing using max-age=0 expected (undefined) undefined but got (string) "DOCUMENT-🍪=DELETED"
PASS document.cookie agrees with CookieStore on encoding non-ASCII cookies
Harness: the test ran to completion.
---

Different failure example:
https://test-results.appspot.com/data/layout_results/Win10_Tests_x64/38274/webkit_layout_tests/layout-test-results/results.html
---
This is a testharness.js-based test.
FAIL document.cookie set/overwrite/delete observed by CookieStore assert_equals: Empty cookie jar after document.cookie cookie-clearing using max-age=0 expected (undefined) undefined but got (string) "DOCUMENT-cookie=DELETED"
PASS CookieStore set/overwrite/delete observed by document.cookie
PASS CookieStore agrees with document.cookie on encoding non-ASCII cookies
PASS document.cookie agrees with CookieStore on encoding non-ASCII cookies
Harness: the test ran to completion.
---

I'm not positive whether the re-enabling the test was appropriate and then regressed with another change later in the day.  I tried to investigate that theory and it became too much of a pain.  The best thing is to disable the failing test and move on, trusting you fellow engineers to figure out the root cause.




Original change's description:
> Cookie Store API: Remove flaky test expectations.
> 
> We expect https://crrev.com/c/1635430 to have fixed the flakiness and
> manually confirmed that the test now passes across 100 repeated runs.
> 
> Bug: 827231
> Change-Id: I4599671cf6db1192847585ba2789995b377d23aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696449
> Commit-Queue: Staphany Park <staphany@chromium.org>
> Auto-Submit: Staphany Park <staphany@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#676343}

TBR=pwnall@chromium.org,staphany@chromium.org

Change-Id: I1402728a7df3635f72d29fa3cd86a619888248a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699441Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676631}

Bug: 982829
Change-Id: I635990f11c04ad8aa098852731832671b5362d00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699224Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676630}

Currently GpuServiceImpl::CreateGpuMemoryBuffer blocks the IO thread
until the DRM thread allocates the buffer. However, the DRM thread
cannot allocate the buffer until the corresponding AcceleratedWidget is
registered, which depends on the IO thread staying responsive in order
to receive the registration message from the browser and process it.
This causes a deadlock. In order to avoid this, make
GpuServiceImpl::CreateGpuMemoryBuffer asynchronous.

Bug: 981721,620927
Change-Id: Id35f17cc4ff3a800999e84cb76ca3e134bc13a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696353
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676629}

Record the number of extensions in ForcedList per session
if ForcedList is not empty.
Add unit test and definition in histograms.xml

Bug: 981891
Change-Id: I39fdd3bb4e5a61411b4d275b7c80229cfe84ca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690967
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676628}

Change-Id: I88da2498df4c837cc037f452bf0b64c1c373e157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699142
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676627}

Add a note about finding V8 regressions without doing a local build
and update the link used in the bug template (old link is dead).

Change-Id: Ica2be83ab833c03a71e25a307e2fb105455805e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699243
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676626}

New functions help to build the protocol objects to be sent to the
front end side.

Bug: 974070

Change-Id: Ia830ea413c2d7a85793654b1e8655a734fd610c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658835
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676625}

Sets several GPU pixel tests on Mac and Win7 to retry on failure due to
their configurations flakily producing valid images that haven't been
seen in a while. This hits a known issue with Skia Gold where images
that haven't been seen in a while aren't included in the provided
baselines.

Bug: 983212
Change-Id: I12fedb9b68ed811108dfd3c88821eb7838d76a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698661Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676624}

- Split ModuleInstaller to ModuleInstallerImpl and its interface.
- Remove //components/module_installer/../src-test
- Create a new ModuleInstallerRule to use in tests.
- Update bytecode rewriting to use getInstance().
- Remove dependency on arcore in chrome_test_java (used on Kitkat).

Bug: 981084
Change-Id: I7909fe67fa29bdb0e5c787faf4293600283421ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687303
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676623}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I1900b29dca70ee4d5cd871b195173e45337a7dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699121Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676622}

This means that the sync_integration_tests code can include e.g. App
Service code without leading to a "#include <dbus/dbus.h>" dependency.
Without this change:

In file included from ../../chrome/browser/apps/app_service/app_service_proxy_impl.h:18:
In file included from ../../chrome/browser/apps/app_service/crostini_apps.h:15:
In file included from ../../chrome/browser/chromeos/crostini/crostini_registry_service.h:18:
In file included from ../../chrome/browser/chromeos/crostini/crostini_manager.h:23:
In file included from ../../chromeos/dbus/cicerone_client.h:14:
../../dbus/object_proxy.h:8:10: fatal error: 'dbus/dbus.h' file not found

Change-Id: I71b4a54ebd7e2ddef05d84c20e1e19826c86f392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688366
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676621}

This adds four ARC feature flags that are needed by arcvm-launch to
determine what commandline parameters should be passed to the Android
kernel.

BUG=b:136128691
TEST=dbus-send

Change-Id: If7e189977d4f289a4278df21ef995d6f8fcc2664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695737Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Chris Morin <cmtm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676620}

While working on http://crrev.com/c/1661175 I noticed that the UI
Automation tree dumper was missing support for the BoundingRectangle
property. This CL adds it.

UIA, like MSAA, reports object locations in screen coordinates. The UIA
dumper offsets these to be relative to the root node's location. This
matches the behavior of the MSAA tree dumper and protects the test from
variability based on window position.

Bug: 844149
Change-Id: Ib4507ce5fe88e2918ddcdf088f693edc37fcb9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663401
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676619}

ScheduledNotificationManager.

Keep this cl simple to just move the ownership of
IconStore for future change.

-TODO in next cl: implement the logic to read/write/delete
icon asynchronously.

Bug: 963290
Change-Id: Ifbbe9875b9b9f4d0bd20db10cfb523d1c847ed2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696452
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676618}

Add a bunch of new tests to cover CopyVideoFrameTexturesToGLTexture and
Paint/Copy for when the source VideoFrame contains GPU textures.

This uncovered an issue where in one particular case the frame was
incorrectly cropped twice when copying a RGBA texture frame, which this
patch also fixes.

Bug: 969201
Change-Id: Id402a85840397522cd6b5c5e44bfe03abdc90f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697529
Auto-Submit: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676617}

Replaced WebGLObject's RunDestructor method with a PreFinalize method.
Removed destructors from all classes inheriting from WebGLObject.
PreFinalizer relies on the same virtual methods as the previous
destructor.

Measured performance using tough_webgl stories of rendering.desktop
benchmark. No significant regressions observed.
Summary of results regarding PreFinalization performance:
https://docs.google.com/spreadsheets/d/1vXjVxS5jFT2Bxla8wKzbCXVgUFvKC86WN0vgt0XK8KE/edit?usp=sharing

Bug: 981043
Change-Id: I1ff2762a843c4c443fd0c2f948484a46a0e94738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690834
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676616}

Bug: 981365
Test: manual
Change-Id: I9d6b3838ee5d641f20b51e0e34810e788c1e24e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696523
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676615}

Code to set the policy host restrictions is duplicated in
Dispatcher::OnUpdatePermissions. Fix it.

BUG=None

Change-Id: I3cfc5cbe6b7565c2093204690bd88333a23f683a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695758
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676614}

Add gpu-fyi-try-win-xr-builder as an alternative.

Drive-by remove non-existent
buildbot/chromium.gpu/Android Release (Nexus 5X)

Bug: 982086, 977735
Change-Id: I30effd28b414ce46df230c9b24305921c8cdb423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696691Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676613}

We can do our masking later, avoiding violating FDIO's assumptions.

Change-Id: Ia28b74b9d7fadae6512af51df18e39935e3e90d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697140Reviewed-by: James Robinson <jamesr@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676612}

If there is an edit field for a flag (e.g "Insecure origins treated as secure"),
it should get focus when tabing through that flag, not after tabing through all
the flags. This PR fixes this focus order issue.

Bug: 982888
Change-Id: I7fd62b4ea60b15f0e1a1abdd48f27e1b08fa1c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696772Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#676611}

Bug: 939674
Change-Id: I54e7eb79a9321ee205c27cbb23b9370ee5a1e1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665939Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676610}

The comment on EAGERLY_FINALIZE metions m_extraData that does not exist

Bug: 981043
Change-Id: I3112e41de68dcf764643bcab802dafa05372e7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697187
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676609}

Intent to implement and ship:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/MzXscv7fT0w/ygq7qc6sBQAJ

The implementation landed behind a flag here:

https://chromium-review.googlesource.com/c/chromium/src/+/1686824

It has been in a few Canary versions without issue, and appears to
work as advertised in manual testing.

BUG=603193

Change-Id: I6e8737ef6de4444f887e986566c154f331869a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695965Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676608}

https://skia.googlesource.com/skia.git/+log/7825d4983f90..f6da14697e15


git log 7825d4983f90..f6da14697e15 --date=short --no-merges --format='%ad %ae %s'
2019-07-11 bsalomon@google.com Move compatible stencil tracking from GrGLCaps::fConfigTable to ::fFormatTable.
2019-07-11 jvanverth@google.com New approach to fixing Vulkan MSAA.
2019-07-11 rmistry@google.com [perf_skottiewasm_lottieweb] Do 2 loops with 25 points each and then pick 25 from the middle
2019-07-11 jvanverth@google.com Remove deprecated discard method and GrCaps support
2019-07-11 mtklein@google.com instructions for JIT tail support on ARM


Created with:
  gclient setdep -r src/third_party/skia@f6da14697e15

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@google.com

Change-Id: I6d313c6f2191858b1da9fcfe8c5ffb8b6a8e43e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698784Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676607}

It's possible for a renderer to trigger ended while a demuxer hits an
error which has not yet propagated to WMPI (where Stop() would be
invoked).

BUG=982747
R=sandersd

Change-Id: Ibf225c85ef3d07f342dabf3e60bc835166f4c3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697435Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676606}

This CL adds support for handling of unsafe-eval in isolated worlds.

Since the IsolatedWorldCSP feature is disabled by default, no behavior changes
are expected.

BUG=896041

Change-Id: I41b5ddc905b2193e29e4fbe56b4c28c350b298b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670352Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676605}

CSSPrimitiveValue::TypeWithCalcResolved() is an ambiguous function that
mixes numeric literal unit types and math function result categories. It
also leads to misuse, as many callers may assume that the returned type
is the unit type of GetDoubleValue(), which is incorrect.

Hence, this patch removes some callers of TypeWithCalcResolved(). It
might have also revealed some existing bugs, which are marked by TODOs.

Bug: 979895
Change-Id: I4051b940d8b67ab22868cd803ee21422a4c5d587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696274Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676604}

The Direct Composition Visual tree should be rebuilt after switching between
overlay and underlay. Because the old code didn't do this, the swap chain is
still in underlay mode after switching from underlay to overlay. Thus, the
video controls from the last underlay frame still shows on the later overlay
frames.

Bug: 978203, 974344
Change-Id: If179fc07de6a2a9580234310e25f90221a06fc12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697312Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676603}

Before this patch, a failure to download a payment manifest would be
printed in developer console, but would not be returned back to the
merchant. This made debugging production problems difficult, because
real world users have different configurations that can be hard to
predict and replicate in a local development environment.

This patch forwards the errors from the downloader to the merchant when
rejecting the promise returned from PaymentRequest.show(). If multiple
errors occur, only the first one is forwarded. If PaymentRequest.show()
is not being rejected, then the downloader error is still printed in the
developer console, but not forwarded to the merchant.

After this patch, the first failure to download a payment manifest is
forwarded to the merchant in the rejection of the promise returned
from PaymentRequest.show().

Bug: 977145
Change-Id: Ide9021293099a9c1488ac3d1bd2c96ce9afe2e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685429
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676602}

Depends on CL 1692987

Bug: 930109
Change-Id: I02093da36b69e50753e8bda2859f9af09a3f5406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695270
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676601}