- 26 Oct, 2019 10 commits
-
-
Mohammad Refaat authored
Bug: 987646 Change-Id: I689dde8f1cdeeb030fd94897507962d02498ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881338 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#709714}
-
Jon Mann authored
When navigating a cr-network-list, announce the connection status of the highlighted network when available. Bug: 1011001 Change-Id: Id075e599f56f57f58a3f192e645ef268ec13b72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873216 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709713}
-
Yuri Wiitala authored
Also includes chrome/browser/media/.../chrome_udp_socket changes to account for openscreen::platform::UdpSocket interface changes. https://chromium.googlesource.com/openscreen/+log/d0f315b3fac8..729798cc3be6 $ git log d0f315b3f..729798cc3 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 miu Cast Streaming: Receiver tweaks, revealed while working on demo app. 2019-10-23 miu Clean-up/Bug-fix: Move all UdpSocketPosix impl out of public API. 2019-10-22 rwkeane DNS-SD: Constants 2019-10-21 mfoltz [Open Screen] Update README.md 2019-10-21 rwkeane DNS-SD: Class Skeletons 2019-10-21 mfoltz [Open Screen] Add scheduler for linux64_gcc_debug. 2019-10-21 takumif Format TODO URLs as TODO(crbug.com/openscreen/000) Created with: roll-dep src/third_party/openscreen/src Change-Id: I87faa4377c42e080fb46454911c3a086c6b84eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877614Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709712}
-
Dale Curtis authored
For 10-bit and 12-bit formats this results in a relative error of ~2.9% and ~3.7% respectively. As discussed offline, it's not worth adding a bit depth to gfx::ColorSpace at this time for this. Potentially at some point in the future someone will create the equivalent of the full vs limited range images we have for 8-bit: https://referencehometheater.com/2014/commentary/rgb-full-vs-limited/ At which point we may need to update our implementation to be more accurate. R=ccameron Change-Id: I0cdc6a9023ec74b53da1620f84f64b531c323634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879720Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709711}
-
Ana Salazar authored
Make the shelf background opaque when in overview mode, so it matches the color with the in-app shelf. Fixed: 1017427 Change-Id: Ic633c9a2df6d8967cc606ebf869559dfba2f719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879708Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709710}
-
Alex Cooper authored
WebXr uses a different channel than WebVR to send up gamepad data, as such, runtime specific support for this WebVr-only channel can now be removed. Fixed: 1017854 Change-Id: Ic597ce27c26b8a70258d5991a3f0ff68bd6f86fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880078 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#709709}
-
Ana Salazar authored
Fixes an issue where the launcher wouldn't close with a down fling if the event started on the shelf. Bug: 1016582 Change-Id: I51a329f74b269f3de7ce1f11ce921db305ae7363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879722 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709708}
-
Xianzhu Wang authored
We are using mock overlay scrollbars in blink web tests and unit tests in particular cases. Mock scrollbar will not be a standalone setting in blink, and doesn't need to expose to chrome. Change-Id: I339398322e473d09364069129b3c716aaddd0d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879706 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709707}
-
Evan Stade authored
The various services in SafeBrowsingService seem like good candidates to be KeyedServices, but their lifetimes don't match up well. Thus, simply replace NotificationService notifications with ProfileObserver. Additionally, fix some bugs in TelemetryService creation/destruction: 1. If an OTR profile were created and destroyed, the TelemetryService for its original profile would have been released, but not destroyed, so it would leak on shutdown. 2. If an OTR profile were never created, the TelemetryService would be destroyed when SafeBrowsingService was destroyed, rather than in ShutDown(). The destructor of AndroidTelemetryService would then access |profile_| after the profile had been destroyed. Bug: 268984 Change-Id: I25c8b092c086f9453e41ceaad5eb34ed1d609100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877149Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#709706}
-
Eric Karl authored
This reverts commit 8ccc248e. Reason for revert: This fix was quick / imperfect due to merge constraints. A more complete fix will be landed following this revert. Original change's description: > DeJelly - Fix SurfaceAggregator's handling of non-merged OOPIF surfaces > > In cases where a SurfaceDrawQuad's root render pass was not merged into > its parent, we did not correctly handle cases where the root render > pass represented a subset of the SurfaceDrawQuad's area. This was > possible in OOPIF cases where the root render pass was clipped to > visible bounds. > > This CL adjusts the root render pass so that it always represents the > full SurfaceDrawQuad area. > > While it's possible to hit this bug without de-jelly, this is much > more common with de-jelly, so the change is restricted to reduce merge > risk. A follow-up will implement this change more generally. > > Bug: 1016677, 995965 > Change-Id: If733065277128d53f0b59483f167d177aa777f54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873277 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Victor Miura <vmiura@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708288} TBR=vmiura@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016677, 995965 Change-Id: I13b953da9b96bd4a111a393b448359d08be18b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879696Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#709705}
-
- 25 Oct, 2019 30 commits
-
-
Olivier Yiptong authored
Sets a new user gesture when the user successfully picks a file or directory. This allows developers to request write permissions immediately following the user making a choice. Will not activate if the user canceled. Bug: 1014171 Change-Id: Ie7847b67316244348bf1021bac0ca058a8521dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872776 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709704}
-
Matthew Mourgos authored
Correctly set the drag handle size after the delegate_view_'s layout manager is removed and set to nullptr. Bug: 1009731 Change-Id: I68a0f137e9f065a67631d0a8df81d641d1be1f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880267Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709703}
-
Daniel Murphy authored
The connection request system keeps around the LevelDBDatabase object when a delete happens to allow subsequent open on that same database. To do this, it resets the IndexedDBMetadata back to a default state. During a recent refactor, this state reset wasn't done properly, and we don't have any tests to catch that error. This change fixes that incorrect state reset. A test isn't included here because: 1. It passes the third party test provided to us, 2. The current unittesting framework isn't great and needs to be replaced (don't want to create negative work) 3. It is pretty obvious this fixes the problem, and there are no other 'incorrectly' or 'not' re-initialized state here, 4. Current layout tests should have caught this, and it is unclear why. Bug to create this test: https://crbug.com/1018444 5. IndexedDB work is currently on the backburner while Storage Service is pursued, and won't be re-prioritized until next year-ish. I don't want to spend time on this now when it's needed for Storage Service work. If more P0 bugs crop up in IndexedDB over the next week, then we may have to re-think this policy and divert engineering effort towards making IndexedDB more stable. This is present in m78, which was just promoted to stable. If there are any more issues, we expect them to show up in the next week or so. TESTED=Manually tested using example test case from field. R=cmp@chromium.org Bug: 1018406 Change-Id: I36e42777e07ef91bf8cf11b9a633a9171ca3755e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880320 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#709702}
-
Moe Ahmadi authored
Currently we track the match element being deleted. This is in order to detect focusout events on the realbox wrapper as a result of matches being replaced by new ones after deletion. This CL avoids that by stopping to listen for 'focusout' just before the matches are replaced and starting to listen for it immediately after. Bug: 243926 Change-Id: I8e37fdc7d6a1f52f052de6ef3ec711ed7bc927bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879660 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#709701}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to FilterInterfaces in Connector interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert MakeStrongBinding to MakeSelfOwnedReceiver. Bug: 955171 Change-Id: I63129314a47f98c0687a71e0da441ebd545556b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875893Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709700}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateInterfaceFactory function in MediaService interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert DeferredDestroyStrongBindingSet to mojo::UniqueReceiverSet Additionally, this CL applies pending_remote CreateCdmFactory function in CdmService because this CL needs to change it for the dependency. Bug: 955171 Change-Id: I6974114eda8c27539185227a10a65f121d660b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880234Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709699}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateAssistantAudioDecoder in NetworkContext interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. Bug: 955171 Change-Id: Ie3fbeaf64d26252d05aabeba289e733d65ea7c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873829Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709698}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8bf5caaa8fd..2c615017d3a8 Created with: gclient setdep -r src-internal@2c615017d3a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:992974 Change-Id: I8ae2ad5f9c97a3fa25c4c0b51a9a10d7e84858db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881489Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709697}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ddc6b4834534..d2bf14695546 git log ddc6b4834534..d2bf14695546 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 saklein@chromium.org artifacts controller: Consider no-image-dir a success. Created with: gclient setdep -r src/third_party/chromite@d2bf14695546 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2aafe7dfda5ab56ac688c9eacbdfc0cdb5a81bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709696}
-
Wez authored
TBR=kmarshall Bug: 1018178 Change-Id: If6d6c4d3950c4a231fee75c6dbd114ac9aab30f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879686Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#709695}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7697476ad2d7..ff82e15d014a git log 7697476ad2d7..ff82e15d014a --date=short --no-merges --format='%ad %ae %s' 2019-10-25 herb@google.com Add GL Caps for Radeon Pro Vega Created with: gclient setdep -r src/third_party/skia@ff82e15d014a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ic1527b11bdb3dc10e49c1913e5e7f0e2d1b3f76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709694}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a4f45ee. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox creis@chromium.org, lukasza@chromium.org: external/wpt/fetch/corb foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ia73aa81021435f5133f6b08734cf72a549e84dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880959Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709693}
-
Alex Cooper authored
This removes WMR's support for WebVR, and refactors some helpers that existed to simplify those code paths. Also fixes a few lint errors for these files. Fixed: 1017847 Change-Id: I95d60fe4892f37febbda0a383e2bf270441f2845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879661Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#709692}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c9b070c..4812325d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32b031ad9eac46aabf44e21b5dc96ed9809e6e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880963Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709691}
-
Chris Mumford authored
Converted Demuxer::Seek to use OnceCallback and Renderer::Initialize to use OnceClosure. These are landing in the same large CL because media::SerialRunner is used for the callbacks for each of these calls and needed to switch from repeating to once at the same time. Bug: 1007799, 1007810, 751838 Change-Id: Ib0396c4db5d1cba47efbe1774d49c0217439943d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879558Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#709690}
-
Ryan Hamilton authored
Clean up HttpStreamFactory::Job by removing an unused method, and factoring out a large block of code into asmaller stand-alone method. Change-Id: I307b284b29ebe7113e90a9afda2d0f47123939f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881225 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/04ee27effffb..76763cb90a43 git log 04ee27effffb..76763cb90a43 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 ianelliott@google.com SwiftShader: Update the expectations file according to latest testing Created with: gclient setdep -r src/third_party/angle@76763cb90a43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I3c7b0dc47aa5dd3434b320d27ba86cde12170ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709688}
-
Connie Wan authored
See inline comments for why this is needed and when it happens. I don't have a good test repro for this, since I'd need to manually trigger a paint cycle to get the underline to appear anyway. I was, however, able to reproduce the issue in the bug and verify that it is fixed. Bug: 1014913 Change-Id: I0b70be1b0d83370714a004b96a437ca589c34bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874448Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#709687}
-
Aleks Totic authored
The author meant "reverse linear", not "reverse-linear" Bug: 849152 Change-Id: I8273c0c5866ceebe5a150cd8e29a0a4047c7b813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881890 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#709686}
-
Kai Ninomiya authored
# Docs update No-Try: True Bug: None Change-Id: I06e79dd19bd049d854a1cedf6898b77d5568bbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879719Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709685}
-
Adrienne Walker authored
This adds a new storage.mojom.BlobStorageContext that can be used to register new blobs. Previously, cache storage code subclassed from BlobDataItem::DataHandle and added the blob directly to the BlobStorageContext. Now, cache storage code creates a new mojo struct BlobDataItem and calls the BlobStorageContext mojo interface's register function with that entry to create a new blob. The storage::BlobStorageContext creates a MojoDataItem (the BlobDataItem::DataHandle subclass) and creates the blob as needed. That entry struct has readers on it so that the blob system can ask for data from cache storage over mojo. Bug: 1012869 Change-Id: Iabea4b6f5d1ac3e111602b0ec317b94870ab7332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830360 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#709684}
-
Stephen Roe authored
This adds ARM64 version of qemu and the Fuchsia SDK host tools to the test isolates. ARM64 host tools are required when the host_os is linux (which means that the test build host is a linux-x64 machine) and the target_cpu is arm64 (which means that the test run host is a linux-arm64 machine, as Fuchsia arm64 VMs need to be run on linux-arm64 machines for efficiency). The Fuchsia ARM64 SDK CIPD dependency in DEPS was updated because the initial version of the CIPD used the default symlink install_mode which doesn't load correctly into the isolate. The new version uses the copy install_mode which does load correctly. Bug: 1000901 Change-Id: Ia85e000a03897a2eaff07f882ca1291905b104de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880067 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#709683}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4861444124e0..b96466297216 git log 4861444124e0..b96466297216 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 ehmaldonado@chromium.org presubmit_support: Set python_executable to vpython. Created with: gclient setdep -r src/third_party/depot_tools@b96466297216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1017410 Change-Id: I4ec59e84157f1d1a9efd46b82da9745f8630dda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881477Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709682}
-
Connor Lange authored
Added agent_url to support applications being handled by different agents. Bug: b/141573972 Test: cast unittests + CQ Change-Id: I00c400338c848baa3fd50edc884ca1956ae3646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872797Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Connor Lange <connorl@chromium.org> Auto-Submit: Connor Lange <connorl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709681}
-
Asanka Herath authored
The metric already expired. We have sufficient data to make a decision on whether to keep the code in for removing the pre-v2 fallback logic. R=mmenke@chromium.org Fixed: 988798 Change-Id: Idbe73d6d665ee719ecac27589dfe376c3b86502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881710 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709680}
-
Thomas Guilbert authored
The WSOLA algorithm introduces noticeable audio artifacts when doing small adjustments to playback rate (e.g. 1.03 playback speed). The distortions can be described as warbling or transient stuttering. This CL introduces fixes this issue by using resampling instead, for speeds close to 1.00. The resampled audio doesn't have any distortions, but its pitch is shifted proportionally to the playback changes. The maximal slowdown/speed up we use resampling for is 5-6%, which corresponds to shifting by 1 note tone. Beyond that, the WSOLA artifacts become tolerable, and the pitch shifting doesn't. Bug: 920019 Change-Id: Ia1f93dc6a5de8be14e054b9e165fb9508af491f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875654 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709679}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/62fcd0cb19d2..fc54119cc0ae $ git log 62fcd0cb1..fc54119cc --date=short --no-merges --format='%ad %ae %s' 2019-10-25 jb Update NEWS for 0.5.1 2019-10-25 gramner x86: Fix overflows in inverse identity SSSE3 transforms 2019-10-24 gramner x86: Fix overflows in inverse identity AVX2 transforms 2019-10-22 victorien x86: adapt SSSE3 wiener filter to SSE2 2019-10-21 victorien x86: adapt SSSE3 warp_affine_8x8{,t} to SSE2 2019-10-22 martin arm: looprestoration: Fix register names in a comment 2019-10-10 martin arm64: looprestoration: Minimal scheduling improvements 2019-10-22 martin arm64: looprestoration: Fix a typo 2019-10-21 martin arm64: looprestoration: Fix register references in comments 2019-10-08 martin arm64: looprestoration: Use ld2r instead of ld1+dup+dup 2019-10-07 martin arm64: looprestoration: Pass a correct height parameter to sgr_box3_h_neon for the top slice 2019-10-07 martin arm: looprestoration: Port the ARM64 SGR NEON assembly to 32 bit arm 2019-10-24 gramner x86: Add minor ipred_z AVX2 optimizations 2019-10-22 gramner Shrink some stack buffers in the C versions of ipred_z 2019-10-22 ltrudeau Don't backup pixel if next block not "CDEFed" 2019-10-17 victorien x86inc: fix LOAD_MM_PERMUTATION for AVX512 2019-10-13 victorien x86: adapt SSSE3 cdef_filter_{4x4,4x8,8x8} to SSE2 2019-10-14 victorien tools: fix SSE2 cpu masking Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: If312bcb010b42064bce9b11217faf65d510b29fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880541Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709678}
-
Matthew Mourgos authored
This change ensures that the home button is not recorded as showing the app list multiple times once the app list is already shown. Also correctly records app list shown during transitions between tablet mode and clamshell mode. Tests have also been added to ensure that the AppListShowSource metric is recorded correctly for the fixed cases. Bug: 1013790 Change-Id: I67bb0f1de8b6bd20c03fd6ac586095d92255119b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869123 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709677}
-
Joon Ahn authored
tc/1073295953913769610 Bug: chromium:1005533 Change-Id: I8c1a688801b0b10a312a2e2ab1ad9a487123b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874015Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#709676}
-
Chris Lu authored
Since BadgeState is a mask, a direct equality comparison to BadgeState values for the BadgeItem properties is not the correct way to assess if a badge is accepted. To add testing support for this case, accepted a11y identifiers for BadgeButtons are created, and they will be properly set in setAccepted: in BadgeButton. This change is a relanding of crrev.com/c/1872938, which failed because iPhone SE's screen was not wide enough to contain all the view in Showcase. Changes were made in sc_badge_coordinator to create two rows instead of one. Bug: 976901, 1016793 Change-Id: Iadc7e3e42529ded0aa331da3845e8644e4cac9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881364 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709675}
-