GitLab

Fix the audio and video code which shouldn't have derived from the
ResourceObjectBase class. This produced a diamond inheritance on refcounted.

The refcounting for resources is no longer threadsafe. We weren't doing any
thread stuff with these, so this should be fine.

There should be no behavior change.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7608033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92410
TEST=Open bookmark folder menus. Don't see '&' signs.

Review URL: http://codereview.chromium.org/7619007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92482
TEST=
TBR=jkummerow@chromium.org, chaitanyag@chromium.org

Review URL: http://codereview.chromium.org/7622011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96392 0039d316-1c4b-4281-b951-d872f2087c98

  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7623015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98

The concept of some WebUIs not being based on TabContents lived for two weeks (added r62478, removed r63713) but this support code was never removed.

BUG=76788
TEST=no change visible

Review URL: http://codereview.chromium.org/7554008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96390 0039d316-1c4b-4281-b951-d872f2087c98

Roll new ffmpeg, libvpx and gyp. Also modify remoting.gyp so
that everything should builds.

BUG=70688, 47285
TBR=scherkus
TEST=All buildbots are green

Review URL: http://codereview.chromium.org/7621013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96389 0039d316-1c4b-4281-b951-d872f2087c98

control group is http://codereview.chromium.org/7461150
Review URL: http://codereview.chromium.org/7613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88353
TEST=On Lion, scroll past the edge of the web content area and see textured over-scroll area.

Review URL: http://codereview.chromium.org/7582009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96387 0039d316-1c4b-4281-b951-d872f2087c98

Mark the binaries' EULA as having been accepted when GCF is installed via quick-enable.  This causes Google Update to start updating the multi-install.  Chrome's EULA will still be required on first-run.

BUG=88544
TEST=1) Do a multi-install OEM install of Chrome for which the EULA is required.  Alternatively, install system-level multi-install Chrome and then manually add eulaaccepted=0 to Chrome's and the binaries' ClientState keys.  2) Visit the GCF download page and install GCF via quick-enable.  3) Verify that eulaaccepted=1 is written to the binaries' ClientStateMedium key.


Review URL: http://codereview.chromium.org/7600023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96386 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92478
TEST=
TBR=cbentzel@chromium.org

Review URL: http://codereview.chromium.org/7622010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96385 0039d316-1c4b-4281-b951-d872f2087c98

Added Autofix, Exposure, Blur, Sharpen.
Also improved appearance a bit by avoiding non-integer coordinates
and fixed W3C compatibility (a standalone demo now works on Opera
and Firefox allowing for performance comparisons).

BUG=
TEST=

Review URL: http://codereview.chromium.org/7552035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96384 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7618011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96383 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for akalin.

BUG=None
TEST=None

R=akalin@chromium.org

Review URL: http://codereview.chromium.org/7612015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96382 0039d316-1c4b-4281-b951-d872f2087c98

```---------------------------------------------------------------------
r825 | mark@chromium.org | 2011-08-11 09:47:38 -0400 (Thu, 11 Aug 2011) | 6 lines

The process_id field is unsigned, so we need this cast in c++0x.

Patch by Rafael Ávila de Espí­ndola <respindola@mozilla.com>

https://bugzilla.mozilla.org/show_bug.cgi?id=677644
```

---------------------------------------------------------------------
r824 | mark@chromium.org | 2011-08-11 09:45:30 -0400 (Thu, 11 Aug 2011) | 8 lines

The first field in a MDLocationDescriptor is a u_int32_t, so change this cast
to the correct type. This fixes an error newer clang versions find in c++ 0x
mode.

Patch by Rafael Ávila de Espí­ndola <respindola@mozilla.com>

https://bugzilla.mozilla.org/show_bug.cgi?id=677641
------------------------------------------------------------------------
r823 | mark@chromium.org | 2011-08-11 09:40:13 -0400 (Thu, 11 Aug 2011) | 2 lines

Fix clang warnings.
Review URL: http://breakpad.appspot.com/298002
------------------------------------------------------------------------
r822 | mark@chromium.org | 2011-08-11 09:39:44 -0400 (Thu, 11 Aug 2011) | 3 lines

Zero out the entire context on MD5_Final, not just the number of bytes in a
pointer.
Review URL: http://breakpad.appspot.com/298001
------------------------------------------------------------------------
Review URL: http://codereview.chromium.org/7619005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92300
TEST=None


Review URL: http://codereview.chromium.org/7599028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7617007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92307
TEST=Steps described in the bug should not crash a debug build of chromium.


Review URL: http://codereview.chromium.org/7608024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96378 0039d316-1c4b-4281-b951-d872f2087c98

It looks that the CL still causes interactive_ui tests failures, even though I cannot reproduce failures on my machine. Reverting this to be safe.

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7622008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96376 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7626001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96374 0039d316-1c4b-4281-b951-d872f2087c98

Make the determination of whether or not Chrome Frame is in use on-demand rather than during initialization.

BUG=92146
TEST=GCF quick-enable should work again.


Review URL: http://codereview.chromium.org/7600021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92467
TEST=
TBR=suzhe@chromium.org

Review URL: http://codereview.chromium.org/7616007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92314
TEST=see bug

R=yoshiki@chromium.org

Review URL: http://codereview.chromium.org/7608028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
TEST=
TBR=mpcomplete@chromium.org, jochen@chromium.org

Review URL: http://codereview.chromium.org/7618008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80794
TEST=none

Review URL: http://codereview.chromium.org/7564006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96364 0039d316-1c4b-4281-b951-d872f2087c98

There's no need to use wstring or printf for this; the l10n code already
knows how to substitute values into translated strings and will do it in
less conversions.

R=rogerta@chromium.org


Review URL: http://codereview.chromium.org/7590023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92270
TEST=none


Review URL: http://codereview.chromium.org/7610005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92148
TEST=Read the docs. Do they make sense?

Review URL: http://codereview.chromium.org/7601024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92170
TEST=none


Review URL: http://codereview.chromium.org/7558024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96360 0039d316-1c4b-4281-b951-d872f2087c98

See http://src.chromium.org/viewvc/chrome?view=rev&revision=95821

BUG=
TEST=


Review URL: http://codereview.chromium.org/7491099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
TEST=
TBR=mpcomplete@chromium.org, jochen@chromium.org

Review URL: http://codereview.chromium.org/7623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96358 0039d316-1c4b-4281-b951-d872f2087c98

The new NTP (enabled from about:flags) doesn't have this issue.

BUG=86543
TEST=Force install an app using the ExtensionInstallForcelist policy. The app shouldn't have the uninstall menu enabled on the NTP.


Review URL: http://codereview.chromium.org/7552036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96357 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth

Review URL: http://codereview.chromium.org/7619004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90443
TEST=none

Review URL: http://codereview.chromium.org/7621008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92150
TEST=None
Review URL: http://codereview.chromium.org/7606032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92297
TEST=
TBR=mnissler@chromium.org

Review URL: http://codereview.chromium.org/7621009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:92460
TEST=

TBR=jochen@chromium.org, phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/7621007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96351 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7621003

TBR=jkummerow@chromium.org
Review URL: http://codereview.chromium.org/7621005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96347 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:5066
TEST=manual

Review URL: http://codereview.chromium.org/7608023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96344 0039d316-1c4b-4281-b951-d872f2087c98

Make sure we return value in non-void function.

BUG=none
TBR=erikwright
TEST=it builds with linux_use_heapchecker=1

Review URL: http://codereview.chromium.org/7623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96343 0039d316-1c4b-4281-b951-d872f2087c98