- 03 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b670120619c..caf7bdf789eb Created with: gclient setdep -r src-internal@caf7bdf789eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I5ec0cc335dc83ab244467cbad489a6ee3a70a3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656443}
-
Seth Hampson authored
This is a reland of 1aaab3f0 Original change's description: > Disallows reusing RTCIceTransport. > > Currently if an RTCIceTransport that comes from an RTCPeerConnection is > reused to create and RTCQuicTransport there is a crash. This disallows > this from happening by throwing an exception if the client attempts to > do this. > > Bug: 10589 > Change-Id: Idcf538972516825fef3b275d062a19d0bd7a68c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593872 > Commit-Queue: Seth Hampson <shampson@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Auto-Submit: Seth Hampson <shampson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656241} Bug: webrtc:10589 Change-Id: I879d3149e3fd3585e1efa395f63917bc94970efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594691Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#656442}
-
Eric Willigers authored
We were incorrectly accepting "ellipse(10px at 20px 30px)" as an ellipse. Retire use count BasicShapeEllipseOneRadius 0.00002% https://chromestatus.com/metrics/feature/timeline/popularity/2327 We were incorrectly serializing "ellipse(10px closest-side at 20px 30px)" as "ellipse(10px at 20px 30px)" BUG=899150 Change-Id: I6594ff990f659be2497acb336afbb138b5d91ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593882 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#656441}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c0620120980..5b1f4aaf31d8 git log 9c0620120980..5b1f4aaf31d8 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 oprypin@chromium.org Revert "Reland "bot_update: Pass target-ref to gclient."" Created with: gclient setdep -r src/third_party/depot_tools@5b1f4aaf31d8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: Ib5b1081c897f580b793ca4652f960567ba02811d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656440}
-
Jordan Werthman authored
Much like dynamic_annotations, Chromium's //base contains a copy of base/thread_annotations.h which causes macro classes and ODR violations when compiling a target with both //base and Abseil. In order to prevent these issues, the ./rename_dynamic_annotations.sh script has been generalized to also rename base/thread_annotations.h macros and symbols. Verified that WebRTC uses its own custom thread_annotations.h with "namespaced" macros and GoogleTest does not include thread_annotations.h so this change should be a no-op for all targets currently depending on Abseil. Bug: None Change-Id: I1b0115128aa22f4a3982082ede437ae8f0324bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592684Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Jordan Werthman <jordanjtw@google.com> Cr-Commit-Position: refs/heads/master@{#656439}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ad5289ea4b3..09db9d21756e git log 6ad5289ea4b3..09db9d21756e --date=short --no-merges --format='%ad %ae %s' 2019-05-03 herb@google.com Reland "SkShaper JSON output with cluster visualization" 2019-05-03 jvanverth@google.com Move GrMtlBufferManager functionality to better places 2019-05-03 halcanary@google.com Shaper : new unit test 2019-05-03 halcanary@google.com SkShaper: new benchmarks Created with: gclient setdep -r src/third_party/skia@09db9d21756e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I72cf891fec46fcea148d42568a0435a258af8ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594108Reviewed-by:
-
Sean Risser authored
We removed the definition a while ago, but forgot to remove the declaration in the header. BUG=959231 Change-Id: I6e58af7a4337df8957bb4f8c5b6b670fd9233252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594892Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Sean Risser <srisser@google.com> Cr-Commit-Position: refs/heads/master@{#656437}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I6dd41369875d445a90598e01c4c31f59094e267e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592681Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#656436}
-
Ian Kilpatrick authored
Removes some public methods from NGPhysicalBoxFragment, and NGPhysicalContainerFragment. There should be no behaviour change. Change-Id: Icf7612405b756b44121e223be8ecf24ca47d7151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591882Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#656435}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e3af8d9. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" 25e7f8dd "Reland "Reland "bluetooth: FakeBluetoothChooser impl.""" 501ae8c7 "Use testdriver Action API in WPT pointerevent tests - Part 4" 1aaab3f0 "Disallows reusing RTCIceTransport." b7c13214 "Revert "Disallows reusing RTCIceTransport."" ccb097db "Revert "Use testdriver Action API in WPT pointerevent tests - Part 4"" 7e454669 "[EventTiming] Increase threshold to dispatch entries" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I918cf8e081424a5780d089ff995aee5c7656e022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592390Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656434}
-
Nicolas Ouellet-Payeur authored
This CL splits //headless:headless into 2 components: - :headless_renderer - :headless_non_renderer :headless_renderer is intended for child processes, and has a smaller footprint than :headless_non_renderer. For release builds, this reduces the size of chrome_child.dll by about 9.7MB. Bug: 929408 Change-Id: I514a1bb5604f8ab8d6c6031970b5c7a965a8393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570654Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#656433}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29afe3e4c351..14fc5d16ccf4 git log 29afe3e4c351..14fc5d16ccf4 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 saklein@chromium.org SdkService/Create: Fix chroot version fetch for non-default chroot paths Created with: gclient setdep -r src/third_party/chromite@14fc5d16ccf4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I04ce599206ee14c1b5de1ad81e06060b97f5a2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594813Reviewed-by:
-
Wei Li authored
View's subclasses use quite a few base::string16 type properties. We need to add support for such type in MetaData. Also, this CL added support to a general setter type for a complex property whose setter should take a constant reference. This CL also added a string16 property -- Combobox's AccessibleName as an example. TBR=pkasting@chromium.org BUG=938501,957271 Change-Id: I9a06cf411871450b85d9ccf273776966cf182977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592194 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656431}
-
Becky Zhou authored
+ Change download storage permission icon to primary icon color + Unify download stroage permission dialog text style + Update icon and text color on text bubble for dark mode Bug: 958489, 958501 Change-Id: I8a8003191a3ec28a01fd6d905997fbb0182361ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592620Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#656430}
-
Gaofeng Huang authored
The existing code of GetProcessType() never works, because it's always running in browser process. Bug: internal b/128680778 Change-Id: I8ad7b2ccfdef036c05cbb4aeaf791b334c41d3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589010Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#656429}
-
Kenneth Russell authored
This format is exposed via a WebGL 1.0 extension and was missed when adding validation of texture and sampler types. The passthrough command decoder and ANGLE don't have the same bug. Bug: 957371 Change-Id: I3c73bbeda61f25515181dff5a1fc5d0bd27821ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594238 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#656428}
-
Elly Fong-Jones authored
This quirk, used on Android 18 and older (shipped mid 2013) causes page-defined viewport constraints that are smaller than the device width or the page height to be snapped to the device's display width and height. There is an accompanying comment saying that it can "presumably" by removed any time after 2015. This is a time after 2015, so let's see if that comment is correct :) Bug: 277369 Change-Id: Ie8c2f44aa57c534fc42388980b886dd88377d9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594694Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#656427}
-
Christian Biesinger authored
The height version of https://crrev.com/c/1590508 -- we again did not handle images correctly. R=dgrogan@chromium.org, eae@chromium.org Bug: 957943 Change-Id: Ie849c097e14d883ea65f3d316313b7da4f660a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594059 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes enable-font-cache-scaling which was deleted by an earlier CL 2) Fixes a typo ("omners") in omnibox-zero-suggestions-on-ntp The typo at (2) would have been caught by the every-entry-has-an-owner requirement but that isn't enforced yet. Bug: None Change-Id: I1936ad1cfe238be54020d00a4e658523f3743105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594700 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: -
Chris Harrelson authored
The rounded_corner_bounds field of SharedQuadState needs to be in the space of the target render surface. When changing that target, therefore, rounded_corner_bounds needs to be updated accordingly. Bug: 947715 Change-Id: I83b3f773d960e82d75060326c197ef12ae1755fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590900Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#656424}
-
Alexander Dunaev authored
There are two independent scale factors that were not used properly, which caused incorrect scaling behaviour on HiDPI screens. The first scale factor is property of the window manager (Wayland); it is integral and expected to be used as scale of buffers that back the window surface (see wl_surface_set_buffer_scale). This value is provided by the window manager, and neither user nor browser can affect it directly. I will refer to this value as 'platform scale'. The second scale factor defines how much the browser UI should be scaled. This value is real (floating point), and it can be set via the aforementioned --force-device-scale-factor command line flag. The default base scale is equal to the platform scale, which results in UI that looks more or less the same size as other applications. This scale is set in display::Display, and I will refer to it as 'UI scale'. So here is what this CL fixes. 1. The platform scale had been forwarded to the UI scale with no regard to the forcing flag, which caused issue 910797 (the flag did not have any effect). 2. The platform scale had not been used to scale the backing buffers, which caused the issue 929871 (blurry contents of windows on HDPI screens). 3. The coordinate-aware events (mouse and touch) and window sizing logic were not aware of the buffer scaling. 4. Both parameters had been named 'device scale factors' which was confusing. There are some issues that will be fixed in consequent CLs. The forced device scale factor is not propagated properly through display::Display. For fixing that, https://crbug.com/950313 is filed. Bug: 910797 Change-Id: I51a95e7218306295e3ab1f90d4b088b8bee93951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472617Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#656423}
-
Adam Langley authored
Change-Id: Ibf77d613bb5de9fdbcbbfef94746106cbf3004f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593877 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#656422}
-
Olivier Robin authored
On each report upload, report a CrashReport.BreakpadIOSUploadOutcome histogram with the error code. Change-Id: Id9fff90e97a6aae6f44600006f33d0149dcc58a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589959 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#656421}
-
Eric Karl authored
When submitting Vulkan command buffers via Skia, we may not have a VkFence to provide VulkanFenceHelper. In these cases Skia provides a callback which is run after the fence associated with a Skia flush + Vk Submit passes. This CL allows VulkanFenceHelper to consume these callbacks and use them to pump cleanup tasks. Bug: 951768 Change-Id: I2327de163b96a266a36d0db32b4653845f80b1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591942 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#656420}
-
Mark Mentovai authored
Add breakpad_unittests on Linux bots, including Chrome OS. Don’t run breakpad_unittests on Android, where Crashpad has replaced Breakpad. Includes a Breakpad update to 21b48a72aa50dde84149267f6b7402522b846b24 9f90ceb904b7 Linux MinidumpWriter: fix stack-use-after-scope violation 21b48a72aa50 Linux breakpad_unittests: fix ThreadSanitizer problems Bug: 949098 Change-Id: Ie726f22b8f0acea7b482dd84f099f2dc5c6cab91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575720 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#656419}
-
Dan Harrington authored
When tapping the complete notification, Chrome should re-use the tab that originally contained the dino page, unless the tab's URL changed. To explain what this change does and why this change is necessary, let's assume this redirect chain: foo.com -> bar.com -> baz.com When rendering the offline page, we attempt to load foo.com, and end up loading the full redirect chain. Depending on the cache headers, it's possible that only the first redirect is cached. So if we attempt to set a tab's URL to foo.com later, we can end up at bar.com. If we're offline, we will reach another dino page. If we're online, we'll end up at baz.com, but not the offlined page. Instead, to load the offlined page, we navigate to baz.com. The problem is that the old tab's URL is still 'foo.com', so the intent handler doesn't let us re-use the tab, and instead creates a new tab. This change introduces a new extra for the intent to pass along 'foo.com' so that the intent handler can determine whether or not the tab's URL has changed. Bug: 939850 Change-Id: I3b97113da944fa215f2a04434d21ccaf6fc9de4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547943 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Katie D authored
This reverts commit e3d0f13d. Original change description: Adds plumbing so that window event changes will notify the autoclick controller to update the menu's bounds if needed. This allows the menu, like the PIP menu, to re-position itself so as not to overlap system menus and dialogs. Bug: 943703 Change-Id: I80f79fb093948a2585a64f849d50759640476d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593454Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#656417}
-
Navid Zolghadr authored
As per the latest spec change we need to use pointerrawupdate instead of pointerrawmove. TBR=foolip@chromium.org Change-Id: If18d28ccfd326a3550bd7d0e5ebffd5e96def782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584405Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#656416}
-
Gabriel Charette authored
This CL is intended to be a no-op logic wise (aside from merging DoWork()/DoDelayedWork() into a single call). As a follow-up, it might be possible to take better advantage of NextWorkInfo::recent_now but it wasn't trivial to do so in this pump since the sleep is not invoked directly from Run() but rather implicit from HandlePrepare(). We could also potentially reuse |recent_now| between HandlePrepare() and HandleCheck(). For now we stick to invoking TimeTicks::Now() as much as the previous impl did. Bug: 885371 Change-Id: I4f9d6642c44dbad82cb3588cf3f5323ddf9c19ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594695 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#656415}
-
Eugene But authored
This code should be unnecessary after moving from UIWebView to WKWebView. Bug: 617560 Change-Id: I5079874bfb850333872d4336ea6b9195b78d480b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593978 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#656414}
-
Etienne Bergeron authored
This CL is adding unittests for the GetFallbackFont on Windows. It's fixing GetUniscribeFallbackFont which was failing on multiple added tests. The ShapeRuns (ui/gfx/render_text_harfbuzz.h) function applies fonts on runs in a specific order. The FallbackFont is a fastpath to determine a font based on a sequence of characters. If this is failing, the FallbackFonts returns the list of fonts in that family. FallbackFont on windows 7 is using the Uniscribe API and on windows 10 it's using the DWrite API. We are exposing the Uniscribe API to allow better unittests. GetUniscribeFallbackFont is determining the fallback fonts by parsing the uniscribe commands generated in a metafile. The previous code was assuming the fallback font is the first font to be set. By looking to failing cases we realized that multiple fonts may be selected and some spacing may be produced into the metafile. A state machine is now assuming the fallback font is the font used when the requested text is produced. We are adding tests for script that are currently working. A CL will follow with fixes for broken scripts. They are working in Chrome because the FallbackFonts is able to return the full list of fonts. BUG: 944227 Change-Id: I272a877d82fa031eff9e129e9cd4af915c756e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549882 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#656413}
-
John Budorick authored
Tbr: wfh@chromium.org Bug: 959223 Change-Id: I935873e5ae1ed2c86288f0cce3dcc5d2f81b58b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594653 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#656412}
-
Anna Malova authored
This is a reland of ca80dfd9. Update layout test expectations for Mac. Original change's description: > [Dark Web Contents]: Implement color inversion using CIELAB. > > To invert color: > 1. Tranform color to CIELab. > 2. Invert the L and add 10. > 3. Transform back to RGB. > > Bug: 939312 > Change-Id: Iadeec2232afbe35cb189f0a36722392514db4781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547830 > Commit-Queue: Anna Malova <amalova@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656195} Bug: 959104 Change-Id: Ic776983f2cb2a2d9b6b53d116bf122db174b26c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594579Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#656411}
-
Eric Roman authored
Bug: 958841 Change-Id: If9cd5570d6d1b6ceb34b9b34310ef11052b39757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593979 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#656410}
-
Lily Chen authored
This CL changes the CookiesWithoutSameSiteMustBeSecure flag's behavior. Previously, a SameSite=None cookie set without Secure, would be treated as Secure if set from a secure context, or rejected if set from an insecure context. This CL changes that to always reject such a cookie regardless of source scheme. Bug: 954551 Change-Id: Ie035ebc97425f855665b81419ac717173e2dcba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594693 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
-
Bruno Santos authored
Bug: 959076 Change-Id: I5e9c7e34c016f6496d34db2b8e669653f50860c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594113Reviewed-by:
Lucas Tenório <ltenorio@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#656408}
-
Weiliang Chen authored
SkiaOutputDeviceOffscreen is not using the color space that is passed in. Bug: 957040 Change-Id: I51bfa5c8ee890abe960d0059ec71c54823abb252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586345Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#656407}
-
Olivier Yiptong authored
This is a reland of a283f958 Original change's description: > [Native File System] FileSystemWriter::write takes non-stream data only > > The implementation of `write` before this CL accepted a Blob or a > ReadableStream. > > This change limits `write` to byte-array-like data, the stream-semantics > to be implemented in another dedicated API. > > Bug: 955190 > Change-Id: Icdec561a706bb18fc2b56bd3304b9e8346923fcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589671 > Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656209} Bug: 955190 Change-Id: I67e488f3b0dddf09ca1b31a34e15b6e4e185d0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594154Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Lan Wei authored
This function is reverted from pointerevent_support.js file, but the tests that use it are still in the wpt repository. Bug: 606367 TBR=nzolghadr@chromium.org Change-Id: Ifd97bab0bf411b000573056152a563f4385f2500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594735Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#656405}
-
Nick Burris authored
I previously changed the scroll into view behavior to edge-aligned, with the idea that we don't want to scroll to the middle of a long text range, but this results in the scroll position being at the bottom of the page for shorter text ranges. This patch reverts to centering the text range, but specifically the top of the text range to handle the case of long ranges. Also changes the text highlight color to light yellow instead of orange as recommended. Bug: 958545 958544 Change-Id: I8d35d916acec0199db2a33a6d05089311129d66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592399 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
-
