- 22 Jan, 2021 40 commits
-
-
Tim van der Lippe authored
If users set a large font, the checkbox would no longer be aligned. Therefore, we need to force the alignment of the checkbox with the text, to make sure it works for all font sizes. R=yangguo@chromium.org Fixed: 1168996 Change-Id: I526e9e3a623594ef5a1547fd133b54e17d866c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643725 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#846147}
-
Sylvain Defresne authored
Those file were just forwarding functions from base/ios/ios_util.{h,mm} so change client code to use the //base functions are remove the files. Bug: none Change-Id: Ie39dda86754c9a063a470abb2f323f7ad363c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642693 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#846146}
-
Yutaka Hirano authored
Bug: 1161996 Change-Id: Iedc79e57787ef9e9c300bd8b9696353a28ba138e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643892Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846145}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611304267-90669dcf550835de268a2353a6cf5648f5d0af68.profdata to chrome-win64-master-1611316382-2d0f555a9d3aa5811a7e026e1b7c53cee9a9715c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I73ba11f8c44066a2020bd3b24ae3bd79f12d6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846144}
-
Eric Seckler authored
This experiment evaluates the impact of a bug fix on power metrics. The bug caused the feed spinner to continue running 60fps animation tasks in the background. It turns out that, when this continues after Chrome goes into the background, it can cause Android to terminate Chrome earlier. Currently, users only enroll into a Finch group when the feed spinner is first shown. This doesn't happen in all browsing sessions. As a result, the Finch data is skewed towards shorter browser process lifetimes in one group. To work around this, this patch checks the feature's flag value after Chrome's native startup, thereby enrolling every user and browsing session into one of the Finch groups. This way, we can draw conclusions on the power impact of this bug for any user, and including any impact on cold starts. Bug: 1151391 Change-Id: I2ca59c9539f1bab7bfafe12ad61e59f0a7a8aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642628 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#846143}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ifb9be231a9bc60c39c11c067303d5b9319138430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645046Reviewed-by:
-
Thiabaud Engelbrecht authored
thread Bug: 1169394 Change-Id: Ic6808b5275d954eb0cfef920c2e372e20e0f4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644456Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#846141}
-
Caitlin Fischer authored
The server-side config shows that the study has ended. Bug: 1126640 Change-Id: I76ff1a337b5dad17228ab4c2d2a5b88ca7af37f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632185Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#846140}
-
Evan Stade authored
Bug: 1164069 Change-Id: I0abf13d932f72f3ed2b3f387afe3edc5578c9c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637930 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#846139}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 2021-01-22 primiano@google.com Merge changes I9f4c2738,Ic66051c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4e2edc264645bfbd1efa8de8fbe1fc09f06f31b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643786Reviewed-by:
-
Findit authored
This reverts commit fb8f8c0d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 846061 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZiOGY4YzBkZDZkZjk1ZGRkZmFkNzkzMzhmODhlZjk5NGUwZTliMWEM Sample Failed Build: https://ci.chromium.org/b/8857394482161435200 Sample Failed Step: browser_tests Original change's description: > Update unrar to 6.0.3 > > https://github.com/aawc/unrar/pull/25 for the corresponding change on Github > > BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 > > Change-Id: Idece6bd531d55f1b379d0a38fad5f74f64323749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634824 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846061} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 Change-Id: I7a45d79f9eb6f188fabbc99e3fd4ec3643c7fd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643791 Cr-Commit-Position: refs/heads/master@{#846137}
-
Scott Violet authored
AFAICT it's no longer used. I believe it was orphaned here: https://codereview.chromium.org/1129903008 . BUG=none TEST=none Change-Id: Ib47b4515e139d2ce0175ddb5ef13c5a88e726d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644103Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#846136}
-
Robert Flack authored
Based on the discussion in https://github.com/w3c/csswg-drafts/issues/4953 aspect ratios should be interpolated by the log of their value preserving the same visual speed whether they are wide or narrow. This patch adds a new interpolation type for aspect ratios and uses it for interpolating the CSS aspect-ratio property. Bug: 1156160 Change-Id: I6cbff0abef54290de559a7625e24e3c4e1f1e0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586234Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846135}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/platform_keys. Bug: 1148570 Change-Id: I05f66512de80ac0fd0ac21cd941a408e17190fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644074 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#846134}
-
Marc Treib authored
This aligns the name with the native SyncService. Also rename SyncTestUtil.isSyncActive()/waitForSyncActive() to isSyncFeatureActive()/waitForSyncFeatureActive() for consistency. Bug: 985290 Change-Id: I6383e8bd6bdf3b0767fdd7f5e3c3c4b49292d82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644938 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#846133}
-
Asanka Herath authored
During analysis we may synthesize additional identifiable surfaces. Reserve an `IdentifiableSurface::Type` enum value so that we can represent those surface using the same data type. R=morlovich@chromium.org Bug: 973801 Change-Id: Iac74a97d4ed0bc67fae2f8a4b408c271196a95f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643456 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#846132}
-
Peter Wen authored
The invocation to md5_check was complex and it is easy to miss an arg. Since compile_resources is using transitive assetres deps instead of depending on the actual java targets, it is no longer on the critical path and no longer needs md5_check. See below for benchmark stats. Before (r845557): gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 7.0s chrome_java_nosig: 34.3s avg (34.6s, 33.7s, 34.7s, 34.1s) chrome_java_sig: 35.4s avg (35.1s, 35.4s, 35.0s, 36.2s) chrome_java_res: 38.6s avg (38.7s, 38.6s, 38.5s, 38.7s) base_java_nosig: 42.9s avg (42.7s, 42.9s, 43.1s, 43.1s) base_java_sig: 106.5s avg (107.0s, 106.8s, 105.8s, 106.5s) After: gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.7s chrome_java_nosig: 33.6s avg (33.3s, 33.9s) chrome_java_sig: 34.8s avg (34.1s, 35.5s) chrome_java_res: 38.9s avg (38.5s, 39.3s) base_java_nosig: 43.3s avg (43.0s, 43.6s) base_java_sig: 106.7s avg (106.0s, 107.5s) Bug: 1066943 Change-Id: I538a2c15ee07cf0beec23b2e0885c84b964273c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643120 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/450f8565c7f3..372791761157 2021-01-22 johnstiles@google.com Squelch Metal warnings about unused _globals/_out. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I4b84898849024031c8a8ab1d4d5bf8ba66bf11f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643251Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101220600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/KoDoxKsUgYmDk8Xbp62-4Mftkzdv-ER37BKn6ELSk8MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/154430508 Tbr: media-app@grotations.appspotmail.com Change-Id: If32432424ccc99ebfd1815ef75dde414502fd250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643253Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846129}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7d6a6f33a540..5093ccefbf2c 2021-01-22 petermarshall@chromium.org [loc] Use the localized empty string constant If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab2f76108c40183502e7faf0c681a4d39dce0758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644704Reviewed-by:
-
Elly Fong-Jones authored
The sampling profiler isn't supported on macOS 11.0 because of the new dyld shared cache; have the test check that it is disabled. Bug: 1101399 Change-Id: I312a31d2bc2df3b1e5b6e9da675b11069cca4aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643408Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#846127}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b594cd90bd05..60ba8fe9e71a 2021-01-22 wl@gnu.org Move old ChangeLog files to new `docs/oldlogs` directory. 2021-01-22 wl@gnu.org LICENSE.TXT: Moved to root directory; minor edits. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: I60b249ffbaced6cc423980a7ccee1851989524e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644293Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846126}
-
Gustaf Ullberg authored
This change makes sure that the number of output channels of the media stream audio processor is set correctly when using a discrete channel layout as input. This fixes a crash when making calls with audio processing enabled while using a discrete channel layout for input. Bug: 1169678 Change-Id: I68e37e1ecff74e86ec0248838e4c9d3c740547a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643280Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#846125}
-
Fredrik Söderqvist authored
Said method is only an open-coded version AffineTransform::MapPoint(). Since it only has a single user, fold it into that. Change-Id: I1bac1d612bfbf2910b574735af5e3cebe51466b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643329 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#846124}
-
Wan-Teh Chang authored
This check was added to ImageLoader::ImageNotifyFinished() in https://codereview.chromium.org/2888953004. Add the same check to StyleFetchedImage::ImageNotifyFinished(). Change-Id: Ia9c201c456cdb2e27d8a9abcc9b2dcded0ac8597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644114Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#846123}
-
Ben Wagner authored
Bug: 1168814, 1169126, 1168720, 688613, 1142877 Change-Id: Ic62edd69cc3c2dc8468dcd9bcbed99a9109daab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642444 Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#846122}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.11-r1 to 90-4384.0-1610966178-benchmark-90.0.4393.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idd86dd31d1b15bdf0d20f06fe39cc1a54ce1d38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643788Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.11-r1 to 90-4384.0-1610968059-benchmark-90.0.4393.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia6a721d21ea3966430b13e3e370a86e1a0248b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643787Reviewed-by:
-
Sreeja Kamishetty authored
This CL adds a WebContentsObserver consistency check inside WebContentsObserverConsistencyChecker::RenderFrameHostChanged to make sure that for every subframe, WebContentsObserver::RenderFrameCreated is dispatched before WebContentsObserver::RenderFrameHostChanged. Previous CL (https://crrev.com/c/2614467) modified the way the RenderFrameCreated and RenderFrameHostChanged WebContentObserver callbacks were dispatched in the case of sub-frames, ensuring this consistency check. BUG=1097143 Change-Id: I2564fffad342d0ebf4945166b829b1b6e1f57b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628968 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846119}
-
Jiewei Qian authored
This is a reland of be5c5c0f The 2nd reland contains a bad merge, which incorrectly calls profile() method on the destroyed Browser object. This trips ASAN failure. The correct method for AppBrowserControllerBrowserTest.Shutdown is to call on a previously stored / cached profile*. Original change's description: > Reland "Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API"" > > This is a reland of 38aeef20 > > The first reland adds a test for behaviors during browser shutdown, and > doesn't yield consistent result. The second reland removes that test. > > The shutdown test was intended to fix https://crbug.com/1121894, where > we hit CHECK in Browser constructor. The bug was fixed by checking > browser isn't shutting down in LaunchSWAImpl.] > > It's okay to not test shutdown in LaunchSWAAsync (the added test in > first reland), because LaunchSWAAsync doesn't attempt to create browser > windows, and calls methods on objects (Profile, AppService) that are > still valid during Browser shutdown sequence. So the LaunchSWAAsync API > shuoldn't experience similar crashes observed in > https://crbug.com/1121894. > > Original change's description: > > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API" > > > > This is a reland of 62cb2352 > > > > The original CL fails when AppBrowserControllerBrowserTest.Shutdown > > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK > > because the use of GetCreationStatusForProfile already makes sure the > > DCHECK is always successful. > > > > Original change's description: > > > system-web-apps: implements a new LaunchSystemWebAppAsync API > > > > > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > > > chrome components to launch a SWA safely. This new API should be used > > > for SWA launches. > > > > > > The new API uses AppService to record metrics, handle disabled apps, > > > etc. > > > > > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > > > > > LaunchSWAImpl is publicly declared because certain browser tests need to > > > know the browser that hosts the SWA. It shouldn't be used to launch the > > > App (other than LaunchSWA and Web app implementations). Subsequent CLs > > > will attempt to migrate these browsertests to work with the new API. > > > > > > Bug: 1154540 > > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > > > Reviewed-by: James Cook <jamescook@chromium.org> > > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#843939} > > > > Bug: 1154540 > > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Auto-Submit: Jiewei Qian <qjw@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845049} > > Bug: 1154540 > Change-Id: I823b43be08c4fb6aefd53a92442359eee296bab3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641605 > Commit-Queue: Scott Violet <sky@chromium.org> > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845723} Bug: 1154540 Change-Id: Ia60a84b0c0b96d179854143b2cdacaa98a2bea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642840 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846118}
-
Ali Juma authored
CWTChromeDriver contains a partial implementation of the WebDriver protocol for browser automation, used for Web Platform Tests. This CL adds support for a new "chrome_crashtest" command, that can be used for fuzzing. This new command is similar to the existing "url" command, that loads a URL and waits for it to finish loading. However, the new command waits for an additional amount of time (specified as an argument) after page load to catch cases where a test page crashes just after page load is complete rather than during load. This new command also extracts the stderr output of the app process and returns it to the caller. This is needed for fuzzing because ASan crash stacks will be sent to the app process' stderr before the app process is terminated due to a bug found by ASan. Finally, this new command supports "file:///" URLs by serving the given file using an EmbeddedTestServer, since Chrome on iOS does not support directly loading such URLs. This is useful for fuzzing since fuzzing test cases are typically provided as a local HTML file. CWTChromeDriver is not shipped to end users (unlike ChromeDriver on non-iOS platforms), so supporting a non-standard command for test purposes does not create any compatibility issues. Change-Id: I84ad0100e40c12065a18325501d997a5b34220dd Bug: 1158540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600023Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#846117}
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I0bac0ec2870816c0f92aa68e6d10b56a5df748f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643392Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#846116}
-
Matt Jones authored
This patch aligns the directory structure of the bottom sheet widget with others in the browser_ui component. Specificialy, instead of the "android/name" pattern, the sheet now uses "name/android". Bug: 1169164 Change-Id: I74cf28bd59022624610758c41342f217dbac8ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643023Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Fixes a couple of instances where portals could get page focus: 1) Committing a pending navigation in an iframe inside a portal could cause the portal's frame tree to receive page focus 2) A predecessor page after activation would still have page focus when orphaned (not inserted into DOM) Bug: 1030838 Change-Id: I671d35fbb9b0041adb2d91082e1e6b1ac7a47a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563870Reviewed-by:
-
arthursonzogni authored
[previous patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2635142/4 Remove blink's computation of sandbox flags. Instead, let the browser process being in charge of providing this value. The exhaustive list of Frame.CommitNavigation users: 1. The initial empty document. 2. The synchronous navigation to about:blank that happens immediately after creating an initial empty document in <iframe> with no explicit src. 3. Navigations (regular and error documents) 4. Pseudo new document with same properties (XSLT, javascript). 5. WebViewPlugin (placeholder data URL) 6. Printing > (CopySelection) 7. Test. The browser process computes sandbox flags only for (3). The main work for this patch was to provide something for the 6 other cases. Especially tests running without a browser process. Bug:1041376 Change-Id: Ibbf40afe345d67b45615be4efc942069548d96ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450093 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#846113}
-
Eric Seckler authored
crrev.com/c/2633994 introduced a bug which caused some events to be emitted on an incorrect track. It's caused by the incorrect assumption that a constexpr symbol (kDefaultTrack) only receives a single address within a translation unit, even across different inlined functions. This patch fixes this by making kDefaultTrack a const symbol instead. Change-Id: I3f8a1d569d50839bb2188a037f88b9d6d3d7253b Bug: 1168791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644798 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#846112}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611294737-a15fe97a1063cd1d1146cd301b05a844b1e4cfe8.profdata to chrome-mac-master-1611316382-256aee3c7474e8e8ef074b7619cf9a4131f41980.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8f67fb7eac646d8eb5c42715ded45a6d1d19f985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644841Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e20ed5f01b3..a3545e46d238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: Ib8c0b95260774d71f5627753e9ab09cee94fb6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644839Reviewed-by:
-
Alex Ilin authored
When a new profile is created through the local profile creation, GenerateNewProfileColorWithGenerator() will try to choose a color with lightness close to the current color mode (either light or dark). Currently, the second and third line in the color picker will be considered in light mode, and only the last line will be considered in dark mode. Bug: 1169223 Change-Id: If3c55831a8d4e69a51353b4e52f931dab9fdc287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642455Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846109}
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ief1fff9084e42b284ec733ac344119d326fbe38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642633Reviewed-by:
-
