- 07 Nov, 2019 40 commits
-
-
Vladislav Kaznacheev authored
Attempting to create ShelfWidget while shelf is in-app is causing a crash because ShelfWidget::DelegateView::UpdateOpaqueBackground is called before the widget is initialized. Moving that call from ShelfWidget::DelegateView constructor into ShelfWidget::DelegateView::OnWidgetInitialized. Added a unit test. Bug: 1021662 Test: manual, DisplayManagerTest.ExitMirrorModeInTabletMode Change-Id: I32a5f91c834d673b109ab518bc2600908d8dea5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902273Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#713464}
-
Andrew Grieve authored
Change-Id: I07460e38136338fd944adee6dabd837380b6df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903960 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713463}
-
Andrew Grieve authored
Change-Id: I293c4ea85a90edbfcb28cbcf7bd3f1201550f3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902912Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713462}
-
Joe Mason authored
R=proberge Bug: 969139 Change-Id: I397de43b417d6f4312e54df1d6d3c9cf3b423129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903949 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#713461}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2ef0f867b79..48dc2da07f5b git log c2ef0f867b79..48dc2da07f5b --date=short --no-merges --format='%ad %ae %s' 2019-11-07 lamontjones@chromium.org cbuildbot: run PaygenStage after ArchiveStage finishes. Created with: gclient setdep -r src/third_party/chromite@48dc2da07f5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6535c321efbd7ca49d4196bbda5694b6b2c4df1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713460}
-
Olivier Li authored
1) Remove sync_thread_ from the ProfileSyncService interface to avoid accidental use. 2) Enable experiment in tests to provide coverage. 3) Add some ScopedAllowBaseSyncPrimitives in code that needed it. Bug: 1014464 Change-Id: I79393edac048a2960b4f2bc7593be326f5d27419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895797 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#713459}
-
Peter Kasting authored
Bug: none Change-Id: I5497cc4084bb4240c8fae6a8bb5476c9d775bdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900174Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#713458}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8caa67635d2c..e9f663c8cb8c git log 8caa67635d2c..e9f663c8cb8c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 danilchap@webrtc.org In dependency descritpor add active decode targets bitmask field 2019-11-07 alessiob@webrtc.org Audio Processing Module: add play-out audio device runtime information 2019-11-07 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-07 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." Created with: gclient setdep -r src/third_party/webrtc@e9f663c8cb8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I6b4898e1ed4498abd6564f30600bf8118d471069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903674Reviewed-by:
-
Joe Mason authored
* Removes the ChromePromptChannelMojo class and supporting code. * Merges ChromePromptChannelProtobuf into the base ChromePromptChannel. * Removes ChromePromptActions::PromptAcceptance which duplicated the PromptAcceptance enum from the protobuf. R=proberge Bug: 969139 Change-Id: I11350428dfddee2ec942ceda2fdb2dbc67aac863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903947 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Scott Violet authored
These got lost in the rename. BUG=none TEST=none Change-Id: Ifea2d13329f4a2c739657d918ae93c929ede5499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902708 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713455}
-
Hazem Ashmawy authored
Use millisecs since epoch for crash upload time similar to crash capture time for more consistency. Fixed: 1021926 Test: bin/run_webview_instrumentation_test_apk --test-filter "*UploadedCrashesInfoLoaderTest*" Test: Inspect Crash UI to make sure right time is shown Change-Id: I1adb49eb083044f8af8190aea959fc2e1f9e951f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901293 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713454}
-
Weiliang Chen authored
For each platform, we only use one overlay candidate type. Use build flags to manage that. This also helps unify different platforms' ProcessForOverlay API. This CL is a kindred spirit with crrev.com/c/1664476, but is rebased on top of ToT and crrev.com/c/1739980. This is CL 2/? for the overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I3a560bf8da3c8e86227cb7c43d15ba4c437b8764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753810 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#713453}
-
Fredrik Söderquist authored
at(<key>)+erase(<key>) is two hash computations, which can be replaced with Take(<key>). Change-Id: I0300052c629177ffb5317a8b58c222f32b0c1e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903201Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#713452}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/40aaf7602881..dcd90b1f880a git log 40aaf7602881..dcd90b1f880a --date=short --no-merges --format='%ad %ae %s' 2019-11-07 lalitm@google.com Merge "trace_processor: move counter_definitions to new macro tables" Created with: gclient setdep -r src/third_party/perfetto@dcd90b1f880a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I581c4c9062132acddd92abc2a82fb7dcdd37431d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903927Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cea290f9d5bf..12cea8d6c429 git log cea290f9d5bf..12cea8d6c429 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 mtklein@google.com hook up float comparisons to x86 JIT 2019-11-07 mtklein@google.com gn format BUILD.gn Created with: gclient setdep -r src/third_party/skia@12cea8d6c429 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I3826732bb62fe0d30bc10e799a3f570aec846271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903593Reviewed-by:
-
François Doray authored
This CL removes the |selected_tab_index| argument from SessionRestoreImpl::RestoreTabsToBrowser(). The argument was useless since the selected tab index could simply be retrieved from the SessionWindow. Also interesting, SessionRestoreImpl::ProcessSessionWindow() passed the index of the currently active tab to SessionRestoreImpl::RestoreTabsToBrowser() when the initial tab count was zero. This was strange, but had no impact since SessionRestoreImpl::RestoreTabsToBrowser() did nothing with the value when the initial tab count was non-zero. Change-Id: I9a8e4dce2044495a3257dd14b63e1dc3a52c6643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713449}
-
Sebastien Marchand authored
Change-Id: Id956ce360927ac6c3d81280614a739449dc3b9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903686Reviewed-by:
-
Mikhail Khokhlov authored
This CL uses correct test path format to extract benchmark and story names from the test path. It also removes the url unquoting, since we no longer want to encode test paths in Telemetry. Bug: 981349 Change-Id: I87957778fc832e06afad13b6ebad5e2d548211bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901085 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#713447}
-
Caleb Raitto authored
That directory has been moved to //src/third_party/devtools-frontend/src/. Change-Id: Iff89461d94b1194cb98c59b3af3e0a9c579de4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902728Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#713446}
-
Dave Tapuska authored
Add a FakeRemoteFrameHost so that unittests can override the mojo remote to intercept callbacks. Move VisibilityChanged messages to the LocalFrameHost and RemoteFrameHost interfaces. BUG=1008432 Change-Id: I89fdb124443ddc849321a51e2e65fb2b199502df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897846Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#713445}
-
Sebastien Marchand authored
Change-Id: I811bb177eab0c3f274d7ee62c6967d3ec6d5c520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879710Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#713444}
-
Jason Chase authored
Replace loonybear@ and ekaramad@ as the owners for various histograms, who are no longer contributing to the Feature Control team. Change-Id: I4fa39ff8d71dc98a4e119a764ab1437bc7c2cce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900149 Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#713443}
-
Lucas Furukawa Gadani authored
Bug: 1020830 Change-Id: Icd73d4390504a5820c94ed0cbcedb915cba5384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899310Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713442}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6a838679943ddcd3aa719e2737495a62d1347d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903868Reviewed-by:
-
Frédéric Wang authored
The status of the MathMLCore runtime flag is changed to "test" so that that flag is used for running tests. A new section for MathML-related expectation is introduced in TestExpectations. In addition to expectations for new tests, the ones of MathML-related CSS tests are moved there. Blink currently contains an internal MathML-specific test (mathml/fallback.html) which verifies fallback via the <semantics> element when MathML is not implemented. This test will fail when more MathML patches land but it is still important to ensure that test passes when MathMLCore is disabled. A new virtual test suite is introduced for that purpose and the test is moved there. Expectation for http/tests/xmlviewer/dumpAsText/mathml.xml is also updated since MathML is recognized as a known namespace when MathMLCore is enabled. Bug: 6606 Change-Id: Ia5a657e02850cad142d53a08baf10ec499467726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893878 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#713440}
-
Alexander Hendrich authored
Bug: 957573 Change-Id: I50e7a146cf2ba5a588fb28bfccaa0c3089bf5df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903361 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#713439}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/54875d05f17e..8caa67635d2c git log 54875d05f17e..8caa67635d2c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 59fc3bb1..93ed153e (713284:713404) Created with: gclient setdep -r src/third_party/webrtc@8caa67635d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If0bebfc189c7ad65e3a324914ef0f96c92c0ed7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903515Reviewed-by:
-
Dominic Farolino authored
This CL effectively disables console idlharness tests until the associated v8 change [1] lands that fixes our implementation. When the v8 change lands, the tests can be re-enabled and and the expecations can be deleted. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/1902968 R=mathias@chromium.org Bug: 948678 Change-Id: I53e8494b8630daa96ad742572b70595f2c62f1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903307 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#713437}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/266e4e05a88c..075cc4c355a6 git log 266e4e05a88c..075cc4c355a6 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 88264e3e188d..27a3d31d7a9d (1 commits) Created with: gclient setdep -r src/third_party/angle@075cc4c355a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I7a6ec9371d0b48cdaae404766aa71657999da35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903514Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Ie6043c36e60c2aeedee7722907ef6816f0972b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901430Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713435}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4420ef3dc6c..cea290f9d5bf git log c4420ef3dc6c..cea290f9d5bf --date=short --no-merges --format='%ad %ae %s' 2019-11-07 robertphillips@google.com Add GrPrimitiveType to GrProgramInfo Created with: gclient setdep -r src/third_party/skia@cea290f9d5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ie31f8a470d536b12803abc106414d2774594f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903513Reviewed-by:
-
Elly Fong-Jones authored
This change moves CreateFootnoteView into an anonymous namespace, and passes in the instance variables it needs. While the SharingDialogData member is not itself const, none of the members that CreateFootnoteView depends on change during the lifetime of SharingDialogView. Unfortunately the member cannot be const since it contains some callbacks that need to be run, and the members of SharingDialogData cannot be made const because they are iteratively filled in by other code before the dialog is created. Bug: 1011446 Change-Id: I3af6a9a3d3c2e5aa2f1d50dbb560182ccff945c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901432Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070a9e2a8724..40aaf7602881 git log 070a9e2a8724..40aaf7602881 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 ilkos@google.com Merge "UUID in TraceMetadata" 2019-11-07 fmayer@google.com Merge "Do not use garbage object for unique_retained / retained calculation." 2019-11-07 treehugger-gerrit@google.com Merge "core: Expose kMaxPreambleBytes from TracePacket" Created with: gclient setdep -r src/third_party/perfetto@40aaf7602881 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0bb8e1dd28f6e7523e967de734239b3dd69c9bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903512Reviewed-by:
-
Sylvain Defresne authored
Add function computing the base::TimeDelta since the application launch from kernel information about the process (based on the implementation from google_toolbox_for_mac). Bug: none Change-Id: I5d70aa1f9bb76b1b22f8375c2e7e53319486e460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899994 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#713431}
-
Lei Zhang authored
The flag was deleted in https://crrev.com/708103, so the corresponding entry in flag-metadata.json is useless. Bug: 824867 Change-Id: Ice9bab31555bd0012ab349f636937a8676da2e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902748 Auto-Submit: Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#713430}
-
Olivier Robin authored
Company name is not on the settings page anymore (but country is) Change-Id: Ia6dc7ffc22e6d7cab9ecfc935031bf1c571e83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890078Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713429}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: If302960d0ed9d8f060d49421b14a96761de4e4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903869Reviewed-by:
-
Dave Tapuska authored
The DCHECK already covers the stopped/stopping states, so the only states it doesn't cover are kInactive and kUninitialized. Since JS is calling this API, the kUninitialized state is impossible. So the only state that this occurs in is kInactive. The method can return null in quirks mode so adjusting the DCHECK for inactive documents seems best. BUG=1020787, 1002472 Change-Id: Ief51eb7783ea7ed506107646a258f24e274127b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902007 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713427}
-
Mihai Sardarescu authored
This CL removes a few unnecessary usages of ScopedAccountConsistencyDice. Change-Id: I756d99f16dacd05e348bb46578851fd193600d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899870Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713426}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5de55dca..df4d2ded Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib56aefaafc5dad1ca8046f2d535d60393bf877b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902434Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713425}
-
