- 24 Apr, 2020 40 commits
-
-
Charlie Hu authored
Because WTF::String::Split removes extra white-spaces by default, |origin_string| can never be empty in feature policy parser. This CL removes relevant code that handles empty |origin_string| in feature policy parser. Change-Id: Id83e4dc5cc39b1a3a08407db52db7cd3e09271bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161903 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#762460}
-
Lan Wei authored
In order to do a page zoom, we can press the Ctrl key and do a mouse wheel scroll. therefore we should pass a key modifier to the gpuBenchmarking.smoothScrollBy function to set the modifier of the mouse wheel events. In addition, when I rewrite the layout test "wheel/wheelevent-ctrl.html" that tests mouse wheel scroll with Ctrl key pressed, I found there is a variable "sendGesture" in the eventSender.mouseScrollBy function, which will not send any gesture scroll events when it is set to be false. It is very strange to have this variable, because it does not nothing. I think we should delete it. Bug: 1047176 Change-Id: I1bc1f6f4e4c4e9774754bcba54a5aed00ee371ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131359 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762459}
-
Charlie Hu authored
With feature with non-boolean value support for feature policy removed in previous CLs, there is no reason to keep Allowlist::values a map, whose values are all |true|s. This CL simplify |Allowlist::values| to a vector of origins, and renames |values| to |allowed_origins|. This CL is partially the revert of CL(https://chromium-review.googlesource.com/c/chromium/src/+/1430588) that adds parameterized feature policy. Bug: 993790 Change-Id: I7780a1f9b4e41a41f7edd0ab27fc6873d4cc4cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161429 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#762458}
-
Dale Curtis authored
Seems the DEPS checkout was hiding a directory still checked into the main source tree. TBR=davidben Fixed: 766721 Change-Id: I96d3fc54d6960716cb97d36f66c61d8e5c964313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165573Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#762457}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d5cba9d00055..6b1aabd4d10a git log d5cba9d00055..6b1aabd4d10a --date=short --first-parent --format='%ad %ae %s' 2020-04-24 jvanverth@google.com Fix minor issue in D3D MSAA rendertarget setup 2020-04-24 fmalita@chromium.org [skottie/tools] Video playback support 2020-04-24 mtklein@google.com add SKX opts 2020-04-24 csmartdalton@google.com Add CPU benchmarks for individual methods on GrTessellatePathOp 2020-04-24 herb@google.com condense stack usage Created with: gclient setdep -r src/third_party/skia@6b1aabd4d10a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I84d3d4fd68bd619dbfdca8e87dcf06e833df11c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762456}
-
Robert Sesek authored
The text alignment is slightly improved. Change-Id: Id6ec6a4a0c6e3826b853021b7318a9e99596d10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165569Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#762455}
-
Ian Kilpatrick authored
This changes ComputeMinAndMaxContentContribution to use the lambda type resolving functions, rather than the base::Optional<MinMaxSizes>. After this change the only remaining base::Optional style being used are within ng_absolute_utils.cc which will be a larger more complex change. This also introduces ComputeMinAndMaxContentContributionForTest for exposing the "internal" version for testing. There should be no behaviour changes. Change-Id: I1d313afd340c859f8d500080f9a553a3920133d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165625Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#762454}
-
Lei Zhang authored
Reuse ReportPDFLoadStatus() to report the PDF.LoadStatus UMA, instead of doing it manually. Change-Id: I92943fdf21b3a5bc800f2eab42cc1154e95bbd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163747Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#762453}
-
Adithya Srinivasan authored
Looks like we weren't notifying the activated page's RFH of the tab's constraints, so the page would continue to render with the fullscreen dimensions. Bug: 1064057 Change-Id: Ie6c341f17d2c1672bb70b51ba2acca1052276ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163083Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#762452}
-
Daniel McArdle authored
Before this change, the std::array instances in Create() and Hash() were uninitialized. By specifying an empty brace initializer, we are causing each element in the array to be value-initialized. Since the values are uint8_t, they are zero-initialized. Bug: 1074154, 1074190 Change-Id: I96347950ce6d70013383dae68c40c05f18917c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164988Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#762451}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I15f405e94e97b532d553f5a8252c4495ecd87ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164614 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#762450}
-
David Bertoni authored
Per comments on the bug, this has been fixed and disabled tests should be re-enabled. Bug: 177163 Change-Id: I7dcf4a6a415bc44fac533743c16c0c9a7a7ac173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161468Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762449}
-
Yoav Weiss authored
This aligns the UA-CH implementation with [1] [1] https://github.com/WICG/ua-client-hints/pull/99 Change-Id: I903450f3103c7068aa7548b69b986593d13d8904 Bug: 1074338 Change-Id: I903450f3103c7068aa7548b69b986593d13d8904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164526Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#762448}
-
Leonard Grey authored
Widgets of TYPE_CONTROL are not activatable by default. On Mac, this means that if a user focuses the Find Bar in window B while window A is key, window A does not lose key status, and key strokes are still dispatched to it. "Active" is a concept without a crisp cross-platform definition, so this change is very narrowly scoped to Mac. Bug: 937345 Change-Id: I4f366485eef000e5f66dbab6f8119a2a2ac93a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163636 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#762447}
-
Corentin Wallez authored
Also includes fixes for the use of Dawn's C API for setVertex/IndexBuffers. https://dawn.googlesource.com/dawn.git/+log/635239faf8ef..c244f5392178 git log 635239faf8ef..c244f5392178 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 cwallez@chromium.org Add a size argument to Set[Vertex|Index]Buffer Created with: gclient setdep -r src/third_party/dawn@c244f5392178 Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Change-Id: Ic7aac9a705bd5e9ef6f916baf388ded767c5f3a1 Tbr: cwallez@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164889Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#762446}
-
Sigurdur Asgeirsson authored
Bug: 1068233 Change-Id: I9474004e5ac450ad271dce20da19fd5e9c4a00bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162947 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#762445}
-
Éric Noyau authored
Bug: 1073961 Change-Id: I25528719e13d340b69681941eee4e817b3a2c2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165112 Auto-Submit: Eric Noyau <noyau@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762444}
-
Natalie Chouinard authored
This reverts commit 621c283e. Reason for revert: testAreMultipleChromeInstancesRunningFirstInstanceKilledFirst failing on test-n-tablet https://ci.chromium.org/p/chrome/builders/ci/test-n-tablet Original change's description: > [Multi-Instance] Add method to detect Multi-Instance > > This change provides a simple method to detect if Chrome is in > multi-instance mode. > > Bug: 1071925 > Change-Id: I3b82e5fe7a97e923f67f0ca49735c724f9ed4f17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155017 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762344} TBR=twellington@chromium.org,ckitagawa@chromium.org Change-Id: I5fce8a57284099ca4d14edf5eb3eee3e7d5eced1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165572Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#762443}
-
Steve Kobes authored
Also mark the REF "experimental", so that it is tested, and add a test. Bug: 1053510 Change-Id: I8bac9c8002d20991599a1bf396f28dd9101b0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157988Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#762442}
-
Patrick Monette authored
Replace the use of ServiceWorkerContainerType with an optional ServiceWorkerClientType. This avoids the need to convert from one type to another for GetClientType(). Additionally, this change simplifies a future CL where ServiceWorkerContainerHost knows about the ID of the worker, if the container host is a worker client. Bug: 993029 Change-Id: I29a41d060545e9e88fcdb5e2f83af40c823887f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151465 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#762441}
-
Avi Drissman authored
In r128926 (2012), Content Shell was started as “Chromium 19” as that was “reasonably current” but quickly became outdated as sites said, “that’s too old”. So in r361414 (2015), it was bumped to give a version of “Chromium 99” so that any UA sniffing would think it was modern enough. But given that Chromium 99 is actually coming soon (2022!) let’s bump Content Shell to “Chromium 999”. This kicks the can about 100 years down the road. Bug: none Change-Id: If0ae7f02fde953ee6dbd352e0ab3431e81ad953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161476 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#762440}
-
Matt Jones authored
Bug: 1069815 Change-Id: I02aaafbb50beca3fcb9367be6f7b87495b315457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163074Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#762439}
-
Natalie Chouinard authored
This reverts commit 9c288bdb. Reason for revert: #testBottomSheetHasRestrictedFixedHeight failing on Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25109 Original change's description: > [Autofill Assistant] Fixate bottomsheet in Talkback mode > > This CL fixates the height of the bottomsheet when Talkback is enabled. > It also forces VisualViewport resizing. > > This is done, such that no element is highlighted under the bottomsheet. > > Bug: b/143944870 > Change-Id: I82122aa0dbdfc5649010c396bcfed97cbf4fe602 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127929 > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#761843} TBR=wnwen@chromium.org,arbesser@google.com,sandromaggi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/143944870 Change-Id: Ibf22acfaa3f78cd80910d9deb7d48e7e1f875df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165526Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#762438}
-
Bettina authored
To keep the same behavior as existing blacklisted extensions, the extension is added to the list of blacklisted extensions in the extension registrar. Bug: 1038797 Change-Id: I882fb720ebb49ffe2506191af38c944fb8b76bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134488 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762437}
-
ckitagawa authored
This CL moves the storage location of Embedding Tokens from the FrameTreeNode to the RenderFrameHost. The goal of this change is to more closely align the lifetime of an Embedding Token with that of a document. This CL also attempts to improve documentation around the lifetime of Embedding Tokens to clarify that they are scoped to document lifecycle. Bug: 1072422 Change-Id: I79405089babb744655b26e91a1a55ece4ca8cf1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133869 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762436}
-
Sigurd Schneider authored
This prevents issues from the previous page from showing up in the issues panel. Bug: chromium:1057979 Change-Id: If2f61d9c8a402b30a41d4d9f83b9f356633eb5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164625 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#762435}
-
Ahmed Fakhry authored
This reverts commit 8cd221ee. Reason for revert: SyncConsentTest.SkippedNotBrandedBuild fails on linux-chromeos-chrome BUG=1074396 Original change's description: > SyncConsentScreen: Skip screen properly. > > Use new MaybeSkip method for skipping screen. Add tests for UMA stats. > > Bug: 1064561 > Change-Id: I9ddfa0fb5c994f1cb6d6c7abf5e61ca42fd065a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146900 > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762370} TBR=rsorokin@chromium.org,raleksandrov@google.com Change-Id: I1c171bad3935497ddff7de681a3817a79b354ddf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165571Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#762434}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I3c09f222226736ddb8d69b8e86276c4292ba8d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164891 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#762433}
-
Becca Hughes authored
The GetMediaFeeds API was quite complicated so now we have a "request type" which determines the SQL query to use and the parameters depend on the type. BUG=1053599 Change-Id: I7be7c54647374503fb7fe3c2eb9cbd509f2ba309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159317 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#762432}
-
Mei Liang authored
Change-Id: I85c7e59c607cff66389df8aa2836cb740eda8871 Bug: 1070838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158907Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762431}
-
Matt Jones authored
The bottom bar delegate doesn't need to listen to viewport size changes since it can directly listen to the provider of the information (ApplicationViewportInsetSuppler). Bug: 1071179 Change-Id: I92bd2c57848a092a24e7c4fe55627e2d9bd1c16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163654Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#762430}
-
Liviu Tinta authored
Since it is not easy to reproduce the bug, add Trace Event calls to be able to troubleshoot. Bug: 1063548 Change-Id: I7b86583b852ffe06260da55fc547e743402b7788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161407Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#762429}
-
Mila Green authored
Bug: 1072061 Change-Id: I12890fd304d8699b1db5058b1e6bb61bd1dc2cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159531 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#762428}
-
Yuke Liao authored
This CL supports downloading profiles compressed with gsutil -Z option, and when downloading them, explicit decompressions are not required. Bug: 1071576 Change-Id: I9fcab672505a3a90fd6fb5e70c7a6d2ecd13dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165626 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#762427}
-
Becca Hughes authored
Add an API to increment when feed items are shown in the UI and also another when they are clicked. BUG=1053599 Change-Id: If5eeaa96f3149d77e741ce3ed3b21690e9ba75b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155168 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#762426}
-
yilkal authored
Hosted extension apps and legacy packaged apps should be displayed as disabled after the time limit is reached. They are opened in a browser tab or browser window and are paused when Chrome time limit is reached. The paused icon state should match that of Chrome's. Bug: 1073541 Change-Id: Ic2c62362ce9cd8159095200a2ad340a066ff20e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161666Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762425}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I2dc41b82bfbc3cb425f5f9147fd5afeaef480fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164640 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#762424}
-
Vincent Scheib authored
Note, this go/cla link is already public at https://opensource.google/docs/cla/ Change-Id: I41b7cc6bfd93cf9f47d3c00d4a34869ab6739671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164025Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#762423}
-
Piotr Tworek authored
The code uses strlen in generate_fontconfig_caches.cc, but does not include string.h. This fails on Linux when building the code against glibc newer than 2.29. Bug: 1074286 Change-Id: I1c0d00a2a4b312b770882cf992007b5e80b1978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164527Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#762422}
-
Rakesh Soma authored
and IsUserAccessBlockingEnforced. Change-Id: Idbaf49a3250a50ba62bc2656fd1c1db5b43c771a Bug: 1074217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163121Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#762421}
-