GitLab

Use a proper WebMouseWheelEvent instance when validating the ToString
behavior for events of type WebInputEvent::MouseWheel.

BUG=422083

Review URL: https://codereview.chromium.org/642483003

Cr-Commit-Position: refs/heads/master@{#299038}

On dragging and dropping an item on a folder that is
currently showing its folder menu; the menu moves upwards
by an offset, regardless of its parent button moved or not.
This CL fixes the issue that the folder menu is moved only
when its parent button is moved. Also, the offset value
should be kBookmarkFolderButtonHeight.

BUG=311155
R=asvitkine@chromium.org

TEST=
1) Launch chrome and add a bookmark folder(folder1) to Bookmarks Bar
2) Add two folders(folder2 and folder3) within folder1.
3) Open folder1, now drag folder3 and hover it on folder2,
   wait until folder2 opens its folder menu, now drop the
   folder i.e release the mouse, and observe.
4) folder2's folder menu should not shift upwards, it
   should horizontally align with its button's frame.

Review URL: https://codereview.chromium.org/606593002

Cr-Commit-Position: refs/heads/master@{#299037}

So the core of the mojo spy can travel to new, exciting destinations.

BUG=none

Review URL: https://codereview.chromium.org/648573002

Cr-Commit-Position: refs/heads/master@{#299036}

BUG=

Review URL: https://codereview.chromium.org/614213003

Cr-Commit-Position: refs/heads/master@{#299035}

For SyncExponentialBackoffTest.OfflineToOnline, methods were added to
simulate and reset a network failure. The old (Python server) way of
doing this has been deleted from SyncTest.

For SyncExponentialBackoffTest.TransientErrorTest, a TRANSIENT_ERROR
is now triggered on FakeServer. The old way of doing this,
SyncTest.TriggerTransientError(), has been deleted.

BUG=406545

Review URL: https://codereview.chromium.org/642613002

Cr-Commit-Position: refs/heads/master@{#299034}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1598899..232f6b0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641113006

Cr-Commit-Position: refs/heads/master@{#299033}

This allows us to clearly distinguish between entry
points that are part of termios and the top level
ones which are trying eliminate (by moving them to
the C libraries).

Review URL: https://codereview.chromium.org/639113002

Cr-Commit-Position: refs/heads/master@{#299032}

BUG=402671
TEST=udp_socket_unittest.cc (this CL hasn't run that on the bots)

Review URL: https://codereview.chromium.org/596383002

Cr-Commit-Position: refs/heads/master@{#299031}

We should initialize the |client_| pointer before launching the host process,
as the OnHostProcessLaunched() callback dereferences the |client_| pointer.

BUG=421500

Review URL: https://codereview.chromium.org/642163002

Cr-Commit-Position: refs/heads/master@{#299030}

BUG=128035

Review URL: https://codereview.chromium.org/562273008

Cr-Commit-Position: refs/heads/master@{#299029}

BUG=421665

Review URL: https://codereview.chromium.org/634413002

Cr-Commit-Position: refs/heads/master@{#299028}

Two tile-size cleanups in this patch:

- Fixes a bug where the minimum tile-height for GPU-raster
  pages is 512 until any amount of zoom is applied (all
  layers we being considered 'long-and-skinny' by the old
  logic).

- Reserves default_tile_size/max_untiled_layer_size for
  software-raster. GPU-raster now computes both of these,
  leaving only tile-grid-size which re-uses the setting.
  That will be removed in my next patch.

BUG=365877

Review URL: https://codereview.chromium.org/605773004

Cr-Commit-Position: refs/heads/master@{#299027}

This blacklisting allowed certain cameras to be manipulated
using the QTKit API side by side to the AVFoundation API.
This is not needed anymore since the only blacklisted cameras,
namely the Blackmagic ones, are manipulated via third_party
Decklink SDK.

Note that not all traces of blacklisting disappear: QTKit
Blackmagic must avoid certain resolutions that would
otherwise crash the browser (see http://crbug.com/396812).

BUG=408493, 408089

TEST=After running Chrome, plug in a thunderbolt Blackmagic
device, for instance an UltraStudio Mini. Wait 4 seconds or so,
then enumerate devices, e.g. using http://goo.gl/r0lnFQ. There
should be a number of Blackmagic/UltraStudio mini entries but
no "QTKit " prefixed camera (those are the removed ones).

Review URL: https://codereview.chromium.org/633373009

Cr-Commit-Position: refs/heads/master@{#299026}

BUG=422077

Review URL: https://codereview.chromium.org/644813003

Cr-Commit-Position: refs/heads/master@{#299025}

EasyUnlockKeymanager is not initialized when UpdateEasyUnlockKeys is called
from FinalizePrepareProfile

BUG=419883,422102

Review URL: https://codereview.chromium.org/642153003

Cr-Commit-Position: refs/heads/master@{#299024}

- Adds missing files in BUILD.gn
- path/to/grit/... would be more preferable than grit/...
- remove unnecessary consts

BUG=None
R=nkostylev@chromium.org
TBR=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/644613002

Cr-Commit-Position: refs/heads/master@{#299023}

Add surface sequence numbers, which are used to schedule the
destruction of surfaces. The child surface's destruction can
wait on a set of sequence numbers, and the parent surface can
later queue a frame that satisfies those numbers, causing the
former child surface to be destroyed.

Also move ownership of the SurfaceIdAllocator to the
ui::Compositor, so that the surface id namespace for a
compositor will stay the same across all output surfaces it
ever uses.

BUG=411118

Review URL: https://codereview.chromium.org/553213003

Cr-Commit-Position: refs/heads/master@{#299022}

development.

BUG=415309
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/639773006

Cr-Commit-Position: refs/heads/master@{#299021}

Data reduction proxy should never be enabled for incognito tabs. So
moving it to profile_impl_io_data which is specific to non-ingocnito.

BUG=412873

Review URL: https://codereview.chromium.org/643443002

Cr-Commit-Position: refs/heads/master@{#299020}

This fixes the bots, even though when I log into the bots and run rdmsr
with the full path through Python, it works fine. This should be ok,
since Ubuntu includes the sbin directories in the path by default.

BUG=336556

Review URL: https://codereview.chromium.org/640323004

Cr-Commit-Position: refs/heads/master@{#299019}

BUG=none

Review URL: https://codereview.chromium.org/644833002

Cr-Commit-Position: refs/heads/master@{#299018}

This adds associative arrays to mojom to the main parser, and the C++ bindings generator. This adds a mojo::Map<> class to the C++ bindings, used by the generated bindings. Finally, it moves the clipboard.mojom interface over to associative arrays (which was the inspiration to add them to the mojom language).

BUG=413863

Review URL: https://codereview.chromium.org/611633002

Cr-Commit-Position: refs/heads/master@{#299017}

As InputDevice.getDevice() makes no guarantees that the returned device
will be non-null, always validate the return value before using in a
meaningful way as a Gamepad device.

BUG=421168

Review URL: https://codereview.chromium.org/644783003

Cr-Commit-Position: refs/heads/master@{#299016}

All these testers are now gone after the switch to swarming.

BUG=414808

Review URL: https://codereview.chromium.org/640293004

Cr-Commit-Position: refs/heads/master@{#299015}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e099dd7..1598899

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/646693004

Cr-Commit-Position: refs/heads/master@{#299014}

In our egl_native support, the eglGetCurrentDisplay() returns
EGL_NO_DISPLAY which causes this test to fail.

Add this test to the test expectations so it will be skipped
for now.

BUG=chromium:421568, chromium:412865
R=kbr@chromium.org, piman@chromium.org
TEST=Build and run khronos_glcts_test binary. Ensure test is skipped.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>

Review URL: https://codereview.chromium.org/639203002

Cr-Commit-Position: refs/heads/master@{#299013}

- Adds missing rules of BUILD.gn
- removes unnecessary const which causes warning for some compiler
  flag set on GN.

BUG=None
R=mpearson@chromium.org, cmasone@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/644603002

Cr-Commit-Position: refs/heads/master@{#299012}

The method -shouldShowMenubarInImmersiveFullscreen failed to take into
consideration whether the screen containing the window had a menu bar.

BUG=NONE
TEST=On OSX 10.9 or OSX 10.10, set the screensHaveSeparateSpaces setting to NO.
On a second monitor, fullscreen a youtube video. Move the mouse to the top of
screen. The tabstrip should appear, and should not have extra space for a menu
bar. Prior to this CL, there would be extra space for a non-existent menu bar.

Review URL: https://codereview.chromium.org/645643004

Cr-Commit-Position: refs/heads/master@{#299011}

Consider Easy Unlock behaviour the trial one only if initiated
from Easy Unlock
app during setup.

Autoshows all tooltips on the first run.

BUG=410143, 422084

Review URL: https://codereview.chromium.org/628193003

Cr-Commit-Position: refs/heads/master@{#299010}

Extended java_cpp_enum to parse enums that have values set for some of
the enums. Also fixed a small bug where enum values with comments on the
same line (following the enum) were being ignored.

BUG=NONE

Review URL: https://codereview.chromium.org/636773002

Cr-Commit-Position: refs/heads/master@{#299009}

BUG=

Review URL: https://codereview.chromium.org/616363002

Cr-Commit-Position: refs/heads/master@{#299008}

types in GestureDetector::Config and other usage points.

Basically:
* Times should always be ints representing milliseconds
* Distances and velocities should always be floats

This eliminates a number of implicit type conversions, some of which trigger a
(currently disabled) MSVC warning due to possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/630003003

Cr-Commit-Position: refs/heads/master@{#299007}

When video starts playing, HTMLMediaElement no longer issues a seek(0) call.
As a result, decoders needs to be prerolled so that video and audio will start outputting frames at the same time.
This change also fixes an issue that when EOS is reached, the decoder does not clean up the prerolling state

internal b/17812723

BUG=

Review URL: https://codereview.chromium.org/638233002

Cr-Commit-Position: refs/heads/master@{#299006}

This fixes stat, read and write methods when dealing
with windows tty file descriptors. We were not catching
this is our tests because we run with stdout/stderr
that are not ttys.

Also, fail early and hard during nacl_io_init and ps_main
if anything goes wrong setting things up.

Review URL: https://codereview.chromium.org/635113002

Cr-Commit-Position: refs/heads/master@{#299005}

This change adds a new python testing framework that will replace
the various adhoc variants of this we use in Chromium and Blink,
at least temporarily until if/when we can switch to infra's
expect_tests framework.

Using this library will allow us to consolidate a bunch of duplicated
code used for telemetry_unittests, webkit_python_tests,
mojo_python_tests, webkit_tests, and elsewhere.

TBR=cpu@chromium.org, dtu@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/627763002

Cr-Commit-Position: refs/heads/master@{#299004}

Background: For Athena we have an intelligent applciation management which allows us to load and unload applications / activities at any time. In some cases we "pre-load" applications to short loading time. In that case we do not want that the application can show its window activated (thus bringing it to front). Instead we have to override that request.

At the same time several things have changed in the application window framework which required. The Browsertests are testing the activation override as well as the activity order upon (re-)creation.

I added miket as OWNER for the extensions/* changes.

BUG=419379
TEST=AppActivityBrowserTest.CreatedAppGetsFocus, AppActivityBrowserTest.UnloadReloadApplicationInPlace, AppActivityBrowserTest.ReloadActivatedApplication, AppActivityBrowserTest.ReloadMovedApplication

Review URL: https://codereview.chromium.org/631333003

Cr-Commit-Position: refs/heads/master@{#299003}

Revert of Make it easier to debug failed symbolization (patchset #4 id:130001 of https://codereview.chromium.org/646683002/)

Reason for revert:
"Android Tests" bot is failing in "run stack tool with logcat dump" step.

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests

Suspecting this patch.  Reverting.

@@@BUILD_STEP Run stack tool with logcat dump@@@
> /b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/stack --more-info /b/build/slave/Android_Tests/build/src/out/Release/full_log.txt
/b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-addr2line: /b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../out/Release/icudtl.dat: File format not recognized

See bug https://code.google.com/p/chromium/issues/detail?id=422090

Original issue's description:
> Make it easier to debug failed symbolization
>
> This just adds a --verbose argument and some debug logging sprinkled in
> useful places.
>
> Adds '.' as a candidate directory for libraries (gn puts shared
> libraries at the root build directory).
>
> Committed: https://crrev.com/17ffc51dfc9bd6dfe0d38ce8f6f8313544ea25af
> Cr-Commit-Position: refs/heads/master@{#298952}

TBR=rmcilroy@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/642843003

Cr-Commit-Position: refs/heads/master@{#299002}

Use the ApplicationImpl::args() for InitGoogleTest.
(plumbs GTEST args from the mojo_shell commandline)

BUG=392646
TEST=GTEST args work like this> mojo_shell "mojo:mojo_example_apptests --gtest_filter=ExampleApptest.RunCallbackViaService --gtest_repeat=2"
R=hansmuller@chromium.org,davemoore@chromium.org

Review URL: https://codereview.chromium.org/626033003

Cr-Commit-Position: refs/heads/master@{#299001}

Revert of Enable debug fission for Release build (patchset #1 id:1 of https://codereview.chromium.org/605623002/)

Reason for revert:
Speculatively reverting.  Suspect it may be cause of leaks on linux asan lsan bot:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561

Original issue's description:
> Enable debug fission for Release build
>
> This enables debug fission for Release build. If the target compiler
> satisfies fission requirement, the fission is enabled for target no
> matter how old the host compiler is.
>
> BUG=None
> TEST=simple chrome for x64 platform passes with fission.
>
> Committed: https://crrev.com/d872dd066eb644f2d85e25429f55451cd2dd20d4
> Cr-Commit-Position: refs/heads/master@{#298925}

TBR=tansell@chromium.org,mithro@mithis.com,llozano@chromium.org,llozano@google.com,yunlian@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/649433002

Cr-Commit-Position: refs/heads/master@{#299000}

Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/647573002/)

Reason for revert:
This was not the cause of the regression. See http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6569

Original issue's description:
> Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/)
>
> Reason for revert:
> Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures.
>
> Original issue's description:
> > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed
> >
> > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run.
> >
> > BUG=421536
> >
> > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c
> > Cr-Commit-Position: refs/heads/master@{#298926}
>
> TBR=ben@chromium.org,hansmuller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=421536
>
> Committed: https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542
> Cr-Commit-Position: refs/heads/master@{#298985}

TBR=ben@chromium.org,hansmuller@chromium.org,jwd@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421536

Review URL: https://codereview.chromium.org/642953003

Cr-Commit-Position: refs/heads/master@{#298999}