GitLab

BUG=259492
TBR=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215835 0039d316-1c4b-4281-b951-d872f2087c98

The code was incorrectly using the title as the message for the MessageBox.

BUG=none
TEST=Navigate to about:inducebrowsercrashforrealz and make sure the message
box looks correct.

Review URL: https://chromiumcodereview.appspot.com/22288003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215834 0039d316-1c4b-4281-b951-d872f2087c98

Because variable which has type in the included file becomes pointer.
This change is rest of following:
https://src.chromium.org/viewvc/chrome?view=rev&revision=215590

Review URL: https://chromiumcodereview.appspot.com/22299004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215833 0039d316-1c4b-4281-b951-d872f2087c98

The goal is to delete third_party/gles2_book.
This patch deletes all known references.

BUG=98130
TBR=apatrick@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22299002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215832 0039d316-1c4b-4281-b951-d872f2087c98

Hitting enter in this field should be a no-op instead of closing
the overlay, as hitting enter is a natural thing to do when done
typing in a search.

BUG=266710

Review URL: https://chromiumcodereview.appspot.com/22298002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215831 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268590

Review URL: https://chromiumcodereview.appspot.com/22296002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215830 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215829 0039d316-1c4b-4281-b951-d872f2087c98

Rename the class name as well.
"extensions" in the file name and the class name don't make much sense.

Along the way, add lots of comments and make some cosmetic changes,
but no semantic changes.

BUG=268248
TEST=none
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/22259008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170924
TEST=Manual test by creating progress notifications

Review URL: https://chromiumcodereview.appspot.com/22277003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215827 0039d316-1c4b-4281-b951-d872f2087c98

If the focus before opening an overlay was on a button, the overlay
will restore focus to that button when the overlay closes. If the
cause of the overlay closing was executing a default button via the
document handler, the newly focused button would then execute
immediately via the same event. This CL prevents that from
happening by calling preventDefualt() after executing the defualt
button.

BUG=268336

Review URL: https://chromiumcodereview.appspot.com/22268005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22290003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215825 0039d316-1c4b-4281-b951-d872f2087c98

Main difference from last release 2.1 are as below:
1. New DevTools Command for touch events.
2. Fixed bug that chromeDriver can't find Chrome on windows with non-en locale.
3. Fixed bug that right click doesn't trigger app context menu.
4. Fixed bug that sendKeys to a button failed with chrome 29+.
5. Support for Android WebView apps.
6. Change the key of cache because the original one conflicts with the one used in bot/inject.js included by inject_test.html

BUG=none

Review URL: https://chromiumcodereview.appspot.com/22283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215824 0039d316-1c4b-4281-b951-d872f2087c98

The initialization of volume item has been done in VolumeList.renderRoot_(), but as I wrote in the TODO comment in volume_list.js, it should be done in the constructor of VolumeItem. This patch moves it as the comment.

This patch shouldn't change any functionality.

BUG=none
TEST=Volume list works correctly on mounting/unmounting volume. Folder shortcut can be created and removed.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22021003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215823 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to do this in crrev.com/215775

BUG=268248
TEST=none
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/22314007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215822 0039d316-1c4b-4281-b951-d872f2087c98

WindowTracker.

BUG=none
TEST=none
R=sadrul@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22254003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215821 0039d316-1c4b-4281-b951-d872f2087c98

Currently, copyFileEntry_ depends on FileCopyOperation.maybeCancel. This CL
removes it, instead copyFileEntry_ starts to return a callback to cancel the
on going operation.
Also, this CL adds some missing cancellation handling in copyFileEntry_().

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/22150006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215820 0039d316-1c4b-4281-b951-d872f2087c98

We always print to stderr if a system call is not handled by our sandbox.

It is more friendly to developers than crashing in debug mode, and in release
mode, this will allow to track issues when we can't have crash reports, which
is for instance the case with NaCl.

BUG=168812

Review URL: https://chromiumcodereview.appspot.com/22349002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215819 0039d316-1c4b-4281-b951-d872f2087c98

allocator.gyp removes libcmt/libcmtd from link via direct_dependent_settings
so having chrome_main_dll depend on it fixes the link.

(I think it probably doesn't work in non-multiple_dll Debug either, but
linking Debug-static_library with symbols doesn't work anyway so likely no
one noticed.)

R=jamesr@chromium.org
BUG=262396

Review URL: https://chromiumcodereview.appspot.com/22329002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215818 0039d316-1c4b-4281-b951-d872f2087c98

This property can be removed. This patch also fixes a small bug on changing the selection on the list.

BUG=none
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22167002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215817 0039d316-1c4b-4281-b951-d872f2087c98

These function are unused. OpenActionChoiceDialog() is also unused
but kept as we may need it in the near future.

BUG=268248
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22301003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215816 0039d316-1c4b-4281-b951-d872f2087c98

f_bavail is more appropriate because it tells the amount
of disk space that is available to a non-privileged user.
(Writing to Downloads/ indeed stops working if f_bavail=0.)

BUG=268705
TEST=Checked the gear menu value matches with what chrome:drive-internals shows.
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/22256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215815 0039d316-1c4b-4281-b951-d872f2087c98

Adds a gyp variable to simplify WINSDK path strings,
and grabs the x64 files rather than x86.

BUG=268525,267893

Review URL: https://chromiumcodereview.appspot.com/22262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215814 0039d316-1c4b-4281-b951-d872f2087c98

Feature is stable and this flag has been defaulted to enabled for several milestones.

Review URL: https://chromiumcodereview.appspot.com/22256002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215813 0039d316-1c4b-4281-b951-d872f2087c98

Add erg@ as an owner of x11 specific files in aura and views.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/22253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215812 0039d316-1c4b-4281-b951-d872f2087c98

Remove some old test code that was only needed for testing the old
(now removed) Autofill UI.

R=isherman@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/22211002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215811 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an end-to-end test for the sharing dialog. It uses a mocked sharing dialog implementation. This browser test validates:
- If passing the sharing url from the drive service works correctly.
- If clicking on the Share button invokes the sharing dialog.
- If the communication over messages with the share dialog works correctly: Handshake, displaying contents, synchronizing dimensions.
- If the window is closed when the button in the sharing dialog is pressed.

All of these steps are tested for both - a file and a directory.

TEST=browser_tests:*ShareDialog/FileManagerBrowserTest.Test/*
BUG=268221

Review URL: https://chromiumcodereview.appspot.com/22185002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215810 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a regression by Blink r153039.
We should not focus on "Edit" button in autofill setting by mouse press.
We call preventDefault() in mousedown event handler of the button.

BUG=268031

Review URL: https://chromiumcodereview.appspot.com/22124002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215809 0039d316-1c4b-4281-b951-d872f2087c98

This patch renames:
- "Autohide launcher" to "Autohide shelf"
- "Launcher position" to "Shelf position".

BUG=263531
TEST=out_cros/Debug/chrome --disable-setuid-sandbox --ash-use-alternate-shelf --show-launcher-alignment-menu
R=jamescook@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22007003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215808 0039d316-1c4b-4281-b951-d872f2087c98

This CL allocates a creates unique instance id for each
<webview> in an embedder RenderView/shim instead of in BrowserPlugin. In a subsequent CL, this will permit
usage of the WebRequest API prior to attachment to the DOM.

This CL also fixes a potential crash on edit commands if the instance ID passed did not exist: Perhaps open two <webview> apps and then close the first one, then send edit commands to the second one.

BUG=178663
Test=WebViewTest.*, WebViewInteractiveTest.*
TBR=cdn@chromium.org for deleted field in browser_plugin_messages.h

Review URL: https://chromiumcodereview.appspot.com/21930006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215807 0039d316-1c4b-4281-b951-d872f2087c98

Calling DriveAppRegistry::Update() results in being ignored when there is an ongoing one already.
Add FakeDriveService::app_list_load_count()

BUG=268707
TEST=unit_tests
R=hidehiko@chromium.org, kinaba@chromium.org

Review URL: https://codereview.chromium.org/22297004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215806 0039d316-1c4b-4281-b951-d872f2087c98

Reverse the ordering of these Widget::Init operations.
BubbleFrameView uses title/close presence for sizing.
(requires title/close to be set before bounds init)

DialogDelegate::CreateNewStyleFrameView did this explicitly.
(that changed in http://crrev.com/214637, seems less hacky)

Add a unit test, and cleanup a related test.

BUG=267343
TEST=Dialogs are sized properly, especially non-tab/content-modal dialogs (add wifi, import lock, screen sharing, etc.); see the bug and its dups for examples.
R=sky@chromium.org,ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21967002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215805 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=264396
TEST=compilation succeeds

Review URL: https://chromiumcodereview.appspot.com/21966005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215804 0039d316-1c4b-4281-b951-d872f2087c98

This CL clears composition data in IME in InputMethodBridge::OnBlur.
The cause was that ConfirmComposition called in InputMethodBridge::OnBlue doesn't clear IME's composition, and it will be committed again in host_->SetFocusedTextInputClient(NULL) in case of IMM32.

BUG=265928
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/21874003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215803 0039d316-1c4b-4281-b951-d872f2087c98

flip_in_mem_edsm_server should have unittests.

BUG=267354
R=rch@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215802 0039d316-1c4b-4281-b951-d872f2087c98

GetUploadStatus for an unusable URL always results in an error.
Upload location should be discarded to initiate new upload in such cases.

BUG=267452
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/21790002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215801 0039d316-1c4b-4281-b951-d872f2087c98

These just test same basic operations with a LatencyInfo.

Review URL: https://chromiumcodereview.appspot.com/21447003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215800 0039d316-1c4b-4281-b951-d872f2087c98

native_app_window.h -> apps component
platform specific implementations of this are now in c/b/ui/xxx/apps.

The platform specific implementations should also move to apps/ but
they would currently bring some unwanted dependencies with them; that
can happen later.

BUG=159366

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215753

Review URL: https://chromiumcodereview.appspot.com/21344002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215799 0039d316-1c4b-4281-b951-d872f2087c98

Now that Blink isn't including webkit_support_gfx directly, this moves
it to live next to its only user (the image_diff tool).

R=dpranke
TBR=joth (for android_webview/tools/third_party_files_whitelist.txt)

Review URL: https://chromiumcodereview.appspot.com/21202003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215798 0039d316-1c4b-4281-b951-d872f2087c98

    
WebRTC measures the decoding time and control the timing of the Decode()
calls. In the current implementation, we call decode done callback when
the browser process gets the frame. In order to get frames constantly
from WebRTC, this fix drops the decode done callback.
    
BUG=264585

Review URL: https://chromiumcodereview.appspot.com/20646003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215797 0039d316-1c4b-4281-b951-d872f2087c98

> [telemetry] Add a webdriver backend with support for IE.
> BUG=none
> TEST=tools/perf/run_measurement --browser=internet-explorer octane & kraken
> 
> Review URL: https://chromiumcodereview.appspot.com/20672002

TBR=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/22336006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215796 0039d316-1c4b-4281-b951-d872f2087c98