- 30 Oct, 2019 40 commits
-
-
Robert Sesek authored
Bug: 977637 Change-Id: I46198e40724c0985c2a59b7ac7ebeb1479f286d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888714Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710656}
-
Nate Fischer authored
No change to production logic. This adds tests for already-implemented UMA proto fields. This intentionally skips fields which don't apply to Android OS (ex. os.is_jailbroken, os.arc, os.kernel_version). Bug: 1011991 Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* Change-Id: I35fe2b75164a421a9a5dbc80df621f75ec9b5474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889171 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710655}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: If05a835c62dbb81850b4e0ba3a9a96f606adc2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884366Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710654}
-
Jinsuk Kim authored
Moves the Tab's public API to TabWebContentsDelegateAndroid. - Access from native (TabAndroid::IsCurrentlyACustomTab) is routed to TWCDA. - For the access from Java (externalnav/), ExternalNavigationDelegate is given an interface method |isOnCustomTab|. This is false by default, overriden by CustomTabNavigationDelegate to replace the reference to the deleted API. - Tests uses TabTestUtil (now moved to test support target to make itself available for CustomTabActivityTestRule) to access TWCDA. Bug: 995903 Change-Id: Ie8ef46ef739005de94f990da5ffc7dabf640ec43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880359 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710653}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7146c8fa. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idd6fd11aaf912faf333b3a191425f28b9d2b0dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e662695654ff..1ae54bc22fc2 git log e662695654ff..1ae54bc22fc2 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 csmartdalton@google.com Add sampleVariablesStencilSupport to sksl standalone caps 2019-10-29 mtklein@google.com work around x11/X.h #define pollution 2019-10-29 halcanary@google.com BotsCfg/Perf/RemoteGlyphCache: bots to download and use traces 2019-10-29 nigeltao@google.com Have SkWuffsCodec use two Wuffs decoders Created with: gclient setdep -r src/third_party/skia@1ae54bc22fc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Ieb1268182cfd7aca8c7b3489238fb143fc92132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710651}
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I0d9241a98c12470a95a772a5d9d59da33a3aae65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888615Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#710650}
-
Hiroki Sato authored
This CL adds buttons to set all event stream logging to on or off in ChromeVox Developer option. Bug: None Test: manual Change-Id: If28b6c03427bf2c9a1109346bc79aa601eb2ad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880212Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#710649}
-
Chinglin Yu authored
MemoryKillsMonitor matches OOM kill message with each entry in kernel log. Use precompiled regex object to reduce the load, especially when the kernel log is spammed by some subsystem. Bug: 1019066 Test: Manual timing instrumentations to measure the improvement. Change-Id: Iaf9451de7cffb000718b2b7a219801147999b1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886085Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710648}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2677bf6cf3de..bc1a479a7027 git log 2677bf6cf3de..bc1a479a7027 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 ahassani@chromium.org build_dlc: Check for DLC ID and package identifiers 2019-10-30 dburger@chromium.org Revert "Remove scheduling of master-chromium-pfq and children." 2019-10-29 lamontjones@chromium.org paygen: protect just downloaded file, more logging. 2019-10-29 andrewlamb@chromium.org chromite: Add method to apply FieldMasks to Python dicts. Created with: gclient setdep -r src/third_party/chromite@bc1a479a7027 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf151c865a84123095d10f6a0641d62b266e5eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889052Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74f96eccd6fe..c6c3f862e2a3 git log 74f96eccd6fe..c6c3f862e2a3 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 hta@webrtc.org Expose TLS version and SRTP cipher to API 2019-10-29 honghaiz@webrtc.org Add support to not use turn server as stun server. Created with: gclient setdep -r src/third_party/webrtc@c6c3f862e2a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id76187a9557e610bd27088457a550ed4398caa15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889210Reviewed-by:
-
Yuta Kasai authored
This fixes typos in some comments and chrome/test/data/webui/parse_html_subset_test.html. This CL doesn't change test behavior. This just fixes typo. Bug: N/A Change-Id: I4d516a5c85677f84cb4ff0e8e7c8cecccb77c006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880906 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710645}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6eb7d0ec3ecf..672707f76e2d git log 6eb7d0ec3ecf..672707f76e2d --date=short --no-merges --format='%ad %ae %s' 2019-10-30 enga@chromium.org perf_tests: Compute metrics for command validation and recording 2019-10-30 enga@chromium.org Only mark objects as cached right before inserting into the cache 2019-10-30 senorblanco@chromium.org Add another missing #include. 2019-10-29 bryan.bernhart@intel.com Limit heap growth when uploading with SetSubData. Created with: gclient setdep -r src/third_party/dawn@672707f76e2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9fcb30c9e34d00789056f0b353dd6de8b6496cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889252Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/762db8a15012..51a8c8c56e15 git log 762db8a15012..51a8c8c56e15 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bsheedy@chromium.org Reland "Deduplicate desktop/CrOS minidump code" Created with: gclient setdep -r src/third_party/catapult@51a8c8c56e15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:994274 Change-Id: I3cc503973f78810a153e6747a4a89f768b17c639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889251Reviewed-by:
-
Joey Arhar authored
The html spec does not seem to say anything against emitting change events for input elements which are detached from the DOM. It does say that immutable input elements should not have change events emitted for them, but I don't think that having it detached from the DOM means that it is immutable, especially since we can successfully change the .checked value while detached from the dom. Bug: 773680 Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885093Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710642}
-
Thomas Guilbert authored
This CL adds a new callback to VideoFrameCompositor. A client can now set a callback, to be notified whenever a new frame has been presented for composition. This will be used to ultimately fulfill callbacks registered through the new <video>.requestAnimationFrame API. Bug: 1012063 Change-Id: If7c9e4192db03b81a9040219bedec70e38241509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887743 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710641}
-
Yoshisato Yanagisawa authored
Allow developers to select Xcode.app to be used for iOS development. Bug: 1015730, 619921 Change-Id: I395eda1da49971f4cbd2d22c0901caff604ff89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886553 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#710640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88a74e59f04c..bb35bb4e5379 git log 88a74e59f04c..bb35bb4e5379 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 jmadill@chromium.org Vulkan: Implement simple case ANGLE_get_image. 2019-10-29 tobine@google.com Fix Renderbuffer support for unsized DS formats 2019-10-29 courtneygo@google.com Update docs for recent dEQP / VK-GL-CTS update 2019-10-29 courtneygo@google.com Print the testConfig in dEQP tests. Created with: gclient setdep -r src/third_party/angle@bb35bb4e5379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:997351 Change-Id: I7fba7760d6d5f2b9a3623d1da56a4498d26d2f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888395Reviewed-by:
-
Yoichi Osato authored
This CL fixes the crash if mojo creation in OnAddChannelResponse failed, then we call WebSocket::Reset(), which deletes WebSocketChannel but it tries to call instance methods after that. To fix that, this CL unifies WebSocket::WebSocketEventHandler ::OnAddChannelResponse and ::AddSendFlowControlQuota for quota initialize. Fixed: 1018432 Change-Id: I197a15c07e23b04284713e67fca2dfcd92f01e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883450Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#710638}
-
John Lee authored
Change-Id: Ie57da6d81d9ea386b47333483438b4356f02158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889113 Auto-Submit: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710637}
-
khmel@chromium.org authored
This reads power energy counters available for Intel platform. Energy is reported as runtime power in tracing tool. BUG=b:143532713 b:143534199 TEST=Locally + unit test Change-Id: If07397e36582bc3be985806fa3cd9fe106b64eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888194 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710636}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/651618043819..54eda5713da0 git log 651618043819..54eda5713da0 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 tsepez@chromium.org Avoid duplicate string construction in CXFA_Textlayout 2019-10-29 thestig@chromium.org Properly handle seek failure in CFX_BmpDecompressor::ReadBmpHeader(). 2019-10-29 thestig@chromium.org Get rid of longjmp() usage in CFX_BmpDecompressor. 2019-10-29 tsepez@chromium.org Use span instead of raw pointer in CFDE_TextOut::ReloadLinePiece(). Created with: gclient setdep -r src/third_party/pdfium@54eda5713da0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:997588 Change-Id: I675fae4f2e95848681d80be2b2998a3adbccdbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889253Reviewed-by:
-
Moe Ahmadi authored
- Realbox input always gets focus after deleting a match. - Selects the first match in the list after deletion and fills the realbox input with its content if it is allowed to be the default match. Otherwise sets the input to the user typed value. Bug: 1018437 Change-Id: I02fd690a0c0acaa570f37604970c13391af14b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881991 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#710634}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/512f92b73181..1e4dbf3f6432 git log 512f92b73181..1e4dbf3f6432 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 erikchen@chromium.org Add more git tracing. 2019-10-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e4dbf3f6432 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I039c2ad6ec0888b910e762dcaecbc859bf4d0fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888597Reviewed-by:
-
Adam Langley authored
Windows is commonly observed to take about 10 seconds to establish a GATT connection to caBLE devices. Some reports, however, are suggesting that even a 15 second timeout is insufficient. This change raises that timeout 20 seconds. It's unclear whether humans will actually wait around this long, at least this might make some caBLE actions _possible_. Change-Id: I99a9647cdab8ed7475ce13b1652731a5109c8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884756 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#710632}
-
Jared Saul authored
Bug: 884817 Change-Id: Id2a27744c30ce2d7d3ecc683641069c6a91d2655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877617 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#710631}
-
Chris Lu authored
Creates InfobarTranslateTableViewController with basic setup for its navigation bar. Initializes it in InfobarTranslateCoordinator in addition to creating InfobarTranslateModalDelegate for the TableViewController to send signals back to the coordinator. Screenshot: https://drive.google.com/open?id=1W0UyJ6DQnQ4v3-8_gkhuWxd8SLZGnp1s Bug: 1014959 Change-Id: I5cc434e5330de9bbe3ccd8f8fb0537ea2db4bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878910 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710630}
-
Daniel Clark authored
This change fixes an issue where a sandboxed iframe can be created such that it contains a sandboxed Document with an opaque origin that still shares a script context with the iframe's initial un-sandboxed about:blank Document. The scenario is set up in the following manner: 1) Create a new iframe dynamically, and set its src to a same-domain page that we are going to sandbox. 2) Insert the iframe into a Document, and synchronously grab a reference to its initial about:blank Document. 3) Synchronously set iframe.sandbox = "allow-scripts" (this is still before the same-domain page has loaded in the frame). 4) The iframe’s navigation to the same-domain page occurs, asynchronously. FrameLoader::ShouldReuseDefaultView is called to determine the mode in which to load the new page. FrameLoader::ShouldReuseDefaultView fails to check the iframe’s sandbox flags (it only looks at the CSP ones), so the navigation proceeds without resetting the type system of the iframe. The result is that the newly loaded page shares the type system of the initial about:blank Document. 5) Code in the sandboxed iframe is now free to make changes to its type system that can affect any usage of the about:blank Document since they share the same type system. This is a sandbox escape in that if the same-domain page that the iframe is navigated to contains user-generated code, it could run outside the iframe. It can also result in crashes if we poke things in the right way, since an object that should be considered cross-origin can bleed into the top-level page, with the result that access checks which are never expected to fail can now fail. This change fixes the issue by making FrameLoader::ShouldReuseDefaultView() check the iframe's sandbox flags via FrameLoader::EffectiveSandboxFlags(), in addition to the existing check for CSP sandbox flags. Bug: 1017441 Change-Id: Ide1b13e16b0e0428a243ff47b6e17ae25ad0ff0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881315Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710629}
-
Jinsuk Kim authored
There are situations where back button closes the current tab. Gesture navigation also need to do what back button does in this case. This CL shows close indicator "Close Tab", and does not open the navigation sheet. Bug: 1009059 Change-Id: Ife4f53bb41253646d18feb1cf5e2c50a04b1d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885135Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710628}
-
Hongchan Choi authored
When the buffer is set to `null` while there is an active buffer within a reverb object, SetBuffer() function can prematurely nullify the `reverb_` and `shared_buffer_` while it is still being accessed by the rendering thread. This CL adds two locks (graph lock and process lock) when the buffer gets nullified to ensure the synchronization between two threads. Change-Id: I8f501b6a16b3c7e16db767e0b279a1a53d6eb290 Bug: 1019226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888103 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710627}
-
Dan Beam authored
* restore search magnifying glass (aka loupe) as default icon @ 20px * add 8px of bottom margin below last realbox result * add feature to experiment with Google (g) icon ("super g") R=mahmadi@chromium.org Bug: 1017495 Change-Id: I4db697dcf66d20ab2509ccbec35317f80919c10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884951 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710626}
-
Joonghun Park authored
For additional explanation, add an annotation about HTML body element's 8px default margin to core/layout/README.md with the corresponding spec link. Bug: None Change-Id: I9cfe9acf005f5725dab4b99f7e874c9cdcda37db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886139Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/master@{#710625}
-
Kai Ninomiya authored
We already had this workaround on Mali-T*, but it's needed on Mali-400 as well (and most likely Mali-300, if that even supports WebGL). Bug: 1018528 Change-Id: Iebcaa45a0cc7402399f7a1cb5e24b443b02078cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888954 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710624}
-
Cici Ruan authored
Assign string value to AppWindowInfo#displayId. Bug: None. Test: tested the API and received the correct display id. Change-Id: I43b0142bf60326811f00e2d6661d23d6f92ab55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887876Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/master@{#710623}
-
Peter Kasting authored
Calling GetPreferredSize() on a label which hadn't otherwise computed a layout would return an empty size, which seems wrong. Calling GetHeightForWidth() (a const method) could change the results of GetPreferredSize(), a violation of logical constness. Bug: none Change-Id: I2729b9d83ffa94e368fb6553e9ead4b2646e01c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884360 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#710622}
-
Rune Lillesveen authored
We need to be able to walk the current flat tree ancestors without updating the distribution when marking the ancestor chain for style recalc. For Shadow DOM V1, we introduced a separate method for that since for V1 we update the slot assignment while traversing. For V0, we need to explicitly update distribution and DCHECK during traversal that we made sure it was up to date. Here we skip the DCHECK when FlatTreeStyleRecalc is enabled. We could have introduced some scoping mechanism that sets a flag from outside the traversal saying that we intentionally walk a dirty tree instead of always skipping the DCHECK for FlatTreeStyleRecalc. Since V0 is going away soon, I gathered we could skip the DCHECK. Multiple tests in the TEST lines below will trigger the DCHECK without this change and FlatTreeStyleRecalc enabled. TEST=fast/dom/shadow/ TEST=shadow-dom/ Bug: 972752 Change-Id: I8a850123b9b647a6575c3a2679e382d61c0ed8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875258Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/567c7481c849..9eeaad1a5bde Created with: gclient setdep -r src-internal@9eeaad1a5bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:b/141127636,chromium:1018879,chromium:None Change-Id: Ie12e2cfd3deacd2971cb5dd809c7f885fc9d4bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888822Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710620}
-
Manas Verma authored
Tracking the time it takes to fetch the full PAN of a credit card once user successfully authenticates using WebAuthn. Bug: 949269 Change-Id: Ic50eba0bcc687c988f0f61ceb96399610bf752c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864627 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710619}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Ia79aa823ab42e89b7103b8b89e65cda0c24dbb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885010 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710618}
-
Xiaohan Wang authored
Current WebContentDecryptionModuleImpl and CdmSessionAdapter take a blink::WebContentDecryptionModuleResult during CDM creation. There are a few issues with this: 1. Bad encapsulation, e.g. CompleteWithSession() is exposed to these two classes. 2. Hard to test: There's no easy way to create one |result| for testing. See Bug. 3. Readability: Working with the result directly ends up with more code, e.g. kWebContentDecryptionModuleExceptionNotSupportedError. Bug: 1018832 Test: No functionality change Change-Id: I9b1ec2662873d9da6797133355b1a3261145feac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884277Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710617}
-
