- 12 Nov, 2018 40 commits
-
-
Scott Violet authored
Specifically ash::mojom::UserInfo. I'm going to need this to have ash call into wallpaper code, which needs the gaia account. BUG=756085 TEST=none Change-Id: I9a9c1970bd3cd28ce36cca3d5ff919225dee8084 Reviewed-on: https://chromium-review.googlesource.com/c/1328564Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607300}
-
Weidong Guo authored
Changes: Change the color of the folder title to be Grey 700. Bug: 901286 Change-Id: Ie2e4603a6b248976fbdb114533e1c6e90485bd01 Reviewed-on: https://chromium-review.googlesource.com/c/1330833Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Philip Rogers authored
This patch removes the paint offset parameter for RecordHitTestData which is now baked into the paint_rect parameter. Change-Id: Idecbde110b50db2d62e3cec720861a1f39aecd88 Reviewed-on: https://chromium-review.googlesource.com/c/1329855 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#607298}
-
Takumi Fujimoto authored
If a sink is DISCONNECTING, change the icon to a throbber and change the status text to "Disconnecting...", but don't grey out the title text. If a sink is AVAILABLE but does not support the selected source, change the status text to "Source not supported". The hashes for the screenshots are per the instructions here: https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o/edit And the screenshots are uploaded here: https://storage.googleapis.com/chromium-translation-screenshots/7f85b1d7787495adf8153366ecc39cdd43762144 https://storage.googleapis.com/chromium-translation-screenshots/7f3bb4aeb5b577e98ab1415b31f967311af8747a Bug: 902493, 899998, 883392 Change-Id: Ib556de3e5407500a63c729c7bd02001572fa91e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325070Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#607297}
-
Tommy C. Li authored
For Query in Omnibox, we want to avoid the URL flicker while the page is navigating and the TLS security state has not been initialized. This currently works on Android implementation by toggling a boolean flag on navigation and TLS state update. However, this duplicates a piece of state that's already authoritatively stored within the VisibleSecurityState. This CL: 1. Exposes an IsSecurityInfoInitialized() method on LocationBarModel 2. Updates the security_state::SecurityInfo struct to add a connection_info_initialized flag that's already present in security_state::VisibleSecurityState. 3. Updates LocationBarModelDelegate to provide a general GetSecurityInfo method. Planned followup work: 1. Make Query in Omnibox actually use the IsSecurityInfoInitialized flag. 2. Use LocationBarModelDelegate::GetSecurityInfo to remove some now-redundant methods such as FailsBillingCheck and FailsMalwareCheck. Bug: 874592 Change-Id: I648b30859ec40bb741de1c31378e0a6cd8baeeaa Reviewed-on: https://chromium-review.googlesource.com/c/1324879Reviewed-by:Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607296}
-
Robert Ogden authored
See bug for more context. Bug: 903895 Change-Id: I86c029059a2896084f36af46df56a70a91620838 Reviewed-on: https://chromium-review.googlesource.com/c/1330202Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#607295}
-
Peter Boström authored
This reverts commit 5148d1fe. Reason for revert: Speculative reland, root cause should be fixed with r607193. Original change's description: > Revert "Remove menu_marker from MenuButton." > > This reverts commit 32758758. > > Reason for revert: causes compile failures on windows similar to the ones that appeared in the CQ runs, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/58688 > > Original change's description: > > Remove menu_marker from MenuButton. > > > > This is always false except for in tests and menu_example.cc which is > > not used. This helps simplify MenuButton for the Button cleanup task. > > > > Bug: 901183 > > Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181 > > Reviewed-on: https://chromium-review.googlesource.com/c/1324375 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Reviewed-by: Trent Apted <tapted@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#607061} > > TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,cyan@chromium.org > > Change-Id: I9c311a3c8cea56c7670b2dace3e0410618151034 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 901183 > Reviewed-on: https://chromium-review.googlesource.com/c/1330841 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607072} TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,jbudorick@chromium.org,cyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901183 Change-Id: I8a54361c857ac0a18acfc41dedb9537180aae4ce Reviewed-on: https://chromium-review.googlesource.com/c/1331137 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607294}
-
Xiaohui Chen authored
Also moved some mojom service registration to later stage during initialization. This prevented crash during autotest because the tests are much faster than human when enabling the service which caused the UI to call into Assistant service before the libassistant components are ready. Bug: b:79879622 Test: run a localy autotest that invokes this new api Change-Id: I643d0388115fa2690fa059b73b83748f8d06c335 Reviewed-on: https://chromium-review.googlesource.com/c/1330751Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0243949545eb..49e1239f94fe git log 0243949545eb..49e1239f94fe --date=short --no-merges --format='%ad %ae %s' 2018-11-12 mtklein@google.com put kNone back too 2018-11-12 brianosman@google.com Guard GrOp::dumpInfo with SK_DEBUG 2018-11-12 reed@google.com use SkFontMetrics so we can deprecated the typedef 2018-11-12 egdaniel@google.com Require vulkan 1.1 headers when compiling skia. 2018-11-12 reed@google.com re-add guard to flutter for fuchsia build -- until newer flutter lands 2018-11-12 reed@google.com add guard for fuchsia build 2018-11-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@49e1239f94fe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I7ac123b610407fe6d7bb65f888c4e00ec49a7149 Reviewed-on: https://chromium-review.googlesource.com/c/1331222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607292}
-
Yves Gerey authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/20920a85609b..a0a6951e259b This is a manual roll to integrate MSVC warnings suppressions. It makes Chromium->WebRTC autoroller happy. It doesn't matter for Chromium itself which uses clang even on Windows. Bug: webrtc:9530 Change-Id: I7b0358e16b243b2bb400a1cf3d89c5a14cec14de Reviewed-on: https://chromium-review.googlesource.com/c/1329966Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#607291}
-
Jonathan Metzman authored
This is a reland of b8e27a0d Original change's description: > [skia][libFuzzer] Allow building targets from OSS-Fuzz on Windows > > Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not. > Enable low hanging fruit that can easily be built in a Chromium build. > > Bug: 903632 > Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df > Reviewed-on: https://chromium-review.googlesource.com/c/1328225 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606938} Bug: 903632 Change-Id: I35d49d83e589e04cf11215f63bbe2c2f13fab01c Reviewed-on: https://chromium-review.googlesource.com/c/1330326Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607290}
-
Leonard Grey authored
Bug: 850098 Change-Id: Ic1d51dda680bcc6c24fab1c17099a1d558285528 Reviewed-on: https://chromium-review.googlesource.com/c/1313670 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#607289}
-
Sergey Ulanov authored
Added OWNERS for fuchsia dirs in //chromecast and //media. Also added per-files OWNER rules in //net/base/OWNERS for *fuchsia*. Change-Id: I8fbd409b6cc429dcd636c9a388e095381adaed54 Reviewed-on: https://chromium-review.googlesource.com/c/1330701Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#607288}
-
Emircan Uysaler authored
See https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eKS6bOz9a_o for Intent to Ship and lgtms. Bug: 326740 Change-Id: I2d8cec26bae32281e50137dfd1616926b66e61a8 Reviewed-on: https://chromium-review.googlesource.com/c/1292439 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#607287}
-
Dmitry Gozman authored
Introducing SessionRouter - a common router on top of raw connection which routes messages between multiple sessions based on sessionId. A couple of cleanups along the way. Bug: 775132 Change-Id: I3f773f7ead4d1729d9b936c69b4cdda2d6d20996 Reviewed-on: https://chromium-review.googlesource.com/c/1321854 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607286}
-
Steven Bennetts authored
This CL introduces GetEnableFlags to the mojo API so that GetKeyboardLayout can be moved from keyboard_util.cc/h to chrome_virtual_keyboard_delegate.cc (the only place it was used). It also moves the implementaiton of GetKeyboardWindow to ChromeKeyboardControllerClient. BUG=876138 Change-Id: I83bca47c9a038f9be2bb3322c5500996d898f21b Reviewed-on: https://chromium-review.googlesource.com/c/1330327 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/s* - g*/ Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed. Bug: 887148 Change-Id: Ifb325fbeb0b8f18f4f54978ddc1b3626c08a2e2e Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1328721 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#607284}
-
Daniel Bratell authored
We can't have gn check look through all of blink because it's a messy monolithic pile of internal dependencies, but the public API layer has strict rules that should be enforced by gn check. Also removing a mojo header from a build target since it's supposedly already in a mojo build target and listing it here as well makes gn check unhappy. Bug: 898837 Change-Id: Id46485ffa4ffeb0c897f6d22e684f6d45d4804e6 Reviewed-on: https://chromium-review.googlesource.com/c/1307373 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#607283}
-
Jan Krcal authored
This CL creates the first integration tests for the autofill wallet metadata model type. Bug: 894001 Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23 Reviewed-on: https://chromium-review.googlesource.com/c/1306357 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607282}
-
Nate Fischer authored
This adds an UMA metric to track loadDataWithBaseURL's baseUrl scheme. This logs if the URL is empty, if the scheme is one of several well-known values, or if the scheme is some unknown value (possibly a custom URL scheme). This also adds integration tests to verify we record metrics. R=isherman@chromium.org, torne@chromium.org Bug: 901581 Test: run_webview_instrumentation_test_apk \ Test: --gtest_filter=LoadDataWithBaseUrlTest#testBaseUrlMetrics_* Change-Id: Iaedf6836daeb185da7b1b26145d30fb46a363d21 Reviewed-on: https://chromium-review.googlesource.com/c/1321868 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607281}
-
Joshua Pawlicki authored
Bug: 740715 Change-Id: I58fa13fb81eee6ef6c288026397223eb73659025 Reviewed-on: https://chromium-review.googlesource.com/c/1329545Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#607280}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: I876c39d3f69f7d5e8ed3ead1f07660279e283eb0 Reviewed-on: https://chromium-review.googlesource.com/c/1286455Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607279}
-
Luke Halliwell authored
Change-Id: Ia56a9b605860cb8911bc3e94791760e1ad2b7664 Reviewed-on: https://chromium-review.googlesource.com/c/1303396Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607278}
-
Aaron Krajeski authored
Also adapt them to run automatically with telemetry. Delete the old folder and its contents. Bug: 894043 Change-Id: I5aa4f9172de5ecba0cffd7187ba579b069ae216b Reviewed-on: https://chromium-review.googlesource.com/c/1315530 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607277}
-
Francois Doray authored
This will allow us to assess the impact of using thread priorities. The impact can be both positive (unimportant work gets out of the way) and negative (priority inversions when sharing locks across threads with different priorities). Note: This CL has extra complexity because we don't have guarantees that the FeatureList is initialized before threads are started in unit tests https://crbug.com/846380. Bug: 872820, 890978, 902441, 846380 Change-Id: I8887c7b9e0eb77f7c11aa6e2be8af1ea7150b491 Reviewed-on: https://chromium-review.googlesource.com/c/1318686 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#607276}
-
Tommy C. Li authored
pkasting@ is already in the omnibox component OWNERS file, so he will remain an OWNER of search_engines after this CL. chrome/browser/search_engines includes the below OWNERS file, so it doesn't directly need updating. I'm updating chrome/browser/ui/search_engines as well, as our team recently added code to the SearchEngineTabHelper to auto-update the default search provider favicons as the user browses. Bug: NONE Change-Id: Ib26716fb8ce00b3a166769611e87c4c80273ecba Reviewed-on: https://chromium-review.googlesource.com/c/1329892Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607275}
-
John Budorick authored
Tbr: martiniss@chromium.org Bug: 877264 Change-Id: Icd73a35287a406a2fbe87669cbb5f472a0b4d413 Reviewed-on: https://chromium-review.googlesource.com/c/1331417Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607274}
-
Arthur Sonzogni authored
Some URLLoaders aren't always sending a response's body datapipe to their client after sending URLLoaderClient::OnReceiveResponse(response_head). It even happens to send URLLoaderClient::OnComplete(net::OK) after that. Most of the time, they do not send a datapipe, because the response's body is empty. The goal is to align URLLoaders so that they will always send a data pipe by using OnStartLoadingResponseBody(response_body). This CL is about ServiceWorker's URLLoaders. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Ib28fc2067240d611ec149099b5365f70610a9369 Reviewed-on: https://chromium-review.googlesource.com/c/1323109 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#607273}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: Ia4d3093f9f70dd3aeeb0a49d87475bc3f4f2c58d Reviewed-on: https://chromium-review.googlesource.com/c/1330891Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607272}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I764a9dc6f2d38f896a8d7ec41f15a834e5bbba85 Reviewed-on: https://chromium-review.googlesource.com/c/1330842Reviewed-by:
-
Peter Boström authored
This makes use of COLOR_TAB_THROBBER_SPINNING in both the loading and waiting states. Bug: chromium:903457 Change-Id: I3e6bed8392c956604649c42eb8fcef1d10a7a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1329349Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607270}
-
Francois Doray authored
Previously landed as https://chromium-review.googlesource.com/c/1318438. Reverted because PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess failed on Windows 7. This reland adds more possible return values for ::GetThreadPriority() on Windows 7 (see diff between ps1 and ps7). Previously, SetCurrentThreadPriority(BACKGROUND) did not affect CPU priority on Windows in a IDLE process when the "WindowsThreadModeBackground" feature was enabled. It only affected I/O and memory priorities. With this CL, a second call to ::SetThreadPriority() is made to ensure that CPU priority is affected. TBR=gab@chromium.org Bug: 901483 Change-Id: I21ebc6465b3b8d10a956714d55ef88b28bf89fff Reviewed-on: https://chromium-review.googlesource.com/c/1326423Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is a reland of aaeff5e6 which was a reland of 31bcf8aa which was a reland of 5528336d, which was a reland of dd9df78c, which was a reland of 7bd91635. Relanding with no changes, after disabling the flaky test in https://crbug.com/904389 Original change's description: > [blink] Control ScriptStreamer with ScriptResource > > Move the ScriptStreamer control logic from ClassicPendingScript to > ScriptResource. In the future, this will allow us to start streaming > a ScriptResource before the ClassicPendingScript is available, e.g on > preload. > > The ClassicPendingScript now only sends one "finished" callback, from > ScriptResource. This callback is either when the streaming completes, > or when there is no streaming and the ClassicPendingScript has told > the ScriptResource that it doesn't intend to start streaming. In the > long run, we want all scripts to go through the streaming interface, > and we want ScriptResource to control when streaming starts, so the > "no more streaming" call will disappear -- however it is necessary to > maintain the current behaviour, and be able to control it with a > runtime flag. > > Bug: chromium:865098 > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599148} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org Bug: chromium:865098 Change-Id: Ifa87904db32666517bfe1174fca51b7e552679b2 Reviewed-on: https://chromium-review.googlesource.com/c/1329800Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#607268}
-
Eric Roman authored
This fixes BasicAuthWSConnect.BasicAuthWSConnect. The ordering of proxy bypass rules only mattered until recently, with the addition of the <-loopback> bypass rule (Issue 413511). That rule gives a way to "subtract" the bypass of localhost, and can be used by tests need to proxy localhost (see Issue 901896). Because later rules have priority over earlier rules, we need to move <local> to the front, or it won't be possible for user-provided (explicit) rules to override it. Bug: 902418 Change-Id: I40fb6e23e7b79ba628595cd6724de627bedb5f73 Reviewed-on: https://chromium-review.googlesource.com/c/1321853 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607267}
-
Arthur Sonzogni authored
This is a sort of prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 The main goal is after sending: URLLoaderClient::OnReceiveResponse(response_header) to ALWAYS send: URLLoaderClient::OnStartLoadingResponseBody(response_body) Some URLLoader, when the response's body body is empty, don't even try to send the response_body data pipe. In the URLLoaderClient, not having to handle the case with no data pipe would be a nice simplification. What this CL does: 1) In BlobUrlLoader, create the data pipe at ::Start() time. 2) Pass the producer handle to the MojoBlobCreate at construction time. 3) Pass the consumer handle to OnStartLoadingResponseBody(), immediately after OnReceiveResponse(). Some code simplification was possible. There is no more need to implement PassDataPipe() in BlobURLLoader, ReaderDelegate and DataPipeReaderDelegate. There is no more need to give them the pipe at construction time neither. Bug: 826868, 831155 Change-Id: I827cb39bdd782624ff362874e98be90cab0d47f3 Reviewed-on: https://chromium-review.googlesource.com/c/1329741Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607266}
-
Max Moroz authored
Hopefully this won't break too many things. Libraries removed: - Linux: removed ~5.5MB from ~24.5MB of libs (excluding Android libs): 1.5M libclang_rt.asan-i386.so 4.0K libclang_rt.asan-preinit-i386.a 1.5M libclang_rt.asan-x86_64.so 4.0K libclang_rt.asan-preinit-x86_64.a 36K libclang_rt.hwasan_cxx-x86_64.a 4.0K libclang_rt.hwasan_cxx-x86_64.a.syms 1.4M libclang_rt.hwasan-x86_64.a 4.0K libclang_rt.hwasan-x86_64.a.syms 388K libclang_rt.hwasan-x86_64.so 352K libclang_rt.ubsan_standalone-i386.so 332K libclang_rt.ubsan_standalone-x86_64.so - Darwin: removed ~3MB from ~9MB of libs 1.5M libclang_rt.fuzzer_no_main_ios.a 1.6M libclang_rt.fuzzer_no_main_iossim.a - Windows: (insignificant) removed ~50KB from ~28MB of libs 48094 clang_rt.asan-preinit-i386.lib 892 clang_rt.asan-preinit-x86_64.lib Bug: 870331 Change-Id: I0ccf1310b2ab5bde6d514a31b2c5ba7eb2844401 Reviewed-on: https://chromium-review.googlesource.com/c/1315361Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Mark the delaying_onload_link_preload_after_discovery layout test as flaky, due to flakiness under heavy load. Bug: 904389 Change-Id: I585fd5a02a7f94c98dbf10176f58069153c12b2c Reviewed-on: https://chromium-review.googlesource.com/c/1331392Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#607264}
-
James Hawkins authored
Change-Id: I46f7c22d556302df6a657742fcee5c253e14a437 Reviewed-on: https://chromium-review.googlesource.com/c/1330119Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e5366120355..59d560e4e67d Created with: gclient setdep -r src-internal@59d560e4e67d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85cf5502cde03d3919ecad711c075dc60ef9c248 Reviewed-on: https://chromium-review.googlesource.com/c/1331221Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607262}
-
Benoît Lizé authored
Fix typo in https://chromium-review.googlesource.com/c/chromium/src/+/1323549 Bug: 877044 Change-Id: I377da8d819b3abbe27df8245e608e55c49759f05 Reviewed-on: https://chromium-review.googlesource.com/c/1329799Reviewed-by:
-
