GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/deb8260a..89d5fb66

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1640203002

Cr-Commit-Position: refs/heads/master@{#371779}

The genereated Ogg/Opus files don't seem to play in Chromium (which uses
ffmpeg) while they do VLC or Gstreamer. Turns out we have the wrong flag
set on the OpusTags packet and a wrong size written for one of the strings.

BUG=none
TEST=play the generated file on Chromium

Review URL: https://codereview.chromium.org/1640703002

Cr-Commit-Position: refs/heads/master@{#371778}

A PeriodicWave object can use half a MB and v8 needs to know about that
or it will not schedule garbage collects when memory usage increases.

BUG=578351

Review URL: https://codereview.chromium.org/1632753002

Cr-Commit-Position: refs/heads/master@{#371777}

|ReplaceSelectionCommand| stores the inserted range after |doApply()|.
This range may be invalidated if |Editor::appliedEditing()| modifies the
DOM, causing spellcheck run on an invalid range.

This CL moves the spellcheck request into |Editor::appliedEditing()|
before dispatching any event, ensuring spellcheck run on a valid range.

BUG=580950
TEST=LayoutTests/editing/pasteboard/paste-webkit-editable-content-changed-crash.html

Review URL: https://codereview.chromium.org/1636883003

Cr-Commit-Position: refs/heads/master@{#371776}

Tiny bit of cleanup: Some timers used to be 'snapped' to an 'aligned'
fire time so that work would get batched, particularly when suspended
timers were rescheduled. This sort of thing is now the responsibility of the
scheduler; nobody is using Timer::alignedFireTime any more.

Because alignedFireTime had no tests :O no tests were harmed in the
preparation of this changelist. :D

BUG=331912

Review URL: https://codereview.chromium.org/1625413002

Cr-Commit-Position: refs/heads/master@{#371775}

A crash of crbug.com/537815 was due to an editable <p> as document.documentElement.
Supporting such invalid HTML structure is costly.  So we correct such HTML structure
before executing execCommands.

- We show a console warning if the autocorrection happens.
- After the autocorrection, document.write() doesn't work because the document tree
is complete.

BUG=537815

Review URL: https://codereview.chromium.org/1637323002

Cr-Commit-Position: refs/heads/master@{#371774}

This was an "alias" for -webkit-column-span:none. '1' is not a valid value,
according to the spec. The only valid values are 'none' and 'all'. In an older
version of the spec, '1' and 'all' were the valid values. In the latest version
(2011), '1' was changed to 'none'.

It's highly unlikely that removing this should cause compatibility problems.
The initial value is 'none' (which is what '1' was mapped to), so in order to
cause trouble, one would need a declaration -webkit-column-span:all to be
overridden by a -webkit-column-span:1. I went through httparchive to verify.
No sites were found to do this.

R=timloh@chromium.org

Review URL: https://codereview.chromium.org/1635993002

Cr-Commit-Position: refs/heads/master@{#371773}

If a ScriptRunner has been disposed of already, allow ScriptLoaders
to notify of their failure without asserting.

R=haraken
BUG=570012

Review URL: https://codereview.chromium.org/1644483002

Cr-Commit-Position: refs/heads/master@{#371772}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/45f7b52d..deb8260a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1636383002

Cr-Commit-Position: refs/heads/master@{#371771}

This CL removes the support for the CHROME_PROFILER_TIME env var,
originally introduced by crrev.com/9212025 more than 3 years ago, which
allows to change the time source for the profiler via the environment.
Reason for deleting it: could not find any active user of that.
See also discussion in project-trim@chromium.org @ goo.gl/p3GEUy .

After this CL (almost*) nothing outside of base depends on tcmalloc.
This is the place where we want to be, as base should be the only thing
knowing about allocator internals.

* There is only one dep left in content_child_helpers.cc, which is
relied on by old-style telemetry memory benchmarks. But that code is
literally a dead man walking and there is no point refactoring it.

BUG=564618, 581365

Review URL: https://codereview.chromium.org/1632253002

Cr-Commit-Position: refs/heads/master@{#371770}

Pepper API is device scale factor aware, so we need to convert the coordinates between viewport and DIP, when use-zoom-for-dsf mode is enabled.
* Convert events and bounds from the Viewport to DIP.
* Convert caret bounds from DIP to Viewport.
* Moved the utility function to scale WebInputEvent  to ui/events/blink

This CL depends on https://codereview.chromium.org/1603253003/

BUG=485650

Review URL: https://codereview.chromium.org/1609193002

Cr-Commit-Position: refs/heads/master@{#371769}

This patch moves this free function from generic net_util.h header,
into url_util.h, because it operates on a URL part (hostname), so it
seems more appropriate there than in the soon-to-go-way net_util.h.

BUG=488531
TEST=net_unittests --gtest_filter=UrlUtil*
R=eroman@chromium.org
TBR=felt@chromium.org

Review URL: https://codereview.chromium.org/1629733002

Cr-Commit-Position: refs/heads/master@{#371768}

Revert of command_buffer: Enable gl path rendering by default (patchset #1 id:1 of https://codereview.chromium.org/1626363002/ )

Reason for revert:
This CL is causing the Linux Release (NVIDIA) builder to fail:
https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20(NVIDIA)

It fails on step gl_tests on test GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0 with this error message:
GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0:
[13969:13969:0126/235302:15239455268986:ERROR:buffer_manager.cc(361)] [GroupMarkerNotSet(crbug.com/242999)!:C84AD1F190090000]GL ERROR :GL_INVALID_ENUM : glBufferData: <- error from previous GL command
../../gpu/command_buffer/tests/gl_test_utils.cc:31: Failure
Value of: error
Actual: 1280
Expected: static_cast<GLenum>(0)
Which is: 0
GL ERROR in no errors at line 52 : 1280

Original issue's description:
> command_buffer: Enable gl path rendering by default
>
> Enable gl path rendering by default if it is supported by the
> hardware.
>
> Skia will use it when GPU rasterization MSAA codepath is used.
>
> BUG=344330
>
> Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
> Cr-Commit-Position: refs/heads/master@{#371753}

TBR=vmiura@chromium.org,bsalomon@google.com,zmo@google.com,senorblanco@chromium.org,zmo@chromium.org,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=344330

Review URL: https://codereview.chromium.org/1641623002

Cr-Commit-Position: refs/heads/master@{#371767}

Even if the transform-origin is the same as the current value,
rareNonInheritedData will still be copied.
Add a new macro SET_NESTED_VAR, similar to the existing SET_VAR, but
allowing an intermediate |base| field to be specified, avoiding the
access in the dereference of that field from the group.

BUG=571183

Review URL: https://codereview.chromium.org/1636503005

Cr-Commit-Position: refs/heads/master@{#371766}

This prepares the notification feature plumbing for using multiple
resources when buttons can have icons. IPC messages cannot take more
than 5 arguments, so the idea is that all icon resources will be wrapped
in this struct.

BUG=581336

Review URL: https://codereview.chromium.org/1634933006

Cr-Commit-Position: refs/heads/master@{#371765}

Image::hasRelative{Width,Height} always return the same result so
there is no need for two functions. Since
https://codereview.chromium.org/26390004 there is no reason to have
these separate since the SVGImage implementations are gone.

BUG=581357

Review URL: https://codereview.chromium.org/1634133003

Cr-Commit-Position: refs/heads/master@{#371764}

Just removed NOTIMPLEMENTED from
BridgedNativeWidget::PrepareForLayerBoundsChange() function.

BUG=454698

Review URL: https://codereview.chromium.org/1627193004

Cr-Commit-Position: refs/heads/master@{#371763}

Add dedicated windowToViewport method to convert FloatRect from window coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650

Review URL: https://codereview.chromium.org/1603253003

Cr-Commit-Position: refs/heads/master@{#371762}

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.

Review URL: https://codereview.chromium.org/1637473002

Cr-Commit-Position: refs/heads/master@{#371761}

If we return nullptr trying to consume a compound, and all tokens have
been consumed, we don't recognize that as a parse failure if a valid
selector precedes the compound. Set m_failedParsing to true to notice
we have an invalid selector.

R=timloh@chromium.org
BUG=581257

Review URL: https://codereview.chromium.org/1634273003

Cr-Commit-Position: refs/heads/master@{#371760}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5c7b38de6fd5..537c7c6cb877

$ git log 5c7b38de6..537c7c6cb --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1640553003

Cr-Commit-Position: refs/heads/master@{#371759}

* <!DOCTYPE> should be shown differently.
  Old:    html    0xhhhhhhhh
  New:    DOCTYPE html  0xhhhhhhhh

* Processing Instructions should be shown differently.
  Old:    xml-stylesheet    0xhhhhhhhh
  New:    ?xml-stylesheet   0xhhhhhhhh

* Elements and documents show editability
  Old:    body    0xhhhhhhhh
  New:    body    0xhhhhhhhh (editable)

This CL has no behaivor changes in production.

Review URL: https://codereview.chromium.org/1639193002

Cr-Commit-Position: refs/heads/master@{#371758}

Change getDistributedNodes to getAssignedNodes to make the performance test run.
BUG=531990

Review URL: https://codereview.chromium.org/1630003004

Cr-Commit-Position: refs/heads/master@{#371757}

This CL adds metrics to measure the usage of features that require permissions
in Chrome when they are used in cross-origin iframes only. In particular we only
want to count an iframe if it doesn't have scripting access into the top level
document. A new UseCounter::countCrossOriginIframe function has been added which
will only count this type of usage.

Note that this intends to count cases when a site tries to use an API whether or
not the permission is granted by the user.

BUG=444744

Review URL: https://codereview.chromium.org/1578263006

Cr-Commit-Position: refs/heads/master@{#371756}

Cr-Commit-Position: refs/heads/master@{#371755}

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1639833002

Cr-Commit-Position: refs/heads/master@{#371754}

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Review URL: https://codereview.chromium.org/1626363002

Cr-Commit-Position: refs/heads/master@{#371753}

This will avoid new dependencies and helps with keeping track of the
refactoring.

R=pfeldman@chromium.org
BUG=
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1632273002

Cr-Commit-Position: refs/heads/master@{#371752}

This patch moves implementations of |SelectionAdjuster| into its own file.

This is a follow-up patch of http://crrev.com/1630903005, which introduces
|SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp".

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1640623002

Cr-Commit-Position: refs/heads/master@{#371751}

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10

Review URL: https://codereview.chromium.org/1565303002

Cr-Commit-Position: refs/heads/master@{#371750}

https://chromium.googlesource.com/chromium/src/+/39de759a9

BUG=537077
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1633403004 .

Cr-Commit-Position: refs/heads/master@{#371749}

The old EDK always initializes the new EDK as well, but it wasn't
shutting it down unless --use-new-edk was set. This was hitting
CHECKs to guard against double-initialization, because tests init
and shutdown the EDK multiple times in the same process.

This CL fixes that by always shutting the new EDK down as well.

Also we don't actually use g_io_thread_task_runner anymore so
I removed that.

TBRing since it's a pretty obvious fix IMHO and it's breaking
stuff on bots.

BUG=None
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1642453002

Cr-Commit-Position: refs/heads/master@{#371748}

Spec is described here: http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042

Review URL: https://codereview.chromium.org/1586563005

Cr-Commit-Position: refs/heads/master@{#371747}

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
          mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
                obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                        obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                            obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder

Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc -> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target cause some
important build failures on the official builder.

Defining this target in a new gyp file (instead of in a gypi file) fix this redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525

Review URL: https://codereview.chromium.org/1633343002

Cr-Commit-Position: refs/heads/master@{#371746}

Currently the number of pages per bucket is limited to 2^16,
and this has caused a bunch of crash reports at partitionBucketFull().

This CL increase the limit to 2^24 instead of decreasing the limit of
|numSystemPagesPerSlotSpan| to 2^8 (It is statically guaranteed that |numSystemPagesPerSlotSpan|
does not exceed 2^8). As a result, this CL doesn't change sizeof(PartitionBucket).

BUG=87772

Review URL: https://codereview.chromium.org/1622553004

Cr-Commit-Position: refs/heads/master@{#371745}

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137

Review URL: https://codereview.chromium.org/1619423003

Cr-Commit-Position: refs/heads/master@{#371744}

Before this CL, we don't check required member field when 'null' is
passed as a dictionary. Add the checks.

BUG=580531

Review URL: https://codereview.chromium.org/1631333003

Cr-Commit-Position: refs/heads/master@{#371743}

Step 7 in

https://html.spec.whatwg.org/multipage/embedded-content.html#processing-model

BUG=578125

Review URL: https://codereview.chromium.org/1631303002

Cr-Commit-Position: refs/heads/master@{#371742}

https://chromium.googlesource.com/chromium/src/+/a9c81551f

BUG=570611
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1641533002 .

Cr-Commit-Position: refs/heads/master@{#371741}

Classes outside of core/layout/ that need a reference to an InlineBox's
layoutObject must currently use the API-busting shim we've set up to
get a reference to a LineLayoutItem's underlying layoutObject.

Some references can simply be changed to lineLayoutItem() directly, where
the line layout API already provides access to the methods used.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1629643002

Cr-Commit-Position: refs/heads/master@{#371740}