GitLab

This removes the PermissionManagerFactory dependency from
WebsitePreferenceBridge.

Bug: 1058600
Change-Id: I474a8a40e178ee1cc79f3a0454617e9b12a8d789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110671Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751831}

Previously the loading.LayoutShift trace event included impacted_nodes
only if the layout_shift.debug trace category was enabled.

With this change:
(1) the loading.LayoutShift trace event always includes impacted_nodes
(2) with layout_shift.debug, the impacted_nodes includes debug_name

The debug name is the string from Node::DebugName, and gives the
attribution some immediate utility even without devtools integration.

Bug: 1053510
Change-Id: I7f4174e7a2379df9e91676cf7ef6f31cfcec8507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106841
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751830}

When the fieldset is expanded to encompass the legend, the fieldset
content no longer applies the fieldset padding. This change
ensures that in this case, the fieldset content is aware of the change
in the border box size so that it will properly take care of fieldset
padding.

Bug: 875235
Change-Id: I2ee67221f195bdbcb06122ee4f01a1024e49ceb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109128
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751829}

This moves the caching from preferred logical widths "down" one level to
intrinsic logical widths.

This improves performance of FlexNG in particular, but also legacy
flexbox and other functions. This comes at the expense of some grid
perf-tests which seems like the right tradeoff given how popular flex is.
FlexNG: https://pinpoint-dot-chromeperf.appspot.com/job/17dcb4ff620000
non-FlexNG: https://pinpoint-dot-chromeperf.appspot.com/job/161c179b620000

This patch transforms ComputePreferredLogicalWidths into
PreferredLogicalWidths.

We also store what we used to resolve %-block-sizes within the min/max
phase. We can use this additional data for a more precise min/max size
cache see: CanUseCachedIntrinsicLogicalWidths.

Bug: 845235
Change-Id: I4a6584f580ae7967b156592d1e97ddbb4631a432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099322
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751828}

Bug: 1013127
Change-Id: I959395cab2f9a1322c932e38ba490b25a81a101d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106807
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751827}

This CL converts resource_dirs to sources for android_resources in
chrome/android/BUILD.gn file.

Details:
https://crbug.com/1026378
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ

Bug: 1062263
Change-Id: I9b7b437163ac4d9529de9a18799279a8b1ee9e53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109975
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751826}

Currently Vasco suggestions are disabled in NTP when ZPS is showing in NTP
Omnibox/Realbox. This CL add new feature flag that, once enabled, shows
Vasco suggestions in NTP while ZPS is showing.

Bug: 1063122
Change-Id: I927f3b29e7c5ae46d3a2250ed89f026a26e6c8f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111070
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751825}

Calling Widget::Init() from OverlayWindowViews constructor seems too
early. Widget::Init() triggers calls to virtual functions such as
OnNativeWidgetMove() while OverlayWindowViews hasn't been constructed
fully. To cope with this, the |is_initialized_| flag was used as a
trigger for early returns. This turned out error-prone as some crucial
parts of the virtual functions were skipped, resulting in the PiP window
becoming blank and unusable on some systems. It seems safer in general
to call Widget::Init() on a constructed OverlayWindowViews object
anyway.

With this CL, we still call SetUpViews() in the constructor to set up
all the views::View pointers that are dereferenced as a result of
Widget::Init(). Since the root view is not available at this stage (it
gets created by Widget::Init()), we keep the child views in a temporary
container. We defer the initialization steps that require the root View
to a new helper function OverlayWindowViews::OnRootViewReady().

Bug: 1058852
Change-Id: I7434fc6067fae0b5fcc0135d6c3b7b8ff62d79d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107991
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751824}

I enabled this test since it passes all of 20 runs locally, but
it turns out it is still flaky on our dbg buildbots. I guess
that's because of the performance regression noted as
crbug.com/1054489 and it's passing since my workstation performs
well. Anyways, let's disable it for now.

Bug: 1054489, 1057868
Test: none
Change-Id: Iea764beb4000bd2dcd8361dad011404a92995db5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111057Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751823}

This CL combines AutocompleteControllerDelegate and
OmniboxControllerEmitter::Observer classes into a single
AutocompleteController::Observer class.

This is because these two classes are essentially the same, both
observing the AutocompleteController.

In the future, we can also make OmniboxControllerEmitter itself an
instance of AutocompleteController::Observer, because it too, is
essentially an observer class that's a KeyedService.

The ultimate goal is to hook up the Android omnibox and NTP realbox
to the chrome://omnibox debug surfaces.

This refactor is to pave the way for that. See the bug for the full
engineering plan on how to get there.

Bug: 1058486
Change-Id: Ieb65cc2570a5af1ba417be6a87f4779bbe4710ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088223Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751822}

Ran `./tools/clang/scripts/upload_revision.py 5d881dd8a8b8ea6f80bf4ef5b900ca006dacd9bf`.

Bug: 1063010
Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Change-Id: I3060358001121738e9cc5ae76242b8ba6b18623d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109177
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751821}

This CL modifies the NTP to work with the status indicator.

When the top controls height changes, the layout's margin will be
updated without any animation.

Bug: 1059438
Change-Id: I06285cda66681fd5af2ecd5abcb972965aa6e9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108182
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751820}

Before this CL, os settings could be opened in the browser. This
CL removes a check that prevented os settings from only being
opened in PWA (settings app).

Removed Disposition_OSSettings_UseNonIncognitoWindow because this test
checks if os-settings is opened in a browser but not opened when browser
is in incognito mode. As os-settings no longer opens in browser this
fails every time.

Fixed: 871144
Change-Id: Idc142e47e7c058597afd6bc7d5402a511119d696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086316
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751819}

Bug: 1030938
Change-Id: Ideed094ca6fa5ec61d0ff2578737cfdd658ff395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106848Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751818}

Change-Id: I31401d78ab9da6a1a8f00945e617e70e6c1ecd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110631Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751817}

Adds a class which polls for uploadable metric data at regular intervals
and sends the data to a FIDL MetricsRecorder endpoint.

Bug: 1060768
Change-Id: I632fceea606c3d78b24a15afc76340dc7b22b802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103404
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751816}

DISALLOW_COPY_AND_ASSIGN is deprecated:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#explicitly-declare-class-copyability_movability

Change-Id: I384bdf3376d01834b6aa60ac202a9e7c368a869d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105271Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#751815}

When preparing to collect a BaseAudioContext, go through all the
rendering_orphan_handlers_ and deletable_orphan_handlers_ and remove
the context from the handler.  This ensures that these handlers no
longer have references to the context when the BaseAudioContext is
destroyed because in some cases, these orphan handlers will get pulled
and access the context, which is already gone.

Clearing these in a prefinalizer ensures these orphan handlers don't
try to touch the context.

Manually verified that the repro case no longer reproduces.

Bug: 1062247
Change-Id: I50d083743903eb9544e09aa1ee912fc880331501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107806Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751814}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I71fb05c97c1b9ab9905619d44ed4d4b547ed5892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110390Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751813}

This lets us control FlexNG rollout via Finch.

The Finch CL will be http://cl/301721010

Bug: 845235
Change-Id: Ia147ae5a37dc41f0e3d519051f8e8a397d3cca5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109470Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751812}

This was testing a flag that is now enabled by default.

Bug: 1062254
Change-Id: Id0b2c0cf4d882c83b0ed5278230cd63299f49d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108909
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751811}

This CL adds SmartDimComponentInstallerPolicy which takes care of
downloading, installing smart dim components and feeding them into
SmartDimMlAgent to update its download_worker_.

It also takes care of the smart dim experiments, concretely, it
fetches and uses exact expected_version from the server, while
expected_version can be configured by a finch flag. Therefore we
can use finch to control the version it uses.

expected_version from the server, no matter what other versions
already exist in the disk.

Bug: 1018065
Test: Tested on DUT, it successfully fetches and uses the
Change-Id: I2759d55291e9424c255b977ccba2f1632dc44f43
Cq-Depend: chromium:1903168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990885
Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751810}

Bug: 1052460
Change-Id: Iefa6e94b08665d152b891f0dfd6e12d5788b1adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109377
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751809}

Bug: 1052460
Change-Id: I7ac24b7727003304040d15492faeaacd3e417aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109134Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#751808}

This allows observers to monitor for the first connection to a Wi-Fi
network configuration

Bug: 966270
Change-Id: I732ab658f106326dde5dc959c99ea98d49ab005b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110075Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751807}

This updates crrev.com/c/2110510 by moving the failure expectations
from web_tests/FlagExpectations/composite-after-paint into the
main TestExpectations because they aren't just flaky on
composite-after-paint.

TBR=sullivan@chromium.org,npm@chromium.org

Change-Id: Id92fc952ed8c211cfd63bdc909f13c43fac05d39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1062984, 1063079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110591
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751806}

In this CL, we split classes used in Instant Start into the following
way:
Dependencies of native is removed from the constructors into an
initWithNaive() method.

This refactoring involves:
- Inheritance chain from LayoutManagerChromePhone to LayoutManager
- StartSurface*
- Coordinators and Mediators for Tab management.

Note: this CL doesn't create LayoutManagerChromePhone in pre-native, but
defers some code from creation to initialization. We could like to see
nothing breaks due to these changes.

Bug: 1041865
Change-Id: If85137c4bd63d89d92f4a9ed0929c0a52175be2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999001
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751805}

This library provides access to RenderFrameImpl things but
WebFrameTestProxy is-a RenderFrameImpl and can be used instead.

R=creis@chromium.org

Bug: 866140
Change-Id: Iefdeef8de4fa70966119ac026f7be1b5c592a918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110071Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751804}

Bug: 1060382
Change-Id: If8022bfe71c9a8c8f70a4de37153e1c7ad028d64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106742Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751803}

It isn't necessary to run BeginFrame and all of the UpdateVisualState
code. This should make it easier to move LayerTreeView into blink.

Change-Id: Iefb0caffc6cdc38db10352b50404afebb8120dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110512Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751802}

Test: browser_tests --gtest_filter=ChromeVoxBrailleTableTest.*
Bug: b/150635270
Change-Id: I8cb685af0fc84f913711f0b2e4d0e5744669db9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109821Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751801}

Bug: 1048429
Change-Id: Ie52fceeea3c246e2dc24a3c8475babf64c840cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076414
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Auto-Submit: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751800}

The adopters of the updater project should be able to change the guids
of the COM service exposed by the updater.exe to prevent conflicts
when services are installed on the same machine. To make it easier to
deal with conflicts, we want the UUIDs to be defined outside of the .IDL.

This change allows for compile-time defines expressed in GN to be passed
to the midl.exe compiler.

Change-Id: I6764d1625fb01635c8426d3634ff6fcd7561ae27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094711
Commit-Queue: Maciek Kumorek <makumo@microsoft.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751799}

Fix the name of ShouldFetchCrosHealthData() to align with similar
function names (e.g. FetchCrosHealthdData()).

Bug: 1063109
Change-Id: I444c44204b09f9c2d5f113bbb9faa5045325ead4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110680
Auto-Submit: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751798}

Bug: 1063001, 1047175
Change-Id: I294c672607b0428b68c9f42cffca9f6d017c3691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108513Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751797}

Bug: 1063064
Change-Id: Ib757f4273daf5136d39e3353c998faa2d0ce09dd
Fixed: 1063064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110688
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751796}

This field is being used on the server side in cl/301451451.

Change-Id: I4fc7932a20b51354541886e42b833ad73344a4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110211
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751795}

This allows for safer and easier passing of values between the renderer
and browser processes.

Some minor cleanup of replacing empty constructors/destructors with
"= default" is also included in this CL.

Bug: 1016615
Change-Id: I0bd922c9a541abf63edc296099ebfa0b8e8413a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103133Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#751794}

It is tracking if ReadyToCommitNavigation happened first, which is true
iff the RenderFrame was a provisional frame and is being swapped in.
For same document navigations, ReadyToCommitNavigation would not have
happened.

The DidCommitProvisionalLoad() method already receives the flag for
is_same_document_navigation which can be used for this purpose instead.
When it's false, we should move focus to the main frame.

R=avi@chromium.org

Bug: 866140
Change-Id: Ida170bb699fe3f53c43bd3163c16aa4d2e307e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110170
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751793}

In this scenario, the x & y attributes are baked into both the the
content-rect of the <foreignObject> (as passed to the clipper), *and*
the transform.  As a result, any x & y offsets were being double-applied
to a <clipPath> that used clipPathUnits="objectBoundingBox".

We modify |ReferenceBoxForEffects| so that it removes the unnecessary
transformation from the reference box when it's called on an SVG foreign
object.

Bug: 1009222
Change-Id: Ifc009eb84d46d49c7840e2903d44a90502d6b51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101320
Commit-Queue: Ian Prest <iapres@microsoft.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751792}