GitLab

Let's use FrameSelection::DirectoinalOption instead of bool.


BUG=

Review URL: https://codereview.chromium.org/328243004

git-svn-id: svn://svn.chromium.org/blink/trunk@176192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/334793005

git-svn-id: svn://svn.chromium.org/blink/trunk@176191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Will allow reuse of this function in the implementation of the enterprise.platfromKeys Chrome extension API.

BUG=364435

Review URL: https://codereview.chromium.org/312393004

git-svn-id: svn://svn.chromium.org/blink/trunk@176190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We use VectorComparer to compare WTF::Vector<T>.
If T is not primitive type, we use std::equal to compare.
By the way, we use the WTF::VectorBufferBase class for a base class of Vector.  VectorBufferBase doesn't alloc a array if we init it without a size argument.
As a conclusion, we pass NULL object to std::equal when we compare Vectors with the default constructor.
It is asserted especially on a Windows debug build.

BUG=

Review URL: https://codereview.chromium.org/332113002

git-svn-id: svn://svn.chromium.org/blink/trunk@176189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Evaluate explicit "delete this[p]" to delete a property.

R=vsevik

Review URL: https://codereview.chromium.org/323423002

git-svn-id: svn://svn.chromium.org/blink/trunk@176188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since r276361 made chromium side not to use the methods, now we can remove these methods from Blink.

c.f. https://codereview.chromium.org/301883002 and svn://svn.chromium.org/chrome/trunk/src@276361

BUG=369451

Review URL: https://codereview.chromium.org/327483002

git-svn-id: svn://svn.chromium.org/blink/trunk@176187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=373120

Review URL: https://codereview.chromium.org/318393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We frequently saw object path dump like:

    Path to 1d6ec5d8 of WebCore::Node
    <- 7abc4660 of Persistent

Then, we needed to investigate what this Persistent is. It took much time.

This CL introduces 'tracing name' property to Persistent if
ENABLE(GC_TRACING). The property is automatically filled with
backtrace of a Persistent constructor. We'll get dump like:

    Path to 1bd56220 of WebCore::Node
    <- 1bd55ff8 of WebCore::Node
    <- 1bd55dc8 of WebCore::Node
    <- 7d046600 of Persistent ... Backtrace:
            Persistent<HTMLSelectElement, ThreadLocalPersistents<(ThreadAffinity)1> >::Persistent(HTMLSelectElement*)
            v8::Handle<v8::Object> V8DOMWrapper::associateObjectWithWrapper<V8HTMLSelectElement, HTMLSelectElement>(HTMLSelectElement*, WrapperTypeInfo const*, v8::Handle<v8::Object>, v8::Isolate*, WrapperConfiguration::Lifetime)
            v8::Handle<v8::Object> V8DOMWrapper::associateObjectWithWrapper<V8HTMLSelectElement, HTMLSelectElement>(WTF::RawPtr<HTMLSelectElement>, WrapperTypeInfo const*, v8::Handle<v8::Object>, v8::Isolate*, WrapperConfiguration::Lifetime)
            V8HTMLSelectElement::createWrapper(WTF::RawPtr<HTMLSelectElement>, v8::Handle<v8::Object>, v8::Isolate*)

Additional improvement of the object path dump:
* Correct host info name for heap collections
* Don't try to dump unknown objects.

BUG=

Review URL: https://codereview.chromium.org/337653002

git-svn-id: svn://svn.chromium.org/blink/trunk@176185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Internal properties inherently are not writeable, thus they should behave so in the frontend.

R=vsevik

Review URL: https://codereview.chromium.org/323313005

git-svn-id: svn://svn.chromium.org/blink/trunk@176184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As bug305497 is marked WontFix, I'd like to merge back
ExecutionContextClient to ExecutionContext for readability. This is 1st
step for that.

Note about behavior change induced by this CL

addConsoleMessage():
When addConsoleMessage() is called via ExecutionContextClient, it just
calls addMessage(). But ExecutionContext has non-virtual
addConsoleMessage() which checks if m_client is non-NULL. We'll call
the latter after this CL. If this change breaks something, that means
such an addConsoleMessage() call has been invalid since it's called
on an ExecutionContext that is already partially destructed.

isDocument():
OK for the same reason.

disableEval():
OK for the same reason.

securityContext() and reportBlockedScriptExecutionToInspector():
No change as ExecutionContext doesn't have a non-virtual override for it.

contextURL() and contextCompleteURL():
No change as they're implemented only on ExecutionContextClient.

BUG=305497

Review URL: https://codereview.chromium.org/332993002

git-svn-id: svn://svn.chromium.org/blink/trunk@176183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the third parameter to PropertyWrapper was removed in
https://codereview.chromium.org/139273007 (legacy animation engine
removal) setZoomWithoutReturnValue lost its last caller.

Review URL: https://codereview.chromium.org/324063002

git-svn-id: svn://svn.chromium.org/blink/trunk@176182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384956
TBR=

Review URL: https://codereview.chromium.org/331583004

git-svn-id: svn://svn.chromium.org/blink/trunk@176181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384950
TBR=

Review URL: https://codereview.chromium.org/338743002

git-svn-id: svn://svn.chromium.org/blink/trunk@176180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The original CL https://codereview.chromium.org/329183002/ got reverted in
https://codereview.chromium.org/330933002/ as it was causing failures on the
Chromium Linux Tsan v2 bot.

The problem was that std::abs(int) is found in <cstdlib> but we apparently only
include <cmath> everywhere. So the compiler only knows about std::abs(float) and
variants.

There were two ways of fixing this:
1. include <cstdlib> whereever std::abs(int) is used.
2. use abs() as it was done earlier.

Because we already include <cmath> everywhere, and Since C++11, additional
overloads are provided in the header <cmath> for the integral types as well, so
its better to directly just use abs() rather than including an extra header file
This CL uses the second way.

BUG=None

Review URL: https://codereview.chromium.org/333173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This puts the blink heap asm targets in the GN build set and enables
both blink platform test targets behind a single flag. They compile, link
and run successfully on mac but (probably) don't link yet on linux due
to ffmpeg deps.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/332123002

git-svn-id: svn://svn.chromium.org/blink/trunk@176174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Page::willBeDestroyed() detachs any frames remaining in the frame tree,
so there's no need to do this before calling willBeDestroyed().

In addition, since frameDetached() recursively detaches all frames,
eliminate the loop inside Page::willBeDestroyed() to detach all frames.

Review URL: https://codereview.chromium.org/339493002

git-svn-id: svn://svn.chromium.org/blink/trunk@176173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't move uneditable paragraph contents in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary

This patch makes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary
not to move uneditable paragraph contents.

In attached test case, Blink tried to move contents in uneditable ABBR element.

BUG=381076, 383811
TEST=LayoutTests/editing/execCommand/justy-center-with-uneditable-crash.html

Review URL: https://codereview.chromium.org/335773002

git-svn-id: svn://svn.chromium.org/blink/trunk@176172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces Blink specific CSS classes for editing for
  - Apple-interchange-newline
  - Apple-converted-space
  - Apple-paste-as-quotation
  - Apple-style-span
  - Apple-tab-span
These CSS classes are defined in "core/editing/HTMLInterchange.h"

We would like to deprecate these Blink specific CSS classes for browser
compatibility, if possible.

BUG=383677
TEST=n/a

Review URL: https://codereview.chromium.org/327323005

git-svn-id: svn://svn.chromium.org/blink/trunk@176171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Textarea resize-able only to larger; min-height and min-width properly set (https://codereview.chromium.org/239983004/)

Reason for revert:
Regression for RTL textareas.


Original issue's description:
> Textarea resize-able only to larger; min-height and min-width properly set
> 
> Textarea does not respect the min-height and min-width property when they are
> set by user. When textarea min-height and min-width is set by the user and
> if we resize textarea it will only resize to value larger than the width and
> heght of textarea and not with value smaller than it's width and height. It
> assumes width and height as min-width and min height and does not take into
> account the actual min-width and min-height set by user. This patch removes
> this bug by initializing the setMinimumSizeForResizing value with min-width
> and min-height.
> 
> BUG=94583
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173269

BUG=94583,371743
TBR=harpreet.sk@samsung.com, chaffraix@chromium.org

Review URL: https://codereview.chromium.org/336143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will make it possible to get the text surrounding the
current selection by calling WebFrame::selectionRange() and
passing that range to WebSurroundingText.

BUG=330238

Review URL: https://codereview.chromium.org/294073005

git-svn-id: svn://svn.chromium.org/blink/trunk@176168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove useless override of executionContext() in HTMLMediaElement. This was
previously done to remove ambiguity because HTMLMediaElement inherited two
implementations of executionContext() from its base classes (Node and
ActiveDOMObject). This CL gets rid of the override and uses a "using"
statement instead to remove ambiguity, which is the proper way to do this.

The executionContext() override in Node can now be marked as FINAL as a
result.

R=tkent@chromium.org

Review URL: https://codereview.chromium.org/334063002

git-svn-id: svn://svn.chromium.org/blink/trunk@176167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, sigbjornf@opera.com
BUG=384246

Review URL: https://codereview.chromium.org/338533002

git-svn-id: svn://svn.chromium.org/blink/trunk@176166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384857
TBR=tonyg@chromium.org
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/336093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is removing ~250 files that are not required because they are
passing testharness output in an expected file. Adding such file will be
prevented via a PRESUBMIT check, see https://codereview.chromium.org/332583002/

BUG=None

Review URL: https://codereview.chromium.org/328243002

git-svn-id: svn://svn.chromium.org/blink/trunk@176164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CachedUAStyles are large (160b) and not cheap to create because they
include several Length objects which have non-trivial destructors,
making CachedUAStyles expensive to destruct. This patch reduces the
number of CachedUAStyles by only creating them when needed.

There are two changes in this patch:
1) CachedUAStyle& is no longer a member on StyleAdjuster but is
instead passed in through StyleAdjuster::adjustRenderStyle.

2) The cached UA style is now constructed as-needed in
StyleResolverState::cacheUserAgentBorderAndBackground.
StyleResolverState always owned the CachedUAStyle but this patch
makes it explicit by changing the type to OwnPtr<CachedUAStyle>. A
null check was needed in RenderTheme::adjustStyle but otherwise
CachedUAStyle was not accessed without being set.

Before patch:
  facebook.com - 19,850 CachedUAStyles constructed
  wikipedia cat - 22,686 CachedUAStyles constructed

With patch:
  facebook.com - 538 CachedUAStyles constructed
  wikipedia cat - 16 CachedUAStyles constructed

Review URL: https://codereview.chromium.org/338673002

git-svn-id: svn://svn.chromium.org/blink/trunk@176163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With OOPI, the main frame can be either local or remote. Features that depend
on the main frame being local will have to be updated to account for this fact.

This patch takes an aggressive approach--most locations that depend on main
frame being local have been updated to directly attempt to downcast to
LocalFrame, with no attempt to check that the main frame is local first. The
only places that check are those on the critical path towards getting
rendering/input events working with the updated OOPI infrastructure.

BUG=346764

Review URL: https://codereview.chromium.org/336553003

git-svn-id: svn://svn.chromium.org/blink/trunk@176162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also fixes a real bug where we reversed the order of the
type/release/debug columns for the list of failing builders,
but we didn't adjust cellByBuildType or the tests to account
for it. Instead, re-reverse the order. Tests pass, bug fixed.
I'm not sure when this bug got introduced, but its at least
from before the Blink fork, as are most of these other test
failures.

NOTRY=true

Review URL: https://codereview.chromium.org/332073002

git-svn-id: svn://svn.chromium.org/blink/trunk@176161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Traditionally, frame tree mutation has been driven from inside the renderer
itself. However, for out-of-process iframes, the embedder needs to mirror the
same frame tree structure between several different renderers.

BUG=346764

Review URL: https://codereview.chromium.org/334483002

git-svn-id: svn://svn.chromium.org/blink/trunk@176159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the fetch, fileapi, frame and part of html subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/336893002

git-svn-id: svn://svn.chromium.org/blink/trunk@176158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=379012

Review URL: https://codereview.chromium.org/324893002

git-svn-id: svn://svn.chromium.org/blink/trunk@176157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The biggest change is removing RelativeTime. We were creating these,
but not doing anything with them. These were also the only
things that ever called setIndex on Notification, so we can remove
index/setIndex from Notification.

The rest of the patch is just removing dead code.

NOTRY=true

Review URL: https://codereview.chromium.org/336033002

git-svn-id: svn://svn.chromium.org/blink/trunk@176156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the very complicated logic from computeLogicalHeight() and
computeLogicalWidth() whose sole purpose was to use the writing mode of
the child vs the containing block when appropriate. The complexity was
unnecessary and the same result can be achieved by ensuring we use the
child's writing mode when computing the size of the box and the parent's
writing mode when computing the margins for position (e.g. for margin
collapsing).

Review URL: https://codereview.chromium.org/298563002

git-svn-id: svn://svn.chromium.org/blink/trunk@176154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depends on the yasm stuff landing and sticking.

Review URL: https://codereview.chromium.org/336633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We focus the plugin on mousedown/touchstart, so similarly we should
focus it on gesturetapdown.

This fixes IME input on plugins, if a plugin gets gesturetapdown
without any mousedown/touchstart, the plugin will be focused correctly
and input fed to the plugin would work properly.
This could happen if the plugin doesn't have any touch handlers, then
tapping sends gesture event(s) to plugin, without any touchstart.

BUG=383484
Test=Using chrome app webview, which is a plugin.
Enable virutal keyboard in chrome://flags if it's not enabled.
In chromebook pixel: load the sample
browser app
https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/browser
Navigate to a simple page that has <input> element, e.g.
http://jsbin.com/togif/1/
Now without generating any mouse/touchpad inside the content area, tap on the screen on the input box in the jsbin page.
Notice virtual keyboard opening and it is possible to type stuffs into the input box.

Review URL: https://codereview.chromium.org/333813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depending on the inlineBox bidiLevel use the right or left offset.
Do not use bidiLevel of the previous box when attribute is auto.

R=eseidel, leviw
BUG=296847
TEST=TextArea with strong RTL word, when on next line LTR word is
entered, caret position is changed.

Review URL: https://codereview.chromium.org/302433015

git-svn-id: svn://svn.chromium.org/blink/trunk@176151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the process, inline RenderLayerRepainter::setBackingNeedsRepaint's one call site
and remove the method.

BUG=384520

Review URL: https://codereview.chromium.org/337793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Request.method should be ByteString (now supported)
Response.status should be assignable
Response.statusText should be assignable
Response.statusText should be ByteString (now supported)

And added tests for assignable properties/invalid ByteStrings.

R=falken@chromium.org,horo@chromium.org

Review URL: https://codereview.chromium.org/337793003

git-svn-id: svn://svn.chromium.org/blink/trunk@176148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The json mirror is apparently better able to scale to load
and is less dependent on the buildbot master being in
good state.

As part of this, we how have a way of querying the step
information for the last build on a builder, so we can
skip the request and code related to finding out the
build number of the latest run.

Change the masters data structure to store a url name
instead of the whole URL. The url name is the master name
to use for constructing URLs. This way buildershandler
can use the mirror, but builders.js can continue pointing
to the actual master for it's non-json queries.

Also, get rid of the force_update code path in buildershandler.
This seemed like a good idea at the time, but in practice it
just masks errors by making it seem like things are working.
The downside of deleting this is that persistent errors loading
the JSON won't be noticed until the memcache is flushed for
some reason. We should add monitoring of 500s to catch these
things earlier.

Review URL: https://codereview.chromium.org/337433003

git-svn-id: svn://svn.chromium.org/blink/trunk@176147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

readline blocks, so reading stdout, then stderr doesn't make any
sense because we'll block on each on. So if we print only to one
of them, we'll just wait until the process completes.

Also, simplify the readline loop in RebaselineOMatic to just
use readline instead of poll. That way it avoids missing any
output between the last poll and when the process finishes.

Review URL: https://codereview.chromium.org/329873005

git-svn-id: svn://svn.chromium.org/blink/trunk@176146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384565,245025

Review URL: https://codereview.chromium.org/333063004

git-svn-id: svn://svn.chromium.org/blink/trunk@176145 bbb929c8-8fbe-4397-9dbb-9b2b20218538