GitLab

In metadata box of Quick View, we show year recorded metadata in mp3
files in any.
This CL also populates track metadata from the metadata in mp3 if any.
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=636191#c22

BUG=636191
TEST=
1. Download a mp3 file from Google Music.
2. Open the file on Quick View
3. Confirm year recorded metadata is shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2581133002
Cr-Commit-Position: refs/heads/master@{#439440}

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Review-Url: https://codereview.chromium.org/2561983002
Cr-Commit-Position: refs/heads/master@{#439439}

BUG=651041

Review-Url: https://codereview.chromium.org/2576353004
Cr-Commit-Position: refs/heads/master@{#439438}

determineIfLayoutSizeChanged was used by LayoutSVGContainer to let
a subclass, LayoutSVGViewportContainer, update its "layout size
changed" flag. This can be refactored by overriding layout (as
LayoutSVGRoot does) so other subclasses of LayoutSVGContainer are
not confused by this virtual.

With this refactoring it is possible to recalculate the viewport
only when needed (selfNeedsLayout), and move the viewport update
out of calculateLocalTransform.

No measurable perf difference, and no change in behavior.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2587623002
Cr-Commit-Position: refs/heads/master@{#439437}

After crrev.com/2564833002, RenderThreadImpl calls SuspendRenderer() and
ResumeRenderer() unconditionally. This could cause assertion failures
when the renderer isn't backgrounded.  Rather than reverting
crrev.com/2564833002, do early return when not backgrounded because
having multiple flags to check whether a renderer is suspended doesn't
sound a good idea.

BUG=674784

Review-Url: https://codereview.chromium.org/2583083002
Cr-Commit-Position: refs/heads/master@{#439436}

Per https://crrev.com/2536173002, it seems no need to keep
the check at head of WindowProxy::createContext().
http/tests/xsl/xslt-transform-with-javascript-disabled.html
passes with this CL.

BUG=

Review-Url: https://codereview.chromium.org/2586883002
Cr-Commit-Position: refs/heads/master@{#439435}

The feature is planned to be enabled step by step through a server side
configuration. This patch add a field trial flag and plumb it to the
Blink runtime flag to enable it.

BUG=670237

Review-Url: https://codereview.chromium.org/2572063002
Cr-Commit-Position: refs/heads/master@{#439434}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74c24dd2..78033db9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582283002
Cr-Commit-Position: refs/heads/master@{#439433}

EarlGrey is the framework used for integration tests on iOS and the
corresponding test files are by convention named *_egtest.mm.  Add
the pattern to PRESUBMIT.py so that no warning is printed if there
is code calling test functions in those files.

Remove knowledge about KIF test files as this is no longer used.

BUG=666375

Review-Url: https://codereview.chromium.org/2582223002
Cr-Commit-Position: refs/heads/master@{#439432}

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call clearContext
explicitly.

BUG=610176

Review-Url: https://codereview.chromium.org/2588663002
Cr-Commit-Position: refs/heads/master@{#439431}

The spec specifies its own Sensor task source.
https://w3c.github.io/sensors/#the-sensor-interface

BUG=624696

Review-Url: https://codereview.chromium.org/2587733002
Cr-Commit-Position: refs/heads/master@{#439430}

Previously, the folder hierarchy of a file reference in project navigator was
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while
path should be "ios/tool.cc", and they are different.

BUG=614818

Review-Url: https://codereview.chromium.org/2576773002
Cr-Commit-Position: refs/heads/master@{#439429}

The spec specifies its own Presentation task source.
https://w3c.github.io/presentation-api/#common-idioms

This CL assigns it to Presentation API-related tasks.

BUG=624696

Review-Url: https://codereview.chromium.org/2587723002
Cr-Commit-Position: refs/heads/master@{#439428}

This patch adds Bidi reordering to NGInlineNode, using ICU BiDi[1] to
implement rules defined in UAX#9 3.4 Reordering Resolved Levels[2].

The CreateLine() function produces NGTextFragment in the visual order.

This patch also adds a pointer to NGInlineNode and item index range to
NGPhysicalTextFragment.

UAX#9 L1[3] is not supported in this patch. ICU BiDi has a function for
L1, but efficient implementation needs more considerations. This will be
revisited after the line breaker. Note, L1 is not fully supported in
BidiResolver <crbug.com/316409>.

There is only one test case for the Bidi reordering in this patch. We
may run test cases from Unicode[4], or maybe it's overkill. More test
coverage is to be worked out.

[1] http://userguide.icu-project.org/transforms/bidi
[2] http://unicode.org/reports/tr9/#Reordering_Resolved_Levels
[3] http://unicode.org/reports/tr9/#L1
[4] http://www.unicode.org/Public/UNIDATA/

BUG=636993

Review-Url: https://codereview.chromium.org/2563403002
Cr-Commit-Position: refs/heads/master@{#439427}

The base Media elements spec has TaskType::MediaElementEvent as its own task source.
It should be used as the default, unless explicitly overridden by derived specs.
https://html.spec.whatwg.org/multipage/embedded-content.html#media-elements

Both Remote Playback API and Web Audio API also don't override it, so we should use
TaskType::MediaElementEvent here.
https://w3c.github.io/remote-playback/
https://webaudio.github.io/web-audio-api/

BUG=624696

Review-Url: https://codereview.chromium.org/2588603002
Cr-Commit-Position: refs/heads/master@{#439426}

The spec specifies its own DatabaseAccess task source.
https://www.w3.org/TR/webdatabase/#processing-model

BUG=624696

Review-Url: https://codereview.chromium.org/2584263002
Cr-Commit-Position: refs/heads/master@{#439425}

BUG=610176

Review-Url: https://codereview.chromium.org/2581943002
Cr-Commit-Position: refs/heads/master@{#439424}

So we get it from WebLayerTreeView (RenderWidgetCompositor), not from
timeline.

BUG=610763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2559273003
Cr-Commit-Position: refs/heads/master@{#439423}

Add scan mode parameter to choose whether to do content duplication check or just check the import history.

This change will not actually change the behavior of the app but will be used by a following change https://codereview.chromium.org/2569163002/ .

BUG=668574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568723005
Cr-Commit-Position: refs/heads/master@{#439422}

We're replacing DOMWindowProperty with ContextLifecycleObserver.
This CL does the replacement for ScreenOrientationCoontroller.

BUG=610176

Review-Url: https://codereview.chromium.org/2568913003
Cr-Commit-Position: refs/heads/master@{#439421}

These warnings started emerging after:
https://codereview.chromium.org/2535093003

BUG=376039, 667357

Review-Url: https://codereview.chromium.org/2578073002
Cr-Commit-Position: refs/heads/master@{#439420}

TranferBufferManager takes buffers whose backing store might or might
not be SharedMemory, but accumulates shared memory usage no matter what
the buffer is. This CL fixes this to make TranferBufferManager count
shared memory usage only when the buffer's backing store is
SharedMemory.

BUG=604726
TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2575803002
Cr-Commit-Position: refs/heads/master@{#439419}

The test waits twice for communication to and from the compositor.

Sometimes the test times out.

BUG=664857

Review-Url: https://codereview.chromium.org/2587873002
Cr-Commit-Position: refs/heads/master@{#439418}

r368481 added support for force touch to the BaseView and r423419 implemented
dictionary lookup for views::Textfield on MacViews. This CL implements the
method forceTouchEvent: on the BridgedContentView. As a result, force touching
on a views::Textfield now performs dictionary lookup for the word under the
cursor as per the user's system preferences.

BUG=640502
TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some
text in the name textfield. Force touch on one of the words in the text. Verify
that a dictionary popup appears showing the definition of the word under the
cursor.

Review-Url: https://codereview.chromium.org/2587833002
Cr-Commit-Position: refs/heads/master@{#439417}

This event is fired when a web app is "installed" (i.e., a shortcut is
added to home screen).

This implements from the working draft of Web App Manifest:
https://www.w3.org/TR/appmanifest/#onappinstalled-attribute

BUG=621393

Review-Url: https://codereview.chromium.org/2379923002
Cr-Commit-Position: refs/heads/master@{#439416}

https://skia.googlesource.com/skia.git/+log/57845a7264ef..64b70b096ac2

$ git log 57845a726..64b70b096 --date=short --no-merges --format='%ad %ae %s'
2016-12-18 joel.liang Generate Signed Distance Field directly from vector path

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2583053002
Cr-Commit-Position: refs/heads/master@{#439415}

Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled
anyway. This CL assigns it as TaskType::Internal for now rather than
using TaskType::Unspecified.

BUG=624696

Review-Url: https://codereview.chromium.org/2580253002
Cr-Commit-Position: refs/heads/master@{#439414}

Currently supplement objects are reused when an initial empty document navigates to
a same-origin document. This is problematic because ContextLifecycleObservers are
detached when the initial empty document is destroyed. They cannot be used after
the navigation.

To fix the problem, we need to install supplements at every navigation.

BUG=610176

Review-Url: https://codereview.chromium.org/2580753004
Cr-Commit-Position: refs/heads/master@{#439413}

Sheriffs: This patch will likely cause crashes. I'll revert once we
gather enough data.

BUG=485900

Review-Url: https://codereview.chromium.org/2580793004
Cr-Commit-Position: refs/heads/master@{#439412}

Revert of Extend CopyTextureCHROMIUM to more ES 3.0 texture formats. (patchset #27 id:620001 of https://codereview.chromium.org/2479513002/ )

Reason for revert:
Caused crashes in dozens of layout tests.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/21138

Original issue's description:
> Extend CopyTextureCHROMIUM to more ES 3.0 texture formats.
>
> Add support for the following copying techniques:
>
> 1) Using CopyTexImage2D when the source is color-renderable.
>
> 2) Drawing a quad when the destination is color-renderable.
>
> 3) Drawing to an intermediate texture, and copying from that
> intermediate texture to the destination, when neither is
> color-renderable.
>
> Add support for nearly all of the new ES 3.0 texture formats.
>
> Follow-on work remains, including some scenarios described in the bug,
> such as copying to faces of currently-incomplete cube maps.
>
> BUG=612542
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/bcf132827ebd0436fd3620bbda4cbcf3febdc161
> Cr-Commit-Position: refs/heads/master@{#439312}

TBR=kbr@chromium.org,zmo@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612542

Review-Url: https://codereview.chromium.org/2589613002
Cr-Commit-Position: refs/heads/master@{#439411}

When a renderer enters THROTTLED state, we should send a notifications
to V8 so that V8 is aware of memory pressure.

BUG=674815

Review-Url: https://codereview.chromium.org/2577353002
Cr-Commit-Position: refs/heads/master@{#439410}

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2585673002
Cr-Commit-Position: refs/heads/master@{#439409}

https://skia.googlesource.com/skia.git/+log/d4b9c35d9d8c..57845a7264ef

$ git log d4b9c35d9..57845a726 --date=short --no-merges --format='%ad %ae %s'
2016-12-16 fmalita Fix clamp lowbits extraction when combined with non-clamp

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2586143002
Cr-Commit-Position: refs/heads/master@{#439408}

This CL adds 'sm' param to naver's search url.

BUG=

Review-Url: https://codereview.chromium.org/2578953002
Cr-Commit-Position: refs/heads/master@{#439407}

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.

Review-Url: https://codereview.chromium.org/2576353002
Cr-Commit-Position: refs/heads/master@{#439406}

For fast polling the dump provider keeps the /proc/<pid>/statm files
open during the tracing session.

BUG=607533

Review-Url: https://codereview.chromium.org/2568313004
Cr-Commit-Position: refs/heads/master@{#439405}

Instead, use only constructors that take CSSAngleValues, so that the
unit is explicit, then actually store this information.

This is to reflect the spec change that removed these constructors in
https://github.com/w3c/css-houdini-drafts/commit/535591271f88d71fd7ca60dc4132db15f93b980a

Also includes:
- Adding support for making a CSSAngleValue out of a
    CSSPrimitiveValue, to continue supporting getting
    CSSTransform(CSSRotation) from inline StylePropertyMaps.
- Moves some of the inlineStyle CSSRotation tests to use the
    property-suite for more thorough testing. I was not able
    to convert all the tests, as I still have to figure out
    how to test the behaviour when the value is set using the
    old CSSOM to something like "rotateX", "rotateY" and
    "rotateZ".

BUG=545318

Review-Url: https://codereview.chromium.org/2550063002
Cr-Commit-Position: refs/heads/master@{#439404}

Cr-Commit-Position: refs/heads/master@{#439403}

BUG=628016

Review-Url: https://codereview.chromium.org/2583043002
Cr-Commit-Position: refs/heads/master@{#439402}

Move the file manager kRemovableMediaPath constant to a
header so it can be used by tests.

BUG=633243

Review-Url: https://codereview.chromium.org/2582143002
Cr-Commit-Position: refs/heads/master@{#439401}