- 30 Apr, 2018 22 commits
-
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7ce49dfc6b769ad98311b883def83aaa05d9c6ee Reviewed-on: https://chromium-review.googlesource.com/1034456 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554702}
-
Zhongyi Shi authored
Bug: 794688 Change-Id: I051882193473490ecf1ea2cc61dbb1459a3f00ea Reviewed-on: https://chromium-review.googlesource.com/981305Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#554701}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f578e9249f18..64133ee653fb $ git log f578e9249..64133ee65 --date=short --no-merges --format='%ad %ae %s' 2018-04-29 manojgupta Revert "SimpleChrome: Attempt to fix SimpleChromeWorkflow." Created with: roll-dep src/third_party/chromite BUG=chromium:837794 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie329a31141115eba0a1fd11c85395da0e15af347 Reviewed-on: https://chromium-review.googlesource.com/1034452 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554700}
-
Alan Cutter authored
This CL provides guarantees that the close button is in the top right of each window frame. This change fixes a couple of bugs where transitionary layouts didn't meet this assertion. Bug: 832338 Change-Id: I44cc946b80fac8244f4f9b66f2738df837be552d Reviewed-on: https://chromium-review.googlesource.com/1025493 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 4/30 - 5/9) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#554699}
-
Timothy Loh authored
Use views::DISTANCE_RELATED_CONTROL_VERTICAL for the space between the message text and the progress bar, and fix re-layout to happen after updating the message instead of before. Change-Id: Iba4a1d9585dc4135ae13a5122cbec67d89736cf2 Reviewed-on: https://chromium-review.googlesource.com/1034431Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554698}
-
Christopher Lam authored
Bug: 834205 TBR=sky@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b23ae84f287f688b1f0cebd2f278f3580588c8a Reviewed-on: https://chromium-review.googlesource.com/1016223Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#554697}
-
Alan Cutter authored
This change disables the menu item for creating page/PWA shortcuts while in incognito mode. This makes desktop consistent with Android's behaviour. The test added by this CL uncovered a feature list DCHECK hit when calling GetPwaForSecureActiveTab(). This CL cleans up that minor bug as well. Bug: 829716 Change-Id: I5818a280724e65c8af5e0a0c6a1d24a0809c77bb Reviewed-on: https://chromium-review.googlesource.com/1032273Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#554696}
-
Pavel Feldman authored
Change-Id: I9495216a14e15d35fd55894b48a19f616a649213 Reviewed-on: https://chromium-review.googlesource.com/1034196 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554695}
-
Michael Giuffrida authored
TabMetricsLogger logs the TabMetrics UKM event for a background tab. This event includes the state of the tab, as well as some slightly tricky or nullable fields. Add a new TabFeatures struct that contains all this information, and generate the struct in a separate function. The UKM logging function now simply forwards info from the TabFeatures struct to the UKM event. Later we will use the same TabFeatures to calculate tab scores with an ML model. Encapsulating the logic for these features in a single function ensures that we use the same logic for logging as we will for inference. Bug: 784639, 783989 Change-Id: I11e64119ce30465f98409f54f7e97af0251ce4b3 Reviewed-on: https://chromium-review.googlesource.com/1028562 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554694}
-
Patti authored
gfx::VectorIcons currently support being created via CreateVectorIcon() without any size. In this case, a default size is retrieved from the icon's file (provided via a CANVAS_DIMENSIONS directive). However, icons may not always specify a CANVAS_DIMENSIONS, so if the code is provided no size *and* there is no CANVAS_DIMENSIONS, it will fall back to a size of 48. This isn't ideal as it may result in some icons being drawn for a canvas that is too small or too large, so add a DCHECK to prevent this. Bug: 836116 Change-Id: I176d4b5ed7f07fe679a2b70addcce02a09a6b5a3 Reviewed-on: https://chromium-review.googlesource.com/1029556 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#554693}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: Iae9f4b4da15cba41d6dc3605d011b4ec25ec8469 Reviewed-on: https://chromium-review.googlesource.com/1034091 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554692}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I614044e46da6ef7351f9d4a4237a7c63412e4651 Reviewed-on: https://chromium-review.googlesource.com/1034089Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554691}
-
Patti authored
Ink drop colors in touch / newer refresh mode have different alphas to the default, according to the spec. Update them in this patch. Screenshots - https://drive.google.com/file/d/1h4PUbTkNnWvRY5ZRpPRX5Kqp89ll1cOv/view?usp=sharing Bug: 829986 Change-Id: I7b42d09c07f953d1198bdad0f522f52633d2fb57 Reviewed-on: https://chromium-review.googlesource.com/1031630 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554690}
-
Jinsuk Kim authored
AppWebMessagePort is the only implementation of the interface MessagePort. Replaced the direct reference to the class with the interface and added a public helper method |MessagePort.createPair()|. That makes AppWebMessagePort an implementation detail, and exposes only the public interface to embedders. Updated DEPS rules to remove the exception. Bug: 617324 Change-Id: I3f35c2db2436bc3c82a00c07cfede1062d447d29 Reviewed-on: https://chromium-review.googlesource.com/1031690 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554689}
-
Noel Gordon authored
Persistent flake cause affecting all FileManager browser tests is fixed by issue 831074 issue 804413 issue 829310. Intermittent flake cause affecting Providers and other FileManger tests is fixed by crrev.com/554647. Run the Providers test all bots to help confirm issue 668680 is gone. Bug: 668680,836254 Change-Id: Ib2eb38cddd454ae0671929da201c70a157f29308 Reviewed-on: https://chromium-review.googlesource.com/1034418 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#554688}
-
Alexey Baskakov authored
In low disk space scenarios, Cryptohome performs a lot of disk space operations to erase data. This is a number of milliseconds taken to perform a cleanup. Reported only if longer than 5 ms. BUG=835114 Change-Id: I7af2fe673dd01581fa0442a1e26bf08dc2a7f315 Reviewed-on: https://chromium-review.googlesource.com/1032210Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#554687}
-
Euisang Lim authored
1. Remove the links of deleted files - docs/common_build_tasks.md - docs/shift_based_development.md deleted in https://chromium-review.googlesource.com/679054 - docs/subtle_threading_bugs.md deleted in https://chromium-review.googlesource.com/897782 2. Remove Old Chrome OS build instructions and add Chrome OS build instructions in Checking Out and Building - docs/old_chromeos_build_instructions.md renamed in https://chromium-review.googlesource.com/861043 3. Remove the link of an unidentified file - docs/testing/test_browser_ui.md can't find the history of the file. Bug: N/A Change-Id: I4c6d3e6fbe442ad79905c94b94627ad8baf251dd Reviewed-on: https://chromium-review.googlesource.com/1029396 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554686}
-
Noel Gordon authored
MapStringToTargetVolume is only used by AddEntriesMessage: move it to AddEntriesMessage as a static helper. Bug: 833834 Change-Id: Iafcc7f5d2a464987145f8102c2e476ad89484243 Reviewed-on: https://chromium-review.googlesource.com/1034416Reviewed-by:
-
tzik authored
If a ScriptPromiseResolver is requested to resolve in a ScriptForbiddenScope, it delays the resolution. However, as no one retains a reference to the SPR instance, the GC may collect it before the promise is fully resolved. Bug: 831118 Change-Id: Ic8b506d808a7d7cf851e25fe2fb6e7d3aa7464c0 Reviewed-on: https://chromium-review.googlesource.com/1034046Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#554684}
-
Noel Gordon authored
Comment only change. No-Try: true Bug: 833834 Change-Id: I17bfb7a9ba9c9146a1c5496001b368f00a627f55 Reviewed-on: https://chromium-review.googlesource.com/1034414Reviewed-by:
-
kylechar authored
This reverts commit 6f5d66e1. Reason for revert: Test is failing on Windows 7 GPU bots. Original change's description: > Add viz_screenshot_sync_tests. > > Add a new GPU test target that runs screenshot_sync a second time with > --enable-features=VizDisplayCompositor. This test will verify that GPU > compositing is working for OOP-D. The test only runs on Windows and > Linux bots. > > Bug: 812385 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I56de0d01922d1c08521f3fd5aed4f64c148374e3 > Reviewed-on: https://chromium-review.googlesource.com/1028613 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554529} TBR=kbr@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 812385 Change-Id: Icf9c2d398312bebfd7ca5b7d47e2b0876716dd70 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1034392Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#554682}
-
Mohamed Amir Yosef authored
This is required for bookmarks to identify permanent folders such as bookmarks bar. Bug: 516866 Change-Id: If8d763479045c8bb9b9a8368382201bfff1dbe36 Reviewed-on: https://chromium-review.googlesource.com/1032788 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554681}
-
- 29 Apr, 2018 18 commits
-
-
Noel Gordon authored
Tbr: slangley, yamaguchi Bug: 833834 Change-Id: I0b1e1ad58e66e5822449e1d03b8ff7bdd9502df9 Reviewed-on: https://chromium-review.googlesource.com/1034413Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554680}
-
Noel Gordon authored
Move JSON conversion helper definitions into their class so we declare and define them once only (less to read). Document class members. Bug: 833834 Change-Id: Ic60e833271bce822795f63e34956992a51ad7f74 Reviewed-on: https://chromium-review.googlesource.com/1034412Reviewed-by:
-
Rune Lillesveen authored
With [1], user-modify is updated as part of style recalc for the inner editor element, and the inner editor element recalc is triggered from LayoutTextControl::StyleDidChange(). This removes the last mutable style access from LayoutTextControl. [1] https://crrev.com/4ef836ad2e67ce25e263514bcda94f808bfb02d6 Bug: 813068 Change-Id: I923e0081b2bb2a796b512e23a027550c35b045e4 Reviewed-on: https://chromium-review.googlesource.com/1034052Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554678}
-
Darren Shen authored
In a previous patch, we created a dedicated function for reloading the VK without recreating the KeyboardController. This patch replaces all the remaining calls of CreateKeyboard that reload the VK to ReloadKeyboard. Note that some calls to CreateKeyboard are to enable the keyboard, so they will be replaced with a different function later. Bug: 731537 Change-Id: I2cf964d825433fb3fbeb19231e5c5757213a604f Reviewed-on: https://chromium-review.googlesource.com/1031970Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#554677}
-
Noel Gordon authored
Bug: 833834 Change-Id: I261665a70256ba03d838dddfe546dedcfd397865 Reviewed-on: https://chromium-review.googlesource.com/1034044Reviewed-by:
-
Noel Gordon authored
Make helper routine GetTestFilePath internal to class TestVolume and its derived classes, which are its only callers. Also change its name to GetTestDataFilePath() since the file created, or read, must reside in file manager's test data directory. Bug: 833834 Change-Id: I49bc321916c2a2a0fabaa1570c6a47ea890d9568 Reviewed-on: https://chromium-review.googlesource.com/1034047Reviewed-by:
-
Noel Gordon authored
Also change the DownloadsTestVolume Mount() code to match the way other test volumes Mount(). No change in behavior, no new tests. Bug: 833834 Change-Id: Ifc31a5d2157eb605e4d9763c40bde2b0ff367bb7 Reviewed-on: https://chromium-review.googlesource.com/1034045Reviewed-by:
-
Donn Denman authored
Disables testLongPressGestureFollowedByTapDoesntSelect on versions before Android L because those tend to be flaky. This was the case until a recent CL speculatively enabled this test on all platforms. TBR=twellington@chromium.org BUG=837998 Change-Id: I8fe049da497f514bb2c390493fa716992258e23e Reviewed-on: https://chromium-review.googlesource.com/1034285Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#554673}
-
Erik Luo authored
We previously disabled ExecutionContext.p.evaluate() from running with 'timeout' option while paused. Now that it is supported by inspector-protocol, we can allow these evaluations to run. Bug: 810176 Change-Id: Icf81da3d533c719a347f49b3ccd63106e30412c7 Reviewed-on: https://chromium-review.googlesource.com/1033995Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51556bb7. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16442 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=qyearsley No-Export: true Change-Id: I6bb2420dc1b1ce974115c24450c9a65cb506b2aa Reviewed-on: https://chromium-review.googlesource.com/1034082 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554671}
-
Vaclav Brozek authored
This CL addresses comments raised on https://crrev.com/c/1013580 after it landed: * Changing name and the declaration comment of a FormFieldData method to reflect its effect on textarea fields. * Adding some std::vector::reserve calls to avoid extra heap allocations when calling push_back in a loop with known maximal iteration count. Bug: 807623 Change-Id: Ibc9fefbf29676563bbc317e1fd8a0386d245bdd2 Reviewed-on: https://chromium-review.googlesource.com/1032791 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#554670}
-
tzik authored
https://chromium.googlesource.com/chromium/deps/mesa.git/+log/803b11320967..9d9b0710470f $ git log 803b11320..9d9b07104 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 tzik Regenerate chromium_gensrc with newer flex and bison Created with: roll-dep src/third_party/mesa/src BUG=752720 Change-Id: I29ff738aab99fb36f8a89ea0b3732ad5cba29ec0 Reviewed-on: https://chromium-review.googlesource.com/1032132 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554669}
-
https://skia.googlesource.com/skia.git/+log/cccafe8cfd23..efb4d08dd43c $ git log cccafe8cf..efb4d08dd --date=short --no-merges --format='%ad %ae %s' 2018-04-29 skia-recreate-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ib82fbaf0670bc304b9440805d71ad47cac79a063 Reviewed-on: https://chromium-review.googlesource.com/1034280Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554668}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic833a4571a1a43df0ca24a32c3bbaaa0f1560f59 Reviewed-on: https://chromium-review.googlesource.com/1034278 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Xiaohan Wang authored
Previously this was only partially done due to issue 634270. Now that issue has been fixed and we can mark more EME APIs with SecureContext. In the current EME spec, there are 9 APIs marked with SecureContext. This CL makes sure all of them are marked with SecureContext in Blink IDL. Also mark getStatusForPolicy() (not in EME spec yet) with SecureContext. Bug: 692289 Test: Manually tested and verified no MediaKey* exposed in http:// Change-Id: If976d30b3371c4be2bcd33ab61268f21145232a1 Reviewed-on: https://chromium-review.googlesource.com/1030760Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#554666}
-
Kirtika Ruchandani authored
crosreview.com/950683 introduces this enum. BUG=b:35648315 Change-Id: I4f9a7ac56270d20ca60eb08d27a9ae30ff75cf2f Reviewed-on: https://chromium-review.googlesource.com/1027127 Commit-Queue: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by:
-
Samuel Huang authored
CL https://chromium-review.googlesource.com/1028836 adds patch validation to ensure equivalence blocks for element pairs would not span outside the regions for respective elements. The check assumes that equivalences use absolute offsets for entire "old" or "new" archives. This was mistaken (and missed in review), since equivalences in fact use "local" offsets relative to the start of each element. As a result, ensemble patching for Zucchini-apply would mistakenly trigger the check, leading to patch failure. This CL fixes the check. This removes the need for RangeIsInRegion() (now removed), since RangeIsBounded() suffices. Bug: 837096 TBR=grt@chromium.org Change-Id: I2b1e575c4a44f112adebaf1487a41f12cf23f570 Reviewed-on: https://chromium-review.googlesource.com/1034274Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#554664}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Id5ae0d575523bc1deaca09d20088aceefbed3a39 Reviewed-on: https://chromium-review.googlesource.com/1034218Reviewed-by:
-
