- 21 Dec, 2020 40 commits
-
-
Matt Reynolds authored
This CL adds a blocklist to block device functionality that should not be accessible from javascript. The blocklist may be extended by setting the WebHIDBlocklist.blocklist_additions Finch variation parameter. The blocklist may be bypassed by passing allow_protected_reports=true when connecting to the device. Bug: 1093544 Change-Id: I4d04161669f969c2e332c656808ad1bd7774409a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587797Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#838722}
-
Bailey Berro authored
This change adds support for routine cancellation to SystemRoutineController. Routines can be cancelled by closing the RoutineRunner associated with the execution. Test: Unittests, verified manually Bug: 1128204 Change-Id: I9e65d1e1bc14b537445b6520e2fca23f27b88ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559327 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#838721}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a89143c8..ab90f825 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I71207aa42dba54a31a21af9c68e00bbc932f3fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838720}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f541a18c4f3..cb4a68ccf148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: liberato@google.com,juanmihd@google.com Change-Id: Ia2c8d681df0a7d948bb88d8a370a8220dba6903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600012Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838719}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I0ef8b58e08b4872618cd93085462e30b15ff3df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600021Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838718}
-
rajendrant authored
This CL updates the date before which users who have enabled LiteMode will be treated as non-recent users. These users will show a one time infobar when the first page gets compressed. Bug: 1159971 Change-Id: I98b2fed0475a3b79c8e3f698853ad1122d1f355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598464 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#838717}
-
Wenbin Zhang authored
Disabling stories which are consistently failing. Bug: chromium:1160628, chromium:1160630 Change-Id: Iab07e5809159743bd919d5791a09b1423da980c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599340 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838716}
-
Yuheng Huang authored
Remove tab_search_resources.grd since it's no longer needed with auto-generated grd Bug: 1099917 Change-Id: I8a71669432ec21ee0a89ae65c218913ac9620f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599443Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838715}
-
Nico Weber authored
Upstream now requires Py3, so let's see if the bot update to 10.15 happened to fix crbug.com/1037896... Bug: 1160953,1037896 Change-Id: Ib38ee655411c21552521b04e7852e16e5e2515b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595261 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#838714}
-
Hui Yingst authored
The Pepper plugin uses pp::Core::CallOnMainThread() to schedule tasks on the main Pepper thread, while the non-Pepper plugin plans to use base::SingleThreadTaskRunner() instead in the future. This CL adds method ScheduleTaskOnMainThread() to PDFEngine::Client and PaintManager::Client as a wrapper for pp::Core::CallOnMainThread() and base::SingleThreadTaskRunner() calls, so that direct calls of these two functions can be removed in the code shared by the Pepper and the non-Pepper plugin. Bug: 1108517 Change-Id: Ie1103adce2dbcf40ece40f318f7c3159f67e93ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594508 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838713}
-
Jeroen Dhollander authored
This TAST test had become flaky because it uses the beta Libassistant server backend. Bug: 1158005 Test: Tast tests Change-Id: I54d102323cf14e9c5996995d63de4a444aa259a9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595686 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#838712}
-
Joey Arhar authored
For some reason the win7 bot started producing the same baseline as the regular win baseline, so the win7 specific baseline is no longer needed. Fixed: 1160594 Change-Id: Ic63d548dc59cda60bf589c2b13f5b990038b3af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599582Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e98f9539164..8649e49d10e6 2020-12-21 crodbro@webrtc.org Add a field trial to skip REMB modification of BWE internal state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iac3ad384b699851d4fee598eb681b4b4809c7930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838710}
-
Cattalyya Nuengsigkapian authored
- Add a tab slider and update windows shown in Alt-Tab so that "Current desk" mode only display windows in the active desk, while "All desks" display all windows. - Handle special cases: As before, entering Alt-Tab with less than two windows aren't allowed. However, if users switch from the all-desks mode to the current-desk mode resulting in zero or one window, it should show "no recent items" or show a window consecutively. - Hide behind Bento flag and make sure to overwrite kLimitAltTabToActiveDesk in case of conflict, so the old flag works. - Disable remapping Alt+LeftClick to a right click when using Alt-Tab. - Ash unittests for switching between modes and special cases. Bug: 1142726 Test: A manual test (a video in crbug) and unit tests `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.*` Change-Id: Ia203358d0b658529a3090a292ae36850ea60a36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581684Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#838709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4ebcee3eb02f..4e2b6d6b0102 2020-12-21 syoussefi@chromium.org Fix PackedVarying's move constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1159444 Tbr: ynovikov@google.com Change-Id: I5e6538af5209645265299db47bef8500a80a70fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598333Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I687b9b39d97686d5336f376ce0a9762b928bd37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600014Reviewed-by:
-
Thomas Lukaszewicz authored
This CL adds an additional check to ensure the browser returned from tab_strip_->controller()->GetBrowser() is valid before de-referencing it for the is_type_normal() check. This prevents crashes in various unittests where the browser has not been properly instantiated. Bug: None Change-Id: Ic2f1a2d8487d4e7ff5a5a4872fc5a6984faed282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598723 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#838706}
-
mark a. foltz authored
A runtime change to the kMediaRouterEnabled policy (managed preference) results in undefined behavior and crashes. This is a workaround to ensure that MediaRouterEnabled() returns the same value for the lifetime of a profile. Fixing the Media Router to be enabled/disabled dynamically is possible, but will be blocked on extension removal (specifically the MediaRouteProvider mojo interface). Tested by manually enabling/disabling the policy while running Chrome and ensuring no crashes or partially-enabled UI states happen. Bug: 1076831 Change-Id: I966a58196f92be40aed8771282c27f762102da6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597752 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#838705}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608332413-e74bf19c468b4f240b918ee99bd718a9ec1e581b.profdata to chrome-linux-master-1608573074-24f850c78c572e5bf0ca93d4771b7966907fde32.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I429c73efb7ede012bae137d59c5507a03f0c7732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600060Reviewed-by:
-
Megan Jablonski authored
Bug: 1160834 Change-Id: I28260daab4ca6e04c7772413106d80b49eaf5fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600037Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838703}
-
Alexander Surkov authored
NSAccessibility AXSize attribute is identical to dumpacctree size attribute, thus get rid of size attribute. Bug: 1133330 Change-Id: Ib5f16c3335f3c126369bee9e27253fbdf41cee2d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595604Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#838702}
-
Nico Weber authored
TBR=ellyjones Bug: 1149587 Change-Id: Id4c8e205a050ed96c77f6bbaf19edc57e711e785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599799Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#838701}
-
Joel Hockey authored
DataDevice::OnPerformDrop() has a nested RunLoop() and the current object can be destroyed inside that loop. Bug: 1160553, 1160925 Change-Id: I09872e5f88d4d5c3e582ce7b3e6e4085afed0518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598519 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima (slow: gardener) <oshima@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#838700}
-
Xiaoqian Dai authored
Bug: 1160367 Change-Id: If3ebbe49d221e41bd19f495fcadb5881a0252e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600043Reviewed-by:
-
Xida Chen authored
There are a few layout tests under css-backgrounds/ that are flaky and no bug is associated with them. Because they are flaky, the virtual/ version are also flaky. This CL updates the bug number associated with them. Bug: 1160916, 1148369 Change-Id: I842670c047066dd94b6a082e4645249ced8f07bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600019Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838698}
-
Frank Liberato authored
Bug: 1160922 TBR: rsesek Change-Id: I6e1e2868b8dfd3dd2079cf69ea4688b30d5ae2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600039Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#838697}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608551422-fc95b9f468d4d803d74a281f45985087ff3374a0.profdata to chrome-mac-master-1608573074-c037592ba2f8332cc5c933010a8eab8414fcad34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie227d55837e29587450f16b5f524475efb58e277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600056Reviewed-by:
-
Erik Jensen authored
This script, if present, will always be run before the user's configured session. The user's session will start if and only if the pre-session script returns successfully. Change-Id: I1e2fcb427c72cf102bb5e8da8ccf36d8209584c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595791 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#838695}
-
Donn Denman authored
Fixes a bug that caused the SERP to show blank. This was actually due to preloading when that was inappropriate (on a literal tap) when the user had accepted the opt-in. This CL fixes the logic to make sure we have a resolving gesture before we prefetch - server access is gated on the resolve since it's the primary server request. The Cl with the bug is https://crrev.com/c/2557337. BUG=1160041 Change-Id: Ida97ffb037022b039c5d843f770edd2907716836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597886 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#838694}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd212973. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ifc01b8e667be2b8d60c1b2602d02551b652746d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599868Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838693}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608508387-093abbef3f1d2d94b454a0cdd869bb44780245e6.profdata to chrome-win64-master-1608560380-1035bf8a36b405614508f1a548443341a120ef85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0c1c6d9bd7f6453f267de8fd1da9781b407e6020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599825Reviewed-by:
-
Vincent Palatin authored
The cellular code in shill can now configure an Attach APN for the LTE connections by using the data in the Mobile Operators DB. For now, the feature is disabled by default until it is fully baked as extensive testing requires to use it on various carrier network over the world. Bug: b:160812573 b:170367556 Change-Id: I196a2ade76557369c0af6ecb46b048af4266204e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584932 Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838691}
-
Mario Sanchez Prada authored
As agreed on [1], media::mojom::MediaPlayer::SetMediaPlayerObserver() is not the right method to expose in that interface since it should be possible to register more than one observer for MediaPlayer related events outside of the renderer process, so this CL migrates that old method into a new AddMediaPlayerObserver() one. [1] https://crrev.com/c/2526440/21#message-2189f6a0f6328b9cb01e5be9b4fae80ec7e1f080 Bug: 1039252 Change-Id: Ifb55f6c6eb896de02608df98654bc62ff7e7ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595049 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#838690}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e02962c02f81..37fb5ece29fd 2020-12-21 brcui@microsoft.com Fix Pretty-Print Infobar not working If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159531 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a8c716415e4340693419030f627554d5a187994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599487Reviewed-by:
-
Frank Liberato authored
DragAllToSeparateWindow and ...AndCancel were previously disabled for mac-arm-64, but are failing on other macs as well. This turns them off for all macs. Bug: 1160917 Change-Id: Iaba32424b597905c9a7b35a083fe14e9d4d26948 TBR: tbergquist Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600036Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id2454d351edbfc1e975a3afbc4cd6b62aa1ecb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599823Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88883c4ca259..6aea07880248 2020-12-21 reed@google.com Don't use sprite-blit if cubic sampling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Ia06e160fd0065a972f1b241d605cf6bb1c8b7898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599388Reviewed-by:
-
Tarun Bansal authored
Change-Id: Id886d3ef45eb73ca4e9b97174e0183f6fa9457e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576505 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#838685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3974e6736435..7f541a18c4f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156847 Tbr: juanmihd@google.com Change-Id: Ie3f4235d5e680fae833f87915dcc1b4bd5d3d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599826Reviewed-by:
-
Sam Maier authored
This reverts commit 9fc47234. Reason for revert: Stopped renaming GMS_VERSION_NUMBER - won't cause compile errors now Original change's description: > Revert "Reland "GMSCore API availability function for specific versions"" > > This reverts commit 6fb713b3. > > Reason for revert: Renamed GMS_VERSION_NUMBER > > Original change's description: > > Reland "GMSCore API availability function for specific versions" > > > > This reverts commit 0de6ec1b. > > > > Reason for reland: > > > > Original change's description: > > > Revert "GMSCore API availability function for specific versions" > > > > > > This reverts commit 6a6c700a. > > > > > > Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8860631130980203728/+/steps/compile__with_patch_/0/stdout > > > > > > Original change's description: > > > > GMSCore API availability function for specific versions > > > > > > > > Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929 > > > > Commit-Queue: Sam Maier <smaier@chromium.org> > > > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#838236} > > > > > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > > > > > Change-Id: Iac1a894b3d3adaa58c0fcfefd407cd8db82b3e56 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597817 > > > Reviewed-by: Sam Maier <smaier@chromium.org> > > > Commit-Queue: Sam Maier <smaier@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#838253} > > > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Change-Id: I5f677795de16199bf54804a60e8460ae160af4fb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597818 > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838659} > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > Change-Id: I512c518f0c99cbd7cec497943c703d0eb0d6a554 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595844 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838668} TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org Change-Id: I3593475785926da93293fc877c2709d864fb8fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600017Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#838683}
-
