- 09 Sep, 2019 40 commits
-
-
Xida Chen authored
This CL makes a paint worklet that uses a non-registered custom property to be painted on the compositor thread. Bug: 996723 Change-Id: I0d8afce0ba4008a585fcf83184a51782cc51af3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788319Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694742}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/renderer/media/webrtc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to tests that use a ChildProcess (requires full TaskEnvironment) R=sergeyu@chromium.org Bug: 891670 Change-Id: I2b3cffbd2341f0d331f752542534ebcfe8254271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786951 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694741}
-
Martin Šrámek authored
TBR: ntfschr@chromium.org Bug: 1001499 Change-Id: I9bcd4dd17b46485c9ff0ac788438059fcd281a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791153 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694740}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d6b2691bd5d..ee3d995091da git log 4d6b2691bd5d..ee3d995091da --date=short --no-merges --format='%ad %ae %s' 2019-09-09 nisse@webrtc.org New class VideoReceiver2, a trimmed-down vcm::VideoReceiver Created with: gclient setdep -r src/third_party/webrtc@ee3d995091da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ia3e4c3eef45328c551a9781d1e1b0e8e012edf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694739}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/content_settings. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 891670 Change-Id: Icbf7ec34d5cec0751a115c88cddb1e57ad7afa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786746 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Robbie Gibson authored
See the attached bug for a screenshot. Bug: 1002040 Change-Id: I3143aec972fe6cd172ab1de625d51c3e02159d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790884Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694737}
-
Marc-Antoine Ruel authored
Add apks/ChromeModernPublic.aab to the known failure. This should turn 'Deterministic Android' and 'Deterministic Android (dbg)' back green. .aab doesn't have effect at the moment, as --use-isolate-files is currently passed in by the recipe. Add a note about eventually using gn directly. Bug: 972075 Bug: 939984 Change-Id: Iccfbd7cc614fbfab441fa189a7d4eb0c086b97ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649142 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694736}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/base/ime. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=yhanada@chromium.org Bug: 891670 Change-Id: I33f045fb6999ffc600ca04255547512bd81861d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786748 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694735}
-
Julie Jeongeun Kim authored
This CL converts DataPipeGetterPtr to new Mojo types. It also updates traits which uses DataPipeGetterPtr. Bug: 955171, 978694 Change-Id: I947fc8d4ce489f50045e2353db59445792deb6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787659 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694734}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in P2PSocketManager::StartNetworkNotifications function. - Apply pending_remote to the first arguement of StartNetworkNotifications. Bug: 955171 Change-Id: I3d5900c322e40d36383ced855e4b60228e27925b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788419Reviewed-by:
-
Gauthier Ambard authored
Before this CL, the current session was saved when the page was loaded. The page is loaded when the main frame has finished loading its content. When there is a push state event, this callback isn't called. This CL changes it to store the current session when the navigation is finished, which happens when the item is committed. Bug: 998563 Change-Id: Ibc77d38cf4e130477471161d28a4d6cb6c03365f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778483Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#694732}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 714018 Change-Id: I6296434bcb2b82ebca81c06e84b3bd9d56fe40f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778551Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#694731}
-
Miyoung Shin authored
This CL converts BluetoothInternalsHandlerRequest in chrome to the new Mojo type. Bug: 955171 Change-Id: I5a04f8653dbc53022ff52171fc2569a373c5743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788768 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#694730}
-
Lowell Manners authored
With this CL, every time scheduer_tracked_features changes, if the document has become uncacheable, we evict it from the BackForwardCache (if it is in the cache). Change-Id: Ic7a6693344687951c70d0e6d580f3ebb4a272fec Bug: 996267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784601Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694729}
-
Martin Šrámek authored
TBR: liberato@chromium.org Bug: 986021 Change-Id: I30aed42ffdeb612e0b7f3518b8b30026ccc73951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790205Reviewed-by:
-
Gabriel Charette authored
Backport some tests in /services/resource_coordinator/memory_instrumentation to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/resource_coordinator/memory_instrumentation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. TBR=hjd@chromium.org Bug: 891670 Change-Id: I80842200365e9839ec91af4e1550af6e7d976109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786820Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694727}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink::mojom::DWriteFontProxy interface. Bug: 955171, 978694 Change-Id: Ia2fd5c7b65b01bb62fb4d91978e8fb4881131c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#694726}
-
Mikhail Khokhlov authored
This CL adds two methods to ResultsProcessor: for aggregating traces and uploading artifacts. They do (almost) nothing so far, because the corresponding work is done by Telemetry. Implementing full versions of the methods will allow us to gradually transfer the responsibility for these tasks from Telemetry to ResultsProcessor without major refactoring. Bug: 981349 Change-Id: I5b2cb3f55dffe5f12e0e8ec0f3aaa1641e009f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781152 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#694725}
-
Yue Zhang authored
Bug: 1000202 Change-Id: I7a28746d4cb8eb785c96b4bcc51497adebe37ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787891Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694724}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7010f3a19670..e67138c9836d git log 7010f3a19670..e67138c9836d --date=short --no-merges --format='%ad %ae %s' 2019-09-09 lalitm@google.com Merge "Use int64_t in sliced_protobuf_input_stream" Created with: gclient setdep -r src/third_party/perfetto@e67138c9836d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4a59fbdf0a7ef4ae07755cbdd85fac36d3ecb986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792444Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/627d15588f4d..4f2674da4bbc git log 627d15588f4d..4f2674da4bbc --date=short --no-merges --format='%ad %ae %s' 2019-09-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@4f2674da4bbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Iaab7f69a901c4f5fc91cdea4c7c7a1b22177a5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792443Reviewed-by:
-
Mohamed Amir Yosef authored
This CL only introduces the class skeleton with empty implementation. Follow up CLs will gradually provide implementation for the methods of that class. Change-Id: I617c076cf0f5a349361a7f1f910f094ceda7b4ff Bug: 1002000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789156 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#694721}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6e3e0232. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I37aa23fa13ea99fedb1da5e60864e0d7e95cad5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792642Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694720}
-
Jan Wilken Dörrie authored
The HTTP FOAS feature will be rolled out to 100% starting M77. Following the advice in go/finch-best-practices this change enables the feature by default ToT and deletes the Field Trial Testing config. Bug: 914765 Change-Id: Ief6a62c17ebbcc8adf66ff7e1678c3ae02dfc124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789228 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694719}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in DataReductionProxy interface. - Apply pending_remote to DataReductionProxyThrottleConfigObserver argument in AddThrottleConfigObserver. Bug: 955171 Change-Id: I97e09e918f3ef206196d5f856b00a60b9e382650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787762Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
If the user started the browser in incognito mode and triggered a restart in regular mode, the browser was started in the incognito mode. Similarly, if the user started in the regular mode and triggered a restart in the incognito mode, the browser was started in the regular mode. The fix is to find the profile type that invoked the restart. Then use this type to modify old switch arguments which are used to create the new cmd line arguments for restart. Bug: 999085 Change-Id: Ide6e86aabb90b5a333ec10ea23e3add62a3d0e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789582Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#694717}
-
Justin Cohen authored
This reverts commit 063da117. Reason for revert: Test disabled, relanding. Original change's description: > Revert "[ios] Enable SlimNav and dependent features by default." > > This reverts commit 7c516511. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > [ios] Enable SlimNav and dependent features by default. > > > > Tentatively enabling this by default for M79. > > > > Bug: 789582 > > Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694620} > > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > Change-Id: Idb139bf5eed97036ccd2d0f26d331db77786b6e8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789582 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789152 > Reviewed-by: Yi Su <mrsuyi@chromium.org> > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694670} TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org,mrsuyi@chromium.org Change-Id: Ia3470ee5f77a5171af99940b0efa32104cfdb873 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789582, 1001965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791266Reviewed-by:
-
Simon Que authored
CI/try builders migrated: - android-cronet-arm-dbg / android-cronet-arm-dbg - android-cronet-arm-rel / android_cronet - android-cronet-arm64-dbg - android-cronet-arm64-rel - android-cronet-asan-arm-rel - android-cronet-kitkat-arm-rel - android-cronet-lollipop-arm-rel - android-cronet-marshmallow-arm64-perf-rel - android-cronet-marshmallow-arm64-rel - android-cronet-x86-dbg - android-cronet-x86-rel - android-incremental-dbg - android-kitkat-arm-rel / android-kitkat-arm-rel - android-mojo-webview-rel - android-pie-arm64-dbg Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I42b3f0a21846ea4b6d20b46ed9a8850b61f3d24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780083 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8629d82b7f98..f5102cee4165 Created with: gclient setdep -r src-internal@f5102cee4165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I32300e5c13fa051d5cceadeb0ae01dc1a8dc8eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694714}
-
Martin Šrámek authored
TBR: mlamouri@chromium.org Bug: 1001421 Change-Id: I2916cd9443d2b169176036919491bc1c1306f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790104Reviewed-by:
-
Justin Cohen authored
TBR: eugenebut Bug: 789582 Change-Id: I12a1fa41211036bb94b663fae1264e7eacfdbb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790416 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694712}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce when applicable, removes calls to base::AdaptCallbackForRepeating when the returned base:: RepeatingCallback is immediately converted to a base::OnceCallback, and replaces calls to base::Passed with std::move where appropriate. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 714018 Change-Id: Iaf6fd2df7ca796caac734053194b6ee479550b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778777 Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694711}
-
Adam Rice authored
This reverts commit 60617f58. Reason for revert: Reverted because the interfaces have been fixed. Original change's description: > Mark QueueingStrategy methods as not webview exposed. > > These currently aren't being properly exposed in WebView and it's > causing ongoing test failures. Mark them as intentionally not exposed > for now - this can be reverted when the interfaces are fixed. > > Bug: 994324 > Change-Id: If5cf5fcf61ac6d046e913362c684430216528f40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787890 > Auto-Submit: Richard Coles <torne@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693952} TBR=torne@chromium.org,changwan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994324 Change-Id: I9028d57463d12e45f271a6b7bdf844268cc2d000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792411Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#694710}
-
Maksim Ivanov authored
Cancel the whole SAML sign-in flow when the user clicks "Back" in the security token PIN dialog. This allows to avoid the unexpected popup of Network Selection screen to the user after they click the "Back" button. It was happening because, under the hood, terminating the PIN request alone aborts the pending HTTPS connection to the SAML IdP server, which is seen as a generic network error by the Chrome Login code and leads to popping up the Network Selection screen. Also this CL makes the behavior of the Back button more consistent, since it had always been aborting the SAML sign-in before the special case of the security token PIN UI was introduced. Bug: 1001718 Test: start SAML sign-in using a smart card, click "Back" in the PIN dialog, check that no Network Selection screen pops up Change-Id: I6bb9b2e506f7330181ad7a3c560582e3cefd7d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789804Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#694709}
-
Mohamed Amir Yosef authored
This CL introduces PasswordFeatureManager class which will act as a central point for checking which feature is enable. In this CL PasswordGeneration is already migrated to be using the newly introduced class. Follow-up CLs will also include other features here. Change-Id: Iaf52f20b9846ee25ae084079f5a7a6b5dc339633 Bug: 1001122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Ilya Bizyaev authored
This adds a feature flag that will be used in the near future to test experimental functionality for Ansible software management playbook generation from JSON schema. This is intentionally separated in meaning from the CrostiniAnsibleInfrastructure flag, which controls Ansible infrastructure as a whole. Test: compile Bug: 998124 Change-Id: I38fc61a4bf2c717386019ddabe8e9691c3c78be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787552Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Cr-Commit-Position: refs/heads/master@{#694707}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fcd6915ca283..3c6c057c3feb git log fcd6915ca283..3c6c057c3feb --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ulan@chromium.org Handle DevTools target navigation error in WaitForJavaScriptCondition Created with: gclient setdep -r src/third_party/catapult@3c6c057c3feb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:999004 Change-Id: I347fdccebf136663a7b354931bb7bf47f7445475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791900Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/879cafdd9c15..7010f3a19670 git log 879cafdd9c15..7010f3a19670 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 fmayer@google.com Do not pass -Werror on fuzzers. Created with: gclient setdep -r src/third_party/perfetto@7010f3a19670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie56806af8799cbb76ec771e227c52a17ada09728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792562Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4b8f8f4..97a7d404 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0007425e00737757dea4ed585ccabbe0b6c25cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792313Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694704}
-
Julie Jeongeun Kim authored
This CL converts DataPipeGetterRequest to new Mojo types. It also updates Clone from data_pipe_getter.mojom and AsDataPipeGetter from blob.mojom and methods and members which implements them. Bug: 955171, 978694 Change-Id: I7e55369a870ec047c10c52ccca449c94c47744c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787760Reviewed-by:
-
