GitLab

Blink is applying ligature feature when letter spacing is specified which is not correct as per the CSS
specification [1].

With this patch ligature is not applied when letter spacing is specified in CSS.

BUG=382381
TEST=fast/text/font-ligature-letter-spacing.html

1: http://dev.w3.org/csswg/css-text-3/#letter-spacing-property

Review URL: https://codereview.chromium.org/325673002

git-svn-id: svn://svn.chromium.org/blink/trunk@176539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Capture snapshots of File metadata whenever we send a File to IDB.  This way if someone changes a File during a long, slow commit, we won't surprise the user by storing the new version.

Also includes missing error-checking in a test that's sensitive to changes in this area.

See https://codereview.chromium.org/333533002/ for the Chromium code that will check the metadata if you're curious.

BUG=none

Review URL: https://codereview.chromium.org/325383002

git-svn-id: svn://svn.chromium.org/blink/trunk@176538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176243

TBR=hartmanng@chromium.org

Review URL: https://codereview.chromium.org/342553009

git-svn-id: svn://svn.chromium.org/blink/trunk@176537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For out-of-process iframes, we require an alternate limited
functionality DOMWindow to be bound to JavaScript window objects.

Renaming DOMWindow to LocalDOMWindow is allows us to later create a
DOMWindow interface class, that is implemented by LocalDOMWindow and
RemoteDOMWindow.

Discussion:
https://groups.google.com/a/chromium.org/d/msg/site-isolation-dev/BC0vAaxCSuM/ChoG4e_lXEYJ

BUG=346764

Review URL: https://codereview.chromium.org/334283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A follow up fix for spec update: https://github.com/slightlyoff/ServiceWorker/issues/312.

Review URL: https://codereview.chromium.org/340763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per XML Level2 spec, withCredentials flag cannot be set on sync request.
http://xhr.spec.whatwg.org/#the-withcredentials-attribute
However for time being add useCounter and throw console warning to web developers.

Intent to deprecate - https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483

Review URL: https://codereview.chromium.org/329323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Based on the IDLs in the SW spec and now Fetch spec, use
ScalarValueString as appropriate.

Also, add cases to the overload resolution implementation for ByteString
(and ScalarValueString, though the spec hasn't caught up yet).

R=nbarth@chromium.org,haraken@chromium.org,horo@chromium.org
BUG=379009

Review URL: https://codereview.chromium.org/340943002

git-svn-id: svn://svn.chromium.org/blink/trunk@176531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176416

BUG=344873
TBR=habib.virji@samsung.com

Review URL: https://codereview.chromium.org/342943003

git-svn-id: svn://svn.chromium.org/blink/trunk@176530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176361

BUG=384963
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/342983002

git-svn-id: svn://svn.chromium.org/blink/trunk@176529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Restore it since the referred bug is already in the trunk.

BUG=

Review URL: https://codereview.chromium.org/345733003

git-svn-id: svn://svn.chromium.org/blink/trunk@176528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Force full alaiased rendering for the Gulim font as sizes smaller than
12px.

BUG=386400
R=cpu@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/342853003

git-svn-id: svn://svn.chromium.org/blink/trunk@176527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since only the entire buffer is ever reversed, a simpler and more
obvious implementation using WTF::Vector::reverse is possible.

Review URL: https://codereview.chromium.org/348553003

git-svn-id: svn://svn.chromium.org/blink/trunk@176526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org,timvolodine@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/341053002

git-svn-id: svn://svn.chromium.org/blink/trunk@176525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/345593003

git-svn-id: svn://svn.chromium.org/blink/trunk@176524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds async stacks support for the following DOM events:
- audio & video events (play, pause, ratechange, etc.)
- TrackList events: addtrack, removetrack
- MediaSource events (sourceopen and etc.)
- autocomplete and others

BUG=272416
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/335963004

git-svn-id: svn://svn.chromium.org/blink/trunk@176523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no need to do "(m_direction == LTR) ? LTR : RTL".

While here, remove extra parameters from applyFontTransforms.

Review URL: https://codereview.chromium.org/330063005

git-svn-id: svn://svn.chromium.org/blink/trunk@176522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously this was included in many other source files.
For me, this reduces the number of affected build targets from 889 to 93.

Review URL: https://codereview.chromium.org/344873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function should have walked up the containing blocks rather than
the parents. This cl fixes that and removes the useless
ancestorCompositedScrollingLayer.

Note: the layout test here was taken from abarth's patch
https://codereview.chromium.org/340913002/

BUG=None

Review URL: https://codereview.chromium.org/344733003

git-svn-id: svn://svn.chromium.org/blink/trunk@176520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec says that bufferedAmount must not decrease in the task that
send() is called.
Fixed both the new and the old implementation although the old implementaion
is at any rate broken (bufferedAmount in the old implementation includes
the protocol overhead).

BUG=159563

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176298

Review URL: https://codereview.chromium.org/311993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The ScriptPromiseResolverWithContext destructor is checking if it is misused,
but the current code calls ref() and deref(), which are  invalid in the destructor.
This CL replaces the implementation with a simple assertion.

BUG=386479

Review URL: https://codereview.chromium.org/344733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace the include with forward declarations.

Prior to this patch, KeyframeEffectModel.h had roughly 700 targets
depending on it. After this patch this number has shrunk to around 11.
In the last 90 days, KeyframeEffectModel.h was modified 13 times on
trunk, which is a relatively high number.

KeyframeEffectModel.h also pulls in a large amount of other animation
headers so they should see similar benefits.

Review URL: https://codereview.chromium.org/346803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/342163002

git-svn-id: svn://svn.chromium.org/blink/trunk@176515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/345713004

git-svn-id: svn://svn.chromium.org/blink/trunk@176514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383435
TBR=reed@google.com

Review URL: https://codereview.chromium.org/348563002

git-svn-id: svn://svn.chromium.org/blink/trunk@176513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/335103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376039
R=haraken@chromium.org, sigbjornf@opera.com, tyoshino@chromium.org

Review URL: https://codereview.chromium.org/342103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

So we don't need to include WebLockOrientationCallback in places where
we should only include enums.

BUG=162827
NOTRY=true

Review URL: https://codereview.chromium.org/332493003

git-svn-id: svn://svn.chromium.org/blink/trunk@176510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to set offset/scale from DevTools protocol
instead of caluculating them in embedder.

NOTRY=true

Review URL: https://codereview.chromium.org/342953003

git-svn-id: svn://svn.chromium.org/blink/trunk@176509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/338283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [DevTools] Add offset and scale to WebDeviceEmulationParams. (https://codereview.chromium.org/342953003/)

Reason for revert:
Broke compile.

Original issue's description:
> [DevTools] Add offset and scale to WebDeviceEmulationParams.
> 
> This will be used to set offset/scale from DevTools protocol
> instead of caluculating them in embedder.
> 
> BUG=327641
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176506

TBR=pfeldman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=327641

Review URL: https://codereview.chromium.org/342963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to set offset/scale from DevTools protocol
instead of caluculating them in embedder.

BUG=327641
NOTRY=true

Review URL: https://codereview.chromium.org/342953003

git-svn-id: svn://svn.chromium.org/blink/trunk@176506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/333143003

git-svn-id: svn://svn.chromium.org/blink/trunk@176505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WARNING: should be landed after corresponding chromium patch.

BUG=245436

Review URL: https://codereview.chromium.org/342433002

git-svn-id: svn://svn.chromium.org/blink/trunk@176504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

title is a presentation entity and shouldn't be exposed on model record. TimelineUIUtils should be used to retrieve it.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/336183005

git-svn-id: svn://svn.chromium.org/blink/trunk@176503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the ExecutionContext is destroyed, the outstanding request is marked as cancelled.

The corresponding chromium side of this change is https://codereview.chromium.org/341923004/

BUG=375430

Review URL: https://codereview.chromium.org/343723003

git-svn-id: svn://svn.chromium.org/blink/trunk@176502 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clicking on a disabled form control element like a button should not
make it active. This patch adds a check for the disabled element before
setting the activation. This is as per the spec 
http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#selector-active
This matches the behavior on IE. Firefox behavior is same as Chrome.

BUG=385601
TEST=fast/css/disabled-form-control-elements-should-not-be-active.html

Review URL: https://codereview.chromium.org/340143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is needed for removing --enable-service-worker
(https://codereview.chromium.org/339973003/).  Chromium-side currently
returns ErrorTypeDisabled for both "SW is disabled" and "SWContextCore
was destroyed during shutdown" when handling a registration request.
Since the former will no longer happen, add a generic operation aborted
error for the latter.

BUG=365201

Review URL: https://codereview.chromium.org/342863003

git-svn-id: svn://svn.chromium.org/blink/trunk@176500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'fePointLight' and 'feSpotLight' light-source elements for
'fe{Diffuse,Specular}Lighting' defines positions, and in the case of
the latter a 'look-at' point (implicit direction). When an SVG filter is
declared to use primitiveUnits=objectBoundingBox, these positions/points
needs to be mapped to the user-space of the filter.
This is achieved by adding a new method resolve3dPoint() to Filter, and
perform the coordinate space mapping when creating the various
LightSources.
Open-code SVGFELightElement::findLightSource() in it's sources to avoid
passing the Filter-instance around more than necessary.

BUG=176419

Review URL: https://codereview.chromium.org/337903003

git-svn-id: svn://svn.chromium.org/blink/trunk@176499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is preparation for removing the --enable-service-worker flag and
removing the virtual/serviceworker test suite.

BUG=365201

Review URL: https://codereview.chromium.org/338853006

git-svn-id: svn://svn.chromium.org/blink/trunk@176498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |lastEditablePositionBeforePositionInRoot()| to get
to editable |Position| instead of |VisiblePosition| for making
DeletetSelectionCommand to work editable position regardless its visibility.

The root cause of issue 339187 is |DeleteSelectionCommand| shrinks end point of 
selection range, start position is start of "bar", which is hidden editable, 
and end position is "foo", which isn't editable, to editable position but 
|DeleteSelectionCommand| checks both editability and visibility, then it gets 
null position since end point is hidden. 


BUG=339187
TEST=LayoutTests/editing/execCommand/delete-hidden-crash.html

Review URL: https://codereview.chromium.org/340713003

git-svn-id: svn://svn.chromium.org/blink/trunk@176497 bbb929c8-8fbe-4397-9dbb-9b2b20218538