- 05 Nov, 2018 40 commits
-
-
Jordan Demeulenaere authored
This CL replaces ObjectAnimators by ValueAnimators for the progress bar animations, allowing us to remove the properties introduced in http://crrev/c/1312477. Change-Id: I45565b4aa863880e8a16522b9160dc2c8d0c4559 Reviewed-on: https://chromium-review.googlesource.com/c/1314630Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#605290}
-
Andy Paicu authored
When setting the eval flag for a worker context, report only policies were treated as enforcing. Because AllowEval with supress reporting does not take into account the ReportOnly state of the policy because it calls CheckEval directly. AllowEval: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/csp/content_security_policy.cc?g=0&l=603 CheckEval is called here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc?g=0&l=712 Bug: 777076 Change-Id: I80994553037d29c9301aff1ea845386c776c6837 Reviewed-on: https://chromium-review.googlesource.com/c/1301439 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#605289}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c26971222e50..f6ff6ce4e89d Created with: gclient setdep -r src-internal@f6ff6ce4e89d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9e2d162e7a89d009ee15eb455eb8efeb94fa6b75 Reviewed-on: https://chromium-review.googlesource.com/c/1317176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605288}
-
Jordan Demeulenaere authored
Change-Id: I7728cd4d3f8b22027b1461f611271f9358443a75 Reviewed-on: https://chromium-review.googlesource.com/c/1314528 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605287}
-
Kenichi Ishibashi authored
disk_cache::Entry::GetDataSize() can return zero. If the size of side data is zero, it doesn't make sense to try to read side data. Call ReadSideDataCallback with an empty vector when the size is zero. I don't expect this improves performance in general though. Change-Id: I07237a1b41a4b95349a430806122270084f8b55d Reviewed-on: https://chromium-review.googlesource.com/c/1307029Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605286}
-
Niels Möller authored
This is a step towards deleting the rtc::PacketTime class. Bug: webrtc:9584 Change-Id: Iaae4dd05d398fc6ea67d63981277fb84859b5c21 Reviewed-on: https://chromium-review.googlesource.com/c/1313931Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#605285}
-
David Jean authored
When going from bookmarks root to another folder through search (we replace the controller stack) the search bar was at different height (on iOS 11), resulting in a kink in the animation. This solves it by moving to small title before the animation. Bug: 893559 Change-Id: I74424e25ae475ea493a967f49c89eb0d5cc96242 Reviewed-on: https://chromium-review.googlesource.com/c/1304514Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#605284}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5b45ab29f46c7e4a7451b04ea7e7da60173c1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1317358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605283}
-
http://crrev.com/c/1288350Shu Chen authored
Bug: 900124,856135 Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865 Reviewed-on: https://chromium-review.googlesource.com/c/1317010Reviewed-by:
Lan Wei <azurewei@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605282}
-
Yoshisato Yanagisawa authored
Change-Id: I960d10e7c83169918e49bf923c6c32d6ffa1b5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1317111 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605281}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cd3016c5e3b..c26971222e50 Created with: gclient setdep -r src-internal@c26971222e50 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0f5c5410edba3acf070317f4b3bd4684be8171f5 Reviewed-on: https://chromium-review.googlesource.com/c/1317175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605280}
-
Tatsuhisa Yamaguchi authored
Add the full name of current IME as the tooltip and the accessible name for the IME indicator icon. This change also revises the TrayItemView by extending the views::Label class. We are using some text like "US" or "あ" (the first hiragana alphabet of Japanese language) as the icon, but those should not be read literally like a normal label. Bug: 888072 Change-Id: I2295a15f6891731487f17dac29c8b9886b6c0b4b Reviewed-on: https://chromium-review.googlesource.com/c/1317299Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605279}
-
Kunihiko Sakamoto authored
TBR=nhiroki@chromium.org Bug: 901317 Change-Id: I59e6693ea8999835227f9ade7b922e6ec07e09e8 Reviewed-on: https://chromium-review.googlesource.com/c/1316953Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605278}
-
Sara Kato authored
String for dialogs was confirmed by jonann@, add word 'keyboard' to confirmation dialogs already implemented. Bug: 881929 Change-Id: Ibd3d13e95ff5b56eeabbf24ac1e6ba90fcf456a9 Reviewed-on: https://chromium-review.googlesource.com/c/1316951 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605277}
-
Hiroki Nakagawa authored
This is a preparation for adding more tests for postMessage to worker clients. Bug: n/a Change-Id: I9e20b04fd86ad27faaecd7d592cac6dfa5ae16b1 Reviewed-on: https://chromium-review.googlesource.com/c/1317067 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605276}
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Also, this CL simplifies the code that assumes Platform::CurrentThread() or Thread::Scheduler() can return null, which is no longer true. Bug: 826203 Change-Id: I0a59ef17be978d3a4d8b229dc19069aeb0a4c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/1314084Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#605275}
-
Fumitoshi Ukai authored
in chromium.goma, mac goma staging runs on 4 cores mac vm, which runs ninja -40 by default. it would take ~2 hours for full builds (cache misses cases). let's run ninja -j80 to mitigate such cases. Bug: 901699, b/115585306 Change-Id: I1bc637c29cd47c339af1148ed5f7e36dc857021d Reviewed-on: https://chromium-review.googlesource.com/c/1317220Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605274}
-
Yuta Kitamura authored
The virtual function IdleTaskRunner() defined in WebThreadScheduler is not used by anybody except the scheduler internal code, so it should be defined in ThreadSchedulerImpl instead. Along with that function, the header for SingleThreadIdleTaskRunner is moved to scheduler/common, as it's only used in combination with IdleTaskRunner(). SingleThreadIdleTaskRunner uses base::RefCountedThreadSafe which is banned, but this can't be replaced with WTF::ThreadSafeRefCounted, because MainThreadSchedulerImpl having a SingleThreadIdleTaskRunner is instantiated before PartitionAlloc is initialized. The presubmit script is modified so it would allow the usage of base::RefCounted just for this file. Bug: 826203 Change-Id: I2ddcbe9a9a1af6bce5cd87e9d097be86641703fe Reviewed-on: https://chromium-review.googlesource.com/c/1306951 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605273}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a8b4e1acbd6..51916083e752 git log 0a8b4e1acbd6..51916083e752 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@51916083e752 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id7d6b2a118f8616356a7e9dc2baad02cdb98730b Reviewed-on: https://chromium-review.googlesource.com/c/1317174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605272}
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Also, this CL simplifies the code that assumes Thread::Scheduler() can be null, which is no longer true. Bug: 826203 Change-Id: I994db5b3be6e5e0f29cfe346dac15b49ca40394e Reviewed-on: https://chromium-review.googlesource.com/c/1314079Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#605271}
-
Anand K. Mistry authored
BUG=791396,855197 Change-Id: I4e4602e3748247c6bd0d1973c368467e1dc057fc Reviewed-on: https://chromium-review.googlesource.com/c/1309387 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605270}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: Ia19d30eb1b996d3dfda03d8f12e3c227f6f46c60 Reviewed-on: https://chromium-review.googlesource.com/c/1317347Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605269}
-
Kunihiko Sakamoto authored
This reverts commit aa69df1c. Reason for revert: culprit for flakes of - SystemDisplayApiTest.SetDisplay (crbug.com/901586) and - HeadlessBrowserTest.CreateAndDestroyBrowserContext (crbug.com/901637) Original change's description: > Perfetto: Unify TraceEventAgent classes > > This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so > that it's possible to use Perfetto directly even when it's not enabled > as the default TraceLog backend. > > Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService > so they get cleaned up if the service gets shut down. > > Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 > > Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af > Reviewed-on: https://chromium-review.googlesource.com/c/1307998 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605060} TBR=oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901586,901637 Change-Id: I45f18d58e6355722c124ee753de5021e1d965da5 Reviewed-on: https://chromium-review.googlesource.com/c/1317298Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605268}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: I259e29f1fc0423e87983d89ac50794cfb1fb3fca Reviewed-on: https://chromium-review.googlesource.com/c/1317218 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605267}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ad24595..fad38646 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I91b549d0c276abe50b547c96d814f768f35c237a Reviewed-on: https://chromium-review.googlesource.com/c/1317345Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605266}
-
Leon Han authored
This CL removes the typemapping of (blink.mojom.Referrer, blink::Referrer), a follow-up CL will remove the typemapping of (blink.mojom.Referrer, content::Referrer), after that we can move blink/public/platform/referrer.mojom into blink/public/mojom/. BUG=789854 Change-Id: I9acb000e5f64939cd5898954e85f4288e2a88678 Reviewed-on: https://chromium-review.googlesource.com/c/1317344Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#605265}
-
David Tseng authored
List items in Android settings are: 1. clickable 2. have no content description 3. contain text nodes (possibly multiple) Fixes: 1. never consider clickables as containers. ChromeVox has logic to descend into containers. For ordinary list items on the web, we usually want to treat them as containers because list items have arbitrarily nested complex structures (e.g. links, headings inside). 2. fix the computation of list item name. Previously, we only computed the name based on a tree walker that visits and stops descent into leafs or static text. Since clickables themselves are leaves, this stopped the walker from descending into the children of the list item. Bug: b:118842617 Test: manually on ARC++ settings. Regression coverage provided by browser_tests --gtest_filter=ChromeVox*.* Change-Id: I916c2a4187502c19d489e7c78e965523c05f6074 Reviewed-on: https://chromium-review.googlesource.com/c/1316095 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605264}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. CircleFunctions => circle_functions EllipseFunctions => ellipse_functions InsetFunctions => inset_functions PolygonFunctions => polygon_functions BasicShapeInterpolationFunctions => basic_shape_interpolation_functions FilterInterpolationFunctions => filter_interpolation_functions This CL has no behavior changes. Bug: 889726 Change-Id: Ia5e4075c8d48b87a1a536f1d6715be999891a771 Reviewed-on: https://chromium-review.googlesource.com/c/1317416Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#605263}
-
Xiaocheng Hu authored
In some cases, we create anonymous block flow wrappers for float pseudo elements. Such wrappers should be skipped by TextOffsetMapping. Bug: 900906 Change-Id: I7f9ce5906ed8b2daaff3b0c9310e639d932ae5d0 Reviewed-on: https://chromium-review.googlesource.com/c/1315701 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605262}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34b7d6a21843..8cd3016c5e3b Created with: gclient setdep -r src-internal@8cd3016c5e3b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I773875d2b7d7fc4978101646917f6b70255df645 Reviewed-on: https://chromium-review.googlesource.com/c/1317357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605261}
-
Yoshisato Yanagisawa authored
This CL fixes the following warning: W: 133, 2: Unused variable 'version' (unused-variable) Change-Id: I73a3eb3fe40b46196a2fbf014c398bd90e693ced Reviewed-on: https://chromium-review.googlesource.com/c/1317009Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#605260}
-
Takashi Toyoshima authored
This patch factors out allow/block list calculation logic into cors_util so that browser side list management code can reuse the same logic. Also this patch fixes some wrong tests, and refines access list management APIs among network::OriginAccessList, and blink::(Web)SecurityPolicy so that developers are not confused. Bug: 870172 Change-Id: I781b258e2f0ec7ad70065beda0f6eb96923cc690 Reviewed-on: https://chromium-review.googlesource.com/c/1309389Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#605259}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I4482aa852393f4bdc67eaf8b5732f0b58e1974cf Reviewed-on: https://chromium-review.googlesource.com/c/1317211Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605258}
-
Tetsui Ohkubo authored
This CL removes all remaining old SystemTray related code. This is the part 3 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray It's the last CL for this cleanup. TBR=oshima@chromium.org TEST=trybot pass BUG=898419 Change-Id: Ib64a3c31f0d63221f4289b8fe66e39c05ed2d83a Reviewed-on: https://chromium-review.googlesource.com/c/1307354 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605257}
-
Wenzhao Zang authored
Bug: 871412 Change-Id: I5bf054ed6ef4c927253fbad4fe09ec674cc58d39 Reviewed-on: https://chromium-review.googlesource.com/c/1310559Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605256}
-
Matt Falkenhagen authored
All subclasses define their own RequestStillValid() already, so we can make it a pure virtual method. Change-Id: Ic5bf5deb40eb52e6f93733a5770b1e3f1761b91f Reviewed-on: https://chromium-review.googlesource.com/c/1317418Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605255}
-
sangseok.jang authored
InkDrop is handled before View::OnMouseEvent() in OnMouseEvent(). So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()), there is a problem with not getting the something appropriate(ex. Button::STATE) Bug: none Change-Id: I8543a1354197a42478075b941671e5c0e59fc0b7 Reviewed-on: https://chromium-review.googlesource.com/c/1309561Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605254}
-
yoshiki iguchi authored
This CL adds the code to open the message center after unlocking if user clicks the inline reply button on the lock screen. We also need to focus the target notification but let me leave it to the separate CL. Bug: b/79951342 Test: manual Change-Id: I7d47e4064d0a85dc144d2895ae34c85789acf9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1314022Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605253}
-
Leo Zhang authored
Bug: 888885 Change-Id: Ic5b8f4decbfb5508cc52bb7d3f4540d41bcdb185 Reviewed-on: https://chromium-review.googlesource.com/c/1312145 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605252}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: I4ec00babc22db0d0efb96f8481d724e78ee73cca Reviewed-on: https://chromium-review.googlesource.com/c/1313712 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605251}
-