- 04 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1604316477-benchmark-88.0.4312.0-r1 to 88-4296.0-1604316477-benchmark-88.0.4314.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I470eb0f1ba2822e19ada5fca5969520c870aa865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823907}
-
Frank Tang authored
This is a reland of 38e15fd1 Original change's description: > Roll ICU to 68-1 > > See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2511803 > for the actual changes and the details of the data size changes. > > > Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel > > Bug: 1138555,854201,927703 > Change-Id: I8f1b6157f2f1c13c2864836b38e36a37b8c778bf > Binary-Size: 40K ICU increase due to increase version of ICU. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474093 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823458} Bug: 1138555 Bug: 854201 Bug: 927703 Bug: 1145094 Change-Id: I1ba81ab75224a3264da0d50481b48766965efccc Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518034Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823906}
-
Asami Doi authored
When a timeout happens in ServiceWorkerEventQueue, the error status transfers to ServiceWorkerFetchDispatcher::OnFetchEventFinished(), but the callback of an offline capability checker (ServiceWorkerOfflineCapabilityChecker::OnFetchResult) can't catch the error status. This CL set a flag `is_timeout_event_` when the timeout happens and if the flag is set, call DidFail() with the error status instead of DidFinish() which is called in a successful case. Bug: 965802 Change-Id: I9b38c8332f3bfc539d16b0f101143e7af3db66f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437081 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823905}
-
Jérémie Boulic authored
Moving interfaces definitions in files_app_entry_types.js to ui/file_manager/externs/files_app_entry_interfaces.js. This is part of the preparation for the migration of Files app JS code to JS modules. Due to Closure compiler limitations with externs and JS Modules we'll generate modules for some externs files and use as modules instead of externs. This fixes a circular dependency where the implementations in files_app_entry_types.js depend on volume_info.js which depends on these extracted interfaces. BUG=chromium:1133186, b/172300267 Change-Id: If2643c1bc50732c847d0dc99ae19bc4918c5be3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517186Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823904}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e54309477ac..938932225cef 2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 959f41988a18 to 31e28d20f878 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I7688dbe7e92ccec25ab64d29f9b7e5e69f638998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519210Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit eec7bff8. Reason for revert: After this change, JsonSchemaCompilerErrorTest.* are failing on several linux bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95122 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/92709 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21165 Original change's description: > JsonSchemaCompiler: Raise error on parse failures of optional properties. > > Currently when an optional property fails to parse and error generation > is enabled for the schema, the auto-generated Populate function > continues parsing the type but still populates error. This CL changes > the code to ensure that we raise an error in these cases. > > We also don't raise an error on unrecognized keys any longer since we > shouldn't be raising an error while returning a parse success: Most > consumers currently don't distinguish between the two cases and this can > lead to the returned error being a concatenation of unrelated errors, > which is not ideal. > > We now enforce the constraint that Populate only returns an error iff > there is a parse failure. We DCHECK the same in the auto-generated > FromValue function. > > This also brings the code more in-line with what we do for > auto-generated manifest parsing. > > Currently only 3 schemas use error generation: > - declarative_net_request.idl > - extensions_manifest_types.json > - manifest_types.json > > The latter two may be affected by the change. In particular, parsing > manifest types declared by them may lead to a hard error when an > optional property can't be parsed now. > > BUG=1113513 > > Change-Id: I63966389e25f7591b4425815d32d9da59d35c3fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500425 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823545} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org Change-Id: I3b26905381996192b377f79abcde757efaf08f31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519330Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823902}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3980b1f815aa..dc1c1cb562bb 2020-11-04 xinghua.cao@intel.com Restrict to translate uniform block to StructuredBuffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Iaa512627535ccc8f0080b106475f72fa801d797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519154Reviewed-by:
-
Alexey Baskakov authored
This CL introduces no behavior changes. chrome/browser/web_applications/web_app_migration_manager.h must not depend on extensions, only forward declarations are visible. This is a preparation CL to remove web_applications_on_extensions GN node. WebAppProvider will be moved from web_applications_on_extensions to general web_applications GN node. Bug: 1065748 Change-Id: Ic74d8cdc9afe77472d13e27d889375add8e732d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517213Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#823900}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This CL also includes a simplied flow by consolidating TpmAttestationDoesKeyExist and TpmAttestationGetCertificate, of which results come from the same methods of attestation service anyway. BUG=b:158955123 TEST=unit_tests. Change-Id: I36933b4ee20e86fd6946644d957ab70459609482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515801 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823899}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/9RB3jeFjhWq4kvS Bug: 889763 Change-Id: I5393f7e64ecc5251ab31127f9337ebe2b579a417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517402 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823898}
-
Nicholas Hollingum authored
When shutting down the VM we must invalidate the current context. We support that in this CL by unconditionally requesting concierge to shut the vm down (which is fine to do even if the vm is not running). Any queued callbacks are invoked with the new kCancelled status. Bug: b/172006764 Change-Id: I8e9d5817728ede618967392959ec78b6f7d595f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513807 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#823897}
-
Josiah K authored
Bug: 1131153 Change-Id: I959958dbfe5d81cac99bd3f747170fd60921e415 AX-Relnotes: Adds Docked Magnifier support for active-descendant focus-following Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465491 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
Peter Kvitek authored
Having non canonical forward slashes in log file name causes problems with sanbox file name pattern handlign on Windows. Bug: 859676 Change-Id: I8e00eb72db3bd7959b7e8d493fa90c5069727ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518879 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#823895}
-
Alexander Dunaev authored
webui::GetFontFamily() had a Linux-specific piece of logic that was disabled for Ozone because use of pangocairo was not enabled for Ozone. However, since [1] pangocairo is enabled for desktop Linux Ozone platforms. This CL removes the check for Ozone in webui::GetFontFamily(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2366901 Bug: 320050 Change-Id: I2fe8a9cc12db183e5299f953f720c4241cb43cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505752 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823894}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/227d345692cc..6ea2dd438732 2020-11-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9fe71c2142e66baaa2014b3c9a3a855cfaa3644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519152Reviewed-by:
-
Hiroki Nakagawa authored
This CL renames PrerenderTabHelper to NoStatePrefetchTabHelper. See the design doc for the overall plan: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing Bug: 1144577 Change-Id: I5629d556e5a5269da007f1fa32a36d0e2ce48fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516679Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823892}
-
Melissa Zhang authored
This CL adds the sharesheet zero state png. This image will be displayed in the sharesheet when no targets are available. Bug: 1138037 Change-Id: Ie234ccb2d4c884641194d2c7dc80123d96913e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515505 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Tim Song authored
This is a reland of 3dcbf868 BUG=1138137,1106937, 1145157 TBR=yoshiki@chromium.org,khorimoto@chromium.org,isherman@chromium.org Original change's description: > [CrOS PhoneHub] Add notification metrics. > > We add metrics for PhoneHub notification actions by introducing' a new > PHONE_HUB notification type. This way, metrics will be logged into > existing histograms. > > Additionally, this CL also adds a new Ash.PhoneHub.NotificationCount > histogram counting the number of active PhoneHub notifications. > > BUG=1138137,1106937 > > Change-Id: I4529eb6cc0d861ec9eb720e4eeac5c6d2d6257ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505728 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823474} Bug: 1138137 Bug: 1106937 Change-Id: I89dedf4d97ed65aee8330f7251ad20a4c9afe62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518784Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823890}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This CL also includes a simplied flow by consolidating TpmAttestationDoesKeyExist and TpmAttestationGetCertificate, of which results come from the same methods of attestation service anyway. BUG=b:158955123 TEST=unit_tests. Change-Id: Ib1f9de5a6db041e8c3a86c5d90a0f55b8e4d8285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515800 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Matt Menke authored
When PrefetchedSignedExchangeCache encountered subresource integrity failures, it was using an empty NetworkIsolationKey to try and send NEL reports. This CL makes it use the correct NetworkIsolationKey, taken from the ResourceRequest used for the navigation. Fixed: 1144776 Change-Id: I83f6dc1e1e9826071c8367e0ae7af91e68f03287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514363Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#823888}
-
Francois Doray authored
These histograms are not actively used. Most of the time, no tab is discarded in a 10 minutes interval. To assess the impact of future changes to the discarding logic, it would be more useful to report the number of discards and reloads per day. Bug: 1088709 Change-Id: Ia1b2573c154e0b01c9b6d6039a9b2c041db94b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514467Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#823887}
-
Minoru Chikamune authored
For the most part in this CL, existing InterfaceProvider instantiations simply use the default per-thread task runner for no behavior change. However, //content/renderer now binds per-frame interfaces on a per-agent task runner as part of updating the Blink architecture to support MBI. Bug: 1105403 Change-Id: I168ace2f06675a0e7559663a8be3b51cd250e2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498961 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823886}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820Reviewed-by:
-
Leo Lai authored
It is not necessary anymore after attestation's GetKeyInfo is used. BUG=b:158955123 TEST=chromeos_unittests. Change-Id: I4d288c8de7227b94941da116267a3253f4a71439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513950 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Francois Doray authored
Fixed: 1089560 Change-Id: I95a1b7565c9ec244b8cbc5e4a6b11553282c2c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511883Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I06832a1ea00f9a3fa50567d40836c249eb7046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518813Reviewed-by:
-
Kyle Williams authored
Chromebox for Meeting is separated from mainline chromium and this causes slight confusion when updating mojoms. As such update the owners group to dedicated members of the CfM team with a process to approve changes to CfM supplemented by a Meet leads review and chromium launch bug security review. BUG=chromium:1105567 TEST=N/A Change-Id: I6b1d036ab60a439e6ee5a57091e9ea37642ff917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448682 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823881}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: If2a7e175b41c47e004a14eaad9290e11ab937209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519192Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823880}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/af6371f32764..33001e2632db 2020-11-03 tsepez@chromium.org Remove pointer to isolate from CFXJSE_Value 2020-11-03 tsepez@chromium.org Move some more binding logic out of CFXJSE_Value. 2020-11-03 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetDocMDPPermission() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5dede778da26b769032709fd5cd0dc1a4b539cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518645Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbc60b7e9ed2..0e54309477ac 2020-11-03 csmartdalton@google.com Merge GrStrokePatchBuilder into GrStrokeTessellateOp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: If26ce2559bb18d5bca893410fc8857b7ba7d0a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518644Reviewed-by:
-
Aleks Totic authored
This rewrite fixes several bugs: - if no cell's are baseline aligned, baseline should be bottom content edge of non-baseline aligned cells. - if row is empty, and has css block size, its baseline should be top of the row. Interesting incompatibility with FF: FF applies css height only if at least one row is non-empty. I also have exhaustive baseline tests that are not part of this CL. I can add if you'd like: external/wpt/css/css-tables/tentative/baseline-table.html Bug: 958381, 1143297 Change-Id: I5e6fe3d6e96f8da9d5305e4366111ee303918ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515266 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#823877}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59eb5dd0e10d..31e28d20f878 2020-11-04 capn@google.com Switch Chromium/Fuchsia to use the LLVM ORCv2 JIT 2020-11-03 nicolascapens@google.com Clarify the ICD/loader compatibility 2020-11-03 swiftshader.regress@gmail.com Regres: Update test lists @ b5bf8269 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1140854 Tbr: swiftshader-team+autoroll@google.com Change-Id: I1355e52ce61e1892e77fc2eac85754413caf0b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517995Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/39adaeb09df0..3980b1f815aa 2020-11-04 ianelliott@google.com Refactor FrameCapture.cpp to use common utility 2020-11-04 syoussefi@chromium.org Vulkan: Fix use of uninitialized data in staged clears 2020-11-04 geofflang@google.com Revert "Vulkan: Add features to modify sampling parameters" 2020-11-03 courtneygo@google.com Fix presubmit failure with recent glslang update 2020-11-03 jmadill@chromium.org Gold Trace Tests: Handle test filter. 2020-11-03 jmadill@chromium.org Enable writing histogram-set-json-format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1144491 Tbr: courtneygo@google.com Change-Id: I658e05ac0c88bd64665dc11ab328d037222e7bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518719Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibb7f3b7b51e73fe66eea94e9abfbea1dba50e2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518902Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604361545-95869d864c8b2bd48e03f9a16b21429d633a6ea4.profdata to chrome-win32-master-1604415585-a805ae049e5b36d9f91fb3f359143964051762d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I85c6ae79807cd273ce56c4e350dc93c4b7f83290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517706Reviewed-by:
-
Nancy Wang authored
SetAcceptCallback for the pause app dialog only quarantines the callback function is called when the OK button is clicked. When press 'esc' to dismiss the dialog, the callback is not called. For the pause app dialog, the callback function should be called when: 1: the OK button is called 2: 'esc' is pressed to dismiss the dialog, The dialog view needs 2 separate callback functions for Accept and Close cases separately, however, we have 1 callback only. So we don't use the dialog view's function, but create the local closed_callback_ variable, and when the pause app dialog is destroyed, call the closed_callback_, so both the above 2 scenarios can call the callback function. The browser test is modified to test the above 2 scenarios. BUG=1144386 Change-Id: I5dd7accfd4e16fcafb7d019877c648b25d71b881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515864 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#823872}
-
Hiroki Nakagawa authored
This test occasionally times out on Linux and Win bots. Bug: 1145424 Change-Id: I448093d26d39167f2c2653b314d34b36d7ef1d09 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518307Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 1144410, 1144666 Change-Id: I340cdd5d160b926a715f69dd841fcc68dda7d74f Tbr: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5bd41121e18..b8b4d61dd32f 2020-11-04 yuhengh@chromium.org Implement webuiMetric If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099917 Tbr: sadrul@google.com Change-Id: I888eca3b9d394c57660eb72295b9b09867329b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518816Reviewed-by:
-
Dale Curtis authored
Logs exceeding these limits are just dropped on the remote side, so there's no reason to send them in the first place. This removes the UnlimitedSize workaround and fixes a test which was generating a ton of log events due to misconfiguration. R=dcheng, tmathmeyer Bug: 1141985 Change-Id: I178a2214005ca82f1f253bb7d59f43f0a79396a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518208 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
