- 27 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac6e1a61d86e..50d43b33bba6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ksakamoto@google.com Change-Id: I94ae16231ca76e935b42fe861d2960f88ba0b66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500370Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821133}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603756748-18fcc653ee73e42ac2d8e9952f1488ef428e6efa.profdata to chrome-linux-master-1603777504-e29f505cee8cadd0b5b5127539f147bff09e64be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If49203d9ec4dc0e7c804afb0d49c005b8fee11b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821132}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a1dd32df06a5e5617a0c7dcbfbeb5856e9ac439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500374Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I42ecc501c07e92ab813629f335128b2a32422e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500292Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821130}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 1142671 Change-Id: I7c026fe91d2a8333295694d6b9bae1aaf62a0bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501124 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#821129}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4c0d19e3ea95c7345ad419ae0107ac7cac14e5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500368Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 1142671 Change-Id: I7c1c0f559e31d0e828ee8dfdd88fee7933117974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500610 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=battre@chromium.org Bug: 1142671 Change-Id: Ia5607ae4f0bcc78168077ac0a73b8c722473c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500554 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#821126}
-
Gyuyoung Kim authored
This CL replaces all uses of blink::PlatformNotificationActionType with blink::mojom::NotificationActionType in order to reduce type conversion between them. Bug: 919392 Change-Id: I70426fe09f9d42085fa54ffaebf8a0587ca8ca04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498241Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#821125}
-
Yoshifumi Inoue authored
This patch gets rid of unused functions |Line{Start,End}Point()| in |NGInlineCursor| for improving code health. CLs[1][2] made these functions unused. [1] http://crrev.com/c/2467046 Make NGInlineCursor:: PositionForEndOfLine() not to use hit-testing [2] http://crrev.com/c/2497742 Make NGInlineCursor:: PositionForStartOfLine() not to use hit-testing Bug: 1136740 Change-Id: I3032907a738560f0789512be80175cfca2c8e2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500687 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821124}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 1142671 Change-Id: I352bace11acd570ae85530a978cc1b0e6853539c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500575 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821123}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af722073..e641c3d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8a2388099d6a41794e9106b4caf97a38b51aebb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500325Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821122}
-
Rafael Cintron authored
To ease the workload on low end devices, we disable WebGL anti-aliasing on opaque swap chains when the max sample count is 1. Bug: 1141989 Change-Id: Ia3cc6dd031e4c8ffec8096372cdb9aa21759e962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495829 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#821121}
-
Fergal Daly authored
It's almost certainly the view but let's be sure! Bug: 1139104 Change-Id: I8b12739be19d286602ee5770354345bd377c28f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500964 Auto-Submit: Fergal Daly <fergal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4296.0-1603709458-benchmark-88.0.4303.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4304.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I701395e2dbfc8c7ce445978f47972f2142af6a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500874Reviewed-by:
-
Shakti Sahu authored
This CL contains : 1- The list of supported languages weren't updated after a fresh fetch. This CL fixes it. In general, after a fresh network fetch is completed, the next call to the service should return the most updated data, without waiting for a chrome restart. 2- A few minor UX improvements such as increasing close button target area, increasing header text sizes, fixing close button callback for language picker etc. Bug: 1142643 Change-Id: Ie0e2f6345723f1402f57c6095da5ad9b20ee1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500531 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
PaintLayer does one fragmentainer at a time, but we were painting and hit-testing everything in each iteration, leading to DCHECK failures (duplicate paint entries) for painting, and false hit-test matches. Bug: 829028 Change-Id: Iededd014d84b4db9c29e4df6332033b0138da42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490111Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4303.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4304.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4aa127cd9adacf06946f6b7d0080d479191a022d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500373Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: I3f7d51a37c7a4343cb5e5c891992f4a21aa3fef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500615 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821115}
-
Daniel Hosseinian authored
The original tests in PDFExtensionJSTest.AnnotationsFeatureEnabled tested the behaviors of the ink controller, and did not clear the DOM. The new tests, which only test parts of the UI inside the toolbar, clear the DOM, exposing the tests to potential flakiness if any calls are made to the plugin near when the DOM is being cleared. When the DOM is cleared, references to the plugin's members, including the postMessage() function, vanish. Bug: 1136319 Change-Id: I3e6b4dd8c1ef8a23281c100c4a8748d36e642365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478104 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821114}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the StreamPipeOptions dictionary [1] to the ReadableStream class. [1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions Bug: 1093862 Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488329 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#821113}
-
David Munro authored
The max value gets set automatically when we set the ticks on the slider, but if the observer on slider ticks changing fires after the observer on value changing, then the value gets clamped to the old max meaning even if the user has a larger disk, we'll start the slider off at tick 100. To fix this we explicitly set max, to ensure it's set to the right value when the clamping happens. Bug: chromium:1139722 Test: Manual Change-Id: Ic35d84ce17febdf83ae607e12e0288aa669d55aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497720Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#821112}
-
Kunihiko Sakamoto authored
This reverts commit 314e453b. Reason for revert: HoldingSpaceTrayTest.ShowTrayButtonOnFirstUse is crashing on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21023 Original change's description: > Introduce partially initialized holding space items > > Introduces a concept of partially initialized HoldingSpaceItem - this > state will be used when loading items from persistent storage in case > the item file system URL cannot immediately be resolved (e.g. if the > associated mount point hasn't been loaded yet). > HoldingSpacePersistenceDelegate will deserialize persisted items into > partial state when they are first loaded from the storage, and > "finalize" them when their file system URL can be resolved. > > Compared to an alternative approach where items whose initialization has > to be deferred, this approach keeps the order in which items are added > to the model. > > Updates holding space UI not to show partially initialized items. > > BUG=1140150 > > Change-Id: Ie19997ec02f6323434f4053f6ba41a2998e72efa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#821024} TBR=tbarzic@chromium.org,dmblack@google.com Change-Id: Ie916d1b4f15eab360b7124c481105733736c671c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500688Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821111}
-
Daniel Hosseinian authored
Currently an event is fired to the top-level PDFViewerElement to make requests to the plugin for painting thumbnails. Now that the PluginController is a singleton accessible throughout the PDF Viewer's UI code, make the plugin requests directly inside ViewerThumbnailBarElement. Bug: 1134208 Change-Id: I2867effddf43d06b0a6f8cf13fbe2e0881d0e0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494245 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Christopher Lam authored
This is a reland of 43831226 Original change's description: > Use grd generation in the Sample System Web App. > > Bug: None > Change-Id: I4485ddbb595ade6ef078abda2436fa887a0d8b7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489060 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820135} Bug: None Change-Id: I296319fc96965ca36eae58990a3c1018796b8c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497900Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#821109}
-
Trent Apted authored
The PiexLoader module used for loading RAW image types in chrome://media-app returns the JPEG "preview", with an orientation field from the Exif data embedded in the RAW file headers separate. Currently, chrome://media-app ignores this orientation. To fix, "splice" in a minimal Exif header at the front of the returned JPEG data in the RAW loading codepath. Bug: 1030935, b/169717921 Change-Id: Ie5454736078d6ece854318b5f6142d7ee42f187b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500684 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#821108}
-
Hirokazu Honda authored
DynamicFramerate/BitrateChange test cases encodes 600 frames and also validates them. It takes too time that it times out on low end devices. This resolves the failures by setting longer event time out. Bug: b:170790027 Test: video_encode_accelerator_tests crowd-3840x2160 --codec=vp8 Change-Id: I2add724637a42175123a64bb5aeb426a03d8528a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470285Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dce2946f57c..ac6e1a61d86e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1102995,chromium:1129937 Tbr: ksakamoto@google.com Change-Id: I4ca85a31ac76378496272a16e8b55848b3ff12a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500909Reviewed-by:
-
Nicholas Hollingum authored
This is preferred for type-safety reasons. Bug: b/171760827 Change-Id: Ib589b5f16f99097b9d885a5d99a04741945c55ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500645Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#821105}
-
Joel Hockey authored
This change replaces the word "modify" with "access" when the user is asked to confirm that they want to share a folder or google Drive with Crostini. Bug: 1133618 Change-Id: I06b107efaa5f4200a7546c5b1d64754cf07ff047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500464 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#821104}
-
Melissa Zhang authored
This reverts commit 2374eacf. Reason for revert: Punting sharesheet to 89 so flags need to be disabled. Original change's description: > [Sharesheet] Turn on flags to enable sharesheet by default. > > This CL turns on the kIntentHandlingSharing and kSharesheet flags to > enable sharesheet feature by default. > > BUG=1097623 > > Change-Id: Idff4e37934fb730b7f83b86206d555a8c049f12e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460206 > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816071} TBR=dominickn@chromium.org,mxcai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I4d4914ad4ec363c2a63fdaaf7c55163dd1205f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501161Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821103}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1142671 Change-Id: Ic42c517716103f0e8f27bce69e054ab54a5e27f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500210 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#821102}
-
Sophey Dong authored
This reverts commit 6769a912. Reason for revert: Causing crashes (https://crbug.com/1142672) Original change's description: > [ShareCCT] Implement sharing in the toolbar and by default in CCT. > > Bug: 1135311 > Change-Id: I967300591d383a21b9f3f40233422b763180ddb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459403 > Reviewed-by: Tanya Gupta <tgupta@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820029} TBR=agrieve@chromium.org,peconn@chromium.org,tgupta@chromium.org,sophey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135311, 1142672 Change-Id: Id0a3d68fc60893c39eef76c6fa79379dfe8faf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500591Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Auto-Submit: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#821101}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I2f882da7205380ecceb471c6fec553a27e69421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495710 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821100}
-
Dominik Röttsches authored
Issue 996410 shows that this can occur, perhaps due to file corruption or the system being unable to open the file. It's too strict to DCHECK on it. Fixed: 996410 Change-Id: I386afb02b6762b29c7d337646809cccd54133817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498604Reviewed-by:
-
Xiaocheng Hu authored
CompositeEditCommand::MoveParagraphs() serailizes part of the DOM and then re-parse it and insert it at some other place of the document. This is essentially a copy-and-paste, and can be exploited in the same way how copy-and-paste is exploited. So we should also sanitize markup in the function. Bug: 1141350 Change-Id: I25c1dfc61c20b9134b23e057c5a3a0f56c190b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500633 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Kent Tamura authored
... to LayoutNGTextControlSingleLine. This CL has no behavior changes for now, however this CL fixes at least four unit test failures with LayoutNGTextField flag. Bug: 1040826 Change-Id: I9c6677b7de9d595602caa312678856d79ffb94d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501103 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I8dde09f28cee1c1390f32ebf9ec200d9ecd8f4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492740 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821096}
-
Melissa Zhang authored
This reverts commit efbf947b. Reason for revert: Reverting because we are disabling sharesheet flags by default. Original change's description: > [Sharesheet] Run file manager browser tests with sharesheet enable. > > This CL updates the option.enable_sharesheet default value to be true to > run all tests with sharesheet enabled. This is because we turn on the > sharesheet flags by default. > > BUG=1097623 > > Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816074} TBR=lucmult@chromium.org,mxcai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I48580601e1287ae27b3c8be32e199963b8cdc713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501164Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 77307244. Reason for revert: collected crash dumps so we can turn it back to DCHECK Original change's description: > [PartitionAlloc] Temporarily use CHECK in SetFreelistHead > > Temporarily use CHECK in SetFreelistHead to debug a crash. > Should be reverted after a Canary release. > > Bug: 1137799 > Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724 > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819797} TBR=yukishiino@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137799 Change-Id: I645119e34f6767b9e6a6d1fc739efb0e2c85aff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500387Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
