Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Apr, 2018 37 commits
  3. 19 Apr, 2018 3 commits
    • Jinsuk Kim's avatar
      Adds a reference to web contents/container view in Tab class · a69c5403
      Jinsuk Kim authored 
      This is a preparatory CL for upcoming changes that will remove API
getWebContents/getContainerView from ContentViewCore. Tab defines
direct references to WebContents and container view. WebContents is
passed to |initialize| and ContentView is created as the container
view in |createContentViewCore|, so it doesn't need to access them
indirectly through CVC. They are set in |setContentViewCore| and
nulled out in |destroyContentViewCore| to keep their validity in sync.

Accompanying changes for cleanup:

- Deleted |getActiveContentViewCore|. Other method of similar name
  |getContentViewCore| returns null if Tab is showing native view or
  rendered content is already destroyed. So using it instead is
  enough for all the callsites that already have null checks or tests
  that know all the preconditions.

- |getContentView| always returns container view for non-native page.
  In fact it is what it was already doing - just made it clearer by
  removing some dead code in it. Its return type is ViewGroup, and
  will be used as a replacement for CVC.getContainerView() in other classes.

Bug: 598880
Change-Id: I0c5966b69f6871ce53aa5ffadb73a76214ad35b2
Reviewed-on: https://chromium-review.googlesource.com/1018561Reviewed-by: default avatarYash Malik <ymalik@chromium.org>
Reviewed-by: default avatarMaria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552206}
      a69c5403
    • Sergey Ulanov's avatar
      Fix documentation in callback.h · 3947bb6e
      Sergey Ulanov authored 
      Comments in callback.h were confusing because sample code was
incorrect. Updated sample code to make it consistent with the
documented behavior.

Change-Id: Id42a9465c49b65937d7b34bf8c0b3664085a628f
Reviewed-on: https://chromium-review.googlesource.com/1019870Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552205}
      3947bb6e
    • Saman Sami's avatar
      Remove RenderWidgetHostLatencyTracker::OnSwapCompositorFrame · 478e85a9
      Saman Sami authored 
      This method adds the right component id to snapshot-related latency
info, We can just send the right component id to the renderer so that
a correction browser-side is not necessary.

Test: Lots of pixel tests take screenshots. Also tested
Page.captureScreenshot manually.

Bug: 810037, 775030
Change-Id: I61242ad63c5af8975331cb405fc629ce19ef92f8
Reviewed-on: https://chromium-review.googlesource.com/1019389
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552204}
      478e85a9