- 03 Jul, 2018 40 commits
-
-
Alex Newcomer authored
NOTIFICATION_CONTAINER is a container MenuItemView which is added and removed to an app context menu as notifications for the app come and go. The container is added to the tree of MenuItemViews by adding it to the menu's SimpleMenuModel. The bug is that the container MenuItemView for NOTIFICATION_CONTAINER is not enabled when added. The root cause is that when the NOTIFICATION_CONTAINER is added, it is not addd to |menu_items_|(same name for both classes modified). I originally tried to ensure that items added to the SimpleMenuModel were also added to |menu_items_|, but when adding an item to |menu_items_| in ash/public/cpp/menu_utils.h, we check |delegate_|->IsCommandIdEnabled(), which requires that the item is in |menu_items_|. This means that new items are disabled. This is because |menu_items_| was designed to be built once, and not modified. This fix works because we don't need to check |menu_items_| anyways because NOTIFICATION_CONTAINER is always enabled. Fixing |menu_items_| so that it holds all items that SimpleMenuModel holds would be ideal, but its current behavior is only a problem in the NOTIFICATION_CONTAINER edge case. Bug: 857565 Change-Id: I1ec1d6db20b1ba45d0a772eb2ec7ab3ec0498c06 Reviewed-on: https://chromium-review.googlesource.com/1119057 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572215}
-
Kyle Milka authored
Add study to test new NTP features on ToT. Disable these features for old tests. Bug: None Change-Id: Ie706c56263f232fc1f0dd4e7c9ae03909b77a935 Reviewed-on: https://chromium-review.googlesource.com/1111009Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572214}
-
Kyle Milka authored
Latest UI/UX decision is to revert to the previous size for the mic icon. Bug: 859383 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I147a11890112dbc78063254693cbe6bb31bc34b1 Reviewed-on: https://chromium-review.googlesource.com/1122971Reviewed-by:
-
A Olsen authored
Store enough metadata in policy_constants.cc that we can use it to decode policies, and so don't need to generate any more code in cloud_policy_generated.cc The metadata required to decode a policy from a proto is the key, the type (both the raw type ie integer or string, and also whether it is JSON or external), and pointers to both has_policyproto() and policyproto() functions, where policyproto is the message field that holds this policy. The metadata that is stored in policy_constants.cc looks like so - the lines starting with &em are function pointers into the CloudPolicySettings proto: constexpr BooleanPolicyAccess kBooleanPolicyAccess[] = { {key::kAbusiveExperienceInterventionEnforce, &em::CloudPolicySettings::has_abusiveexperienceinterventionenforce, &em::CloudPolicySettings::abusiveexperienceinterventionenforce}, {key::kAllowCrossOriginAuthPrompt, &em::CloudPolicySettings::has_allowcrossoriginauthprompt, &em::CloudPolicySettings::allowcrossoriginauthprompt}, ... {nullptr, nullptr, nullptr}, }; constexpr IntegerPolicyAccess kIntegerPolicyAccess[] = { {key::kAdsSettingForIntrusiveAdsSites, &em::CloudPolicySettings::has_adssettingforintrusiveadssites, &em::CloudPolicySettings::adssettingforintrusiveadssites}, {key::kArcBackupRestoreServiceEnabled, &em::CloudPolicySettings::has_arcbackuprestoreserviceenabled, &em::CloudPolicySettings::arcbackuprestoreserviceenabled}, ... {nullptr, nullptr, nullptr}, }; constexpr StringPolicyAccess kStringPolicyAccess[] = { {key::kAllowedDomainsForApps, &em::CloudPolicySettings::has_alloweddomainsforapps, &em::CloudPolicySettings::alloweddomainsforapps, StringPolicyType::STRING}, {key::kContentPackManualBehaviorHosts, &em::CloudPolicySettings::has_contentpackmanualbehaviorhosts, &em::CloudPolicySettings::contentpackmanualbehaviorhosts, StringPolicyType::JSON}, {key::kNativePrintersBulkConfiguration, &em::CloudPolicySettings::has_nativeprintersbulkconfiguration, &em::CloudPolicySettings::nativeprintersbulkconfiguration, StringPolicyType::EXTERNAL}, ... {nullptr, nullptr, nullptr}, }; constexpr StringListPolicyAccess kStringListPolicyAccess[] = { {key::kAllowedInputMethods, &em::CloudPolicySettings::has_allowedinputmethods, &em::CloudPolicySettings::allowedinputmethods}, ... {nullptr, nullptr, nullptr}, }; Bug: 852366 Change-Id: I1b8a0ebc0c6d5019e63d81a4cb7e1cd1cb461bb3 Reviewed-on: https://chromium-review.googlesource.com/1110219 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#572212}
-
Guohui Deng authored
Chromecast needs to know which application session certain CastRenderer/CmaBackend is created for (see b/79265398). In order to establish the association between the application session and the CastRenderer, we need to pass a std::string type |application_session_id| into the CastRenderer initialization process. This CL adds a |host_interfaces_| member in CastRenderer and an ApplicationSessionIdManager service that's attached to RenderFrameHost. During Initialization process, the CastRenderer uses |host_interfaces_| to obtain the ApplicationSessionIdManager service and then retrives the corresponding |applicationSessionId| from such service. Bug:internal b/79265398 Test: 1. verified a special case (LocalAudioRenderer) is not broken. 2. cherry-picked into internal Chromecast and verified real ID arrived at CastRenderer. Change-Id: Ief94a532dbdc346516333e981c8f445efb3a4333 Reviewed-on: https://chromium-review.googlesource.com/1117840 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#572211}
-
Emily Hanley authored
Bug:859073 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I338021866a0a7c975d25198b194999f2c2f3f45a NOTRY=true # obbs_fyi failure are flakes Change-Id: I338021866a0a7c975d25198b194999f2c2f3f45a Reviewed-on: https://chromium-review.googlesource.com/1124380 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572210}
-
Robert Liao authored
We will not be shipping MacViews without Material Refresh. BUG=857573 Change-Id: I8692fad1e7f56b51c7fc9913a1023db2722d9d39 Reviewed-on: https://chromium-review.googlesource.com/1119367 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572209}
-
Keishi Hattori authored
Calls UpdateIncrementalMarkingStepDuration() every time we allocate a new page. UpdateIncrementalMarkingStepDuration() will check if the estimated time left is increasing (i.e. marking speed is not keeping up with allocations). If so it will double the step size. Also increases default duration from 1ms to 2ms. Bug: 757440 Change-Id: Icf262a4b851fd730698e6b09384c5c181c671de2 Reviewed-on: https://chromium-review.googlesource.com/1105695 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572208}
-
Miguel Casas authored
This CL introduces a new MediaRecorderHandler::ActualMimeType() method that produces the mimeType used for recording by MRHandler. This method is then called from Blink's MediaRecorder when the user has specified no mime type for recording, so the output Blobs can have the correct type. Bug: 859199 Change-Id: I941f46a2ef495f5ac68995f79319fe6f07836a89 Reviewed-on: https://chromium-review.googlesource.com/1121141Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#572207}
-
Lei Zhang authored
It is reachable when form submission fails. Change-Id: If6e6e7358f945c290c84d96b4563ba3c76470fa8 Reviewed-on: https://chromium-review.googlesource.com/1121634 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#572206}
-
Jochen Eisinger authored
Otherwise, the renderer will turn cross-origin downloads into navigations BUG=857441 R=asanka@chromium.org Change-Id: I7a584951d794d22a6c417d06bd80d6de0db53236 Reviewed-on: https://chromium-review.googlesource.com/1120818 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572205}
-
Robert Liao authored
Hiding the Layer can also trigger a paint request. This causes the following omnibox interactive_ui_tests to fail with material refresh: OmniboxViewTest.PreserveDisplayTextOnFocusSearch OmniboxApiTest.ExtensionSuggestionsOnlyInKeywordMode OmniboxViewTest.Paste OmniboxViewTest.BackspaceInKeywordMode OmniboxViewTest.UndoRedo * thread #1, name = 'CrBrowserMain', queue = 'com.apple.main-thread' * frame #0: libcc.dylib`cc::SchedulerStateMachine::SetNeedsBeginMainFrame(this) at scheduler_state_machine.cc:1279 frame #1: libcc.dylib`cc::Scheduler::SetNeedsBeginMainFrame(this) at scheduler.cc:116 frame #2: libcc.dylib`cc::SingleThreadProxy::SetNeedsCommit(this) at single_thread_proxy.cc:244 frame #3: libcc.dylib`cc::LayerTreeHost::SetNeedsCommit(this) at layer_tree_host.cc:536 frame #4: libcc.dylib`cc::Layer::SetNeedsCommit(this) at layer.cc:166 frame #5: libcc.dylib`cc::Layer::SetHideLayerAndSubtree(this, hide=true) at layer.cc:1085 frame #6: libcompositor.dylib`ui::Layer::SetVisibilityFromAnimation(this, visible=false, reason=NOT_FROM_ANIMATION) at layer.cc:1164 frame #7: libcompositor.dylib`ui::LayerAnimator::SetVisibility(this, value=false) at layer_animator.cc:115 frame #8: libcompositor.dylib`ui::Layer::SetVisible(this, visible=false) at layer.cc:537 frame #9: libviews.dylib`views::BridgedNativeWidget::OnVisibilityChanged(this) at bridged_native_widget.mm:796 (lldb) frame select 9 (lldb) print this->window_visible_ (bool) $0 = false BUG=858864 Change-Id: I07014b36e289ecc942e25a2e789517ef76fd5a1b Reviewed-on: https://chromium-review.googlesource.com/1121324Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572204}
-
Calder Kitagawa authored
Adds a fuzzer for disassembly of DEX files. This achieves ~7500 exec/s and covers 97% of files of interest in 10000 runs. The bulk of the uncovered code is writers which require a patch file and this is more complex and expensive to fuzz so like the Windows Disassembler we will hold off on fuzzing this for now. The source seed for fuzzing is the WebAPK shell app and is uploaded to the Fuzzing GCS bucket as it is on the larger side. See: zucchini_disassembler_dex_fuzzer_static Bug: 835341 Change-Id: I40651286b571964b719ca61074d5e35934e88189 Reviewed-on: https://chromium-review.googlesource.com/1117123 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#572203}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91a410dd..fe51067f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1b51030ec91071ca361d20e3bc80a24790e030a5 Reviewed-on: https://chromium-review.googlesource.com/1124402Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572202}
-
Calder Kitagawa authored
Adds a fuzzer for the ImposedEnsembleMatcher. This achieves between 5000 and 10000 exec/s. At 10000 runs this covers 96% of the imposed_ensemble_matcher and 50% of the io_utils (another file lacking coverage). Uncovered lines in io_utils are attributed to debug tools. The missing lines in imposed_ensemble_matcher are error cases which haven't been hit yet. The seed uses duplicated back to back copies of old.ztf and new.ztf. Bug: 835341 Change-Id: I742ca6f4c409c9a9ec4a335da2b50fd8d4d6ed6f Reviewed-on: https://chromium-review.googlesource.com/1117572 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572201}
-
Chris Harrelson authored
SVG content can't fragment (see LayoutFlowThread::LocateFlowThreadContainingBlockOf) but since it is painted as a replaced-normal-flow stacking context, multiple calls into its paint can happen anyway. Bug: 859586 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ied0b869d37373499e6a784dee8bd620d7b535fa9 Reviewed-on: https://chromium-review.googlesource.com/1123765Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572200}
-
Mathieu Perreault authored
Priority is now: - Local favicons - Server favicons - Letter fallback (circle + drawn letter) Bug: 856852 Change-Id: I45d5daae4ee3734a12018c01307c32c2e4047a59 Reviewed-on: https://chromium-review.googlesource.com/1116869 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#572199}
-
Boris Sazonov authored
Failed builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-marshmallow-arm64-rel/6078 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-marshmallow-arm64-rel/6077 TBR=jianli@chromium.org Bug: 859849 Change-Id: I7553ec7a757a88bb4202b62e15d2293b331f96b4 Reviewed-on: https://chromium-review.googlesource.com/1124563 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#572198}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a8eb1e619eb9..46f858a626d5 git log a8eb1e619eb9..46f858a626d5 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 saza@webrtc.org Fix fuzzer-found overflow in AGC1 Created with: gclient setdep -r src/third_party/webrtc@46f858a626d5 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:858989 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7ea35823c1825b0742baa259ae6e6bb84a0959b8 Reviewed-on: https://chromium-review.googlesource.com/1124420Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572197}
-
Jan Wilken Doerrie authored
This change adds jdoerrie@ as an OWNER for //components/password_manager and //chrome/browser/password_manager. Bug: NONE Change-Id: Ifdda569548233120284c99fd91259071bd777b9e Reviewed-on: https://chromium-review.googlesource.com/1124679 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572196}
-
Hans Wennborg authored
These were created following the instructions from https://chromium.googlesource.com/chromium/src/+/master/docs/win_order_files.md using Chromium #572176. Bug: none Change-Id: Iedd2bfb6455ba32f37e26f7745b11adbd98b57c1 Reviewed-on: https://chromium-review.googlesource.com/1124473 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#572195}
-
Takuto Ikuta authored
AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed. This will be affective for some jar related actions. (e.g. mojo/protobuf generator for java) Bug: 810298 Change-Id: If7b5dd4405214164818b18e49642fb29147667c8 Reviewed-on: https://chromium-review.googlesource.com/1123970Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572194}
-
Peter E Conn authored
This reverts commit e83d1f12. Reason for revert: https://crbug.com/857437 Essentially, as well as adding if statements to all usages of mMenuButton within the class, you need to add if statements to all other classes calling 'getMenuButton()' (and ToolbarManager.getMenuButton() transitively). Unfortunately this isn't so trivial for all the cases (eg, I'm guessing we still want to show the data saver when this feature is enabled, or the download text bubble?), so I'm reverting instead of attempting and TBRing a fix myself. Sorry! Original change's description: > Don't show top toolbar items when bottom toolbar is enabled > > Remove the top toolbar buttons (home, tab switcher, and menu buttons) > from their parent view and set them to null. Also add a bunch of > null checks since now things can be null. > > Bug: 852117 > Change-Id: I620f35f81388d1f4ac8791a9eb45576566474604 > Reviewed-on: https://chromium-review.googlesource.com/1105569 > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570578} TBR=tedchoc@chromium.org,amaralp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852117 Change-Id: I2c16533f8dec11c5d11b920693157735e7438e89 Reviewed-on: https://chromium-review.googlesource.com/1124579 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#572193}
-
Takuto Ikuta authored
AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed. Bug: 810298 Change-Id: I25fd08b2fb4eed98d25bdaf04437e85236391667 Reviewed-on: https://chromium-review.googlesource.com/1124136Reviewed-by:
-
Takuto Ikuta authored
AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed. Bug: 810298 Change-Id: I4308ffb0c53325f3e4375ef85e7a8a302a8aac7b Reviewed-on: https://chromium-review.googlesource.com/1124126 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
LayoutImageResource::GetImage expects a zoomed container size (it passes it unmodified to SVGImageForContainer::Create which unzooms it), so we need to scale the viewport size before passing it. Bug: 859774 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I24f7f0b1f402aaef112882ab146d573981889cae Reviewed-on: https://chromium-review.googlesource.com/1124163Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#572190}
-
Olga Sharonova authored
This is a reland of c0d56727 The fix helps only on Mac and Linux. Original change's description: > Fix fake audio setup in WebRTC audio perf tests. > > Change them to set up switches::kUseFileForFakeAudioCapture in > SetUpCommandLine(), so that it can be propagated to the audio process. > > Bug: 850936 > Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566 > Reviewed-on: https://chromium-review.googlesource.com/1122857 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572142} Bug: 850936 Change-Id: Ida4f3b888bc0332b68050d6b1cb8a0d5fef3cf32 Reviewed-on: https://chromium-review.googlesource.com/1124519Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#572189}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/957e7756634..2cb075fe26 Contains a fix for Khmer shaping. Bug: 847034 Change-Id: I0ac1fdf4df69e5c5dd3cc8a877809db99ce40fda Reviewed-on: https://chromium-review.googlesource.com/1123826Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#572188}
-
nednguyen authored
Bug:chromium:818319 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I3a7b020744e9fa4ce73ef890ff744da1d0563327 NOTRY=true # test by PRESUBMIT Change-Id: I3a7b020744e9fa4ce73ef890ff744da1d0563327 Reviewed-on: https://chromium-review.googlesource.com/1124408Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572187}
-
Findit authored
This reverts commit deb4b5a5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 572182 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RlYjRiNWE1ZjQwMzllMDhkNWE1ZDMxZDVmN2NhMTQzN2I2OGE1ZmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/68083 Sample Failed Step: compile Original change's description: > Reland "[scheduler] Add a perftest to measure basic scheduling costs." > > This is a reland of 586e21ec > > TBR=skyostil@chromium.org > > Original change's description: > > [scheduler] Add a perftest to measure basic scheduling costs. > > > > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452 > > Reviewed-on: https://chromium-review.googlesource.com/1085295 > > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#566362} > > Reviewed-on: https://chromium-review.googlesource.com/1097295 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#567645} > Change-Id: Ia52d89c4321cf4a6d00c51f83ee5b52ea06769de > Reviewed-on: https://chromium-review.googlesource.com/1122980 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572182} Change-Id: Ia1c1d4413878bb5101cd696412e630ff3c90b343 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1124540 Cr-Commit-Position: refs/heads/master@{#572186}
-
Colin Blundell authored
This CL adds APIs to IdentityManager for obtaining the set of all accounts with refresh tokens and querying whether the primary account is available with a refresh token. The design follows that of IdentityManager's caching of the primary account information: - IdentityManager initializes its state with the current state of ProfileOAuth2TokenService. - IdentityManager updates this state in response to notifications from PO2TS that an account's refresh token was updated/removed. This CL is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1098668 with the following addition: In https://chromium-review.googlesource.com/c/chromium/src/+/1098668, we made the assumption that when IdentityManager receives a notification from ProfileOAuth2TokenService that a token will be revoked, it had previously known about that account (either because the account was available at IdentityManager startup or because IdentityManager previously received a notification from PO2TS that a refresh token had been made available for the account). However, as demonstrated in the linked bug, it turns out that this assumption is not valid in one case: while loading tokens during startup, PO2TS sometimes revokes tokens without having previously made them available. This violation of IdentityManager's assumption causes a crash. It is not feasible at the current time to change this behavior on the part of PO2TS, as AccountTrackerService should be made aware of these events so that it removes the accounts. However, this situation poses a challenge for IdentityManager: Should it forward on the callback to its own observers or not? In this CL, we fix the crash and additionally nail down the semantics that IdentityManager sends token removed callbacks only for accounts of which it previously knew the existence. The reasons for making this choice on the semantics are twofold: (1) Sending an observer callback that a token was removed for an account that was not previously present in IdentityManager::GetAccountsWithRefreshTokens() seems like a violation of the principle of least surprise. (2) It's not clear that AccountTrackerService will always know about the account in this case, in which case we wouldn't have the full information to forward on in the observer callback. This does mean that IdentityManager::Observer::OnRefreshTokenRemovedForAccount() is not strictly identical semantically to ProfileOAuth2TokenService::Observer::OnRefreshTokenRevoked(). However, we strongly believe that the only consumer that needs to know about revocations in this corner case is AccountTrackerService, which will not be converted to depend on IdentityManager as it lives below IdentityManager. TBR=bsazonov@chromium.org Bug: 806774 Change-Id: I9f77525e26825ab418b15c7d1c2a8e4f8e3b4910 Reviewed-on: https://chromium-review.googlesource.com/1124320 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#572185}
-
Bence Béky authored
Bug: 807724 Change-Id: I87cc7b2909df287ae7e70e8726eac63af2e541ab Reviewed-on: https://chromium-review.googlesource.com/1120745Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572184}
-
Emily Hanley authored
This reverts commit 4da4a0c8. Reason for revert: Failing on mac and windows. I will add more comments to crbug.com/855234 Original change's description: > Reland "Reland "gtest perf tests: Output well formed test results json"" > > This reverts commit 89c5e790. > > Reason for revert: Testing possible fixes > > Original change's description: > > Revert "Reland "gtest perf tests: Output well formed test results json"" > > > > This reverts commit f02c92e1. > > > > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315 > > > > Original change's description: > > > Reland "gtest perf tests: Output well formed test results json" > > > > > > This reverts commit 9eeaba4e. > > > > > > Reason for revert: Will re-land with fix > > > > > > Original change's description: > > > > Revert "gtest perf tests: Output well formed test results json" > > > > > > > > This reverts commit 71b865f4. > > > > > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > > > > > > > Original change's description: > > > > > gtest perf tests: Output well formed test results json > > > > > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > > > > test results json. > > > > > > > > > > Bug: 855234 > > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#570943} > > > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 855234 > > > > Reviewed-on: https://chromium-review.googlesource.com/1118238 > > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#571083} > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 855234 > > > Reviewed-on: https://chromium-review.googlesource.com/1118789 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#571245} > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 855234 > > Reviewed-on: https://chromium-review.googlesource.com/1119445 > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#571321} > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1120798 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571968} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: I031c5d6204e0b53fa2719168a38292455d676167 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1124539Reviewed-by:
-
Alexander Timin authored
This is a reland of 586e21ec TBR=skyostil@chromium.org Original change's description: > [scheduler] Add a perftest to measure basic scheduling costs. > > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452 > Reviewed-on: https://chromium-review.googlesource.com/1085295 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566362} Reviewed-on: https://chromium-review.googlesource.com/1097295Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567645} Change-Id: Ia52d89c4321cf4a6d00c51f83ee5b52ea06769de Reviewed-on: https://chromium-review.googlesource.com/1122980Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572182}
-
Matthew Cary authored
This will be used for orderfile generation benchmarks. More precisely, they are thin wrappers around the system health benchmarks that make it more convenient to run orderfile generation. Bug: 843561 Change-Id: I5d3a2288d4f4a2f74004ef90f3cec0e4b44c7198 Reviewed-on: https://chromium-review.googlesource.com/1124161Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ce3f7b384d77..c56c2429b0f6 git log ce3f7b384d77..c56c2429b0f6 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 hjd@google.com perfetto-ui: Plumb trace_processor to javascript 2018-07-03 hjd@google.com perfetto-ui: Add deferred Created with: gclient setdep -r src/third_party/perfetto@c56c2429b0f6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I991045dc1e2a17250481a273b50bcd7a53d86b8a Reviewed-on: https://chromium-review.googlesource.com/1124379 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572180}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cbfa46069e2b..c61a0380486a git log cbfa46069e2b..c61a0380486a --date=short --no-merges --format='%ad %ae %s' 2018-07-03 nednguyen@google.com Revert "Only output the total histogram format if there is at least a single page that succeed" Created with: gclient setdep -r src/third_party/catapult@c61a0380486a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859073 TBR=sullivan@chromium.org Change-Id: Iaa7a6b9160b2e0235e160f8014e48b85bc4e2a82 Reviewed-on: https://chromium-review.googlesource.com/1123945Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572179}
-
Hiroki Nakagawa authored
As a cleanup, this CL removes ResourceFetcher::AddWarningConsoleMessage() and instead implements ResourceFetcher::GetUrlsOfUnusedPreloads(). Before this CL, AddWarningConsoleMessage() printed warnings in the console via an implementation of FetchContext because ResourceFetcher is in platform/ and cannot access ConsoleMessage etc. To simplify layering around that, this CL makes ResourceFetcher return URLs of unused preloads and a caller (i.e., LocalDOMWindow) in core/ print warnings with the URLs. Bug: 845285 Change-Id: I241c9567ba79df0ec24f8817cf6045456e44b75b Reviewed-on: https://chromium-review.googlesource.com/1124137Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572178}
-
Vadym Doroshenko authored
Now NewPasswordFormManager waits for server predictions for 500 ms before filling (kMaxFillingDelayForServerPerdictions const). But this const was taken arbitrary. This UMA measure time of receiving credentials from the password store and server predictions in order to understand which delay would be right. Bug: 831123 Change-Id: I42ee476fc949dca63fc7978b94998a20a1ac5e69 Reviewed-on: https://chromium-review.googlesource.com/1120253 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572177}
-
Guido Urdaneta authored
This fixes a bug where removing a device did not result in stopping all its associated streams. A unit test for this requires a minor refactoring to remove the MediaStreamManager dependency from MediaDevicesManager, and will be provided in a follow-up CL. This CL is deliberately simple in order to make merging easier. Bug: 856658 Change-Id: I84ef2856195cc7650bb08992d2095f8f853e9ea9 Reviewed-on: https://chromium-review.googlesource.com/1124323Reviewed-by:
-
