1. 12 Sep, 2014 5 commits
    • ericzeng's avatar
      Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest · b34659d0
      ericzeng authored
      Give the delegate class an ExtensionOptionsGuest member so that the
      calls to the delegate do not require passing a WebContents.
      
      BUG=409316
      
      Review URL: https://codereview.chromium.org/562353002
      
      Cr-Commit-Position: refs/heads/master@{#294495}
      b34659d0
    • rob's avatar
      In Chromium, requests can be redirected before they hit the network by (re)starting · 4e0be1f3
      rob authored
      the request with a URLRequestRedirectJob. This is used by HSTS, the extension
      webRequest API and protocol handlers.
      
      These redirects are trusted and must be followed. However when such redirects are
      triggered  for a cross-origin resource, e.g. <img src=".." crossorigin="anonymous">,
      Blink blocks the redirect because the Access-Control-Allow-{Origin,Credentials}
      response headers are missing.
      This CL adds these headers to fix the problem.
      
      Adding these CORS headers to the redirect response is safe, because CORS is still
      enforced at the redirect target. For example, if HSTS is active for google.com and
      an evil page embeds <img src="http://google.com/" crossorigin="use-credentials">,
      then the image is not displayed because google.com does not reply with
      "Access-Control-Allow-Origin: null".
      
      BUG=387198
      TEST=ExtensionWebRequestApiTest.WebRequestBlocking, HTTPSRequestTest.HSTSCrossOriginAddHeaders
      
      Review URL: https://codereview.chromium.org/348253002
      
      Cr-Commit-Position: refs/heads/master@{#294494}
      4e0be1f3
    • jamescook's avatar
      Clean up extensions permissions unit tests · 646de7d8
      jamescook authored
      * Move socket_permission_unittest.cc and usb_device_permission_unittest.cc
        into src/extensions -- they have no src/chrome dependencies.
      * Move permissions_data_unittest.cc back into src/chrome -- its tests rely on
        extension manifest keys that aren't part of src/extensions yet.
      * Rename the latter tests to PermissionsDataTest
      
      BUG=397165
      TEST=unit_tests PermissionsDataTest.* and extensions_unittests
      
      Review URL: https://codereview.chromium.org/563663002
      
      Cr-Commit-Position: refs/heads/master@{#294493}
      646de7d8
    • chrome-tpm's avatar
      Updating trunk VERSION from 2155.0 to 2156.0 · abfe4031
      chrome-tpm authored
      Cr-Commit-Position: refs/heads/master@{#294492}
      abfe4031
    • ericzeng's avatar
      Add a user agent stylesheet for extension options pages · 685c341a
      ericzeng authored
      Apply WebUI styles to extension options pages that opt into using them
      through a user agent stylesheet. The styles are copied from widgets.css
      and chrome_shared.css in ui/webui/resources/css/ - this is intentional
      so that WebUI changes won't break extensions.
      
      The extension.css stylesheet will only be applied to extensions that
      opt in using the "options_ui.chrome_style" manifest entry, and it will
      only affect the options page specified in the manifest. The font
      stylesheet for extensions have been moved to extension_fonts.css, and
      are still applied to every extension page.
      
      BUG=408271
      
      Review URL: https://codereview.chromium.org/537773003
      
      Cr-Commit-Position: refs/heads/master@{#294491}
      685c341a
  2. 11 Sep, 2014 35 commits