- 12 Jan, 2021 40 commits
-
-
Ken Buchanan authored
The RenderFrameHost's URLLoaderFactory has CORB enabled which prevents WebID from retrieving the .well-known/webid JSON from the IDP. This changes WebID to use to the browser process factory. Bug: 1141125 Change-Id: I18636fb2a155900fb6d2f2304b144aef0fa39032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618601Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842712}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bd6bd346f677..c60dda78e4ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib5a20c91727ebef21d2285bfcac099c7ddba2da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842711}
-
Xianzhu Wang authored
We clamp raster scale during animation by the device viewport size, so we need to force raster scale update on device viewport rect change. This is expecially important for remote frames which have zero device viewport size initially, and the size is the frame size instead of the actual device viewport. This happens in the testing frame on codepen etc. Also limit the minimum viewport geometry to avoid too small scale in small remote frames. Bug: 1164960 Change-Id: Idb1cfeb878fde76252a467bf8aca8c97ef506c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623720Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842710}
-
John Lee authored
Bug: 1164838 Change-Id: Ife2d3e970b9ab70bf1fd488f47eb9bf1bf516a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622732Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842709}
-
Trevor Perrier authored
This CL renames language code enums to make them more clear. The current enum |LanguageCode| hashes the first two letters of a local code and maps these to language name. This is renamed |LanguageName|. The current enum |CLD3LanguageCode| hashes the entire ISO639 locale code and maps these to the locale code. This is renamed |LocaleCodeISO639| Bug: 1155031 Change-Id: I08fce33d008e26af29607fe35f060c3800318d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613285 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842708}
-
Michael Checo authored
Screenshot: http://shortn/_Y2KIJpUWPu Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#8834837d-1583-4a5f-b1a5-b0eef63be7ac Notes: - Styling for "queued" state is currently not represented in the spec which makes it subject to further change. - "Stopped" badge state will be added in a follow-up CL that implements routine cancellation. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9144ef846a7553042d16edd5a075f5158a4ae9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567932 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842707}
-
Michael Lippautz authored
Miscellaneous changes: - IWYU fixes for the library; - Move some needed traits to global includes; - Add stub for invoking a testing GC; Bug: 1056170 Change-Id: Ia4871852a4f73595d0c9466140d7fb7cd7bd6e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624729 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842706}
-
Darin Fisher authored
Fixed: 1163970 Change-Id: I679e38977c4a4bd76a4c1210ef9057ab8d11f59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616981Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842705}
-
Mustaq Ahmed authored
Create a new class SimulatedEventUtil to remove duplicate code blocks from MouseEvent and PointerEvent classes that are used only for simulated-click related events. Change-Id: I2cb8ac3cc14dc1a562f8e3966686a8a62e5ecb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602379Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#842704}
-
Javier Ernesto Flores Robles authored
Fixed: 1156205, 1156201 Change-Id: Ic0f11263c2c128f12155effb56d2fd9a79e6e15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577890 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842703}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4385.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4386.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I37fb3b07837d89f068d4329b0e609e503a1b9944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842702}
-
Abigail Klein authored
Only show Live Caption toggle in volume slider in bubble, not in status tray. Also, enable this behavior for the ChromeOS system- wide launch. Bug: 1055150 Change-Id: Ibdcee58a86355890154fd35d700862d379830033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619944 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#842701}
-
Mohamed Amir Yosef authored
Those are still important health metrics and hence extending their life time. Fixed: 1160827 Change-Id: I158c9cc5a98204a793ecb2094ddc31ea692602f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624610 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842700}
-
Bryan Bernhart authored
Adds support to bind video textures used for overlays with the shared image system. This change enables overlays to be backed by DXVA decoded output textures by wrapping them in a mailbox per plane. Bug: 1011555 Change-Id: Ide149097c1331c0bcb3dc99ae67def8bf4768472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485682Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Cr-Commit-Position: refs/heads/master@{#842699}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I3b2b26128d0dce591fefe323a730b827e160bb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618679 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842698}
-
Tommy Li authored
In M89, we introduced a regression where we didn't adequetely protect the Default Search Provider from removal during keyword deduplication while the model was still being loaded (loaded_ == false). This CL fixes that and adds a regression test. It also adds another CHECK during Remove() which just crashes Chrome if some other code branch tries to delete the DSE. Deleting the DSE causes permanent damage to the user's Profile, which can be synced to other installations of Chrome. It's really bad, so crashing is not bad in comparison. Bug: 1164024 Change-Id: If1e70cc2a7b4e0c07b20b4e76acb243d7630937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623120 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842697}
-
Junji Watanabe authored
Tested the script manually. https://chromium-swarm.appspot.com/task?d=true&id=510e82c2bbfccc10 Bug: 1163817 Change-Id: I0724c51da3c61df645c8ea070180af1d4e3c8d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623734 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#842696}
-
Rune Lillesveen authored
Bug: 1146097 Change-Id: I2fbb9d6f41d916fc85b6538f5a3d4545daac40fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624654Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#842695}
-
Eugene But authored
Bug: 1156200 Change-Id: Ic8f18a270485606f12f35b9b2686cb3fd1c54e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622950 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842694}
-
David Roger authored
This CL also fixes the policy which was intended to disable the picker at startup. Change-Id: I12e387259e862dff8235d22bc1696e843ab6b2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624675 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#842693}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/002c03c4b6ed..51e1fea7385f 2021-01-12 skyostil@google.com Merge "tracing: Allow tracing category names to contain spaces" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36ff978e13b5e607a06b082ae20599d0dafb9561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842692}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4385.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4386.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I22435ae0b1569fa1ef2a7596bf6f857e098388c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842691}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610452567-9a68a195870106cae6c4ac4841f20ff7b185cdf9.profdata to chrome-mac-master-1610474333-6e9ea86fde1168dfc05bd82ef581aacfe157db52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieda6bb22f231441732a039a974cd411a59a8770b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842690}
-
John Lee authored
By moving the `direction: rtl` CSS to an internal div, direction-dependent CSS properties like margin are no longer affected by the direction and can be used to correctly space out the host element. Bug: 1164840 Change-Id: I4d2c7d02284fe0b8a9593ea48ffd65fd9969d83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622657 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842689}
-
Yulun Wu authored
Bug: 1139478 Change-Id: Ie9179fc42d59def83910475e93ef93c5eef3b496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622761 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842688}
-
Shuran Huang authored
This is to support SameParty for document.cookie queries. IsolationInfo has fields origin, top_frame_origin and site_for_cookies, is typically the same for all subresource requests made in the context of the same frame. Bug: 1136102 Change-Id: Id43ca760150adca28862e42f6e22fe4953cf9164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582608 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842687}
-
Dave Tapuska authored
Convert UnfreezableFrameMsg_Delete to a navigation control message. Move the FrameDeleteIntention to mojo and add a callback for testing that a frame is deleted. This is possible because associated channel messages are not currently frozen. Do not perform the disconnect on main frame remotes as those will be owned by the view itself. BUG=993189 Change-Id: Icaab6d2d2ea47e9dc9b66fd269ff14274f617c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533520Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#842686}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81b3d28a..16b9bbbd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1dca01c7ab7ca6d38a0ea021ea3e0d9874bc0986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624698Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842685}
-
David Bertoni authored
This CL removes ExtensionsClient::ExtensionAPIEnabledInExtensionServiceWorkers() and its overloads. Bug: 1165397 Change-Id: I8a5bd861c81ec57f1f3d1c9fe8780d904bb48332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623894Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842684}
-
Ken Rockot authored
This is in preparation for use of JS modules within the tests. They share some library code with external bluetooth WPT, and that code will soon use JS modules. Bug: 1004256 Change-Id: I0817dde4216fa43287cde2788edf5c324cf47fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622578 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#842683}
-
Charlie Hu authored
This CL removes the comma separator support in allow attribute parsing. Bug: 1062400 Change-Id: Ib1c481b492903384a0413f221474ec7703e6f0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600388 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842682}
-
Josiah K authored
Gate "Zoomed in screen follows keyboard focus" toggle in Chrome OS Accessibility settings behind feature flag MagnifierPanningImprovements. (following crbug.com/1144947, hide toggle in M89) Feature off: https://screenshot.googleplex.com/8wTtrRRQCC4XNx5 Feature on: https://screenshot.googleplex.com/7RaUNBhcpQsgBeC AX-Relnotes: N/A. Fixed: 1165650 Change-Id: I8286f977a6099cdc31e82b536d09e5c291aac637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622716 Auto-Submit: Josiah Krutz <josiahk@google.com> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#842681}
-
Austin Sullivan authored
This overload of IDBRequest::EnqueueResponse was only used for devtools, which no longer uses it as of [1]. The implementation of this method was removed here [2]. [1] https://crbug.com/992958 [2] https://crrev.com/c/2563872 Bug: N/A Change-Id: Iacf15ee27b7505c7fba44d00f675a38bf7125f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621954 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#842680}
-
Sonny Sasaka authored
This lets Googler users who report issues related to Nearby Share or Phone Hub to attach Bluetooth logs. Bug: b:177249078 Change-Id: Ib35ed5cb6d1a20421d5772a0b2a63b2553599e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622523 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842679}
-
Ryan Daum authored
* Backspace, tab, and delete are special in that they are characters, but non-printable. * This catches them and passes them through as non-printable class characters, so they are properly handled by blink. Bug: internal b/174869138 Test: manual with wayland_webview_client Change-Id: I2e33c602fbe6c85f0998717541d2f5fca0b48a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625207Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#842678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/767ed2f6b642..d0102e007e70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com,dfried@google.com Change-Id: I60efa1ffacb568a47b32bde6682878129e68db89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842677}
-
Findit authored
This reverts commit 107694e1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 842561 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEwNzY5NGUxOGZlZTE1MGEwODczNDc3Y2M4NGJmYzVmZGFkMmM5NjMM Sample Failed Build: https://ci.chromium.org/b/8858284128460739264 Sample Failed Step: content_unittests Original change's description: > [conversions] Use base 10 encoding for impression and conversion data > > What: > No longer parse impressiondata as hex, or use hex when sending > conversion reports. > > Why: > This causes needless conversions for developers, as raised on > https://github.com/WICG/conversion-measurement-api/issues/60 > > Note that the conversions database stores imp and conversion data as > strings currently because they are represented as hex. These can > be converted to strings now, but this is left as a followup. > > Bug: 1163599 > Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842561} Change-Id: I811167ec2b72a1a2d0fd9f12931ffc2dd2c85f08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625608 Cr-Commit-Position: refs/heads/master@{#842676}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e59aac750e..c60dda78e4ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a568d84fb9dac1eb46860774cf45305a320a68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622805Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842675}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59b0ce20d3e5..f6b414c57847 2021-01-12 gavinmak@google.com Add client not configured message to gclient validate and flatten If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:732733 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3e4c07db24080d701e882b57d73700c06f265fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842674}
-
Ben Kelly authored
Bug: 1165799,1150991 Change-Id: I8b47aa1f87ea022b8813fa1d097174854797e4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623954Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#842673}
-