GitLab

Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/398c70a..d5d1eac
d5d1eac  Stop calling memmove when unnecessary
482062f  Fix some fragile code that is likely to cause future memory corruption problems.

BUG=450137
R=mark@chromium.org

Review URL: https://codereview.chromium.org/879283002

Cr-Commit-Position: refs/heads/master@{#313505}

This paves the way to allowing logic living elsewhere in Chrome to
specify a value for this param (which will come in a later CL).

Also, cleans up a couple areas of the code, including cleaning up the
unit test for the URL generating function to abstract away the policy
pref code and using a weak pointer instead of base::Unretained() in
a callback.

BUG=452605

Review URL: https://codereview.chromium.org/883803002

Cr-Commit-Position: refs/heads/master@{#313504}

Add a DuplicateFinder and introduce it into the cloud import pipeline.  Note: Deduplication takes place in-place on the source files, which could be slow for MTP devices.  Profiling will be necessary to test this.  The duplicate check returns a simple yes/no answer.  Non-duplicate media is then imported as before.

Destination is now promoted to a top-level concept.  MediaImportHandler has a new function which enables clients to register new import destinations.  Each destination requires a DestinationFactory and an optional DuplicateFinder.  The import destination is selected at import time by its ID.

The Observer pattern on the ImportTask class was tweaked to support auxiliary data being passed with each observer call.  This is to allow richer updates (e.g. an entry-changed update that informs observers when a file was copied, and sends along the source and new destination).

A new importer.TestLogger had to be created and inserted into some tests in order to circumvent the running of the regular RunTimeLogger, which uses functionality that doesn't exist at test time (i.e. chrome.syncFileSystem.onFileStatusChanged)

MockEntry et al. were  augmented to do more "realistic" moves and copies, needed to test the new two-stage import.

Unit tests were cleaned up.

BUG=420680
TEST=browser_test: FileManagerJsTest.MediaImportHandlerTest

Review URL: https://codereview.chromium.org/881463003

Cr-Commit-Position: refs/heads/master@{#313503}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b27ee88..0d1eda3

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/885623003

Cr-Commit-Position: refs/heads/master@{#313502}

Cr-Commit-Position: refs/heads/master@{#313501}

The renderer is using this to conditionally enable payload API surface
for incoming push messages, and thus needs to know about it.

This patch also re-enables the tests.

BUG=452666

Review URL: https://codereview.chromium.org/884093003

Cr-Commit-Position: refs/heads/master@{#313500}

This is done following a suggestion in
https://codereview.chromium.org/686413002/.

BUG=361548

Review URL: https://codereview.chromium.org/879853002

Cr-Commit-Position: refs/heads/master@{#313499}

Revert of Reenable oobe spoken feedback test. (patchset #4 id:60001 of https://codereview.chromium.org/866713002/)

Reason for revert:
Still failing :(

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6244

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6247

Original issue's description:
> Reenable oobe spoken feedback test.
>
> The test was disabled because it was flaky.  This CL tries to address that
> and reenables the test.
>
> BUG=346797
> R=dtseng@chromium.org
>
> Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7
> Cr-Commit-Position: refs/heads/master@{#313467}

TBR=dtseng@chromium.org,dmazzoni@chromium.org,plundblad@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=346797

Review URL: https://codereview.chromium.org/884643003

Cr-Commit-Position: refs/heads/master@{#313498}

- ServiceWorkerRegistrationHandleReference::Create() should increment registration refcount
- ServiceWorkerMessageFilter::OnStaleSetVersionAttributes shouldn’t decrement registration refcount

TEST=n/a
BUG=452403

Review URL: https://codereview.chromium.org/868483008

Cr-Commit-Position: refs/heads/master@{#313497}

Currently RunShellCommand may not work if the command passed to
adb.Shell is too large (e.g. > 1024). This CL addresses this
issue, allowing to run even very large commands, by first writing
the command as a shell script and then running it.

Original CL: https://codereview.chromium.org/751063002/

BUG=436133

Review URL: https://codereview.chromium.org/787813002

Cr-Commit-Position: refs/heads/master@{#313496}

No intended behavior change.

BUG=448790,451741

Review URL: https://codereview.chromium.org/882943002

Cr-Commit-Position: refs/heads/master@{#313495}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/881973004

Cr-Commit-Position: refs/heads/master@{#313494}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f55332d..b27ee88

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/884703002

Cr-Commit-Position: refs/heads/master@{#313493}

Revert of Use data_deps rather then deps for mojo_bindings. (patchset #1 id:1 of https://codereview.chromium.org/876783003/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=452847

Original issue's description:
> Use data_deps rather then deps for mojo_bindings.
>
> Using deps caused pulling a bit of mojo code to chrome.exe. That
> caused weird unresolved externatls problems during Windows GN build.
>
> Committed: https://crrev.com/f7b4f01989be22df44d9b5475143ef98b653b1ac
> Cr-Commit-Position: refs/heads/master@{#313126}

TBR=brettw@chromium.org,dpranke@chromium.org,vchigrin@yandex-team.ru
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/880573005

Cr-Commit-Position: refs/heads/master@{#313492}

BUG=449500,449499

Review URL: https://codereview.chromium.org/854153003

Cr-Commit-Position: refs/heads/master@{#313491}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/877323002

Cr-Commit-Position: refs/heads/master@{#313490}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/868753004

Cr-Commit-Position: refs/heads/master@{#313489}

Device policy pushing requires a connected invalidation service which
belongs to an account that is affiliated with the device's enrollment
domain. If an affiliated user is logged in and has a connected per-profile
invalidation service, that service is used. Otherwise, a device-global
invalidation service is spun up.

This CL extracts the mechanism from DeviceCloudPolicyInvalidator and
generalizes it so that it can be used by any number of consumers. This
will allow the same invalidation service to be resued by e.g. device
policy pushing, device-local account policy pushing and device remote
commands.

The CL adds a new AffiliatedInvalidationServiceProvider with tests but
does not switch the DeviceCloudPolicyInvalidator to this new
infrastructure yet. That will be done in a follow-up CL.

BUG=442800
TEST=New unit tests

Review URL: https://codereview.chromium.org/828953004

Cr-Commit-Position: refs/heads/master@{#313488}

Fixs several release blocking regressions in the behaviour of the
startup page list. Lamentably there are no tests for this code and
adding new ones looks tricky (we'd either need to fix crbug.com/419370)
or refactor the classes to be testable.

BUG=452370,452407

Review URL: https://codereview.chromium.org/879953002

Cr-Commit-Position: refs/heads/master@{#313487}

BUG=346582

Review URL: https://codereview.chromium.org/874363002

Cr-Commit-Position: refs/heads/master@{#313486}

Pass to InMemoryURLIndex a pointer to the owning HistoryService and
remove the reference to Profile that is no longer necessary.

Fix the unit tests to no longer pass the Profile, and to call the
Shutdown method before destroying the object so that it properly
remove itself from the HistoryService observer list.

BUG=370850

Review URL: https://codereview.chromium.org/879763002

Cr-Commit-Position: refs/heads/master@{#313485}

This is a follow up to crrev.com/866893002 which fixed the tracing
includes without updating the generator.
This CL involves mostly mechanical changes to trace include headers.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/885443005

Cr-Commit-Position: refs/heads/master@{#313484}

The additional callbacks caused the SupervisedUserUrlFilter to update its filter unnecessarily, which in turn flakily quit the observer run loop too early.

This CL fixes the flakiness by using the main thread message loop for the SupervisedUserUrlFilter (removing non-determinism), spreading out the synchronization points for site list updates and URL filter updates, and adding additional sanity checks about observed changes.

BUG=452071

Review URL: https://codereview.chromium.org/875423002

Cr-Commit-Position: refs/heads/master@{#313483}

BUG=None

Review URL: https://codereview.chromium.org/882023004

Cr-Commit-Position: refs/heads/master@{#313482}

Revert of PlzNavigate: Add a browser test for basic navigations (patchset #6 id:100001 of https://codereview.chromium.org/715203004/)

Reason for revert:
Broke the build:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/7409

http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/18976

http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/73255

Original issue's description:
> PlzNavigate: Add a browser test for basic navigations
>
> This CL adds a browsertest that checks that basic browser initiated navigations
> work with browser side navigations enabled.
>
> BUG=376014,376006,376091
>
> Committed: https://crrev.com/cd857adbb07fb2e889fa24282648e1f64ede2c95
> Cr-Commit-Position: refs/heads/master@{#313480}

TBR=carlosk@chromium.org,nasko@chromium.org,clamy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=376014,376006,376091

Review URL: https://codereview.chromium.org/884683002

Cr-Commit-Position: refs/heads/master@{#313481}

This CL adds a browsertest that checks that basic browser initiated navigations
work with browser side navigations enabled.

BUG=376014,376006,376091

Review URL: https://codereview.chromium.org/715203004

Cr-Commit-Position: refs/heads/master@{#313480}

BUG=None
TEST=user_manager GN ninja build (debug|official; is_component_build=yes|no)
TBR=oshima

Review URL: https://codereview.chromium.org/880203003

Cr-Commit-Position: refs/heads/master@{#313479}

BUG=450167

Review URL: https://codereview.chromium.org/847163002

Cr-Commit-Position: refs/heads/master@{#313478}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e57f7c1..f55332d

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/882033002

Cr-Commit-Position: refs/heads/master@{#313477}

- expose RunUnitTestsSerially and RunUnitTestsBatch
- hide private static ProcessTestResults in anonymous namespace

This will be used to implement ios-specific unit test
relaunch logic. Exposing the helpers makes it possible
to re-use them in ios code.

BUG=426870
R=sky@chromium.org

Review URL: https://codereview.chromium.org/879883002

Cr-Commit-Position: refs/heads/master@{#313476}

This reverts the removal of the kUseGpuInTests flags done in
https://crrev.com/cf04d9696a7f1f321294bc0970037ddb23c1204d
since it seems this affected performance results.
It also adds it to the new chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc
test.

BUG=452654,452655

Review URL: https://codereview.chromium.org/879223002

Cr-Commit-Position: refs/heads/master@{#313475}

Main changes are:
- Layout change.
- Selected tree item's color is not inverted now.
- Use core-icon's preset icons for for subfolders.
- Add touch feedback.

BUG=402344
TEST=run browser_tests

Review URL: https://codereview.chromium.org/884653002

Cr-Commit-Position: refs/heads/master@{#313474}

With the display configuration now asynchronous, we can't immediately read the display size. We need to wait until the hardware is probed.

Also the VSyncProvider cannot trigger the given callback until the PlatformWindow is properly setup with the display. We need to wait for it the actually be resized.

BUG=447798
TEST=run video_decode_accelerator_unittest on freon

Review URL: https://codereview.chromium.org/835653005

Cr-Commit-Position: refs/heads/master@{#313473}

BUG=452799

Review URL: https://codereview.chromium.org/885563002

Cr-Commit-Position: refs/heads/master@{#313472}

Previously, this unit test was consistently failing because DOM wrappers were
retained at the time of detecting Document leaks. This patch adds a call to
V8's gc() before the leak check to make sure the DOM wrappers are freed.

BUG=422244
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/882913002

Cr-Commit-Position: refs/heads/master@{#313471}

Registration info and its version attributes owned by SWProviderContext can be
accessed from both the main thread and the worker thread, so they are protected
by a lock operation. However, getter functions for those info and attributes are
separated and returned values could be in an invalid state due to interleaved
operations.

This CL merges getter functions (registration() and GetVersionAttributes()) into
GetRegistrationInfoAndVersionAttributes() and avoids such an unexpected state.

BUG=437677
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/885443006

Cr-Commit-Position: refs/heads/master@{#313470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb45ad8..e57f7c1

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/870263003

Cr-Commit-Position: refs/heads/master@{#313469}

TopSites was created and owned by profile.

This patch creates a TopSitesServicefactory which is keyedService.
So now instead of calling GetTopSites() from profile, can get the TopSites from
TopSitesFactory.

BUG=435501

Review URL: https://codereview.chromium.org/815983002

Cr-Commit-Position: refs/heads/master@{#313468}

The test was disabled because it was flaky.  This CL tries to address that
and reenables the test.

BUG=346797
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/866713002

Cr-Commit-Position: refs/heads/master@{#313467}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/879203003

Cr-Commit-Position: refs/heads/master@{#313466}