GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=178400

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/404673002

git-svn-id: svn://svn.chromium.org/blink/trunk@178417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

base's TestSuite already does this for us, so we can just let it handle
that detail, instead of doing this twice.

BUG=None
TEST=webkit_unit_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/401733002

git-svn-id: svn://svn.chromium.org/blink/trunk@178416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Chromium change in question https://codereview.chromium.org/379383002/ will change two JWK errors, requiring the test to be rebased.

BUG=374912
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/400533008

git-svn-id: svn://svn.chromium.org/blink/trunk@178414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If any transition-elements metatags are present, we signal Chrome that this is a transition navigation and serialize the HTML elements designated by the selectors in the transitions-elements metatag.

The isTransitionNavigation flag needs to be passed through both WebFrameClient::decidePolicyForNavigation and WebFrameClient::dispatchDidStartProvisionalLoad to cover both same-origin and different-origin navigation paths.

Requires https://codereview.chromium.org/281383006/

R=esprehn,eseidel
BUG=281383006

Review URL: https://codereview.chromium.org/319573008

git-svn-id: svn://svn.chromium.org/blink/trunk@178413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oysteine@chromium.org,oilpan-reviews@chromium.org
BUG=

Review URL: https://codereview.chromium.org/404563006

git-svn-id: svn://svn.chromium.org/blink/trunk@178412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-1)

Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view.
This removes the dependency upon using xxd.py which embeds the resources as strings.

BUG=312586

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178214

Review URL: https://codereview.chromium.org/394003002

git-svn-id: svn://svn.chromium.org/blink/trunk@178411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can simplify the code by createCrossThreadTask.

BUG=392788

Review URL: https://codereview.chromium.org/398293003

git-svn-id: svn://svn.chromium.org/blink/trunk@178409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Resolve screen.orientation.lock() promise with undefined. (https://codereview.chromium.org/400703003/)

Reason for revert:
Chromium unit tests fail to compile with this patch on Windows.

http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/58418

Compilation error:
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj.rsp /c ..\..\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc /Foobj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj /Fdobj\content\content_unittests.cc.pdb 
c:\b\build\slave\win-latest-rel\build\src\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc(121) :error C2259: 'content::MockLockOrientationCallback' : cannot instantiate abstract class
        due to following members:
        'void blink::WebLockOrientationCallback::onSuccess(void)' : is abstract
        c:\b\build\slave\win-latest-rel\build\src\third_party\webkit\public\platform\weblockorientationcallback.h(26) : see declaration of 'blink::WebLockOrientationCallback::onSuccess'


Original issue's description:
> Resolve screen.orientation.lock() promise with undefined.
> 
> This is following the current state of the specification.
> 
> BUG=162827
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178406

TBR=abarth@chromium.org,mvanouwerkerk@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=162827

Review URL: https://codereview.chromium.org/400623004

git-svn-id: svn://svn.chromium.org/blink/trunk@178408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to allow MediaKeySession to be created only when resolving
the promise, add the ability to set the client callback interface on
WebContentDecryptionModuleSession after the object is created.

BUG=358271
TEST=EME layouts tests pass

Review URL: https://codereview.chromium.org/379343003

git-svn-id: svn://svn.chromium.org/blink/trunk@178407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is following the current state of the specification.

BUG=162827

Review URL: https://codereview.chromium.org/400703003

git-svn-id: svn://svn.chromium.org/blink/trunk@178406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/396993003

git-svn-id: svn://svn.chromium.org/blink/trunk@178405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new GYP/GN variable blink_asserts_always_on (mirroring Chromium's
dcheck_always_on) can be set to 1 to enable assertions in Release
builds.

Tests of NDEBUG related to assertions have been changed to test
ENABLE(ASSERT). Printing/debugging-only code is still guarded under
NDEBUG. Debug-only fields and counters remain debug-only.

Once this CL lands, Blink's assertions will be enabled on the GPU
bots, which only test Release builds (with dcheck_always_on).

Tested:
 - WebGL conformance tests, Release build, asserts on
 - Release build, asserts on, inserted ASSERT(FALSE) guarded under
   ENABLE(ASSERT), verified it was triggered
 - Release build, asserts on, inserted ASSERT(FALSE) guarded under
   ENABLE(SECURITY_ASSERT), verified it was triggered
 - WebGL conformance/context tests, Release build, asserts on, with
   https://codereview.chromium.org/251373005, verified assertion
   failure was triggered
 - WebGL conformance/context tests, Debug build, default assertion
   behavior, with https://codereview.chromium.org/251373005, verified
   assertion failure was triggered
 - wtf_unittests, Release build, asserts on

BUG=393838

Review URL: https://codereview.chromium.org/397733004

git-svn-id: svn://svn.chromium.org/blink/trunk@178404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to serialize markup for transition elements, which is then sent to the transition layer.

BUG=370696

Review URL: https://codereview.chromium.org/281383006

git-svn-id: svn://svn.chromium.org/blink/trunk@178403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clang does treat the in-class initialization as a definition, just like MSVC.
The problem was that Clang failed to emit the definition unless it was referenced,
which broke the components build. This has been fixed in Clang r213304.

The work-around was added in Blink r176469, and this patch effectively removes that.

BUG=82385

Review URL: https://codereview.chromium.org/397323002

git-svn-id: svn://svn.chromium.org/blink/trunk@178401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The bookkeeping for this property has gotten a little stale, and it's
prevented transforms from propagating in some cases. This CL ensures
that we use the same code everywhere for updating
should-flatten-transform on all applicable layers, and that we call it
at the right times.

BUG=None

Review URL: https://codereview.chromium.org/399733002

git-svn-id: svn://svn.chromium.org/blink/trunk@178400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ICU 52 has slightly different date time format for a lot of locales 
including en-US. A comma was added between date and time in en-US.
In https://codereview.chromium.org/302323004, I made a necessary adjustment
to TestExpectations, but forgot to list the following test as requiring
a manual rebaseline.

fast/forms/datetimelocal/datetimelocal-appearance-basic.html

In addition, add back 'Android' for a few tests that require manual 
rebaselining after ICU 52 update.

BUG=378919,132145
TEST=datetime* tests passed as expected (fail or pass).
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/401473004

git-svn-id: svn://svn.chromium.org/blink/trunk@178398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a replaced element has a percentage min or max height specified then that height value should
compute to 'none' for max-height and 0 for min-height  when its containing block
does not have a height 'specified explicitly'.

See http://www.w3.org/TR/CSS21/visudet.html#min-max-heights

http://lists.w3.org/Archives/Public/www-style/2014Jun/0079.html

BUG=385877

Review URL: https://codereview.chromium.org/360613003

git-svn-id: svn://svn.chromium.org/blink/trunk@178397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The flakiness dashboard forces different whites-space handling for the
bugs column to handle long bugs. When the dashboard is narrow due to
the screen being narrow or the flakiness runs being longer than the
page (common after [1]), the wrapped "File new bug" text causes every
row to be tall and ugly (see: http://pr.gg/longbug.png). This patch
changes the new bug text to be nowrap.

The original code for longbug handling was added before
TestExpectations was as clean as it is today.

[1] https://codereview.chromium.org/359533004/

Review URL: https://codereview.chromium.org/402643002

git-svn-id: svn://svn.chromium.org/blink/trunk@178396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is an updated version of a patch originally written by
nasko@chromium.org.

A forthcoming Chromium CL will cause the entire frame tree of a page to
be replicated across processes when out-of-process iframes are in use.
This patch updates Blink to remove, in some places, the assumption that
top-level frames are in-process. The immediate goal is to prevent crashes,
while allow rendering and input events to work. Other breakages will be
addressed in the future.

BUG=357747

Review URL: https://codereview.chromium.org/397023003

git-svn-id: svn://svn.chromium.org/blink/trunk@178395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Scroll interruption tests for CSSOM View smooth scroll (https://codereview.chromium.org/398043005/)

Reason for revert:
fast/scroll-behavior/listbox-interrupted-scroll.html times out on Mac:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fscroll-behavior%2Flistbox-interrupted-scroll.html

Original issue's description:
> Scroll interruption tests for CSSOM View smooth scroll
> 
> This adds a SmoothScrollInterruptionTest class and tests using
> this class.
> 
> BUG=243871
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178387

TBR=vollick@chromium.org,ajuma@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=243871

Review URL: https://codereview.chromium.org/400763003

git-svn-id: svn://svn.chromium.org/blink/trunk@178394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is split from https://codereview.chromium.org/373503002/.

This call was added back in 2007 in
https://src.chromium.org/viewvc/blink?revision=21093&view=revision. All of the
layout tests continue to pass with the call removed.

BUG=391288

Review URL: https://codereview.chromium.org/397333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The partial layer invalidation logic that was added in r176815 was not
properly transforming the invalidation region from the layer's local
frame of reference to the layer's content area.  The proper logic
already existed for non-accelerated 2d canvases, but we were short-
circuiting it whith acceleration enabled because we did not
support partial invalidations in the past.  This fix makes
accelerated 2D canvases use the same invalidation code path as
non-accelerated canvases.

TEST=fast/canvas/canvas-partial-invalidation-zoomed.html
BUG=393192
NOTRY=true

Review URL: https://codereview.chromium.org/402613006

git-svn-id: svn://svn.chromium.org/blink/trunk@178392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This contains fixes for the following sorts of issues:
* Possibly-uninitialized local variable
* Assignment inside conditional
* Signedness mismatch

This also contains a small number of other cleanups to nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/383153007

git-svn-id: svn://svn.chromium.org/blink/trunk@178391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/397273005

git-svn-id: svn://svn.chromium.org/blink/trunk@178390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=v8:2948

Review URL: https://codereview.chromium.org/323523004

git-svn-id: svn://svn.chromium.org/blink/trunk@178389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch reorganizes the flakiness dashboard to group results by
blink revision so that regressions are easier to spot.

With patch:
http://head-and-shoulders.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg

Without patch:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg

This patch works by creating an array of the unique builds. In the
simplest case this array will have a blink revision corresponding to
each unique build, and each column in the flakiness results will
correspond to one of these blink revisions. Because a bot can run a
test multiple times for the same blink revision (e.g., if the chrome
version changed), blinkBuildRevisions can return multiple
entries with the same blink revision.

htmlForTestResults has been updated to use the new unique revisions.

To make the results easier to understand, we "interpolate" results
for revisions that were not tested. For example, if r123 passed and
r126 passed, r124 can be an interpolated result which probably passed.
These interpolated results use a lighter color.

NOTRY=true

Review URL: https://codereview.chromium.org/359533004

git-svn-id: svn://svn.chromium.org/blink/trunk@178388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a SmoothScrollInterruptionTest class and tests using
this class.

BUG=243871

Review URL: https://codereview.chromium.org/398043005

git-svn-id: svn://svn.chromium.org/blink/trunk@178387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SPEC: http://dom.spec.whatwg.org/#dom-node-textcontent

Current spec describes to use new text node
on setting Node.textContent
However, current implementation added early return
for optimization purpose.

So this CL added a note as well as crbug pointer
to describe those explicitly.

TEST=LayoutTests/fast/dom/Node/textContent.html

Review URL: https://codereview.chromium.org/383163003

git-svn-id: svn://svn.chromium.org/blink/trunk@178386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Check that we have an ExecutionContext to deliver a process event to
before dispatching.

R=haraken@chromium.org
BUG=394718

Review URL: https://codereview.chromium.org/398573005

git-svn-id: svn://svn.chromium.org/blink/trunk@178385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/402633002

git-svn-id: svn://svn.chromium.org/blink/trunk@178384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/391373008

git-svn-id: svn://svn.chromium.org/blink/trunk@178383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/399953002

git-svn-id: svn://svn.chromium.org/blink/trunk@178382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MS Shell Dlg is the aliased font name that means "the one font that
shall always be available" per http://msdn.microsoft.com/en-us/library/windows/desktop/dd374112(v=vs.85).aspx
DirectWrite doesn't like that name, but we add the two fonts that it
can map to so that we can be very certain to succeed on retreiving a
font, even if Arial has gone missing.

R=eae@chromium.org
BUG=383542

Review URL: https://codereview.chromium.org/402503003

git-svn-id: svn://svn.chromium.org/blink/trunk@178380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should fix a couple of the crashes we are seeing in the debug oilpan builds for websockets.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, tyoshino@chromium.org, vegorov@chromium.org, yhirano@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/405453002

git-svn-id: svn://svn.chromium.org/blink/trunk@178379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have to force a GC to ensure the registered event handler are removed. This happens during weak processing with oilpan.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, jochen@chromium.org, oilpan-reviews@chromium.org, rbyers@chromium.org, skyostil@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/391373009

git-svn-id: svn://svn.chromium.org/blink/trunk@178378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes ConsoleBase, instead of its subclasses, inherit from ScriptWrappable.

BUG=235436

Review URL: https://codereview.chromium.org/396803011

git-svn-id: svn://svn.chromium.org/blink/trunk@178377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes "Timeline tracing mode" and "Timeline flame chart" experiments. The latter is merged into "Timeline on trace events".

BUG=361045

Review URL: https://codereview.chromium.org/396803008

git-svn-id: svn://svn.chromium.org/blink/trunk@178376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178354

BUG=234871
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/399933003

git-svn-id: svn://svn.chromium.org/blink/trunk@178375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/400673002

git-svn-id: svn://svn.chromium.org/blink/trunk@178374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392793
R=apavlov, dgozman

Review URL: https://codereview.chromium.org/403493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178372 bbb929c8-8fbe-4397-9dbb-9b2b20218538