- 18 Jan, 2021 40 commits
-
-
Maria Kazinova authored
Added tests for standard flows for saving a new credential or updating a password for an already existing credential on a successful password form submission. Change-Id: I448fc801984e9462f212c3ae9a643325343fbd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627279 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#844601}
-
Nick Burris authored
* Both PaymentRequestContactInfoEditorTest and PaymentRequestShippingAddressEditorTest are flaky on Mac10.11. The flake output[1] shows that OnPersonalDataChanged is called twice, the first call is unexpected and happens before the profile is created, so the test fails. * Local debugging shows that OnPersonalDataChanged is always called twice when the test runs, but only the second call is meant to be observed. * A possible cause is the persistent observer between tests and not removing the observer from the PersonalDataManager. This is a tentative fix to make the observer local to each test and remove it after the event. * Could not repro the flake with this fix after 7 tries on mac_chromium_10.11_rel_ng (note this bot consistently fails for unrelated tests). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863274960955528464/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/Deterministic_failure:_PaymentRequestShippingAddressEditorTest.AsyncData__status_FAILURE_/0 Bug: 1164438 Change-Id: Ia3e3f4f360f0b58a42a7816616aa8c697047dd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580303Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#844600}
-
Michael Lippautz authored
V8-side change: https://crrev.com/c/2631504 Bug: 1056170 Change-Id: Idd1e1f9d2fcd6804d0d9a010cde83c2fa34a68e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636313Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844599}
-
Camillo Bruni authored
Calculating the source position for a module request is not free. Even the information is only used by DevTools we currently always calculate the line and column information. V8 only lazily initializes line-end information. This behavior currently causes needless memory and performance overhead. To partially mitigate the issue we only report the detailed source position if there is an active DevTools session. Ideally we would only report the source offset and let all the clients (in this case DevTools) resolve the offset to line and column. Bug: 1162107 Change-Id: I9942cde3bc28e483f1aa2c2b03e8cef2e182d838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622217 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844598}
-
Aaron Krajeski authored
This only should happen if the paint canvas exists so that it doesn't wipe out the buffer in the situation when the context is lost. Bug: 1131449, 1131137 Change-Id: I355de75bc92e41e8d2224bf4ecd4e9104b94a67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633345 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844597}
-
Matthias Körber authored
This CL implements the ability to divide a label between a series of fields to address the following scenario in a form: Street Name / House Number: [ ][ ] or First Name & Last Name: [ ][ ] ([ ]: indicates a text input field in a form.) Here, it is anticipated that the label is divided between the two following fields. For this to happen, the label is split by a list of separator characters and words. If the field is followed by a series of unlabeled fields such that the total number of fields exactly matches the non-empty components of the first fields' label after the split, the label is divided. There are additional conditions for the label sharing: * The maximum number of fields to share a label is limited to 3. * The maximum length of the label to be shared is limited to 40. To store the divided labels, a new field |parseable_label_| is added to |AutofillField| which is only supposed to be used in the heuristic type detection. Note, this change only makes the |parseable_label_| available, but does not utilize this yet. This will be subject to a subsequent CL. Change-Id: If098b2aa5a0c3c29a28fff846a4c694c64b837f5 Bug: 1167702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623547Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844596}
-
Maksim Sisov authored
Our current weston version is 6.0.91 and it's pretty old. The latest stable version is 9.0.0. This patch updates weston and does necessary changes to third_party/weston/BUILD.gn to make it compilable with GN. Bug: 1149588 Change-Id: I8dba452cab131052ae3f85486e1f841fc6304847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632585Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#844595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610970273-d0f0048b36f7949e3d42c84fb209656aa5017f8c.profdata to chrome-win32-master-1610981979-8f34756a4da6cb018f171d5c6603852477d6e4b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie0a61b32ea432e01dd46225f6d515d4ad6e6fc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844594}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7b25122c57d4d12b0ea8cbd9dbca1820323e2c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636257Reviewed-by:
-
Tim van der Lippe authored
Required for https://crrev.com/c/2631114 R=jacktfranklin@chromium.org Bug: 1050549 Change-Id: Ibccfb2e59f218754bc9af8254d58e055b60b758e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636315 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Bug: 1152970 Change-Id: I3eab1ea2535c6f03b041519cf3ccf257488f0318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634924Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844591}
-
Patrick Monette authored
The single instance is now owned by ChromeBrowserMainExtraPartsPerformanceMonitor but it can still be retrieved by the Get() method. Bug: 1166820 Change-Id: I27300c2fafb9d5ce04d73397dd791c85efd9393b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630368 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#844590}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c423651c0fb..b434291562fd 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate animation 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate event_listeners 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate layers 2021-01-18 jacktfranklin@chromium.org Inject inspectorStyle.css into the component docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760,chromium:1167724 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I85175a92e7c7f7c16fdf083ef9ab6ae7cb915e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636294Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610970273-10063fdcfa50f030104140b77891927983b7acbd.profdata to chrome-win64-master-1610981979-6557ac3082422cce80dd82b8ef29d8213086e8c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9481ba633ef90044fcc604db8f42f117d3cdcf0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635684Reviewed-by:
-
Mike Reed authored
Bug: skia:11188 Change-Id: I15ebdc464c12537d7c7a489b5b5ff6cb6b9a38a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633747 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844587}
-
Hans Wennborg authored
This rebuilds the current clang version, bootstrapped with the newer GCC version (see second bug) and libstdc++ version. Also add libstdc++ to isolates which use llvm-symbolizer. Otherwise llvm-symbolizer runs with libstdc++ from the host system rather than the clang package; this happened to work before but not anymore. Bug: 1166977, 1164952 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: I739f94aaa3bdc4a0a1c858d0fbf08d1449d4c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633051 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844586}
-
Daniel Nicoara authored
This allows overriding the user agent if an override is set. NOTE: This does require the caller to override the user agent in order for it to happen. If the caller doesn't override, the default user agent is used. Bug: b:175857659 Test: cast_shell_browsertests Change-Id: I713f01076baabe108b17e1d4934f7dc4259b7139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633705Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#844585}
-
Christoph Schwering authored
Bug: 1007974 Change-Id: Ia50bbdef505695f29b9c924dfa4c62ffbd156be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630806 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844584}
-
Guillaume Jenkins authored
Adds support for changing the value of the BrowserSignin policy to 0 while the browser is running. Adds a BrowserAgent that monitors the kSigninAllowed pref, which is controlled by the BrowserSignin policy. When kSigninAllowed changes to false, the BrowserAgent dispatches a command to SceneController to dismiss any in-progress sign-in UI and sign the user out. Bug: 1155745 Change-Id: Ifac4c785f73e098e94be8c3df35040ec60b489c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616278Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#844583}
-
Stephen McGruer authored
This reverts commit af9cb62a, as the hopeful fix for the WPT manifest hang problem in Python 3 has now been landed upstream and rolled into Blink's copy of WPT tooling. Bug: 1161274 Change-Id: I09add44c20931feba69321af70ceba4ac6f31d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630866Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844582}
-
Tommy Martino authored
Per discussion on team chat Change-Id: Ibb2747aadabce3b12204a02d4e4d8f39be0af5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635182 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844581}
-
Wez authored
Previously WebEngine bundled only the en-US versions of several sets of string resources, and included some resources PAKs which did not appear to be used. This also required WebEngine to use the ResourceBundle::InitSharedInstanceWithPakPath(), which is intended only for use in testing. WebEngine now uses ResourceBundle::InitSharedInstanceWithLocale(), and bundles the locale resources: - A Fuchsia implementation of LoadCommonResources() is provided, which mirrors the LoadChromeResources() implementation but loads from a "common_resources.pak" file in the bundle, rather than "chrome.pak". - //ui's DIR_LOCALES path is overridden in WebEngine to redirect to ${DIR_ASSETS}/locales/ - Locale-specific resources are placed in separate PAK files under ${DIR_ASSETS}/locales/. Additional some unused files are removed from the bundle: - Two unused sets of locale-specific resources. - The resource PAKs are moved from |data_deps| to |deps|, to prevent the associated "info" files from being implicitly pulled into the FAR. This will be changed back once the "web_engine" target is migrated off of the cr_package_fuchsia() template. Bug: 1092804, 1164990 Change-Id: I94bc1185e9005ba987b86a2ff39b921daf158858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626443 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844580}
-
Peter Kotwicz authored
This CL makes android_lint_test use the android_nocompile_test_suite() template introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2538313 This CL also modifies the android_nocompile_test_suite() template to: - Support pydeps - To rerun the tests when a "expected_compile_output" value is updated. BUG=1132014 Change-Id: Iee0480feb082a0afed4dbafa2c35d2b5d05851c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620838Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844579}
-
Gabriel Charette authored
R=etiennep@chromium.org, olivierli@chromium.org Bug: 1167247 Change-Id: I034b0b6e095b3b10c5cf4318c11e94f83424aba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633365Reviewed-by:
Oliver Li <olivierli@google.com> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#844578}
-
Jarryd authored
* Extend expiry of PercentDiskAvailable * Extend expiry of AvailableDiskSpace * Add team list owner for each of the abovementioned histograms Bug: 1160830 Change-Id: I85db775d96d07b6a1370994ba496282dff6634ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600044Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844577}
-
Luke Zielinski authored
TBR=smcgruer Bug: 1167318 Change-Id: I123f572db757ebadb275f82f0229eb08bec37478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635794Reviewed-by:
-
Roman Aleksandrov authored
Fixed: 1165222,1160906 Change-Id: Ib1de78e8b170c58add51cbbcf1dc7f28e3eaadbe Bug: 1165222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632596 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844575}
-
Victor-Gabriel Savu authored
Delay expiry of PolicyUpdatePeriod.Device and PolicyUpdatePeriod.User. Bug: chromium:1165053 Change-Id: I8b2d8cb4d009bbb7d0fce0c667f0d3eabf21e2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635151Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f572da65b858..9c423651c0fb 2021-01-18 alexrudenko@chromium.org UI to emulate the color-gamut media feature 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate coverage 2021-01-18 jacktfranklin@chromium.org Lint inline CSS inside .ts components 2021-01-18 andoli@chromium.org [module.json extensions] resources views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1158760,chromium:1166108 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifebf9eda101d72d0a73a25818900f09852906431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636342Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68f15c734d5c..297e1ae19685 2021-01-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from aedd133cd85f to 149733cead63 (2 revisions) 2021-01-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7b69f3d087b8 to 2bb77d70cc64 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic9e06e84963842a98f194bd87cb9579c1757b43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636176Reviewed-by:
-
Patrick Monette authored
At first, this class will own the performance_monitor::SystemMonitor. In the future, it will also own the ProcessMonitor when it no longer is a leaky singleton. Bug: 1166820 Change-Id: Ie47865c3b6e9afcae91be14c22342f3b27685426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630228Reviewed-by:
-
Keishi Hattori authored
If GigaCage isn't enabled, this DCHECK gets triggered PartitionRoot()->PartitionRefCountPointer()->DCheckGetSlotOffsetsZero()->PartitionGetSlotOffset()->DCheckIfManagedByPartitionAllocNormalBuckets() We should check IsPartitionAllocGigaCageEnabled before calling IsManagedByPartitionAllocNormalBuckets. Also removed, PartitionRefCountPointerNoDCheck() as it would no longer be needed. Bug: 1073933 Change-Id: Ida270d718f0299837d1b506966d46512a8c60f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631980 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844570}
-
Michael Ershov authored
* Replace `EXPECT_CALL(..., Func(_))` into `EXPECT_CALL(..., Func)` where checking arguments is not useful. (in most cases it expects a pointer to client object). * Expect specific arguments for function calls where it's not a pointer (just a couple of places with empty vector). Bug: 1150887 Test: CloudPolicyClientTest* Change-Id: I23dd01ad2d868e312d9bdc4135ff7a3b5e7249fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550919Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#844569}
-
Omar Morsi authored
In this CL, the 412 pending approval HTTP status error code is handled by the certificate provisioning client by trying the request after a different delay depending on the request that received this error. Bug: 1167055 Change-Id: Id92ea8f3bc47337144b3e81af2aa7c99a8aa465a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632687Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
-
Caitlin Fischer authored
The server-side configs show that these studies have ended. Bug: 1126640 Change-Id: I4df424208d21cbfe4da72c51693185b6bc9910ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631933Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844567}
-
Miyoung Shin authored
This CL keep a swap promise as active when DidNotSwap is called with the commit fail to fix the problem that WebViewClient#onPageCommitVisible callback is not invoked or callbacks arrive at once. This problem was introduced since the CL[1] converted FrameMsg_VisualStateRequest to mojo because the CL missed the migration from the original code[2] which was being ported. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2342532 [2] https://chromium.googlesource.com/chromium/src/+/c75c53f04b0207e654fd2f7f05e6b785988ea30e/content/renderer/frame_swap_message_queue.cc#124 Bug: 1148808 Change-Id: I935bee95332e775fd13fea15fedc856d34b37649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636094Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#844566}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610959165-ca87807bfba7d6db298cc69229704c835aeb25f8.profdata to chrome-win64-master-1610970273-10063fdcfa50f030104140b77891927983b7acbd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I53ea8f8a0e1ad61a4f44464c05d4c9bc7a4350a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636255Reviewed-by:
-
Ella Ge authored
Pass the Supplier<ModalDialogManager> directly when creating CustomTabLocationBar, so that no need to get it from ChromeActivity. Bug: 1155353 Change-Id: Ibdea28fdd85cbda48cf6c9233afee00f862cdd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633685Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844564}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5c20f1ec9ca9..4b316994ad01 2021-01-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c068cfc1397a to 4a110c2726e9 (1 revision) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from c068cfc1397a to 4a110c2726e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I02d04afd2670999e81f1a8e6265d1d865d64ab04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636337Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610959165-8386a0e84f434425b7043e7053c588f46a3ee84d.profdata to chrome-win32-master-1610970273-d0f0048b36f7949e3d42c84fb209656aa5017f8c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I69fe2399215ad8d7487d258f257e0d33005688aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636293Reviewed-by:
-
