- 14 Jul, 2018 40 commits
-
-
Bailey Berro authored
This change adds StartCopy and ContinueCopy on SmbProviderClient so that SmbFileSystem can call these methods on the SmbProvider daemon over D-Bus. These methods enable chunking units of work of a copy operation since the SmbProvider daemon is single threaded and we do not want to block it during long running copies. Bug: 757625 Change-Id: I3de4df31907c29d872820d13ff5004f82160d663 Reviewed-on: https://chromium-review.googlesource.com/1130821Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#575164}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92e955f2c4ab..76c1d14b8e21 git log 92e955f2c4ab..76c1d14b8e21 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 jmadill@chromium.org D3D11: Lift dEQP-GLES3 uniform_api test expectations. Created with: gclient setdep -r src/third_party/angle@76c1d14b8e21 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I73bf917b663f7baedd0fd8548d32ca63563ecbdd Reviewed-on: https://chromium-review.googlesource.com/1137775Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575163}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1d28414e337..bc2e86dd5900 git log d1d28414e337..bc2e86dd5900 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 06ca634eba4a..92e955f2c4ab (1 commits) Created with: gclient setdep -r src/third_party/skia@bc2e86dd5900 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5d3e1e3f522e8e1c34d9816ce237a97d57891e9a Reviewed-on: https://chromium-review.googlesource.com/1137774Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575162}
-
Anders Hartvoll Ruud authored
Registered custom properties should behave as if they weren't registered for parsing and cascading purposes. Only at computed-value time does the syntax from the registration come into play. R=chrishtr@chromium.org Bug: 641877 Change-Id: I5ed5b334318e653da660b88b2dd912cc0b59f36d Reviewed-on: https://chromium-review.googlesource.com/1136448Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#575161}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2efdb333ae27..d1d28414e337 git log 2efdb333ae27..d1d28414e337 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@d1d28414e337 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I1a8eb8184738f4b0937bc59ba971d90f488c48fe Reviewed-on: https://chromium-review.googlesource.com/1137773Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia0ed04bf8a2c625164a65ec545af3c036562198b Reviewed-on: https://chromium-review.googlesource.com/1137747Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575159}
-
Ned Nguyen authored
TBR=eyaich@chromium.org Bug: 713357 Change-Id: Ib99ad0590a266895c25336747cf202b5406206a5 Reviewed-on: https://chromium-review.googlesource.com/1137378Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575158}
-
Yngve N. Pettersen authored
Commit f8b7b43d introduced a CRLF into the services/audio/DEPS file. This CL fixes that CRLF to an LF Bug: 832129 Change-Id: I58128d5f5da76c219ab6de040d87d7465da7a317 Reviewed-on: https://chromium-review.googlesource.com/1136876Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Cr-Commit-Position: refs/heads/master@{#575157}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4e94c6f5b5c..2efdb333ae27 git log a4e94c6f5b5c..2efdb333ae27 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2efdb333ae27 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5b003a958b4ca0e771b57e6e94c3a3fbd0902b7e Reviewed-on: https://chromium-review.googlesource.com/1137514Reviewed-by:
-
rbpotter authored
Overriding Polymer properties defined in a behavior was never fully specified, and could lead to weird corner cases, which Polymer 2 explicitly decided to address. One new specification is that properties declared as computed in a behavior should not be overridden in elements implementing the behavior. As a result the indicatorTooltip property in CrPolicyIndicatorBehavior can no longer be overridden in Polymer2. Remove this property from the behavior and put it in the 3 elements implementing the behavior individually, while retaining the behavior's computation method since it is used by all 3. This causes CrElementsPolicyNetworkIndicatorTest.All (CrOS only) and CrElementsPolicyPrefIndicatorTest.All to pass with Polymer 2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iab7824c5d69c59b00fa0f1a173e3d5c85ec7d2e4 Reviewed-on: https://chromium-review.googlesource.com/1135631 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575155}
-
Patti authored
Add search function to the All Sites page. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1bfe1ff81a3293962a6263e2a54d38bb06d3d382 Reviewed-on: https://chromium-review.googlesource.com/1126596 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575154}
-
Aga Wronska authored
Bug: 827376 Test: Run DemoSetpTest and WizardController browser tests. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0decf05a353fa8e76823b286e3442d6c0bf98814 Reviewed-on: https://chromium-review.googlesource.com/1116246 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575153}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0cd3404ce483..27e21b72d0d7 git log 0cd3404ce483..27e21b72d0d7 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 vapier@chromium.org lint: clean up old statements 2018-07-14 xiaochu@chromium.org script to generate a DLC artifact 2018-07-14 dgarrett@google.com config_lib: Remove unused shared_user_password. 2018-07-14 mka@chromium.org command_vm_test: disable debug test Created with: gclient setdep -r src/third_party/chromite@27e21b72d0d7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iea613d64ff5f18ea6b497fb248a29a7dc74850d9 Reviewed-on: https://chromium-review.googlesource.com/1137471Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575152}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/455ee3a61e2b..2f38df65f95e git log 455ee3a61e2b..2f38df65f95e --date=short --no-merges --format='%ad %ae %s' 2018-07-14 ehmaldonado@chromium.org gclient: Reset the fetch config also when --force is passed. Created with: gclient setdep -r src/third_party/depot_tools@2f38df65f95e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: I209237bd8578ef1903e4544fc23aa5b1e0f8f8e7 Reviewed-on: https://chromium-review.googlesource.com/1137513Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575151}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06ca634eba4a..92e955f2c4ab git log 06ca634eba4a..92e955f2c4ab --date=short --no-merges --format='%ad %ae %s' 2018-07-14 theoking@google.com Vulkan: Fix premature pointer freeing Created with: gclient setdep -r src/third_party/angle@92e955f2c4ab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0e39285b0af1aaa708f49974b37c199e9f988b8d Reviewed-on: https://chromium-review.googlesource.com/1137512Reviewed-by:
-
Sammie Quon authored
Test: manual Bug: 863472 Change-Id: Ifac38e4a217204e1d4fe311d625b62f52d8be925 Reviewed-on: https://chromium-review.googlesource.com/1136843 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#575149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0df97e8c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21208 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I15bbcb3254c7f59ffc2db3c1fa9e85ffec0a6274 Reviewed-on: https://chromium-review.googlesource.com/1137734 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575148}
-
Pavel Feldman authored
Change-Id: I1ddb0f06353aa88673cb690dfb35d82f8b4559ac Reviewed-on: https://chromium-review.googlesource.com/1136895 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575147}
-
Michael Giuffrida authored
The URLBlacklistManager used to take a callback for overriding the blacklist. This was used for limited guest sessions in OOBE, but all code paths that actually triggered this code have been removed, and these limited guest sessions will no longer be supported. Bug: 850213 Change-Id: I299ccace10529696ba2b581ed861e8c6a6cd769b Reviewed-on: https://chromium-review.googlesource.com/1119073 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575146}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1128ebcb6dde..a4e94c6f5b5c git log 1128ebcb6dde..a4e94c6f5b5c --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0cc291365934..06ca634eba4a (7 commits) Created with: gclient setdep -r src/third_party/skia@a4e94c6f5b5c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5f7672e3336a616d9c3a0d8711c2dda6263996f4 Reviewed-on: https://chromium-review.googlesource.com/1137511Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/579c98612b6f..455ee3a61e2b git log 579c98612b6f..455ee3a61e2b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 ehmaldonado@chromium.org bot_update: Don't pass reset-fetch-config to gclient Created with: gclient setdep -r src/third_party/depot_tools@455ee3a61e2b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: Ib5211668747e1ca339123b4efa6058c774768b63 Reviewed-on: https://chromium-review.googlesource.com/1137491Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4b9e51747be22bd43e5b0b364b716b09032b13b3 Reviewed-on: https://chromium-review.googlesource.com/1137375Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575143}
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/offline_pages and components/previews and components/safe_browsing Bug: 561800 Change-Id: I5162d0c53126edf6b5cd12fae5fcacab634d2719 Reviewed-on: https://chromium-review.googlesource.com/1134936Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#575142}
-
Francois Doray authored
With this CL, Hangouts should no longer be discarded during a screenshare session. See privacy doc update: https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAACBUojIc Bug: 775644, 857495 Change-Id: I2fa58efc58d1a9c92ae49c5eb308514722637c14 Reviewed-on: https://chromium-review.googlesource.com/1136513Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#575141}
-
Lei Zhang authored
The scale factor code calculation code in CreatePreviewDocument() is getting too big. Change-Id: Id6fded23c2d9e07e8400632cd92c22c3b68bc29b Reviewed-on: https://chromium-review.googlesource.com/1136947Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575140}
-
Andrew Grieve authored
Bug: 851596 Change-Id: Id4c18ac2be3c5d05b426f4a0f84a9c46b12352e0 Reviewed-on: https://chromium-review.googlesource.com/1137707Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575139}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cf403ba5720c..bfeb9343ee79 git log cf403ba5720c..bfeb9343ee79 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 thestig@chromium.org Use more ternary operators in content mark code. Created with: gclient setdep -r src/third_party/pdfium@bfeb9343ee79 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5373ff7efa6fa60a9d8c04178270a8a0bcb0ba5b Reviewed-on: https://chromium-review.googlesource.com/1137451Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575138}
-
Sammie Quon authored
Depending on if we start in tablet or clamshell, there can either be a shelf item shown on neither shelf, or a shelf item shown on both shelfs. Test: added test Bug: 863169 Change-Id: Id99c3f270d49db8acea535b689576c3de077ea0c Reviewed-on: https://chromium-review.googlesource.com/1135751 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575137}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e115d5d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21207 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I37ec185c314fb37d631e9c0e0d06c4f8eabaa0e6 Reviewed-on: https://chromium-review.googlesource.com/1137479 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Mina Almasry authored
If the audio underruns or the video decoder implementation on the platform has an issue that prevents it from returning the PTS, these logs become very spammy. Limit them to more reasonable values per play session. Bug: b/111371425 Test: Build Change-Id: Ia03d46733941ce393190d8d742fe8f7aa9e40b2f Reviewed-on: https://chromium-review.googlesource.com/1135933 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575135}
-
dpapad authored
- Update reproduce.sh as necessary. - Add python script to minify Polymer 2 since it does not come minified from bower, unlike Polymer 1. Minified version is 135kb (pre-gzip), which is smaller than Polymer 1 (220kb). - grd files will be modified in follow up CLs, along with the addition of the runtime flag. Bug: 862472 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2d084e9ee37c419175831ff64694f47ea277bba Reviewed-on: https://chromium-review.googlesource.com/1132478 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Currently, when a frame navigates, or a tab closes, we only run beforeunload handlers in the affected frame, but not in its cross-process subframes. This can cause data loss in those subframes. For example, if a subframe contains an editable Google Doc or Office Online doc with unsaved changes, it uses beforeunload to prompt the user about losing those changes. This CL introduces support to dispatch beforeunload handlers to cross-process subframes. We now dispatch multiple FrameMsg_BeforeUnload IPCs and wait for all of them to receive beforeunload ACKs before proceeding with a navigation or tab close. This is done for browser-initiated navigations, renderer-initiated navigations, and when closing a tab or browser. For more details and design discussions, see https://docs.google.com/document/d/1XmwjGNUl_PF9OgDTs0JsRe0iuGrtEk6mzDYGkkbqHKg/edit# A few notable tradeoffs and compromises in this initial CL: - We send one IPC per local root (roughly) and let Blink process same-site descendants. - Cross-site beforeunload handlers run in parallel; we only guarantee ordering among same-site frames. This is similar to how we handle unload handlers. - For now, we always send the beforeunload IPC to a navigating frame. For subframes, we only send it if the subframe has registered a beforeunload handler. - Renderer-initiated navigations still execute the navigating frame's beforeunload before notifying the browser process about the navigation. The browser process then additionally executes any cross-site subframe beforeunload handlers, if needed. This avoids an extra IPC roundtrip. - beforeunload in window.close() is not yet supported. This is essentially a renderer-initiated tab close, and it expects to synchronously set window.closed after executing beforeunload handlers in all subframes. Supporting this is left to a future CL. - Blink currently implements an intervention to limit the number of beforeunload dialogs shown to at most one per navigation. To support this with OOPIFs, similar support is added on the browser side in RFHI::OnRunBeforeUnloadConfirm(). More followup work will be needed here with renderer-initiated navigations and with recording metrics. Change-Id: I0b1f86c119a548ee16d34eff229705748f9560be Bug: 853021 Reviewed-on: https://chromium-review.googlesource.com/1121586 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575133}
-
Xiangjun Zhang authored
This CL introduced CastMirroringServiceHost that will be created and connected to Mirroring Service when mirroring starts. It is used by Cast Media Router Provider to start/control a mirroring session, and also provides the in-process resources to Mirroring Service. This CL creates a video capture host when requested. More implementation will be added in later CLs. Bug: 734672 Change-Id: I405c10cb29c7fcca48cfe4f508783d4d1456b38c Reviewed-on: https://chromium-review.googlesource.com/1115773 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Alan Cutter authored
These names are useful when printing out the views hierarchy while debugging. Change-Id: Ie574d464c68e8bfb83af06a970f96efc655c912b Reviewed-on: https://chromium-review.googlesource.com/1127507Reviewed-by:
-
Mina Almasry authored
A number of changes to improve AV sync at playback start: - AvSync now will not perform corrections if it measures a slope that is way off from what it expects. There are a number of reasons this could happen: - Samples measured right after resuming playback may be from the paused state, which messes with the measured slope. This is especially important given our current interaction with the BufferingController... - Some vendor video decoder implementations will play video at an accelerated rate if they are not able to start playback in time, to 'catch up' to the required value, and then resume normally. We need to ignore this behavior in AvSync. - Modify the initialization of AvSync a bit to treat Start/Stop similar to Pause/Resume. From the prespective of AvSync these should be identical calls, and should maybe be combined to one in the future. Also, due to the interaction with BufferingController, Start is actually Start + Pause + Resume, so we need to treat Resume as we do for Start, because the start of playback is actually the first Resume. - For AvSync to compare the slope to an expected case, it needs to know the current rate of playback, so add code from MediaPipelineBackend to notify AvSync of playback rate changes. - As a bonus, the playback rate change is handled a bit better now. It's not perfect, but this is the first time I'm testing it as it seems no app supports it. - Add ability for linear regression to dump its samples. This is very useful for debugging unexpected slope calculations. This was very useful to root cause the issue. Bug: b/110481225 Test: Manual Change-Id: I28ffa83c633446f2441ff5dfb8d5674b5e149ea5 Reviewed-on: https://chromium-review.googlesource.com/1132518Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#575130}
-
Takumi Fujimoto authored
Add CastDialogMetrics, which will be used by CastDialogView to record various UI metrics. The recorder will keep track of when/if certain events (init, paint, load sinks, first user action) happened, to record when an event happens for the first time, and the durations between events. MediaRouterMetrics calls that CastDialogView was making directly will now go through CastDialogMetrics. Metrics recorded by CastDialogMetrics via MediaRouterMetrics: MediaRouter.Ui.Device.Count MediaRouter.Ui.Dialog.Paint MediaRouter.Ui.Dialog.LoadedWithData (new) MediaRouter.Ui.Action.StartLocalPosition MediaRouter.Ui.Action.CloseLatency (new) MediaRouter.Ui.Action.StartLocal.Latency (new) (MediaRouter.Ui.FirstAction will be added later) (MediaRouter.Ui.Action.StopRoute will be added later) Bug: 853369 Change-Id: Ib27ecc9293fd148d8592b76b22c9fbab3910a5e5 Reviewed-on: https://chromium-review.googlesource.com/1135582 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575129}
-
Yafei Duan authored
Use the first tile of the 'Most Visited' as the homepage tile when NTPButton is enabled. HomepageClient will be used to provide information of the homepage from Java to native side, and the tile will be added (if necessary) along with other tiles aggregated by MostVisitedSites. The homepage tile will always be the first tile if enabled, currently it would not be degraded as other tiles, unless the user removes it from NTP. This CL mostly revives the code removed by the following CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1087048 https://chromium-review.googlesource.com/c/chromium/src/+/1087270, and ignoring the changes related with Chrome Home. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I261a0c4cff8e3beb37f4a97db33512abc87b2f23 Reviewed-on: https://chromium-review.googlesource.com/1132613Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#575128}
-
Ryan Hansberry authored
This provides a simple wrapper around MultiDeviceSetup service, allowing it to easily be stubbed out in tests. R=khorimoto@chromium.org Bug: 824568 Change-Id: I3a15ee75cc2886f15dabd90a8b5bba7712a9201e Reviewed-on: https://chromium-review.googlesource.com/1136897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#575127}
-
Xiaocheng Hu authored
When the first letter part of a text node has 'visibility' CSS property set to non-visible, while the remaining text remains visible, current TextIterator fails to skip the first letter part and proceed to remaining text correctly. This patch fixes that. This patch also reveals other existing issues in TextIterator, which will be fixed later. Bug: 858924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id2a52d229393d9f6c4d3a664ac24d794e836cff1 Reviewed-on: https://chromium-review.googlesource.com/1134487Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575126}
-
Takumi Fujimoto authored
When the dialog reports the number of sinks, pseudo sinks should be excluded, because they aren't real sinks and they inflate the number of devices recorded. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb8840c0a06c98ca76275e682fcfa42ca52629a8 Reviewed-on: https://chromium-review.googlesource.com/1137029Reviewed-by:
-
