- 01 Aug, 2019 40 commits
-
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //components/spellcheck. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I0be9f65ba47c24cce99c36d9628d38675dbc575b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730050Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683184}
-
Chris Hamilton authored
VoteConsumers can implement this efficiently, or choose to invalidate a vote and create new one. BUG=971272 Change-Id: I47bf89b6abe223807a2a09b9ba47a2054d241e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724701 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#683183}
-
Fergus Dall authored
Bug: 989802 Change-Id: I34ec22b46276e4c52500e58b9d63d3dc5c2d7376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731294 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#683182}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1532d22050cb..a00318f1ad00 git log 1532d22050cb..a00318f1ad00 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 michaelludwig@google.com Consistify image filter implementation code layouts Created with: gclient setdep -r src/third_party/skia@a00318f1ad00 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6779b459ac8df81a3e538e5dbfbd4d17e35753cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683181}
-
vitaliii authored
On Win because flaky. TBR=siggi@chromium.org Bug: 989810, 732501 Change-Id: I2a168771aee0789b2c2845dc4f9d4c1d180e2e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730905Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683180}
-
Roman Sorokin authored
Was broken on multiprofile-signin screen in CL:1710000 Bug: 987588 Change-Id: Icb0330b4e427e56215796a7aea21c7fcb5724e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730451Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683179}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14cf766b..7ae4b7f3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a4fe6ae8404ca2ff51e235d1304979e80e6efd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683178}
-
Nico Weber authored
TBR=hans Bug: 989932 Change-Id: Id91684d103ad0ce6970c8b69d530d6faf84fc6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731429Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#683177}
-
James Forshaw authored
This CL removes the dynamic linking of Vista-era APIs in preference to static linking. To prevent the uxtheme DLL being loaded unnecessarily the DLL is added marked as delay loaded. Bug: 986625 Change-Id: I29987f493b7fdf92633b3ba4dde61573b5543bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720905Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#683176}
-
Geoff Lang authored
BUG=979342 Change-Id: I9832cc96f3530412a314f79ac9399e93fa986142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680280 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683175}
-
Chinglin Yu authored
WindowedIncognitoObserver provides the interface for querying the current status of incognito windows, and watch for new incognito window opening. The interface can be used off the UI thread. WindowedIncognitoMonitor is used to create WindowedIncognitoObserver instances off the UI thread. Internally, the implementation class, WindowedIncognitoMonitor, is registered as a BrowserListObserver to observe opening/closing of incognito windows on behalf of queries from WindowedIncognitoObserver. Bug: 904785 Test: Add unit_tests WindowedIncognitoMonitorTest.* Change-Id: I936d679c1963e1ffc1a5bbc5c4470274200d100c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692208 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#683174}
-
vitaliii authored
Flaky. TBR=rockot@google.com Bug: 987448 Change-Id: I6db59e7ce6ac618320e10bfe85b1aa700e0fbce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730902Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2bd4cf346e06..ec6ed57a688e git log 2bd4cf346e06..ec6ed57a688e --date=short --no-merges --format='%ad %ae %s' 2019-08-01 rnasri@google.com Add rects based speed index utility functions Created with: gclient setdep -r src/third_party/catapult@ec6ed57a688e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:982025 Change-Id: If708a72fa7aeaf0b5ccc031984e96f312a07dec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730951Reviewed-by:
-
Tibor Goldschwendt authored
Updating paths, add conditional install, clarify limitations. Change-Id: I9f3015b8b59015e6f84a6eb87870d68adc8c1bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730573Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683171}
-
Takuto Ikuta authored
Each builder has around 10 hour hourly resource usage in p99. http://shortn/_gZ2rCCbPNR So I expect this won't add much burden to existing xenial pool. Current usage is in https://datastudio.google.com/s/uf5Kh6NZ8XA And we have 3400 xenial bots in MTV time now. Bug: 954890 Change-Id: I18d8e0cd6e8609f4bb924e348555c8d38d14d1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730492Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#683170}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //content. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I64e94630bdf74821ab454af05240082715a916f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728529Reviewed-by:
-
Chen Xing authored
This change adds the expectation that the `RTCRtpReceiver-getSynchronizationSources.https.html` web test may start to fail (by timing out) after we've fixed bugs.webrtc.org/10545. It also adds a new pair of audio-only/video-only browser tests to restore most of the coverage. This change should be reverted once we've figured out how to fix crbug.com/988432. Bug: chromium:988432, webrtc:10545 Change-Id: I74410dc93e90dd0ce781d4ce8e6a2fc7c8a2dd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728565Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chen Xing <chxg@google.com> Cr-Commit-Position: refs/heads/master@{#683168}
-
Carlos Knippschild authored
Bug: 988744 Change-Id: I390208908f9f5d92f1137b45a1f5e911ba170061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730101 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#683167}
-
Xiyuan Xia authored
TopControlsSlideControllerChromeOS only update |shown_ratio_| for the active WebContents because its ratio is meant for the whole browser window. This should fix the flakiness due to premature WaitForRatio return caused by background WebContents ratio update. Also fix a typo in OpenUrlAtIndex to use |index| arg instead of hard coded '0'. Bug: 983791 Change-Id: I5d8fb7dbfa2ee5bea31130cab215071fc6304198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729531Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683166}
-
Philip Rogers authored
Non-fast scrollable regions are regions on a cc::Layer where the compositor should not handle scroll events. These are primarily for non- composited scrollers but are also used for resize controls and plugins. This patch paints non-fast scrollable regions for plugins that have blocking wheel event handlers. A design doc for this approach of painting non-fast scrollable regions is at: https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj This patch shares the pattern used by non-composited scrollers of emitting ScrollHitTestDisplayItems. ScrollHitTestDisplayItem has a field for supporting both scrolling (kScrollHitTest) and non-scrolling (kPluginScrollHitTest) usecases. This field was required because it will be possible to have two ScrollHitTestDisplayItems for one scroller: one for non-composited scrolling, and a second for a resizer. ScrollingCoordinatorTest::NonFastScrollableRegionsForPlugins is the interesting new test. It shows that PaintNonFastScrollableRegions matches the current behavior for non-fixed plugins, and shows that fixed plugin non-fast regions are now painted in a different layer. Painting the fixed non-fast region into the fixed layer fixes a bug where the non-fast regions would not be updated after compositor changes such as scrolling. Bug: 864567 Change-Id: If72e084241d1684e54d4c02e5d1efc04d91cc858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729551Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683165}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eaa7b5baa3..84de3d95cf0e git log 32eaa7b5baa3..84de3d95cf0e --date=short --no-merges --format='%ad %ae %s' 2019-08-01 oprypin@webrtc.org Factor framework dependencies out of audio_device_impl Created with: gclient setdep -r src/third_party/webrtc@84de3d95cf0e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iea3235882b81a2449173fbb5ddf1c96f0c7cc384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730695Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 980828 Change-Id: Idfcf9c53f0db7e2ab24dcc29ce2d21a10096442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730892Reviewed-by:
-
Arthur Hemery authored
This CL removes most of the references to PlzNavigate in the comments of content/. Some problematic cases where further expertise is needed are left out, but this covers more than 90% of the references. Change-Id: I6e060a5a92afe6ad3e078e3e5351020e4a85565f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729082 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683162}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/27e2873765fa..204a410c8c40 git log 27e2873765fa..204a410c8c40 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 bclayton@google.com SpirvShader: Add a single-entry, last-used sampler cache Created with: gclient setdep -r src/third_party/swiftshader@204a410c8c40 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137649247 Change-Id: If5c4128cce57a38454ad3e3ed1df8b70595beb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730693Reviewed-by:
-
Mohamed Amir Yosef authored
The feature flag has been introduced as kill switch for the change in https://chromium-review.googlesource.com/c/chromium/src/+/1530906 The change stick and then the feature flag isn't needed any more. More details are in the linked bug. Change-Id: I35bd6ff3b221b28e1df14af6156741ff487fca5e Bug: 943579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730160 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683160}
-
Henrique Grandinetti authored
Bug: 988107 Change-Id: Ia9c12a9342342bc080f73ddbe5ba86531b29997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724696Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#683159}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenRemoved in O2ATMtest to test that StartRequest triggers DiagnosticsObserver::OnAccessTokenRemoved which is triggered by ClearCacheForAccount, ClearCache and InvalidateAccessToken. Bug: 967598 Change-Id: Icc49cdc4848ca1e2891b21bb0ac945a9902f2648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728710 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683158}
-
Takuto Ikuta authored
Change-Id: Ib765ab8df18b5f05b3d40e45c426ef6e2c9428ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731169 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#683157}
-
vitaliii authored
TBR=hiroshige@chromium.org Bug: 855860 No-try: true No-Presubmit: true Change-Id: Ied837a5647454a324576de77dc7359b8cb280715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730161Reviewed-by:
-
Benoît Lizé authored
This was unused since at least 2016 (see crbug.com/657093). Remove the code to support this both in LegacyLinker and ModernLinker. In the process, further unify the two linkers, and refactor state tracking. Bug: 979638 Change-Id: I4fad98228a841e1959a93f8ef5dbe5d29dfe7f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715485Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683155}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21b7351d. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia7dcc34fd929aaa29f56815bbd6d8e6c728a2cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729479Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683154}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnFetchAccessTokenCompleteOnRequestCompleted to test that OnFetchAccessTokenComplete is invoked when a request is completed and OnFetchAccessTokenCompleteOnRequestWithoutRefreshToken to test that it is invoked when a request without a refresh token is started. Bug: 967598 Change-Id: If869a4e3647f496f66c58b6547ddb0e6b15a4eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728410 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/470527ec6414..c17e81c243e3 git log 470527ec6414..c17e81c243e3 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 lalitm@google.com base: fix build of UUID on mac Created with: gclient setdep -r src/third_party/perfetto@c17e81c243e3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I43130b5835a405ee65833d19baee662e3ca583f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730692Reviewed-by:
-
Dominic Battre authored
A number of features in autofill depend on the app_locale (e.g. phone number parsing). This CL introduces logging case the locale is impacting the correctness. Bug: 928595 Change-Id: I0801be9271569b0a195b48fa0c7a109d87361d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727291Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#683151}
-
Anders Hartvoll Ruud authored
With the introduction of @property in the spec, we added an at-rule descriptor called "syntax". It is very confusing to have two slightly different things named "syntax descriptor" in the same spec, hence we renamed the first syntax descriptor concept to syntax definition [1], in order to avoid confusion with the at-rule descriptor named "syntax" [2]. There is no web-facing or behavior change in this CL; it's just to align our naming with the spec. [1] https://drafts.css-houdini.org/css-properties-values-api-1/#consume-syntax-definition [2] https://drafts.css-houdini.org/css-properties-values-api-1/#the-syntax-descriptor Change-Id: Ib0183950a49c156ee844c2eadf4208bac47a4d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722947 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#683150}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db2e0c7d..14cf766b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf590aa017e4d4a9f5d10e010a2ac9f1e1386869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729892Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenRequested in O2ATMtest to test that StartRequest triggers DiagnosticsObserver::OnAccessTokenRequested. Bug: 967598 Change-Id: Ia6b9a85d646571d7039d94a1d047cfed02fef1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727112 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d5085a0056a..682bc0e14c7a Created with: gclient setdep -r src-internal@682bc0e14c7a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:954450 Change-Id: I06b34bf37e936aae8a97c919f30c6328342f66bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683147}
-
François Beaufort authored
This CL adds the "readonly-storage-buffer" bind group layout binding type. When used though, it currently raises a validation error as Dawn doesn't support it yet. It also removes the unused `dynamic-uniform-buffer` bind group layout binding type. Bug: 877147 Change-Id: I3266b8931fee3e3f66dd170771195374132feaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730911Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683146}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //sandbox/mac. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I4d0ef55ee27bda9a8abd502d639db3f80bce9fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730771Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683145}
-
