- 09 Jan, 2020 40 commits
-
-
Takuto Ikuta authored
Before rename, let me remove 'ChromeOS Swarm'. This does not have appropriate setup now. Bug: 955013 Change-Id: I5a520236b01dc969b041b6b6db6c2ef7bff37900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992950 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#729665}
-
Rijubrata Bhaumik authored
This CL adds some documentation for the NFC module in Chrome. The detailed design documentation is located at https://sites.google.com/a/chromium.org/dev/developers/design-documents/web-nfc and the READMEs do reference that document for more details. Bug: 520391 Change-Id: Ib8b7632d0bf9bba2b3de9fb1b9bf4f528fa11162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985961 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#729664}
-
Marc Grimme authored
This is a reland of f1f1258e Original change's description: > Fixed overwriting of static default_policy_hosts > > The default policy for allowed or blocked hosts is overwriting > from different contexts(profile) and can lead to wrong policies > being applied to extensions (see bug #1028577). > > This fix creates a static map that stores the profile (by id) and the > relevant default_policy_allowed_hosts/default_policy_blocked_hosts in > a struct. > > TODO: > Write integration tests (crbug.com/1031179) > > R=marcgrimme > > Bug: 1028577 > Change-Id: Ie08447ddd5175562b474fa5801f6959315372c6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946368 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Marc Grimme <marcgrimme@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726333} R=marcgrimme Bug: 1028577 Change-Id: Icf51024c16c110ae71a7d7100714ced3100b0055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978680Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#729663}
-
Koji Ishii authored
This patch supports hit-testing culled inline boxes by leveraging |NGFragmentItem| generated for them by <crrev.com/c/1774425>. This patch recovers the most of regressions in the CL, in addition to fixing ~70 failures. Bug: 982194 Change-Id: I094a77440e5040fcd5a2d8f864c4d95d85925fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989727 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729662}
-
Theodore Olsauskas-Warren authored
To support the display of recently changed permissions to the user as part of the the privacy settings redeisgn, the ability to query when a permission was embargoed is needed. This CL introduces a GetEmbargoStartTime function in the permission auto blocker that facilitates this. Bug: 1032584 Change-Id: I04da71522175a8e59051b45e7573bd65468e78cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983216 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729661}
-
Hiroki Nakagawa authored
This fails on win bots: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/43765 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/98722 Bug: 946023 Change-Id: I59c01572ffbf33416fb3c13d44234281bc3330e2 Tbr: crouleau@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993064Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#729660}
-
Daichi Hirono authored
When accessibility event from Android does not fulfill correct task ID, ArcAccessibilityHelperBridge uses window ID as an identifier of surface instead. BUG=b:146591913 TEST=None Change-Id: I8a5a4750e02de3a2fa22b673c9018d02cc6d8592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982507 Commit-Queue: Daichi Hirono <hirono@chromium.org> Auto-Submit: Daichi Hirono <hirono@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#729659}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92ca3baba6a5..1d457b7d9533 git log 92ca3baba6a5..1d457b7d9533 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 61f03e9a..5d178c93 (411 commits) 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 45a4d0f36bd6..77c89ff847b6 (13 commits) 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 db49bc7dd075..c431d59626e1 (7 commits) Created with: gclient setdep -r src/third_party/skia@1d457b7d9533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Id2e168e6c30ed64174239a2863dc93114047c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729658}
-
Christopher Lam authored
Bug: 1036932, 1037124, 1037000, 1037295 Change-Id: I99d7265fb4a8af9bc4ef19d1ac61bef2e06643ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988089 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729657}
-
Koji Ishii authored
This patch changes to generate |NGFragmentItem| for culled inline boxes. In common cases, inline boxes are not needed for paint purpose, and that we suppress generating |NGPhysicalFragment| for them. However, hit-testing, |getClientRects()|, and some other scenarios require the coordinates of such inline boxes. Synthesizing it saves memory, but has drawbacks in the performance, the correctness, and the code complexity. With this change, we always generate |NGFragmentItem|, while |NGPhysicalBoxFragment| is still suppressed when possible. Some related code need to change accordingly; e.g., hit- testing and |NGInlineCursor|. ~120 new failures are due to the lack of these changes. They will be fixed in following patches. Bug: 982194 Change-Id: I53a336952202087abb0f80214354d092e970a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774425 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Glen Robertson authored
Split out from subsequent CL crrev.com/c/1897398 plus surrounding cleanup. Mostly refactoring except: -remove deprecated metric logging. -diverge when the "Open in PWA Window" menu item is enabled. Previously this used the same CanCreateWebApp check as "Create Shortcut" and "Install <PWA>". The presence of this item is already controlled separately (by checking whether the page is in scope of a PWA) so most of the checks in CanCreateWebApp are redundant. The relevant checks are within AreWebAppsUserInstallable (but just calling that method is answering a different question). So copied body of AreWebAppsUserInstallable. Subsequent CL will modify CanCreateWebApp. Change-Id: Ib2a32b74637be89b6ac230f4d046e31316512680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989739 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#729655}
-
Jinsuk Kim authored
There is a timing issue that keeps the desired bottom sheet content height from being set correctly if tab switcher is invoked between device rotation. The activity tab from which the desired content height is obtained can be still be null when the height change occurs. Currently the related logic does nothing in this case, and the following layout change events cannot update the height either, since they see no change in the height. Therefore, BottomSheet.mContentDesiredHeight retains the old value in |ensureContentDesiredHeightIsComputed|, not being able to get updated with the right value. This CL fixes it by keeping track of the current content height, and updating it when a valid height is available. Bug: 1039204 Change-Id: Id173e90ac35bc3177f647f3c937da61089de7516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989305 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729654}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8d82854..1c30f07c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If24e11f16a7e67bfe4f13ce4b0cc1cc80993ebc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992524Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729653}
-
Miyoung Shin authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/screen_orientation. Bug: 1001114 Change-Id: Ie5d342d6a2a78bb9f44345e7ef61322a188f6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986478Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#729652}
-
Kent Tamura authored
Move Node::DispatchInputEvent() and HTMLFormControlElement::DispatchChangeEvent() to HTMLFormControlElementWithState Only subclasses of HTMLFormControlElementWithState require 'input' and 'change' events. This CL has no behavior changes. Change-Id: Iefe8b128c4b63cc95dc27d660064ad8cec3b4f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990892Reviewed-by:
-
Yoichi Osato authored
This patch makes some parameters |const T&| than |T| to avoid unnecessary copy. Bug: 787704 Change-Id: I914043a82192c18a3db535c77a3a29ab742fd1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989319Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#729650}
-
Hiroki Nakagawa authored
This reverts commit 73d4b9c4. Reason for revert: WebTimeLimitEnforcerThrottleTest.WhitelistedSchemesNotBlocked added by this CL consistently fails on the linux-chromeos-dbg bot. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16315 Original change's description: > Update WebTimeLimit url filter > > This cl does the following: > 1. Adds PrefChangeRegistrar to AppTimeController to enable it > to be notified when user policy has changed. > 2. Enables prefs::kPerAppTimeLimitsWhitelistPolicy policy to be > used in WebtimeLimitEnforcer. > > Bug: 1015661 > Change-Id: Ifd5e0ddc3df9f564ffb018244e652c8b88586865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946936 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729598} TBR=agawronska@chromium.org,yilkal@chromium.org Change-Id: I4db2da830fb68915698b72e8648235ba504abc3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992953Reviewed-by:
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: I31ad5129006e54a0f2d54008fadc6e5a22358b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981520 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#729648}
-
rbpotter authored
Bug: 986596 Change-Id: I473937026ba6d3d14e7de973c325033d7c8484a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990566 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729647}
-
Peter Collingbourne authored
We no longer support bundling the HWASAN runtime with the application, and the support for doing so has been removed from the compiler (see https://reviews.llvm.org/D69574), so this flag has no effect when true and bundles a runtime that doesn't work when false. Bug: 916828 Change-Id: Id2f51b6ed74d1685b896167aab4ee3a26149b665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991706Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#729646}
-
Naoki Fukino authored
ImageLoader still has many vars in its scripts. It will make presubmit linter unhappy even when we modify an line in a file in the future. Let me eliminate all vars beforehand. Bug: 778674 Test: Confirm that thumbnails of image files (incl. raw files) are correct. Change-Id: I6960d6c37f9791f4d3ad52be0cbf607af3bd8337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991056 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#729645}
-
Yoichi Osato authored
This patch introduced a subset of ResourceRequest for test checking. This is a preparation to make ResourceRequest non-copyable. Bug: 787704 Change-Id: Ibca48006e4cf9ec6fd75fc935e3d32135d319d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989736Reviewed-by:
-
Alan Cutter authored
This CL adds a DesktopPWAsTabStrip flag that's disabled by default which adds Chrome's tab strip UI to PWA windows. This is purely for experimentation and communication with UX. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=424245&signed_aid=oQpgjaC2V3-UC0L_ziRbsg==&inline=1 Bug: 1020050 Change-Id: Icd19f9ba58b60c5c9b042fcf3c6325a2c7a555f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950727 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#729643}
-
Zain Afzal authored
BUG=chromium:1040328 Change-Id: I8654ad18ce083e75dc52a46279f914436010ae9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990888 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of content/renderer to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - content/renderer/service_worker - content/renderer/worker This CL has no behavior changes. Bug: 1001360 Change-Id: I4651c616e0aec1397842d70a282037543a8130f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989286Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#729641}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d462e99bc1f..081c5b597968 git log 0d462e99bc1f..081c5b597968 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@081c5b597968 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4e9d9575545f6e7a7b147d854cc1d82e8bc94b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992733Reviewed-by:
-
Peter Wen authored
Tbr: mcarlen@chromium.org Bug: None Change-Id: I7d5ad07696f0db90326a72bd1dc607fb4407ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992811Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729639}
-
Chris Blume authored
Wide color gamut on Pixel 4 was already enabled by default, but the rigging was setup as though it wasn't. Part of the feature roll-out is to mark the feature as enabled-by-default. This CL mimics that step (but leaves it already enabled-by-default) by removing the field trial and updating the feature check to no longer require that field trial. Bug: 1021181 Change-Id: I556a25b39f667e2e9199fb8d6d9b8f680d97fee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992010Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53a21700cf15..b629ec3917da git log 53a21700cf15..b629ec3917da --date=short --first-parent --format='%ad %ae %s' 2020-01-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-09 kahinds@microsoft.com Add some keyboard interactivity to the Animations tool 2020-01-08 brgoddar@microsoft.com Network: Add Screen Reader announcement when data is available 2020-01-08 Rob.Paveza@microsoft.com Fix for too-long length of command line in Windows build. 2020-01-08 tvanderlippe@chromium.org Migrate profiler/ to ESM 2020-01-08 aerotwist@chromium.org Removes global Host refs from ui 2020-01-08 Rob.Paveza@microsoft.com Squelch CSS race condition error on edits 2020-01-08 aerotwist@chromium.org Reland "Migrates refs to Common inside ui/ to ESM" 2020-01-08 almuthanna@chromium.org Add test files for existing classes 2020-01-08 tvanderlippe@chromium.org Use module scope for workers Created with: gclient setdep -r src/third_party/devtools-frontend/src@b629ec3917da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561,chromium:1039577,chromium:1040233,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10e6a8f0b9dbea99c753ae32defcbd4b650636b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992866Reviewed-by:
-
Timothy Loh authored
This CL renames 'Launcher' to 'Installer' in the flow for installing Plugin VM, to more accurately match what is happening. This includes resources, variables, functions, and the following classes: PluginVmLauncherView -> PluginVmInstallerView PluginVmImageManager -> PluginVmInstaller PluginVmImageManagerFactory -> PluginVmInstallerFactory Change-Id: Ie1fc0be0c4bb0d0fbb20728a4a25ba9307760e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985837Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#729636}
-
Demetrios Papadopoulos authored
- Extract registration of handlers still needed by CrOS browser settings to a new InitBrowserSettingsWebUIHandlers - Stop calling InitOSWebUIHandlers InitOSWebUIHandlers itself will be moved to os_settings_ui.h/cc in a followup. Bug: 990166 Change-Id: I332493f81e53eec1a40ac10b6c4b08c3b6c4da2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991940 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729635}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f86589d1522..9553930c2093 git log 7f86589d1522..9553930c2093 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 primiano@google.com Merge "tracing: Remove duplicate data source static data member definition" Created with: gclient setdep -r src/third_party/perfetto@9553930c2093 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8723207f78eb04f874ce248c43084b4237c84ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991836Reviewed-by:
-
chrome://extensionsToby Huang authored
When a child user has an extension installed but lacks sufficient custodian approval, the extension is force-disabled on the chrome://extensions page. The toggles for enabling the extension are force-disabled as well. This CL replaces the force-disabled toggles with buttons that open the parental approval dialog directly on the chrome://extensions page, so that the child user can obtain custodian approval to enable the extension. Bug: 1030958 Change-Id: I284221d37ba2ce51fd2afe178bbf1eaf69f2e1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956227 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#729633}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in device/bluetooth to reduce the pre-processed size of header files and shorter build time. This CL has no behavior changes. Bug: 1001360 Change-Id: Ic450fb4a402c6a2e1d825a20ed271f63dac36b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989299Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e83d8b4f0dd4..f793e3abc4ec git log e83d8b4f0dd4..f793e3abc4ec --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tsepez@chromium.org Remove FWL_STYLEEXT_DTP_LongDateFormat. 2020-01-09 tsepez@chromium.org CFWL_WidgetTP::Initialize() and Finalize() are unused. 2020-01-09 tsepez@chromium.org Remove CFX_Break::SetDefaultChar() 2020-01-09 tsepez@chromium.org Warn about stale |this| in CXFA_FFWidget::On*() methods 2020-01-09 nigi@chromium.org Change StringToCode() to return Optional<uint32_t> type. 2020-01-09 tsepez@chromium.org Rename CXFA_FFWidget::OnHitTest() to HitTest() 2020-01-08 dhoss@chromium.org Use std::unique_ptr inside FPDFDOC_ExitFormFillEnvironment() 2020-01-08 tsepez@chromium.org Clean up stale pointer in CXFA_ViewLayoutProcessor::MergePageSetContents() 2020-01-08 tsepez@chromium.org Give better names to CXFA_ViewLayoutProcessor members 2020-01-08 tsepez@chromium.org Comment move behavior for fxcrt string and pointer types. 2020-01-08 tsepez@chromium.org Move CXFA_Node property manipulation out from CJX_Object. Created with: gclient setdep -r src/third_party/pdfium@f793e3abc4ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1038489,chromium:1039257 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4491d9de0bb7b921ade17c3e589d1679e9337102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992863Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a6e84920793..92ca3baba6a5 git log 4a6e84920793..92ca3baba6a5 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mtklein@google.com JIT today's new _imm ops 2020-01-08 herb@google.com Hoist calculations up to regenerate 2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-08 mtklein@google.com skip no-op masks 2020-01-08 egdaniel@google.com Move the remainder of GrRenderTargetContext factories. 2020-01-08 mtklein@google.com refactor bit ops Created with: gclient setdep -r src/third_party/skia@92ca3baba6a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I10eaa1bed08c8d239f46be047b8199c8d12442ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992726Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f5e1e29..e8d82854 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I196476da575af24b673f1bcbe04402edf5211e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992522Reviewed-by:
-
Kurt Horimoto authored
The iteration loops mistakenly early returned if any observer didn't support a request. This prevents code after an observer iteration from running if any of the observers don't support that request. Bug: none Change-Id: I8fe428ecbdaf54f416cf4bde547bc6aca9d10351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992362 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#729628}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I4cab0bf1f79e355975ed9abf729c1fac7b61e92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991993Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729627}
-
Daichi Hirono authored
BUG=b:146591913 TEST=ShellSurfaceTest.SetClientAccessibilityId Change-Id: I96c5086a9162114432e83c01ac0a36b947ffb180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981963Reviewed-by:
-
