- 03 Jun, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
This CL introduces MultiStoreExceptionEntry, which is the analogous of MultiStorePasswordUiEntry (crrev.com/c/2202237) for exceptions. The common logic between these two classes is moved to a common base class. Future CLs will use the new class to deduplicate the passwordExceptions array in PasswordsSection. The CL also reorders some includes in settings_resources_v3.grdp that were not in alphabetical order. Bug: 1049141 Change-Id: Ibf64de15f49cf20c2f4b310f9a86341a41f6f3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225408 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#774554}
-
Kent Tamura authored
This CL has no behavior changes in production. - Tests which should be fixed are listed in TestExpectations - overhang-*.html tests have notable changes. They are progressions. RubyNG allows to overhang on whitespace-only text nodes. - Other pixel results in this CL are due to differences between LayoutNG and the legacy layout. Bug: 1069817 Change-Id: I4a1b8953f984de2841bb4e964534354286a64fb3 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228009 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774553}
-
Alexey Baskakov authored
Implement backward compatibility uninstall of Web Apps via shadow Bookmark Apps. On a web app uninstall we also must uninstall the shadow bookmark app. All uninstall changes for the extensions registry get propagated to the sync server (syncer::ModelType::APPS) and to all devices where BMO is disabled. Design doc: go/chrome-bmo-migration. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2162507 We do only legacy uninstalls in this CL to fix the bug. Bug: 1020037, 1086909 Change-Id: Ib65edc2762de38f050afedb00ffe06665845431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228371 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#774552}
-
Harald Alvestrand authored
Bug: chromium:1030631 Change-Id: Idc0b9fe6d4c4db05741cd477ad25f98f83b554e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196165Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774551}
-
Nigel Tao authored
I left this part out from the previous crrev.com/c/2222055, which added new code but forgot to delete the deprecated code. Bug: 1070409 Change-Id: Id84bab3ac58b8e0bab979a4fb8ffacbd5d7faa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227941Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL prepares for the introduction of the new "passwords on device" WebUI page. It extracts the logic that is common with the existing page into a new PasswordsListHandler Polymer component. This includes mostly handling requests for copying a password, viewing its details (Edit Dialog) and removing it. The new component does not own the list of saved passwords, those are still retrieved by its embedder. The lists with different subsets of saved passwords (all, device-only or device+account) will be injected by the embedder as well. Bug: 1049141 Change-Id: Iefb9e6bd7d58f43ff4ed57f74983f939b0e1eb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224860 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f050cca7ec47..636f449e1529 2020-06-02 jaebaek@google.com Add tests for merge-return debug info preservation (#3389) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I30d104ca0476586b687a01b28710387668494f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774548}
-
Rob Buis authored
Extend the MathML painter class to be more generic and offer an API through NGMathMLPaintInfo to paint MathML fragments besides fractions, i.e. the upcoming operators and radicals. Bug: 6606 Change-Id: I8b143fc02965fa2d757b19d026d99c693dc33f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190676 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#774547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id13615fffa50143e0b787cbd617843d7f525a8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228485Reviewed-by:
-
Nico Weber authored
Reverts parts of #771096. With this, our clang (and other binaries in the clang zip) no longer have a RUNPATH containing an absolute local path that only exists on the machine that built it. Bug: 1077698 Change-Id: I91a5794c7d3d211bc38e10173690c849d37ba708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225241 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774545}
-
Yuichiro Hanada authored
Key event dispatch order is changed for ARC apps window to support View.onKeyPreIme() API on ARC apps. While the ARC apps are focused, a key event is sent to exo::Keyboard before it's sent to IME. In this case, exo::Keyboard should send a key event to a client always. Please see go/arc-key-event-dispatch for the details. Bug: b:148193316 Test: exo_unittests Change-Id: I65cf1c2eb20eb20bc7767710b7c23e9269404428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215532 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#774544}
-
Thiemo Nagel authored
This reverts commit 8843210d. Reason for revert: I suspect this is causing test failures on Lollipop Phone Tester: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.password_manager.OnboardingDialogIntegrationTest#testOnboardingAccepted https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.infobar.SyncErrorInfoBarTest#testSyncErrorInfoBarForAuthErrorView https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.sync.UkmTest#testMetricsConsent Original change's description: > [Android][Test] Fix flaky bookmark signin promo tests on tablet > > This CL fixes the flaky bookmark signin promo tests on tablet by > destroying the activity in SyncTestRule before tearing down the > mock signin environment. > > Bug: 1088464, 1088730 > Change-Id: Ide2179edc3f4e2ddd1e115d7b8aa512976dca548 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224258 > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774096} TBR=bsazonov@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org Change-Id: I029d6c6b2532819741553c2003c51ff3a96246b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088464, 1088730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228721Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774543}
-
Vasilii Sukhanov authored
The problem was that the Mojo callback was destroyed after the pipe. The fix is to close it a bit earlier than all WebContentsObserver destroyed. Bug: 1090011 Change-Id: Ibc9406808d7fdd1e7fa1c49a32ca68b15522a74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224265Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774542}
-
Maggie Chen authored
Add an info-update callback function to DirectCompositionSurfaceWin so the status change of HDR, direct composition or overlay can be propagated to the browser. The status change could be a result of swap chain creation failure. Bug:1089998 Change-Id: If3ca647cf73edbb776b35775dcc7df46ea8b5ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225144Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774541}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ib33f9511d2564132bc982da53432f0f4cc4fd1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227899 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#774540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/171bd736f2ad..15d5f65efa22 2020-06-03 dberris@chromium.org auto-bisect: Support explicit opt-out If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087820 Tbr: wenbinzhang@google.com Change-Id: Ib6bac675a14bf5a517bcedcd7b33900866471311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227688Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6fbe9310fbb8..b6a8b828fd50 2020-06-03 alexrudenko@chromium.org Move overlay tools to DevTools 2020-06-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1078267 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ba40f926fadeabd89081c322372b8ce6e728382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228477Reviewed-by:
-
Peter E Conn authored
When updating our code to AndroidX.Browser's API changes[1] this bug crept in. Previously `execute` would return a boolean that would be false if we couldn't find a TWA for the given scope. The new version, returns a ListenableFuture. While moving the code over, this requirement got skipped and now when a TWA doesn't exist, we still return `true`. This CL fixes that. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1940329 Bug: 1082718 Change-Id: I78aef4695d1467748590a62b3192d8a76cfcbfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226816Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#774537}
-
tby authored
This is CL #2 for integration testing. It uses the new ResultType method to allow search providers to report _which_ provider is returning results on an update to the SearchController. The SearchController has also had a callback hook added, which is passed the updated result type on each call. This hook can be used by a browser test to control a run loop that stops when the desired set of providers have returned. See the CL description in crrev.com/c/2214736 for more details on the implementation plan for integration tests. Bug: 1086713 Change-Id: Iedd8e7ce6824dc6c90623837342456db26494069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217945Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#774536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71745c66e974..03e4d15d1fa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I945a889b58fffc383aa8e5e92ad9e69e596aa1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228475Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774535}
-
Giovanni Ortuño Urquidi authored
Has been flaky on macOS 10.13: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25584 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25587 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25588 TBR=foolip@chromium.org Bug: 1007228 Change-Id: I2cc599f67cba5e4a8768a24891f69563433e7fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227942Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#774534}
-
Bartek Nowierski authored
They get 'static_cast not related by inheritance' compiler error. - x11::Connection::display_ is a new addition - LocalMouseInputMonitorX11::Core x_record_display_ stopped being filtered be the rewriter Bug: 1069567 Change-Id: I660a7c746b447a55a620f6d9e2f38ae93025f151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227938 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic89e4b35dc6348038fb7ee96581d24ebed8ae3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196092Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#774532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2d123568154..c1150db5e1ce 2020-06-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0fa61969 to 065b0a7f (487 revisions) 2020-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77e5316a515d to 6c1581646c46 (12 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086532,chromium:1090139 Tbr: tdenniston@google.com Test: Test: Test: angle_deqp_egl_no_gtest.exe --deqp-case=dEQP-EGL.functional.fence_sync.invalid.create_invalid_type Change-Id: If632dbe9a28d52c622909be717c11235f80157d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228473Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591113598-40e58c4b4405dc23a9940215457135cbcc33e410.profdata to chrome-win32-master-1591156770-3a8b9ed3582dca859cc61c05847c60f8252d4d44.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib80057d7e4422561fc65de332a9660f001efaba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228469Reviewed-by:
-
Harald Alvestrand authored
The fix for the timeout has been merged downstream (in webrtc). Bug: chromium:1087588 Change-Id: Ib22f35cd9b8c7822c079829261685d27f43ba3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228489Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774529}
-
Hugo Benichi authored
This patch populates new fields relative to the host IP configuration added in Change-Id I08dfd5daa9ba2946a847e555bb94a01da3866eb9 to NetworkConfiguration mojo objects. Currently, layer 3 information can come from shill Device properties (kIPConfigsProperty) or from shill Service properties (kIPConfigProperty, kSavedIPConfigProperty, kStaticIPConfigProperty). This patch changes the order in which this properties are tried to prioritize Device properties. BUG=b:143258259 BUG=b:145960788 BUG=crbug:795603 TEST=Compiled, flashed eve, checked that ARC++ sees the host IPv4 and IPv6 configuration, mtu, and search domains for following networks: eth, wifi, L2TP vpn connections, Chrome extension VPN connections. Change-Id: I6d5e6b6eed477b0aef762d2b18b8ef2ce9fa2ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962129 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#774528}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f2374511ab3..6fbe9310fbb8 2020-06-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f0f132012b95c22955eb31db606fb56c24ed374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227678Reviewed-by:
-
Tal Pressman authored
Change-Id: I341f413487ba8c30f1edd17b0d9087e0a5e2c3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228432 Commit-Queue: Tal Pressman <talp@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
-
François Degros authored
BUG=912236 TEST=autoninja -C out/release ui/file_manager:closure_compile Change-Id: Ifb531550c1a0421f447003fa0e4082b82ab2a3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226577Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#774525}
-
Aaron Leventhal authored
Copies logic from ::ToAccessibilityLabelWithSecondaryButton(), which is used for the accessible value. Bug: 1090517 Change-Id: Ib28f7814e6cd1bfbd7e9502c81e766d196930484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227118 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774524}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. !! is used in situations where the pointer is assigned to or returned as bool, otherwise CheckedPtr's more costly implicit T* cast operator would kick in. !! isn't needed in boolean expressions. Examples here: https://chromium-review.googlesource.com/c/chromium/src/+/2226003 Bug: 1080832 Change-Id: I449817c8949d85bd99a1f7d5043cd189f109303c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227936 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Christopher Cameron authored
TBR=kbr Bug: 1085899 Change-Id: I6df96e0cebcb1b85d4af3674e02ef2936b5a1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227973Reviewed-by:
-
Philipp Hancke authored
adds a test that verifies setting active to false on all three layers stops sending frames. Ref https://github.com/w3c/webrtc-pc/issues/2470 BUG=None Change-Id: Ic6bf346085af98cce13c90e141f83224e57069d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225774 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774521}
-
Maggie Chen authored
If CreateSwapChainForComposition fails, return false after disabling Direct Composition support. Let the Renderer handle it. Either the GPU command buffer or the GPU process will be restarted by the Renderer. This is the same way we handle the overlay swap chain creation failure. Bug:1074582 Change-Id: I631e6f38581c2da9124c15bdf5b697ea049b9f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226076Reviewed-by:
-
Christopher Cameron authored
Add CALayerParams to gfx::SwapCompletionResult. Populate this parameter in ImageTransportSurfaceOverlayMac, and use this parameter to populate gpu::SwapBuffersCompleteParams. Bug: 894929 Change-Id: I484fd6075b0724ef40a2f7157cc2037ae0fbe98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225460 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#774519}
-
Trent Apted authored
This reverts commit 565b6fb9. Reason for revert: Suspected real/root cause reverted in r774287 Original change's description: > Disable newly flaky test MediaAppPreferredOverChromeApps > > Bug: 1090432 > Change-Id: I00eea4851b95669ffa5e6824d2eecf1366f65dbc > Tbr: tapted@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226972 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774327} TBR=dmazzoni@chromium.org,tapted@chromium.org Change-Id: I24868bcd20d7089dd2bba158670a9c8dc12d1052 Bug: 1090432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228271 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#774518}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/957a2359f66b..6c1581646c46 2020-06-02 jmadill@chromium.org Vulkan: Fix XFB invalid accesses in buffer OOM. 2020-06-02 amaiorano@google.com Fix copy subtexture to GL_RGB9_E5 in ANGLE/VK 2020-06-02 ynovikov@chromium.org Roll third_party/VK-GL-CTS/src/ 60972ed7f..80dc8399b (67 commits) 2020-06-02 m.maiya@samsung.com EGL: EGL_CreateSync validation bug fix 2020-06-02 cclao@google.com Vulkan: Add IMAGE_USE_STORAGE bit only if necessary. 2020-06-02 ianelliott@google.com Vulkan: Swap RenderArea coords for pre-rotation 2020-06-02 lehoangq@gmail.com Metal: refactor RenderUtils to split into multiple util classes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1086532 Tbr: ynovikov@google.com Test: Test: angle_deqp_egl_no_gtest.exe --deqp-case=dEQP-EGL.functional.fence_sync.invalid.create_invalid_type Change-Id: I343a8ec56cca202a9cd9240eacada8a47ca9f83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227683Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591142315-2ba0a5e7527dc77b459b1e931964833ae1598a98.profdata to chrome-mac-master-1591156770-1c33a7333211aead2282df21d0f2c3fe491f2db6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie10a68cb6955686a7f3ba8d533199ce3ff7733e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227687Reviewed-by:
-
Dale Curtis authored
Same as the previous patch, but avoids assigning from a const& and skips tests which shouldn't run on Windows 7. PS#1 is take #2, all later patch sets are the new one. ---- [ Original Description Below ] ---- Does the following: - Internalizes h264 and min resolution details. - Sets the minimum resolution to 64,64 for both decoders. - Only loops through the video device profiles once. - Switches away from an std::pair to a named struct. - Adds AV1 GUID values and uses them in DXVA decoder. - Stops D3D11VideoDecoder for enumerating unsupported profiles. - Stops using the DXVA2_Intel_ModeH264_E for enumeration. - Gives all resolution tests a square resolution; e.g., 4k x 4k. - Doesn't test or indicate support for a duplicate portrait resolution. TBR=liberato, tmathmeyer Bug: 1073252 Test: Updated unittests. Change-Id: I56468b1ab56e4bc2bd872cf40cef4235d9d2afc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228112 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774515}
-
