- 31 Jan, 2018 3 commits
-
-
Dmitry Gozman authored
Attaching by default now. Bug: none Change-Id: I76a440a99d194ad64f77e8b39b541ed0836b351d Reviewed-on: https://chromium-review.googlesource.com/894184 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533100}
-
Jialiu Lin authored
Add a new experiment with warn_on_low_reputation set to true. Change-Id: Iac7a2c1d1e91d2696011bb60beed2c81f1e2b1c7 Reviewed-on: https://chromium-review.googlesource.com/893905 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533099}
-
Ilya Sherman authored
This reverts commit 92ffe77a. Reason for revert: I suspect that the original revert was inappropriate – more detailed reasoning left as a review comment on the revert CL. Original change's description: > Revert "[Variations] Avoid duplication of the safe seed value stored in prefs." > > This reverts commit 4db68ed9. > > Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712). > > Original change's description: > > [Variations] Avoid duplication of the safe seed value stored in prefs. > > > > When the safe seed and the latest seed have identical contents, use a sentinel > > value to avoid storing a duplicate value for the two seeds. This is purely a > > storage space optimization; no difference in observed functionality is expected. > > > > R=asvitkine@chromium.org > > > > Bug: 727984 > > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb > > Reviewed-on: https://chromium-review.googlesource.com/880482 > > Commit-Queue: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532027} > > TBR=isherman@chromium.org,asvitkine@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 727984, 806712 > Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456 > Reviewed-on: https://chromium-review.googlesource.com/891119 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532401} TBR=isherman@chromium.org,asvitkine@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727984, 806712 Change-Id: I1627111dacc8d59bc43aa7b1b7ed76db8f165ee2 Reviewed-on: https://chromium-review.googlesource.com/894622Reviewed-by:
-
- 30 Jan, 2018 37 commits
-
-
Misha Efimov authored
- Extract global state initialization code into common API. - Get cronet::EnsureInitialized to work properly if initialized from Cronet_Engine native API. - Add accept_language to URLRequestContextConfig[Builder], but don't expose it to Java. Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I60b9cdd31837e1b15d4c2479427d5d0a77999536 Reviewed-on: https://chromium-review.googlesource.com/868076Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#533097}
-
https://chromium.googlesource.com/catapult.git/+log/3f8c43b79487..9fd18084bd44 $ git log 3f8c43b79..9fd18084b --date=short --no-merges --format='%ad %ae %s' 2018-01-29 dtu [pinpoint] Decrease questionable threshold as repeats increase. 2018-01-30 benjhayden [results.html] Auto Show All when empty search results. 2018-01-30 perezju [Telemetry] Improve GetChildPids on android platform 2018-01-30 eakuefner [Telemetry] Add benchmark_duration histogram 2018-01-30 perezju [Telemetry] Improve GetPsOutput for android platform backend Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I69b5efbd55abb44970d8199d2ac3b7da38adc306 Reviewed-on: https://chromium-review.googlesource.com/894495Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533096}
-
Sammie Quon authored
Test: ash_unittests CustomFrameViewAshTest.HeaderVisibilityInSplitview Bug: 800498 Change-Id: I8bbf318cf1406d788c0b48d9812ca3f15d74c4ae Reviewed-on: https://chromium-review.googlesource.com/858217 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#533095}
-
François Degros authored
This method used to be a template. But since it's not anymore, it doesn't need to be defined in the header file anymore. Change-Id: I5e3b769ff4e7fced01524ddb39bf163b8e82f66f Reviewed-on: https://chromium-review.googlesource.com/892184 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533094}
-
Morten Stenshorne authored
Also avoid scientific notation; see https://codereview.chromium.org/1202773002 for a similar change to the gdb script. Change-Id: I07ddccd91ddefc1f57abbaabaaecb5e786a052e4 Reviewed-on: https://chromium-review.googlesource.com/894062Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#533093}
-
Darren Shen authored
During parsing, we want to store tokens in a vector. This vector is frequently cleared, so to get the best performance, we want to clear the contents of the vector without reallocating the memory. Previously, we used a bespoke TokenBuffer class as a way of doing this, but it turns out that WTF::Vector::Shrink clears the vector without changing the capacity, which is exactly what we want. This simplifies the code, and speculatively fixes a crash which is happening in TokenBuffer. Bug: 806444 Change-Id: I40df0de370511fc7022af3bd7af856a930a210c6 Reviewed-on: https://chromium-review.googlesource.com/892781Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533092}
-
Daniele Castagna authored
We recently changed hw video frame buffer usage to SCANOUT_CPU_READ_WRITE from GPU_READ_CPU_READ_WRITE. SCANOUT_CPU_READ_WRITE/format should be added to the list of supported native gmbs when native gmbs are enabled. Bug: b/71837407 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d73adf88e47fd612a2b955b6f60aa5703fdb71d Reviewed-on: https://chromium-review.googlesource.com/894306 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533091}
-
Alexander Alekseev authored
Bug: 806913 Change-Id: I57a57c860097187d24c5a9727e5cee2ffc591b31 Reviewed-on: https://chromium-review.googlesource.com/894494Reviewed-by:
-
Alexander Alekseev authored
Bug: 806038 Change-Id: If82af4835f2870acf37cc902e3e2f125f4b10f7c Reviewed-on: https://chromium-review.googlesource.com/894200 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Eric Willigers authored
We add a use counter for basic shapes (e.g. they appear in clip-path, shape-outside). We add a use counter for the CSS paint() function (CSS Paint API). We add a use counter for CSS gradients. We add a use counter for -webkit-cross-fade. Use counters for gradients and basic shapes requested in https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/j8HSFsZDAgAJ Change-Id: Ie609997946b97cbde1e5040076ee2a527554c8fb Reviewed-on: https://chromium-review.googlesource.com/892550 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
François Degros authored
Passed PrefRegistry and PrefRegistrySyncable by raw pointer instead of reference to scoped_ptr. PrefRegistry and PrefRegistrySyncable have an internal reference count. There is no need to use a double indirection when passing them around. Used base::MakeRefCounted instead of naked 'new' operator. Change-Id: I53a0fdfc99b7ef3dd32b191664520659c2585fa5 Reviewed-on: https://chromium-review.googlesource.com/892582Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#533087}
-
Lei Zhang authored
If this target is always a static_library, then in component builds it gets linked into multiple .so files and produces ODR violations. As a result, base::FeatureList would have trouble keeping track of the features in services/network/public/cpp/features.h when DCHECKs are turned on. Thus features.h is currently in a component all by itself. Instead of doing that, make the entire cpp target a component, and merge the features component into it. TBR=nasko Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I61f83087bc87b0ccfc4d4884e41adf39524d46e6 Reviewed-on: https://chromium-review.googlesource.com/885914 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533086}
-
Nico Weber authored
No behavior change. Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie21f59f1b5b18663d29c3fae5c331184ae90b9b9 Reviewed-on: https://chromium-review.googlesource.com/894302Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533085}
-
Trent Apted authored
features::kTouchableChrome gets more creative, but the narrow dropdown is a good starting point. That is, features::kTouchableChrome may imply a narrow dropdown regardless of kUIExperimentNarrowDropdown. Consolidate the logic under c/b/ui/views before it gets more complex. See linked bugs for context and links the the big picture CL. Bug: 801583, 728844 Change-Id: I0b6ca6f8f9c6cded9ee2b1ccf0e2b8b34e737cd9 Reviewed-on: https://chromium-review.googlesource.com/892603Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533084}
-
Owen Min authored
This test verifies the policy value is read and copied to local_state properly in the early stage of browser launch on Windows. It's a test for the patch: crrev.com/615e458c. Bug: 806538 Change-Id: I5b150f7429f968312692123d5d40525c3ddbd9c6 Reviewed-on: https://chromium-review.googlesource.com/892043 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533083}
-
Misha Efimov authored
Bug: 807283 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia61bdc85b5f700d58f88cc3093826d0a7e0ce014 Reviewed-on: https://chromium-review.googlesource.com/893681 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533082}
-
Scott Graham authored
Per discussion on https://chromium-review.googlesource.com/884822, this is easier to work with for V8. Bug: 707030 Change-Id: Ida09715f35280652408e209a408c2012a5648479 Reviewed-on: https://chromium-review.googlesource.com/894042 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#533081}
-
Tien-Ren Chen authored
The contents clipping mask layer on the main graphics layer needs to be updated unconditionally because otherwise we can have dangling pointer to a destroyed mask when both the mask and the contents layer are destroyed at the same time. BUG=807240 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ica51387507232c20f1deacf9572546490f587eb9 Reviewed-on: https://chromium-review.googlesource.com/894194 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533080}
-
Tetsui Ohkubo authored
Previously, |icon_view_| was created even if the notification does not have an icon, and changing is visibility by icon_view_->SetVisible(). However, ProportionalImageView always returns the fixed image size and FillLayout does not take visibility into account. As a result, |right_content_| always occupied the right side even if there is no icon. By this CL, the behavior is changed as follows: * When icon is available, * icon_view_->visible() always returns true. * right_content_->visible() may return false. (in case of use_image_for_icon) * When icon is not available, * icon_view_ is null. * right_content_->visible() always returns false. Before: http://screen/5KwSgEQQBaH After: http://screen/ym6upUfc1qc (Pressing Shift-Esc to show the notification) TEST=message_center_unittests BUG=785589 Change-Id: Ie3c133c82947681565cd07ddfada0c17a87dc591 Reviewed-on: https://chromium-review.googlesource.com/891079 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533079}
-
Sergey Ulanov authored
The new port allows to run layout tests on Fuchsia. It starts QEmu with Fuchsia and then connects to it over SSH to execute content_shell. Bug: 778467 Change-Id: If14317553c7e605b3d1c693d006faf0120d214fc Reviewed-on: https://chromium-review.googlesource.com/876932 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
rename attributeStyleMap to styleMap at CSSStyleRule https://github.com/w3c/css-houdini-drafts/issues/572 https://github.com/w3c/css-houdini-drafts/pull/596 Bug: 807008 Change-Id: I8e5f140914783c074f73f75ed94312989e90e0ef Reviewed-on: https://chromium-review.googlesource.com/893239Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#533077}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/adcf8626..bde04194 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4bca4066112a7b80bb7adf8e7596308690b8adac Reviewed-on: https://chromium-review.googlesource.com/894082Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533076}
-
Bret Sepulveda authored
TBR=wjmaclean@chromium.org Bug: 807446 Change-Id: Icc31a390ab51e2b0819c55cd6336df779ffda2c4 Reviewed-on: https://chromium-review.googlesource.com/894501Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533075}
-
Jeremy Roman authored
If so, the exception stack trace is printed (this is identical to JNI ExceptionDescribe, which also looks up and calls printStackTrace). Exceptions which indicate a bug in the browser-side implementation are rethrown as runtime exceptions. Bug: 794320 Change-Id: Ib33a17aae5e5a77cf45c24e055bfb6a097094324 Reviewed-on: https://chromium-review.googlesource.com/893542Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533074}
-
Kyle Horimoto authored
Before this CL, we allowed 3 retries for the entire connection flow, which includes advertising, scanning, creating a GATT connection, and exchanging messages. However, it makes more sense to think of this as a two-part process: (1) Advertising and scanning. This portion always occurs when attempting a BLE connection, even if the device we're trying to contact is not nearby and cannot respond. (2) Creating a GATT connection and exchanging message. This portion only occurs when an Android host is nearby to respond to the Chromebook. Connection attempts which fail in part (2) above indicate that the device actually is nearby and can potentially connect; additionally connection failures during this part of the connection often will succeed on a retry. Thus, this CL adds extra connection retry attempts if a previous attempt failed in part (2). Bug: 805218, 672263 Change-Id: Ifbedc004b96905d3f77662c45bcf2a9210b06c57 Reviewed-on: https://chromium-review.googlesource.com/889991Reviewed-by:Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533073}
-
Christopher Cameron authored
Fullscreen low power mode (which is triggered by use of AVFoundation) is causing 10.11's WindowServer to crash. Bug: 806506 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I40cfdfbd932be56cf0078c91cad824ee6895f9b6 Reviewed-on: https://chromium-review.googlesource.com/892097Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#533072}
-
Eugene But authored
ExabyteResponse is almost never ending response (with an Extabyte content-length). This response will be used in iOS tests, so it is useful to make it default. Bug: 614168,789585 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0edb7bbfc427bb83dc8bfbc9e143d1cd0e890e7 Reviewed-on: https://chromium-review.googlesource.com/890300 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#533071}
-
Alexander Timin authored
Require an enum to be passed to Platform::CreateThread specifying the type of thread which is requested to be created. This allows recording metrics around thread cpu usage. R=haraken@chromium.org,hajimehoshi@chromium.org,nhiroki@chromium.org BUG=776416 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie1855c52ab2259738fdc91ad3af89c476904c7bf Reviewed-on: https://chromium-review.googlesource.com/888920 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#533070}
-
Stephen McGruer authored
These cases were discovered whilst adding a deprecation warning for the use of '#' symbols in data URI bodies. For a '#' to exist inside the body, it must be escape as '%23'. Bug: 123004 Change-Id: If2e52db6c86d2610ecd0d4e175644494e18f47fc Reviewed-on: https://chromium-review.googlesource.com/889718Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#533069}
-
Jinsuk Kim authored
This CL moves Java TextSuggestionHost to be managed by WebContentsUserData so ContentViewCore doesn't have to keep a reference to the object, and the object can be obtained easily by TextSuggestionHost.fromWebContents(). It helps decouple the class from CVC. Bug: 789000 Change-Id: Iefdeb0a727fc975323b7f8f24d4eb187ad38601b Reviewed-on: https://chromium-review.googlesource.com/892180Reviewed-by:
Ryan Landay <rlanday@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
With a MDCButton, the font should not be set on the title label, but on the button itself, using: -[MDCButton setTitleFont:forState:] Bug: 803767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4232f2d080daca4e8fc2e585d51c24c1b10ab1ac Reviewed-on: https://chromium-review.googlesource.com/891221Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533067}
-
Anna Offenwanger authored
Adding the line to enable automatic bug filing for when WPTs are pulled from upstream into the xr folder and are failing. Change-Id: Idc24b4d610ceaa706c7d7fe12a35a8ff39775b43 Reviewed-on: https://chromium-review.googlesource.com/875249Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#533066}
-
Misha Efimov authored
- Use base::BindOnce instead of base::Bind. - Add ShutdownQuicTestServerDispatcher to trigger network errors without shutting down the server. - Don't spam test log with bidirectional_stream state. - Fix lint warnings. Bug: 714018 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4baf1f1e8718d4b5cc21f5664ee2dd1cc0bfa83d Reviewed-on: https://chromium-review.googlesource.com/890058 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
Jungshik Shin authored
Bug: 734093 Test: None Change-Id: I49be629d3d0afe2e329fd4fada263d7746e23e5e Reviewed-on: https://chromium-review.googlesource.com/892287Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533064}
-
Jeremy Roman authored
This doesn't require special support, since the java.lang.reflect API allows calling static methods the same way as instance methods. Bug: 794320 Change-Id: Id9064ec69b6cbdbe23576fa1f3e5d5e0e2c30677 Reviewed-on: https://chromium-review.googlesource.com/894465Reviewed-by:
-
Theresa authored
- Update the toolbar shadow and use alpha animation instead of transition drawable for url focus - Fix composited url bar alpha to prevent C++ url bar background from being drawn - Remove top padding in suggestions list when modern is enabled BUG=803088,803618 Change-Id: I848c1168ef26955a2eeb9b81738941f5fa886dd4 Reviewed-on: https://chromium-review.googlesource.com/893530 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533062}
-
Matt Menke authored
Also convert net::FileStreamContext to use it, as a sample use case with few consumers. This CL does not add a OnceCallback version of TestCompletionCallback, as the repeating version works for use with methods that take OnceCallbacks. I think not creating a new test class will make updating interfaces take a lot less effort. Also, I expect that all net::CompletionCallbacks are effectively used as OnceCallbacks, so we can make TestCompletionCallback return OnceCallbacks when/if we ever finish converting all of net to use CompletionOnceCallbacks. Bug: 714018 Change-Id: Iec76deae075b32fe0c65eb18596859f5e6413647 Reviewed-on: https://chromium-review.googlesource.com/853092 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#533061}
-
