GitLab

Change-Id: I053cec0b52defc0ff4a6ceeb3f4f7c5efb5fd31d
Reviewed-on: https://chromium-review.googlesource.com/979338
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545930}

The flag is deprecated and replaced by --memlog and co. See
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory/debugging_memory_issues.md#taking-a-heap-dump
for more details.

Bug: 758739
Change-Id: I8f7ac614298334a90103cd5b4c9667468d662845
Reviewed-on: https://chromium-review.googlesource.com/970852Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545929}

R=rsesek@chromium.org
TBR=dcheng@chromium.org

Change-Id: Ib1499f0f5a48a87558ede6aa255be8eb8def7009
Reviewed-on: https://chromium-review.googlesource.com/978371
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545928}

Since Position::Before/AfterNode(text_node) are valid DOM
positions, offset mapping should accept such positions.

This patch ensures it, and also fixes test cases incidentally
passing such positions to offset mapping.

This patch is also preparation for crrev.com/c/974909

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I34aa4f9701d0476c93cbe5155e1b6758ebe8c7db
Reviewed-on: https://chromium-review.googlesource.com/974903Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545927}

Fixed small TODO by tomasz@ to reverse order of entries and parentEntry
in zipSelection() method.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8308cc85c4133e47036abeb02aab2df9002ecb58
Reviewed-on: https://chromium-review.googlesource.com/927901Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545926}

The current implementation was masking error return values, making
all test and executable runs return 0. This lead to waterfall errors
being shown as green/passing.

Bug: 825714
Change-Id: I977faf461fceb5b5cd2d3e8e22d0c0135c77ce71
Reviewed-on: https://chromium-review.googlesource.com/981438Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545925}

When user locks/unlocks screen using the on-screen keyboard, it will
trigger the display metrics change. But at this moment, the snapped
windows become inactivatable which will end the split view mode. We
should not end split view mode in this case.

Bug: 824833
Change-Id: I347caf0624c0683c48bbe44762e7449b8623939a
Reviewed-on: https://chromium-review.googlesource.com/978608Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545924}

The crash was being caused by having the NSView pointer passed back-and-
forth between threads. In the meantime, the NSView had become invalid.
This change ensures that the NSView pointer is always being used in the
same call stack, where we know it must be valid.

Bug: 818679
Change-Id: I5c9e0f9ac9b643785a99defd2041c78d90865208
Reviewed-on: https://chromium-review.googlesource.com/981309Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545923}

BUG=794736

Change-Id: Ie60cd3d4892dc0e641b8e59dee0294fee20fd8ec
Reviewed-on: https://chromium-review.googlesource.com/981242Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545922}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d39e8a4..6e9cb694

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7ef43031f28e31d3a9ee6e870eda6a94c5c54de3
Reviewed-on: https://chromium-review.googlesource.com/980606Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545921}

Even with min size change period of zero black borders are still
possible, so make sure we clip the video frame by content rect
before presenting it to the user. This CL also fixes an issue in
PaintCanvasVideoRenderer where we didn't handle visible rect properly.

Bug: 813929
Change-Id: I59db4caaa2e8751e65801ed5d0b230ddece8d03b
Reviewed-on: https://chromium-review.googlesource.com/974650Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545920}

Add a cached variable for RWHVMac's display::Display.
* Initialize it with the the current key window's display, and
  pass that to BrowserCompositorMac's constructor (and remove
  the equivalent initialization from BrowserCompositorMac).
* Update ui::DisplayLinkMac to use the id from the cached
  display::Display, and move its update code into
  UpdateNSViewAndDisplayProperties (this will usually just be a
  std::map lookup).

Move the display::DisplayObserver implementation from RWHVMac (in
the browser process) to RHWVNSViewBridgeLocal (in the AppShim
process).

Change -[RWHVCocoa updateScreenProperties] to only push a new
display::Display to the RWHVMac when the RWHVCocoa is attached to
a window.

Bug: 821651
Change-Id: Ifeddf82ca9858e7e9185b068094af45425790ad0
Reviewed-on: https://chromium-review.googlesource.com/979119
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545919}

This reverts commit 6dbf08b3.

Reason for revert: Compile failure on linux-chromeos-dbg
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4899

BUG=826101

Original change's description:
> Adds AshAssistantController.
> 
> Bug: b:76028606
> Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276
> Reviewed-on: https://chromium-review.googlesource.com/973551
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Muyuan Li <muyuanli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545908}

TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,muyuanli@chromium.org

Change-Id: Ic33bb5e3efcec6547469999fd42e662529275942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:76028606
Reviewed-on: https://chromium-review.googlesource.com/981464Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545918}

This adds the -theme-with-dark-background class to the html element
instead of the body.

Change-Id: I05fbc726a371de32447934825706d22c97a9edb5
Reviewed-on: https://chromium-review.googlesource.com/981460Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545917}

- Block NaCl plugins from using DEV APIs. No NaCl plugins should depend
  on DEV APIs outside of development scenarios, and since NaCl is being
  deprecated, there is little point allowing them in development
  scenarios now.
- Eliminate support for the DEV permission for NaCl in the renderer.

Bug: chromium:823171
Change-Id: Id39814cfbf11682f9867c96ecfddb24c1c184fd1
Reviewed-on: https://chromium-review.googlesource.com/974655Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545916}

RenderWidgetHostViewMac calls into the -[NSView bounds] and
-[NSWindow frame] and -[NSScreen frame] methods for various reasons.
This no longer going to be allowed when the NSView, NSWindow, and
NSScreen are living in another process.

Add client method OnNSViewBoundsInWindowChanged to inform the RWHVMac
when the NSView's bounds in the window change, along with whether or
not the NSView is currently attached to a window.

Add a client method OnNSViewWindowFrameInScreenChanged to inform the
RWHVMac of the window's motion in the screen.

Store the resulting gfx::Rects in RHWVMac, and update the GetViewBounds
and GetBoundsInRootWindow methods to use that data. Push this data to
BrowserCompositorMac (so that that class no longer queries the NSView
for the data directly).

Change several locations in RHWVMac that were rolling their own version
of mac/coordinate_conversions functions. Add caching to the coordiante
conversion functions (somewhat awkwardly, and add a TODO about it).

Bug: 821651
Change-Id: I498324f8965bd76031028adfa4f740a5653319f7
Reviewed-on: https://chromium-review.googlesource.com/977229
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545915}

Bug: None
Change-Id: Ieac0809e2253b8676bf374e255468443699bcab0
Reviewed-on: https://chromium-review.googlesource.com/981177Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545914}

This Cl prevents UpdateUserType call for users that has not changed their
account type.

Bug: 811541
Change-Id: Ic569025f47625478832ba32ccb3ed010ff6d98fe
Reviewed-on: https://chromium-review.googlesource.com/981326Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545913}

This makes it possible to specify alternate backends during testing
and skip the tests that would then fail because of it.

Bug: 825938
Change-Id: Ib8b1ada6b232da0ad60d035554f9e9ca429d6d85
Reviewed-on: https://chromium-review.googlesource.com/980750
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@google.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545912}

Bug: 825270
Change-Id: I978f26cbfbefa48c0c4b1dffe64d49d750749db6
Reviewed-on: https://chromium-review.googlesource.com/977950Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545911}

Currently we need to pass a raw pointer of PerfTracker to ClientTelemetryLogger
because its rate accessors are not const, that's because RateCounter::Rate()
evicts obsolete data points. Given that evicting obsolete data points doesn't
quite change the stats result, we can simply const_cast the eviction logic.

This CL also changes the VLOG level of the perf stats to 0 to allow them to be
printed to the console.

Bug: 825313
Change-Id: Idf8a9c5dd5190566b75a4b60720cd605be774329
Reviewed-on: https://chromium-review.googlesource.com/978662
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545910}

Previously, there was an assumption that the transform ancestor of the compositing
container matched that of the squashed layer. This is wrong in the situation that
the compositing container has a transform.

Previously there was a check in the squashing code to skip some offsets if the
compositing container has a transform. This code was brittle, and started failing
once code was changed to omit composited scrolling offset from the compositing container.

Bug: 824811,646437

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia11af0d954065b31d38d61f8d4561ee3edd57e41
Reviewed-on: https://chromium-review.googlesource.com/979169Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545909}

Bug: b:76028606
Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276
Reviewed-on: https://chromium-review.googlesource.com/973551
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545908}

This Cl displays AiS (Answers in Suggest) differently iff
OmniboxRichEntitySuggestions is enabled. This is a step toward presenting
rich entity suggestions.

Bug: 798631
Change-Id: I0ef87d9bdffdb392f32662a4f13a3721e2826d47
Reviewed-on: https://chromium-review.googlesource.com/981459Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545907}

Observers of the UpgradeDetector are now given notice when the TimeDelta
for the "high" annoyance threshold changes (i.e., the
UpgradeNotificationPeriod policy setting is changed).

This is accomplished via:
- UpgradeDetector::GetCustomNotificationPeriod is introduced so that
  subclasses can easily get the policy setting.
- UpgradeDetector::OnNotificationPeriodChange is introduced and is
  implemented by subclasses (for desktop Chrome and Chrome OS) to handle
  changes of the UpgradeNotificationPeriod.
- UpgradeObserver::OnUpgradeRecommended is now also invoked when the
  thresholds change.
- As a consequence of the above, a "runtime.onBrowserUpdateAvailable"
  event is broadcast to all extension event listeners and
  UpdateAvailable() message is invoked on service processes.

As a result:
- The relaunch recommended bubble is reshown upon a change to the
  UpgradeNotificationPeriod setting if the UpgradeNotification is set to
  show it and the new period puts the browser past the last time that it
  should have been shown.
- If the relaunch required dialog is visible upon a change, its title is
  updated appropriately.
- The relaunch required dialog is shown upon a change to the
  UpgradeNotificationPeriod setting if the new period puts the browser
  past the time that it should been relaunched.
- The browser is relaunched at the proper time in the above case.

Unrelated changes included here are:
- UpgradeDetector and its subclasses now take and use a TickClock.
- UpgradeDetectorChromeos and UpgradeDetectorImpl now use
  base::NoDestructor rather than base::Singleton or other techniques.
- UpgradeDetectorChromeos no longer holds a ChannelsRequester instance
  after it is no longer needed.
- UpgradeDetectorChromeos::Shutdown now does a more thorough shutdown
  that includes stopping its timer and calling off a call to the
  ChannelsRequester.
- More use of base::TimeDelta for compile-time constants throughout.
- Some documentation comments in RelaunchNotificationController have
  been updated.

Bug: 511300
Change-Id: Id868072f494e8c6b2e01e36e4a234ae006e6cc97
Reviewed-on: https://chromium-review.googlesource.com/964324Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545906}

Since r393078, WebMClusterParser no longer inspects payload to
determine "keyframiness" of the blockgroup, this change removes
the special case ChunkDemuxerTest code which fed a valid VP8
keyframe or nonkeyframe payload into generated BlockGroups for
the parser.

This simplifies an upcoming change that allows testing around
0-byte payloads (related to crbug 823375).

BUG=823375
TEST=media_unittests passes

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I05b70f4dc22b9f75b7761188ecee9bd4f7909ac8
Reviewed-on: https://chromium-review.googlesource.com/981458Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545905}

Use ChromeViewsDelegate/WidgetObserver combination to ensure that all
widgets are tested for accessibility as they become hidden or visible
in a browsertest.

The test goes through the View entire subtree and ensure any focusable
View has an accessible name.

Bug: 819350
Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0
Reviewed-on: https://chromium-review.googlesource.com/951933Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545904}

We manually calculated bounds for tabs duing mouse-based tab closure in
order to persist tabs' bounds. But as |available_width_for_tabs_| is
shrunk, we can simplify this using GenerateIdealBounds().

TBR=pkasting@chromium.org

Bug: None
Change-Id: Ice3f965b1224c2952ec0523591d9d3106ff0c5c7
Reviewed-on: https://chromium-review.googlesource.com/979372
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545903}

This reverts commit 1a47d5d6.

Reason for revert: https://crbug.com/825804

Original change's description:
> Add WebSocket-related CHECKs to HttpStreamFactoryImpl::Job.
>
> The primary reason for these CHECKs is to better document expectations
> in code.  Also, they are CHECKs instead of DCHECKs to help track down
> crashes in case these expectations do not hold.
>
> Bug: 819101
> Change-Id: Ia309bbff2f4e048926930cd9a15fbc107994895d
> Reviewed-on: https://chromium-review.googlesource.com/975621
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545196}

TBR=pauljensen@chromium.org,bnc@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Skipping CQ (even though original CL landed more than 24 hours ago) because
this is the top crasher in the browser process on Mac, so this should go in
before next Canary cut, and definitely before next Dev cut, but ios-simulator
bot fails with exception on multiple tries (and also with other CLs).

Bug: 819101
Change-Id: Ib998f6b92dd70df943cfb25b1418e1070cb839aa
Reviewed-on: https://chromium-review.googlesource.com/980632
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545902}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ab45c02..5d39e8a4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2791959767664d44fbfcc9bcebc2e2b6f9806d4f
Reviewed-on: https://chromium-review.googlesource.com/980776Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545901}

Optimize the LocationBarView and friends for touch by making it taller and
enlarging its decorations. This patch will make the circular inkdrops flush with
the edges of the Omnibox as well.

Icons are also enlarged.

Screenshots - https://drive.google.com/open?id=1nzMYsrofnubyZFWT7GQb9KCyV30Wz13p

Bug: 801583
Change-Id: Ifa5ae0e86842970add17b1b23a4f708c7a81a1d7
Reviewed-on: https://chromium-review.googlesource.com/915483Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545900}

Similar to the IPC command buffer proxy unit tests.

R=piman
BUG=824510

Change-Id: I14ecfc448e12d4f143b645cc9290c476fdbf5d0d
Reviewed-on: https://chromium-review.googlesource.com/978959
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545899}

In manifest version 1, all extension resources were considered
accessible by the web (i.e., could be embedded within or
requested by a web page). In manifest v2, only resources
explicitly specified in the web_accessible_resources key are
accessible. Remove support for manifest v1, and always check
the web accessible resources.

Update unit tests to migrate relevant tests and remove tests for
manifest v1-specific behavior.

Bug: 816677, 816679
Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146
Reviewed-on: https://chromium-review.googlesource.com/953177
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545898}

This reverts commit 670c4688.

Reason for revert:

Mysteriously, this has caused some regressions on a bunch of bots that do not support the Haswell instruction set.  Reverting just to see if that's real (and because this wasn't really a noticeable win anywhere when landing the first time).

Bug: 825647, 825586, 825646, 825104

Original change's description:
> Allow HSW stages to detect FMAs opportunistically.
>
> We used to build the .S files with -ffp-contract=fast for this, and
> adding it here to the HSW opts will have the equivalent effect.  None of
> the other x86 targets support FMAs.
>
> In many key places we do call _mm256_fmadd_ps explicitly, but in several
> other stages we have been relying on Clang to sniff out opportunities,
> especially for fused-multiply-subtracts, which we're just not very good
> at seeing in our heads.
>
> Bug: 821012
> Change-Id: I2767cbdb7151d60ea7553e83f51b28ff9340eb94
> Reviewed-on: https://chromium-review.googlesource.com/963141
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543262}

TBR=fmalita@chromium.org,herb@chromium.org,mtklein@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 821012
Change-Id: I61c0627270853b8acdcf6b20fca17ba0fd8bba55
Reviewed-on: https://chromium-review.googlesource.com/980293
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545897}

Bug: 820299
Change-Id: I596113eeea7d4c13cf689364744bff7c261f93d3
Reviewed-on: https://chromium-review.googlesource.com/978247
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545896}

https://crrev.com/c/938623 removed #chromeCleanupSecondary, but there
was an aria reference to it. This CL removes the dangling
aria-describedby.

R=ftirelo@chromium.org

Bug: 824494
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I32e69b37a911f9586e658bae2b9d4b415b7b2008
Reviewed-on: https://chromium-review.googlesource.com/974379Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545895}

We've encountered a DCHECK crash here. I've fixed one potential cause,
where a fetch fails and another call to FetchImageAndData is made before
the image decoding returns. Added unittest to capture this case.

Bug: 823925
Change-Id: I99fc94e90d9032dd1bc196319238f6f2e60c68dd
Reviewed-on: https://chromium-review.googlesource.com/972440Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545894}

The interface was moved from chrome:: to content:: namespace, but this
manifest was not updated accordingly.

Fix that.

Bug: 826024
Change-Id: I8024c983f808001411e05fc52469ff7956f9c258
Reviewed-on: https://chromium-review.googlesource.com/981296Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545893}

This is a relanding of https://chromium-review.googlesource.com/c/chromium/src/+/651147.
After several small issues have been fixed, we can reenable this again.

Bug: webrtc:7950
Change-Id: If7d1e2a5b713eaaa6dfbece73a4006df6187c687
Reviewed-on: https://chromium-review.googlesource.com/980668Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545892}

This reverts commit f8d41208.

Reason for revert: crbug.com/826035, this seems to have broken LARNG.

Original change's description:
> Android: Enable vertical class merging ProGuard optimization
>
> Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed.
> Shrinks method_count by 1400.
>
> Bug: 620323
> Change-Id: Ie9f7c37a20895ecd1d3f1f17357a663252a1be36
> Reviewed-on: https://chromium-review.googlesource.com/981052
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545857}

TBR=agrieve@chromium.org,estevenson@chromium.org

Change-Id: Ib468e971a716c695903be026cfa9ee82eac6b84a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 620323, 825995, 826035
Reviewed-on: https://chromium-review.googlesource.com/981463
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545891}