- 03 Aug, 2017 40 commits
-
-
David Benjamin authored
This is a reland of https://chromium-review.googlesource.com/c/595155 with a fix to a field that wasn't initialized. Until we do https://crbug.com/458365 and remove the global session cache, consumers making SSLClientSockets with the default empty shard should not enable session caching, as they'll interact with other sockets which do that. Bug: 458365 Change-Id: Ib8d0ecf72584b687a768e080dc31439c625ac412 Reviewed-on: https://chromium-review.googlesource.com/598709 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491750}
-
Danyao Wang authored
This uncovered a bug where GetLastCommittedItemIndex() returned the incorrect value because it assumes WKBackForwardList's |currentItem| is always the last committed item. This is not the case if the pending navigation is a back-forward navigation. It turned out that this can't be fixed 100%, but implemented a heurstic and documented the edge case. Bug: 734150 Change-Id: Ie2c026a2c5231cbd4151c106cd0db664dcf6d587 Reviewed-on: https://chromium-review.googlesource.com/596828Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#491749}
-
gaschler authored
Refactor ImageFetchedCallback to be a move-only type callback, which has a clear lifetime. Bug: 752051 Change-Id: I46c8f47f60d88afd3f3825f20404189ff7cb5cc1 Reviewed-on: https://chromium-review.googlesource.com/600052 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491748}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/562197/, we introduced the concept of document paint definition, such that we can have two paint worklet global scopes. However, we didn't Implement the logic to switch between these two global scopes. This CL implements the logic. In particular, after every 120 frames that has called the paint function, we switch to use another global scope. Bug: 728595 Change-Id: Ie48a7e597deb10342ede64c42e595c0b11d779f1 Reviewed-on: https://chromium-review.googlesource.com/593633 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491747}
-
spqchan authored
Create a feature flag for this feature. Bug: 751784 Change-Id: I49ba9af40f68496b1e59f3e5f9fc5e0fa068ae6f Reviewed-on: https://chromium-review.googlesource.com/598628Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491746}
-
Stephen McGruer authored
Bug: 699244 Change-Id: Ie7d573bbda8e57cc718137f04a4b1fb0bde14355 Reviewed-on: https://chromium-review.googlesource.com/598589Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491745}
-
Anthony Vallee-Dubois authored
Bug: 735103 Change-Id: I54ac93cf34a37144dbf257d5f3768af64e319151 Reviewed-on: https://chromium-review.googlesource.com/595027Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491744}
-
Stephen McGruer authored
Bug: 699244 Change-Id: Iab42a2b1363fd3a55ae3bb77e0452157dc66ef89 Reviewed-on: https://chromium-review.googlesource.com/598708Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491743}
-
gogerald authored
This CL changes the stored data scheme of the web payment app, so users have to re-register the web payment app after this patch. This should be fine since this feature is still behind the flag. Bug: 751737 Change-Id: I396960273dca51f82a4490fa2dd5f7756e3a0bf0 Reviewed-on: https://chromium-review.googlesource.com/598636 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491742}
-
John Mellor authored
dummy.c was failing to link under the orderfile build due to undefined references to __cyg_profile_func_enter and __cyg_profile_func_exit. This is because the orderfile build enables -finstrument-functions. This patch attempts to fix that by explicitly disabling cygprofile instrumentation for dummy.c BUG=750120 TBR=agrieve@chromium.org,pasko@chromium.org Change-Id: Ibe3cbbc5b55103840e7b55c3921cae242b185bba Reviewed-on: https://chromium-review.googlesource.com/600311Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#491741}
-
Justin Donnelly authored
This is controlled by the "Use a prediction service to help complete searches and URLs typed in the address bar" setting at chrome://settings/privacy. Bug: 751813 Change-Id: Iedf25fbb95e4fe1133fa994843068b26b749e36b Reviewed-on: https://chromium-review.googlesource.com/598933Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#491740}
-
Eugene But authored
WebState's WasShown/WasHidden is called from Tab, so WebStateObserver callbacks are actually work. WebStateObserver's WasShown/WasHidden callbacks will allow to move code from Tab to TabHelpers. Bug: 616244 Change-Id: I2d8f3eb0f5854dd7204b9aec6db2aac593309638 Reviewed-on: https://chromium-review.googlesource.com/596783Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491739}
-
Ian Kilpatrick authored
Add xidachen@ and flackr@ to modules/csspaint OWNERS. Change-Id: Ic7da1068210941673604d39351633ab4888bed52 Reviewed-on: https://chromium-review.googlesource.com/600193Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491738}
-
Jérôme Lebel authored
Bug: Change-Id: I499cebffcc86aa708cfa99c7b5cdf556305dd0ce Reviewed-on: https://chromium-review.googlesource.com/600210 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#491737}
-
Charles Harrison authored
Bug: 751696 Change-Id: Ic306f3ce59d38e752503304f62bcd26e39b284cb Reviewed-on: https://chromium-review.googlesource.com/598988Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#491736}
-
Koji Ishii authored
Following bot results are included. 88{0..2} 884 888 896 68 lines were removed by consecutive passes since 873. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ic80527887a39c4e73fbf351fc22f01bef4fc54aa Reviewed-on: https://chromium-review.googlesource.com/600447Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491735}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/5788d24..a0bcc50 BUG=750813 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I54127f2ed6fa648e85a104a925fd3a6affaf5407 Reviewed-on: https://chromium-review.googlesource.com/598942Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491734}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ae532f68a035..698edfecef12 $ git log ae532f68a..698edfece --date=short --no-merges --format='%ad %ae %s' 2017-08-02 rmistry Chromium lkgr is no longer updated. Use lkcr Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I74d99a371eeb472761d6a0f52defea2745b78dda Reviewed-on: https://chromium-review.googlesource.com/600250Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491733}
-
sunxd authored
We used to unconditionally return not_solid_color when analyzing the op ClipRRect. This lead to huge memory usage of composited border-radius scrolling because we need to store the texture for the whole mask layer. This CL makes SolidColorAnalyzer capable of determining whether a tile is fully covered by the clip rrect, so we can save memory by not storing textures of solid color quads. Bug: 567293, 567296, 740720 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I24b10a2d68c0c608aec8e5a8bafaabb9800cd466 Reviewed-on: https://chromium-review.googlesource.com/591913Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491732}
-
Marc Treib authored
This CL adds a script to download a number of test doodle configs from the ddljson API. It also adds a captured snapshot of those configs, and a test that they all get parsed without errors. Bug: 690467 Change-Id: Idf8375a4199fc129b905c7f8cd32f12d071389e9 Reviewed-on: https://chromium-review.googlesource.com/597647 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491731}
-
Elly Fong-Jones authored
This change: 1) Makes FirstRunBubble::ShowBubble take an anchor point and a window to observe instead of both of these being implied by the anchor view; 2) Adds a class called FirstRunPresenter to share the logic used to wait to present the first run bubble between platforms; 3) Untangles LocationBar and ToolbarView from showing the first run bubble; 4) Adds chrome::ShowFirstRunBubbleViews() on Mac, to expose the Views first-run bubble Bug: 728160 Change-Id: I67de01f518a38120eb016ea2c6cd163dcf1c1356 Reviewed-on: https://chromium-review.googlesource.com/535735Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#491730}
-
John Mellor authored
This reverts commit d95936bd. Reason for revert: this caused PasswordStoreTest.GetLoginsWithAffiliationAndBrandingInformation to fail on KitKat Tablet Tester with the following error: [ERROR:connection.cc(1964)] Passwords sqlite error 5, errno 0: database is locked, sql: PRAGMA auto_vacuum [FATAL:connection.cc(1979)] database is locked https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FKitKat_Tablet_Tester%2F8506%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests_on_Android%2F0%2Flogs%2FPasswordStoreTest.GetLoginsWithAffiliationAndBrandingInformation%2F0 Original change's description: > Move the task runner creation to password store from the factory. > > In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop. > > Bug: 741660 > Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d > Reviewed-on: https://chromium-review.googlesource.com/584908 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491693} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ifa8c22c62bab7f0200437e3c2ab7661b5fddc78a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 741660 Reviewed-on: https://chromium-review.googlesource.com/600211Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#491729}
-
Dominik Röttsches authored
Addressing remaining feedback from https://chromium-review.googlesource.com/c/581149 Bug: 749091 TBR: rune, eae Change-Id: I734d8115b021ea6f996a2d62064208326c8032df Reviewed-on: https://chromium-review.googlesource.com/598948Reviewed-by:
Rune Lillesveen <rune@opera.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491728}
-
Vasilii Sukhanov authored
Bug: 355145 Change-Id: I9627c0f70f4f9f27023c937e0d2a3a9db48de63f Reviewed-on: https://chromium-review.googlesource.com/600328Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491727}
-
Matt Menke authored
Bug: 715695 Change-Id: Ie0d1c6b22b96c9d144721953ba09fbe3a7528484 Reviewed-on: https://chromium-review.googlesource.com/596804 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#491726}
-
Justin Schuh authored
* Applied BASE_NUMERICS_LIKELY to all predictable clamped and checked branches. (I skipped things like abs, where the branch is not reliably predictable). * Simplified CheckedAddOp and CheckedSubOp, and optimized the generic code for smaller types (although Clang will always use the builtins). * Expanded the cases where CheckedMulOp will use the Clang builtin (this branch is compile-time determined, and should be an improvement on 64-bit). * Restructured CheckedDivOp to allow the compiler remove more of the overflow checking based on compile-time type checks. * Simplified CheckedModOp by putting all the logic in one function. * Simplified branching and eliminated multiplication in CheckedLshOp and ClampedLshOp (much more compact code on Arm, but still unavoidably a bit branchy). * Removed branch in CheckMathOp (variadic template wrapper). Note: Arm code should remain mostly non-branching, unless Clang's optimizer behavior changes in the future to assume better branch prediction (at which point it should branch on the exceptional conditions, like Intel currently does). Bug: 750184 Change-Id: I9948b94722d64e9a5bf363690acf9086dae0c65d Reviewed-on: https://chromium-review.googlesource.com/592852 Commit-Queue: Justin Schuh <jschuh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491725}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a14a5f4f..6c3faf19 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ic36ec4f4a237839e3bbe3860d4edadf9c0d7977a Reviewed-on: https://chromium-review.googlesource.com/600167Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491724}
-
Elly Fong-Jones authored
On Mac, textfields always scroll to the start when gaining or losing focus; this change implements that by: 1) On keyboard focus, doing a reversed SelectAll, so that the new selection "ends" at the logical start on Mac; 2) In OnBlur(), moving the selection to the logical start if PlatformStyle calls for same Bug: 657558 Change-Id: I81c01f6ae5a546f1abb51a28638091907379d04e Reviewed-on: https://chromium-review.googlesource.com/598122Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#491723}
-
Eric Noyau authored
Bug: Change-Id: I0d83c2ab10efe07ec08b87b4c981cd6beea6be81 Reviewed-on: https://chromium-review.googlesource.com/600055Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491722}
-
Eric Noyau authored
Bug: Change-Id: I2eb56189944a490992b861a114ffc58abc207a05 Reviewed-on: https://chromium-review.googlesource.com/600208Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491721}
-
Justin Cohen authored
Sort kill_simulators and fix comments. Add new owners to ios/build/bots/scripts. Followup to https://chromium-review.googlesource.com/c/596669. Bug: 684305 Change-Id: I36b552f47e205d032d35781fe8af1736a73efa5b Reviewed-on: https://chromium-review.googlesource.com/599046Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491720}
-
Yuki Shiino authored
The fix of LAP context is under preparation at https://chromium-review.googlesource.com/c/563152 . Some of layout tests will be broken when the LAP context gets fixed (actually, they're wrong). So, this CL fixes those tests before the fix. Other LAP-related (broken) tests will be disabled while landing the fix and later will be updated using the correct context. Bug: 6156 Change-Id: Iadb04d6326a6285fe6dbaef68de5e3e100bcc765 Reviewed-on: https://chromium-review.googlesource.com/597990Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#491719}
-
Julien Brianceau authored
Fix typo in background.persistent declaration in manifest. This might have been an issue as its default value is true. Bug: 750830 Change-Id: I8154bc72bc22bac613494c035951526dfdfcc770 Reviewed-on: https://chromium-review.googlesource.com/599907Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#491718}
-
Julien Brianceau authored
Javascript variable is declared and tested as "succeeded", but affected with a typo ("suceeded"). Bug: 750830 Change-Id: Ia3bb9e4c7488dac82410a3fea2c2496aae3b456f Reviewed-on: https://chromium-review.googlesource.com/599808Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#491717}
-
Matt Menke authored
This CL also refactors how it works in the case when the network service is disabled to go through the IOThread's NetworkService. Bug: 715695 Change-Id: I3df5126207df21065a42309b8e786f74dabae6cf Reviewed-on: https://chromium-review.googlesource.com/594670Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491716}
-
Yoshifumi Inoue authored
This is a reland of 44e59041 Changes of original is replace |const SelectionForUndo&| to |const SelectionForUndo| at end of DeleteKeyPressed() and ForwardDeleteKeyPressed() as work around of clang's bug which doesn't handle extent of |const T&| as end of scope. Original change's description: > Introduce SelectionForUndoStep > > This patch introduces |SelectionForUndoStep| to hold selection for undo/redo > instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for > improving code health. > > Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and > recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo > time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|. > > After this patch, we use |SelectionForUndoStep| to hold selection at command > execution and change |EndingVisibleSelection()| to compute visible selection > before we used. > > This patch looks large, but most of them are replacing > |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep| > instead of updated |VisibleSelection|. > > Essential part of this change is > * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in > |SelectionInUndoStep| > > * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than > |FrameSelection|. > * "SelectionInUndoStep.{cpp.h}": The implementation > * "UndoStep.{cpp,h}": holding staring and ending seleciton in > |SelectionInUndoStep| > > Just for reference, there is another attempt in the patch: > - http://crrev.com/2457523004: Introduce SelectionForUndoStep > - http://crrev.com/c/582724 Introduce SelectionForUndoStep > > [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and > extent positions by using layout tree. Once layout tree is updated, e.g. by > DOM change or style change, |VisibleSelection| may not be canonicalized. In > other words, once we get |VisibleSelection|, it is valid only until layout tree > updated. > > Bug: 747795 > Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb > Reviewed-on: https://chromium-review.googlesource.com/588874 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491667} TBR=xiaochengh@chromium.org Bug: 747795, 752013 Change-Id: I3135599416fea2af25aeba1ce76348dbf3b36628 Reviewed-on: https://chromium-review.googlesource.com/600007Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491715}
-
Alex Clarke authored
This simplifies working out which frame a document belongs to when processing the scanphot. Bug: Change-Id: Ice1b02fab606c7ccd57154a195b509c35c4cce50 Reviewed-on: https://chromium-review.googlesource.com/597691 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491714}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fba26ea9b7fc..ae532f68a035 $ git log fba26ea9b..ae532f68a --date=short --no-merges --format='%ad %ae %s' 2017-08-02 benjaminwagner Add Win10 QuadroP400 bots. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Iea385fb13333f0027ebe1c9e7e05bd07e6c2d6fd Reviewed-on: https://chromium-review.googlesource.com/600087Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491713}
-
Eric Noyau authored
Bug: Change-Id: Ie06a13d99cd0b7f5112201e64e1d7774dd0700ad Reviewed-on: https://chromium-review.googlesource.com/600054Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491712}
-
Dominik Röttsches authored
NOTRY=true TBR=lunalu, horo, stgao, guidou Bug: Change-Id: Id30e0adf8d32524c819025037605f4b0adec6354 Reviewed-on: https://chromium-review.googlesource.com/600190Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491711}
-