- 25 Sep, 2019 40 commits
-
-
Hans Wennborg authored
The trunk version of Clang caught this bug: ../../net/cert/cert_verify_proc_unittest.cc:2782:53: warning: converting the enum constant to a boolean [-Wint-in-bool-context] EXPECT_TRUE(error == ERR_CERT_AUTHORITY_INVALID || ERR_CERT_INVALID) ^ TBR=eroman Bug: 1007367 Change-Id: I4493f82c7f761f5fc4470343e148f4dd32c3d7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824260Reviewed-by:Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#699680}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba04be8c9ef9..096b08fa42e8 git log ba04be8c9ef9..096b08fa42e8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3a762d54f649..527a689307a4 (5 commits) Created with: gclient setdep -r src/third_party/angle@096b08fa42e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I5e6bfd28755d53df5e71c655eef2646ac16c3a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699679}
-
arthursonzogni authored
When a new renderer initiated navigations starts it will either: 1) Create a new pending navigation entry and use it. 2) Reuse the existing pending navigation entry. The problem is that (2) is very wrong. There is no reasons to do it. For instance, when a main frame navigation starts, it creates a pending NavigationEntry. Then if a subframe navigation starts, is reuses the same pending NavigationEntry. This doesn't make sense. Bug: 999932 Change-Id: I53152ab7b62bdf9bcf745b7512f3b1110d0b5e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818522Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699678}
-
Takuto Ikuta authored
Test is flaky on https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/381379 TBR=karandeepb@chromium.org BUG=1003598 NOTRY=true Change-Id: I2402407f109592cdea7bb0f70529fbd25da9d168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824790Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#699677}
-
Julie Jeongeun Kim authored
This CL converts VisitedLinkNotificationSinkPtr and VisitedLinkNotificationSinkRequest to new Mojo types using Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I3ac5ddc1c7e92072ab1848d2478225cc50dfc29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816059Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699676}
-
Mikolaj Walczak authored
BUG=b:138996293 Test: `test_that my_crbook cheets_AppPositionTest_P` Change-Id: If908ba85e4b3b8016341829c2c337b235b954cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792516Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#699675}
-
Julie Jeongeun Kim authored
This CL converts DownloadStreamClientPtr to new Mojo types. It uses Remote, PendingReceiver, and Receiver instead of DownloadStreamClientPtr, DownloadStreamClientRequest, and binding. Bug: 955171 Change-Id: I20205157b4c0400b95fe0fa6ab915dbb098c7caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810440Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699674}
-
Julie Jeongeun Kim authored
This CL converts CrosNetworkConfigPtr and CrosNetworkConfigRequest to new Mojo types using PendingRemote or Remote, RemoteSet, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I2e942774834cc36d2f6bf586ec8367e9f7d38654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821698Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699673}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4881f75b7ca0..db4083fd7f19 git log 4881f75b7ca0..db4083fd7f19 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check (sum of) table sizes. Created with: gclient setdep -r src/third_party/freetype/src@db4083fd7f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Idbefdf74a1d739cad357a5655b89702094d8e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824897Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#699672}
-
Hiroki Nakagawa authored
The test was disabled because a task bound with an unretained object may run after the object gets freed. To avoid that, this CL adds test::RunPendingTasks() call to drain the queued tasks before the object deallocation. For Sheriff, feel free to revert this CL if the flakiness still happens. Bug: 1007616 Change-Id: If7382250336a0f3820795b8a31e4429c6b64353f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824761Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699671}
-
Eugene But authored
Relanding crrv.com/c/1816807 This CL removes web_state_observer.h and web_state.h from ios/web/public/web_state which are no longer used in downlstream repo (downstream code was switched to use files from ios/web/public). Bug: 942244 Change-Id: I9a6000fd421f9e6a5ac81e45a08d0761d0b9134f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818222 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699670}
-
Wez authored
Reason for revert: Reverting to an SDK revision that allows the "chromium" package to be updated to a local build. TBR=sergeyu Bug: fuchsia:37329 Change-Id: I78c88dd4e37a69ad0bac9dd8c4974b95882e1a5b Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824649Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699669}
-
Rika Fujimaki authored
We can pass isolate instead of script_state to ScriptValue's ctor since we replaced ScriptValue::script_state_ with ScriptValue::isolate_. Now that ScriptValue is completely free from context and persistent! Bug: 998994 Change-Id: I31aef94b7c1ead3ba86de0d5b894d96b00287708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824300Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#699668}
-
Hitoshi Yoshida authored
Web IDL spec allows to use '{}' as a default value for dictionaries, to mean an empty dictionary. This CL makes IDL compiler follows the spec. Bug: 984949 Change-Id: I9979f590cfc7f17c2aeff50f9333f23f7baf87a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824758Reviewed-by: -
Jan Krcal authored
This CL prepares for a later refactoring by making semantically non-equivalent changes first. This CL: - guards bookmark specific code by model_type == BOOKMARKS; - moving one line around to have all bookmark specific changes after the generic ones. The follow-up CL will extract data type specific code into helper functions to separate them from the main flow. This prepares for adding further WALLET_DATA specific code into the worker. Bug: 881289 Change-Id: Ia197e92294b56ecbe49b8f28f4581b4a8bb581a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818482 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699666}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60b35adf. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" a0586590 "Don't fold SaveAlphaLayer into DrawTextBlob" fe1133d1 "Update SXG version in wpt/signed-exchange/README.md" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idf6473b726fad307600a75747f93161fa110de8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823909Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699665}
-
Marc Treib authored
deprecated = true This replaces new_timestamp, from_timestamp, and sync_timestamp by "reserved" entries, and marks a number of other fields as [deprecated = true]. Bug: 950904 Change-Id: Ic4b26ec368ac94e38ff330024698cd13c30417a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821790 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699664}
-
Marc Treib authored
This is a variant of ModelType that fulfills the requirements for recording in histograms (i.e. no reordering/renumbering). It's a type-safe replacement for the current system based on ints. The actual values stay identical to the current ints, so the histograms themselves won't be affected. A follow-up CL will update all histogram recording sites to use the new enum. Bug: 1007293 Change-Id: I3e36c97303ba08e34baccffafbab8b55d8b9288b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821787Reviewed-by:
-
Carlos Caballero authored
Remove references in /device/bluetooth/bluez MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 891670 Change-Id: I4b67ceda2cf508e5f5d76493c5d2aa05e3619924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780738 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#699662}
-
Piotr Tworek authored
This not visible in default chromium setup since it disables exceptions by default. The code does however fail to compile if one enables them: ../../base/containers/intrusive_heap.h:717:48: error: 'operator=' is missing exception specification 'noexcept' IntrusiveHeap<T, Compare, HeapHandleAccessor>::operator=( ^ ../../base/containers/intrusive_heap.h:290:18: note: previous declaration is here IntrusiveHeap& operator=(IntrusiveHeap&&) noexcept; Change-Id: I8c633333ae17002ba0b643e6c88e463d28de0086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815862Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#699661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3731bd7ab054..6abaff3041a3 git log 3731bd7ab054..6abaff3041a3 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6d625bfe6e8a..ba04be8c9ef9 (9 commits) 2019-09-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a76152f4..fb8fbb18 (434 commits) Created with: gclient setdep -r src/third_party/skia@6abaff3041a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None,chromium:None Change-Id: If64c9b4ab6a61a43d460b17da2ce5818af6379ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824839Reviewed-by:
-
Keith Lee authored
Change-Id: Ie48fac3c75f6825eca8372abe09afa2696586333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816340 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699659}
-
Carlos Caballero authored
MessageLoop is going away. Also had to fix a lot of includes as a bunch of files were not directly including their dependencies. Bug: 891670 Change-Id: I1b962b9513596b399175498278ad526fba2240f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807504 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699658}
-
Sergio Villar Senin authored
It's currently returning a double. As part of the process of rewriting the animation engine we're replacing doubles by base::Time* alternatives. Bug: 737867 Change-Id: I9d6cca66354ec22f5387ce7328b92c5c396ce283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819243Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#699657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a130294887fc..f2723363e181 Created with: gclient setdep -r src-internal@f2723363e181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I97aa9f3b4fc7455ef41451c9cb540bebe020d944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699656}
-
Koji Ishii authored
32 can avoid most of memory allocations, by consuming 512 bytes on stack ((4+4+8) * 32) on 64 bits. Most major sites are up to 8 or so, such as Google SRP, facebook, twitter, MDN, youtube, etc. Wikipedia is up to 21. Change-Id: I7f06f0ce01b5d2960becf99e0b453d92723e5253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821501 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#699655}
-
Maksim Sisov authored
This moves IsVisible impl from DWTHX11 to DWTHPlatform and adds IsVisible() method to PlatformWindow. Scenic and Windows implementations are not implemented and return true. Drm's implementation is set to NOTREACHED as it is not expected that the DrmWindowHost::IsVisible is ever called. X11 and Wayland implementations return visibility for unminimized windows and mapped windows (in case of Wayland, it means that either xdg_surface or xdg_popup exist). Bug: 990756 Change-Id: I09ff60a9064ea5bef674d202c5bee994e238c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807239Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#699654}
-
Dominick Ng authored
This moves ownership of the AppServiceImpl directly into the browser's AppServiceProxy, rather than having indirect ownership through Service Manager and Connector. In the original, multi-process aware App Service design, there would be N App Service Proxies connecting to 1 App Service, where N is the number of processes. Now that out-of-process ash is not being worked on, N:1 in theory will remain 1:1 in practice for the foreseeable future, so the browser process App Service Proxy can itself own the service implementation. Bug: 977637 Change-Id: I8320dd5b642b82940f6b8697df5cb06ca5226d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819283 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL adds the ability to search the main app view. Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413193&signed_aid=1gM1GYp3LKjfA-MDmtDCnA==&inline=1 New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413194&signed_aid=AUs-pUuL34V1dT9wVQZICg==&inline=1 Search Active: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413195&signed_aid=3vKsZHA49w1-eKdDzCFMAg==&inline=1 Search No Results: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413196&signed_aid=apBMFLJ_YL0728Ah9Pv5Iw==&inline=1 Bug: 979531, 1001941 Change-Id: Ie70439c334d76f61497a512f7fd1270843210aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775648 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#699652}
-
Koji Ishii authored
Zero-length text item was added in r652199 (crrev.com/c/1571113) so that |NGLineBreaker| can call |ClearNeedsLayout()| for fully-collapsed |LayoutText|. This patch fixes such zero-length text items not to require re-shaping when re-using existing |ShapeResult|. Found when debugging crbug.com/963521. Change-Id: I3d5a78463a1754daf8c9602ce1dcb855d603ade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824759Reviewed-by:
-
Darwin Huang authored
Before this CL, navigator.clipboard.read image/png encoding used fZLibLevel = 6. Use fZLibLevel = 1 instead of the default fZLibLevel = 6. fZLibLevel = 6 is slower, and inconsistent with DataTransfer[1], which already uses fZLibLevel = 1. When testing using https://www.photopea.com/clipboard_img.html , which provides a 8000x4000 px bitmap of random pixels, navigator.clipboard.read took: * 4.10 (4.07 to 4.13) seconds over 3 trials with fZLibLevel = 6 * 3.98 (3.95 to 4.00) seconds over 3 trials with fZLibLevel = 1 * 1.53 (1.50 to 1.56) seconds over 3 trials with fZLibLevel = 0 Switching from fZLibLevel 6 to fZLibLevel 1 should enable a 3% speed-up in Async Clipboard performance, and not cause any change in behavior for DataTransfer (which would occur with fZLibLevel 0). The trade off is that this may cause encoded image/png images to be slightly larger, but this should be acceptable for clipboard content. [1]: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/clipboard/data_object_item.cc?l=141 Bug: 1004867 Change-Id: Ie557b211bbe70e19009c5d67fca310cc970101cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824063 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699650}
-
Rika Fujimaki authored
Now that we replaced ScriptValue::script_state_ with ScriptValue::isolate_, we can pass isolate instead of script_state to ScriptValue's ctor. Bug: 998994 Change-Id: Ibe5c004cf2f1ec598e2df548d32b3a187395b160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824038Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Victor-Gabriel Savu authored
InstallAttributesUsage uses InstallAttributesUsageEvent, the wrong enum was used in the previous CL. CL that added the two entries: https://chromium-review.googlesource.com/c/chromium/src/+/1800751 Bug: 1000305 Change-Id: Ia40c026511ecdc6cf4656673ca4660de9e2130c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817880Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#699648}
-
Emil A Eklund authored
Change-Id: I0dd9816618b396214cbb12d118327e44bdd6cad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824044 Auto-Submit: Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Toni Barzic authored
During app list drag, the app list background shield is gradually translated up so it ends up with rounded corners above the display in the full screen state. The translation is currently applied during drag between peeking and fullscreen state. Given that kHalf state (i.e. extended peeking state for search results UI) is above peeking state, starting drag from kHalf state would immediately apply non-identity transform on the background shield, causing the app list view to jump up. This CL changes the starting height at which the background shield starts getting translated up at the larger, kHalf height, thus avoiding the background shield jump when drag starts. BUG=None Change-Id: I47ea834f87cfd2836058a91954a7aad5bda36a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824077 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699646}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc604aa990d5..84004c441c75 git log fc604aa990d5..84004c441c75 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f24b5ede..b3fb292c (699513:699622) Created with: gclient setdep -r src/third_party/webrtc@84004c441c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ic41dd456a39dab588a775415f190abbf1a111266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824613Reviewed-by:
-
Chris Blume authored
This CL runs pixel_skia_gold_test on the 'Android FYI SkiaRenderer GL (Nexus 5X)' bot with SkiaRenderer, the GLES backend, and OOP rasterization. Bug: 969855 Change-Id: Icde25c694e22c89e2547def673340607afc897b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786871 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699644}
-
Peter Kotwicz authored
This CL: - Adds UKM recording for WebAPK.Uninstall In particular: - recording how long a WebAPK has been installed - recording how many times a WebAPK which has been uninstalled has been launched. - Changes WebappDataStorage#updateFromShortcutIntent() to take in WebappInfo as input instead of an intent - Adds new fields to WebappDataStorage: - Web Manifest URL - WebAPK version code - WebAPK install timestamp - WebAPK uninstall timestamp - Removes now unused macless webapp shortcut intent creation Privacy doc: https://docs.google.com/document/d/10m4NwkTFVjQ7uboJP9rUQM0Yh7ULD6dVvGlL3eQtD3g/edit?usp=sharing BUG=982362 TEST=WebappDataStorageTest.testWebApkInfoUpdate NOPRESUBMIT=true (To surpress new function ordering requirements) Change-Id: Ie47ef125f6bc60d5fad7f58597d09b4a41648982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781664 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#699643}
-
Giovanni Ortuño Urquidi authored
This reverts commit a40589ab. Reason for revert: The flag is used for testing new versions of QuickOffice. Removing the flag makes testing harder. Original change's description: > flags: remove disable-office-editing-component-app > > Bug: None > Change-Id: I2cc23a37cc16724e0056aaec13363483f5d3934e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582230 > Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654013} Bug: None Change-Id: I89c2c857b1aea5e2d08ea7161cc570b9feb11d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824299 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2137f90b9d98..3731bd7ab054 git log 2137f90b9d98..3731bd7ab054 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e3a5983705da..cc3f09861685 (5 commits) Created with: gclient setdep -r src/third_party/skia@3731bd7ab054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: Ia2618af5e6a8b5da160e04b952cd6034c8ee6b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824184Reviewed-by:
-
