GitLab

BUG=143312


Review URL: https://chromiumcodereview.appspot.com/10828392

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153611 0039d316-1c4b-4281-b951-d872f2087c98

Trying to display the Disconnect window causes rejection from the Window Server on
OS X 10.7.4, preventing the capturer from working.

BUG=140984
TEST=Verify Chromoting works on the system login screen.


Review URL: https://chromiumcodereview.appspot.com/10883033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153610 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10878071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153606 0039d316-1c4b-4281-b951-d872f2087c98

The path for the default images in the samples page was wrong because of recent
branch/channel switches, and ExampleZipper was getting cached unicode data
instead of binary data.

BUG=144672

Review URL: https://chromiumcodereview.appspot.com/10878056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153604 0039d316-1c4b-4281-b951-d872f2087c98

For some reason, edit URL can be null in some entries, which
causes a crash.

Along the way, make |callback| parameter of DriveFilesystemInterface::Remove()
mandatory. The only caller in gdata_file_system_proxy.cc passes a non-null
callback.

BUG=144993
TEST=remove operation works as before


Review URL: https://chromiumcodereview.appspot.com/10880075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109940
TEST=On mac, install https://chrome.google.com/webstore/detail/dmgcpfplbobdchnijhbmogkbibagiiam and see a bubble pointing to the wrench menu instead of an infobar.

Review URL: https://chromiumcodereview.appspot.com/10872067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153601 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dominicc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10870112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153600 0039d316-1c4b-4281-b951-d872f2087c98

The previous implementation tried to use pixel sizes for consistency with
implementations of RenderText on other platforms. However, it turns out
that Skia itself uses point font sizes on Mac as does gfx::Font, so it
makes more sense to use point sizes throughout.

BUG=125664, 137033
TEST=Patch in http://codereview.chromium.org/10879069/ and bring up a
print preview on www.google.com. Letter spacing for the header and
footer text should be the same as what's produced by current Canary.

Review URL: https://chromiumcodereview.appspot.com/10874066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153599 0039d316-1c4b-4281-b951-d872f2087c98

Depends on http://trac.webkit.org/changeset/126652

BUG=


Review URL: https://chromiumcodereview.appspot.com/10873073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153598 0039d316-1c4b-4281-b951-d872f2087c98

- Add functions for controlling Caps Lock to CapsLockDelegate
- Move the ownership of CapsLockDelegate to Shell from AcceleratorController
- Add ShellDelegate::CreateCapsLockDelegate

BUG=144474


Review URL: https://chromiumcodereview.appspot.com/10878058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153597 0039d316-1c4b-4281-b951-d872f2087c98

The content_shell doesn't provide a prerendererclient (and chromium and DumpRenderTree do). This browsertest makes sure that encountering a prerendering element doesn't crash the content_shell.

This patch must land after https://bugs.webkit.org/show_bug.cgi?id=95036 lands and is gardened into Chromium.

R=jam@chromium.org
BUG=144556

Review URL: https://chromiumcodereview.appspot.com/10869068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153596 0039d316-1c4b-4281-b951-d872f2087c98

R=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10879008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153594 0039d316-1c4b-4281-b951-d872f2087c98

This CL appears to have caused SavePageBrowserTest.SaveViewSourceHTMLOnly to fail flakily.




This CL is equivalent to CLs http://codereview.chromium.org/10799005, 
http://codereview.chromium.org/10836293, and
https://chromiumcodereview.appspot.com/10823406, which were previous attempts 
to land the same functionality.  

TBR=jam@chromium.org

BUG=123998
BUG=144751


Review URL: https://chromiumcodereview.appspot.com/10867065

TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136588
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10876091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153592 0039d316-1c4b-4281-b951-d872f2087c98

WebContentsUserDataTest.BasicTest is flaky.

BUG=107201
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10868115

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10873101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153591 0039d316-1c4b-4281-b951-d872f2087c98

Refactor SelectFaviconFrames to make it easy to use SelectFaviconFrames on objects other than SkBitmaps.
Changed the selection and score calculation code to operate on std::vector<gfx::Size> instead of an std::vector<SkBitmap>.

Bug=10802066
Test=SelectFaviconFramesTest.* pass
TBR=thakis

Review URL: https://chromiumcodereview.appspot.com/10872093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153590 0039d316-1c4b-4281-b951-d872f2087c98

temporary download directory to avoid Chrome pending on user input of a new
filename.

BUG=144624
TEST=browser_tests --gtest_filter=SSLUITest.TestBadHTTPSDownload


Review URL: https://chromiumcodereview.appspot.com/10868111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153589 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138118


Review URL: https://chromiumcodereview.appspot.com/10874068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141898


Review URL: https://chromiumcodereview.appspot.com/10832349

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153585 0039d316-1c4b-4281-b951-d872f2087c98

Resource files are in http://codereview.chromium.org/10883041/

This is trying to re-created stevenjb's cl:
http://codereview.chromium.org/10883041/

BUG=144723
TBR=oshima

Review URL: https://chromiumcodereview.appspot.com/10879106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153584 0039d316-1c4b-4281-b951-d872f2087c98

These were split out from dharcourt@chromium.org's review here:

https://chromiumcodereview.appspot.com/10868050/

BUG=133746
TBR=asargent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10870116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153583 0039d316-1c4b-4281-b951-d872f2087c98

* DriveResourceMetadata::AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry>.
* DriveFileSystem::AddUploadedParams now take a directory FilePath and a scoped_ptr<DocumentEntry>.
* Anon helper function PostError in drive_resource_metadata.cc posts an async callback error.
* DriveFileSystem's OnCreateDirectoryCompleted renamed to AddNewDirectory. The old synchronous AddNewDirectory is gone, replaced by a call to DriveResourceMetadata::AddEntryToDirectory, continuing with DriveFileSystem::ContinueCreateDirectory.
* DriveFileSystem's CreateDirectoryParams has moved to the header file so AddNewDirectory may be called by the unit test.
* DriveFileSystem's RenameEntryLocally, RenameAfterGetEntryInfo and NotifyAndRunFileMoveCallback now require a non-null callback.
* AddUploadedFileToCache calls OnDirectoryChanged directly instead of the indirection through NotifyAndRunFileMoveCallback. Also additional DCHECKs in AddUploadedFileToCache.
* callback_runner no longer necessary in AddUploadedFileOnUIThread.
* entry replaced with doc_entry everywhere to avoid confusion with GDataEntry.
* virtual_dir_path replaced with directory_path everywhere for consistency.
* delete FindEntryCallback, which is no longer used.

BUG=142048
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/10876075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129861
TEST=NONE
TBR=alexeypa@chromium.org, isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10878087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153581 0039d316-1c4b-4281-b951-d872f2087c98

Added break statement in MediaTransferProtocolDaemonClient::FileEntry::InitialFromResponse function.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10873076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144436

Review URL: https://chromiumcodereview.appspot.com/10873095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144326
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10872094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153578 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10882070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137342
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10872098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153576 0039d316-1c4b-4281-b951-d872f2087c98

Flash isn't using 3D in this case, so using Swiftshader to present just slows it down


BUG=142107


Review URL: https://chromiumcodereview.appspot.com/10875074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143745

Review URL: https://chromiumcodereview.appspot.com/10829436

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153574 0039d316-1c4b-4281-b951-d872f2087c98

Remove MediaDeviceMapService references from |DeviceAttachedIntentSource::OnMediaDetached| function.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10868110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10868115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91551

Review URL: https://chromiumcodereview.appspot.com/10869003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10872076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10828217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133829
TEST=launch an app, then reload via the page reload button or the Reload link.

Review URL: https://chromiumcodereview.appspot.com/10641017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153567 0039d316-1c4b-4281-b951-d872f2087c98

The ClearKeyCdm implements the ContentDecryptionModule. It's a wrapping of the media::AesDecryptor to do real decryption work. The wrapping layer only translates input/output parameters and convert the async calls in media::AesDecryptor to sync calls.

TBR=scherkus@chromium.org
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152672

Review URL: https://chromiumcodereview.appspot.com/10837252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153566 0039d316-1c4b-4281-b951-d872f2087c98

Add !defined(OS_IOS) to if defined(OS_MACOS) around functions GetSandboxProfileForSandboxType and GetCarbonInterposePath.

These functions are not applicable to iOS.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10871013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153565 0039d316-1c4b-4281-b951-d872f2087c98

Reland of http://codereview.chromium.org/10877025/.  Accidentally included other code in the CL when manually landing after the CQ got stuck, so had to revert (See http://codereview.chromium.org/10880048/)

Remove no longer used NetNanny and ESET anti-virus error
strings and ESET error code.

TBR=agl@chromium.org, thakis@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10870103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153564 0039d316-1c4b-4281-b951-d872f2087c98